* [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC
@ 2018-05-04 12:53 Richard Palethorpe
2018-05-08 3:31 ` Li Wang
2018-05-09 12:33 ` Cyril Hrubis
0 siblings, 2 replies; 3+ messages in thread
From: Richard Palethorpe @ 2018-05-04 12:53 UTC (permalink / raw)
To: ltp
This message creates a lot of noise and uses extra resources on slower
machines. It also does not seem very useful.
Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---
This may help debug test failures on ARM machines by reducing the amount of
noise.
include/tst_common.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/tst_common.h b/include/tst_common.h
index d3d50eb19..27924766e 100644
--- a/include/tst_common.h
+++ b/include/tst_common.h
@@ -56,13 +56,10 @@
if (tst_ret_ == ERET) \
break; \
if (tst_delay_ < MAX_DELAY * 1000000) { \
- tst_res(TINFO, \
- #FUNC" returned %i, retrying" \
- " in %ius", tst_ret_, tst_delay_); \
usleep(tst_delay_); \
tst_delay_ *= 2; \
} else { \
- tst_brk(TBROK, #FUNC" failed"); \
+ tst_brk(TBROK, #FUNC" timed out"); \
} \
} \
ERET; \
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC
2018-05-04 12:53 [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC Richard Palethorpe
@ 2018-05-08 3:31 ` Li Wang
2018-05-09 12:33 ` Cyril Hrubis
1 sibling, 0 replies; 3+ messages in thread
From: Li Wang @ 2018-05-08 3:31 UTC (permalink / raw)
To: ltp
On Fri, May 4, 2018 at 8:53 PM, Richard Palethorpe <rpalethorpe@suse.com>
wrote:
> This message creates a lot of noise and uses extra resources on slower
> machines. It also does not seem very useful.
>
Yes! That's the reason why I cancel the print message in shell achievement.
:)
http://lists.linux.it/pipermail/ltp/2018-May/007968.html​
--
Li Wang
liwang@redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180508/7ceea09e/attachment.html>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC
2018-05-04 12:53 [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC Richard Palethorpe
2018-05-08 3:31 ` Li Wang
@ 2018-05-09 12:33 ` Cyril Hrubis
1 sibling, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2018-05-09 12:33 UTC (permalink / raw)
To: ltp
Hi!
Applied with ack from Li, thanks.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-09 12:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 12:53 [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC Richard Palethorpe
2018-05-08 3:31 ` Li Wang
2018-05-09 12:33 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.