[PATCH v1] iommu: Remove extra NULL check when call strtobool()

[PATCH v1] iommu: Remove extra NULL check when call strtobool()

[Andy Shevchenko]

strtobool() does check for NULL parameter already. No need to repeat.

While here, switch to kstrtobool() and unshadow actual error code
(which is still -EINVAL).

No functional change intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/iommu/iommu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index d2aa23202bb9..7f61b142263e 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -116,9 +116,11 @@ static void __iommu_detach_group(struct iommu_domain *domain,
 static int __init iommu_set_def_domain_type(char *str)
 {
 	bool pt;
+	int ret;
 
-	if (!str || strtobool(str, &pt))
-		return -EINVAL;
+	ret = kstrtobool(str, &pt);
+	if (ret)
+		return ret;
 
 	iommu_def_domain_type = pt ? IOMMU_DOMAIN_IDENTITY : IOMMU_DOMAIN_DMA;
 	return 0;
-- 
2.17.0

Re: [PATCH v1] iommu: Remove extra NULL check when call strtobool()

[Joerg Roedel]

On Mon, May 14, 2018 at 07:22:25PM +0300, Andy Shevchenko wrote:
> strtobool() does check for NULL parameter already. No need to repeat.
> 
> While here, switch to kstrtobool() and unshadow actual error code
> (which is still -EINVAL).
> 
> No functional change intended.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

Applied, thanks.