All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: bjorn.andersson@linaro.org, Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral
Date: Mon, 14 May 2018 18:57:55 +0200	[thread overview]
Message-ID: <20180514165755.GB27984@xo-6d-61-c0.localdomain> (raw)
In-Reply-To: <1525341432-15818-3-git-send-email-kgunda@codeaurora.org>

Hi!

> WLED4 peripheral is present on some PMICs like pmi8998
> and pm660l. It has a different register map and also
> configurations are different. Add support for it.
> 
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
>  .../bindings/leds/backlight/qcom-wled.txt          | 172 ++++-
>  drivers/video/backlight/qcom-wled.c                | 749 +++++++++++++++------
>  2 files changed, 696 insertions(+), 225 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> index fb39e32..0ceffa1 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> @@ -1,30 +1,129 @@
>  Binding for Qualcomm Technologies, Inc. WLED driver
>  
> -Required properties:
> -- compatible: should be "qcom,pm8941-wled"
> -- reg: slave address
> -
> -Optional properties:
> -- default-brightness: brightness value on boot, value from: 0-4095
> -	default: 2048
> +- compatible
> +	Usage:        required
> +	Value type:   <string>
> +	Definition:   should be "qcom,pm8941-wled" or "qcom,pmi8998-wled".
> +		      or "qcom,pm660l-wled".
> +
> +- reg
> +	Usage:        required
> +	Value type:   <prop encoded array>
> +	Definition:   Base address of the WLED modules.

I'm not sure if this change of format is good idea here...

									Pavel

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: bjorn.andersson@linaro.org, Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral
Date: Mon, 14 May 2018 16:57:55 +0000	[thread overview]
Message-ID: <20180514165755.GB27984@xo-6d-61-c0.localdomain> (raw)
In-Reply-To: <1525341432-15818-3-git-send-email-kgunda@codeaurora.org>

Hi!

> WLED4 peripheral is present on some PMICs like pmi8998
> and pm660l. It has a different register map and also
> configurations are different. Add support for it.
> 
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
>  .../bindings/leds/backlight/qcom-wled.txt          | 172 ++++-
>  drivers/video/backlight/qcom-wled.c                | 749 +++++++++++++++------
>  2 files changed, 696 insertions(+), 225 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> index fb39e32..0ceffa1 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> @@ -1,30 +1,129 @@
>  Binding for Qualcomm Technologies, Inc. WLED driver
>  
> -Required properties:
> -- compatible: should be "qcom,pm8941-wled"
> -- reg: slave address
> -
> -Optional properties:
> -- default-brightness: brightness value on boot, value from: 0-4095
> -	default: 2048
> +- compatible
> +	Usage:        required
> +	Value type:   <string>
> +	Definition:   should be "qcom,pm8941-wled" or "qcom,pmi8998-wled".
> +		      or "qcom,pm660l-wled".
> +
> +- reg
> +	Usage:        required
> +	Value type:   <prop encoded array>
> +	Definition:   Base address of the WLED modules.

I'm not sure if this change of format is good idea here...

									Pavel

  parent reply	other threads:[~2018-05-14 16:57 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03  9:57 [PATCH V1 0/5] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-05-03  9:57 ` [PATCH V1 1/5] qcom: wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-05-03  9:58   ` Kiran Gunda
2018-05-07 15:41   ` Bjorn Andersson
2018-05-07 15:41     ` Bjorn Andersson
2018-05-10 11:10   ` Pavel Machek
2018-05-10 11:10     ` Pavel Machek
2018-05-03  9:57 ` [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-05-03  9:59   ` Kiran Gunda
2018-05-07 16:20   ` Bjorn Andersson
2018-05-07 16:20     ` Bjorn Andersson
2018-05-08 10:25     ` kgunda
2018-05-08 10:37       ` kgunda
2018-05-08 17:17       ` Bjorn Andersson
2018-05-08 17:17         ` Bjorn Andersson
2018-05-09  5:15         ` kgunda
2018-05-09  5:27           ` kgunda
2018-05-17  9:47       ` kgunda
2018-05-17  9:59         ` kgunda
2018-05-17 12:31         ` Rob Herring
2018-05-17 12:31           ` Rob Herring
2018-05-17 12:31           ` Rob Herring
2018-05-17 15:10           ` kgunda
2018-05-17 15:22             ` kgunda
2018-05-18 12:20             ` Rob Herring
2018-05-18 12:20               ` Rob Herring
2018-05-18 12:20               ` Rob Herring
2018-05-14 16:57   ` Pavel Machek [this message]
2018-05-14 16:57     ` Pavel Machek
2018-05-15  4:55     ` kgunda
2018-05-15  4:56       ` kgunda
2018-05-03  9:57 ` [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling Kiran Gunda
2018-05-03  9:59   ` Kiran Gunda
2018-05-07  8:06   ` Dan Carpenter
2018-05-07  8:06     ` Dan Carpenter
2018-05-07  8:06     ` Dan Carpenter
2018-05-07  9:08     ` kgunda
2018-05-07  9:20       ` kgunda
2018-05-07 17:06   ` Bjorn Andersson
2018-05-07 17:06     ` Bjorn Andersson
2018-05-08 10:35     ` kgunda
2018-05-08 10:47       ` kgunda
2018-05-03  9:57 ` [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling Kiran Gunda
2018-05-03  9:59   ` Kiran Gunda
2018-05-07 17:21   ` Bjorn Andersson
2018-05-07 17:21     ` Bjorn Andersson
2018-05-08 12:26     ` kgunda
2018-05-08 12:38       ` kgunda
2018-05-08 17:19       ` Bjorn Andersson
2018-05-08 17:19         ` Bjorn Andersson
2018-05-09  5:06         ` kgunda
2018-05-09  5:18           ` kgunda
2018-05-09  6:16           ` kgunda
2018-05-09  6:28             ` kgunda
2018-05-03  9:57 ` [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-05-03  9:59   ` Kiran Gunda
2018-05-07 18:10   ` Bjorn Andersson
2018-05-07 18:10     ` Bjorn Andersson
2018-05-09  7:14     ` kgunda
2018-05-09  7:26       ` kgunda
2018-05-14 17:02       ` Bjorn Andersson
2018-05-14 17:02         ` Bjorn Andersson
2018-05-15  4:50         ` kgunda
2018-05-15  4:50           ` kgunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514165755.GB27984@xo-6d-61-c0.localdomain \
    --to=pavel@ucw.cz \
    --cc=b.zolnierkie@samsung.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=kgunda@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.