[PATCH] jsflash: fix compilation

[PATCH] jsflash: fix compilation

[Christoph Hellwig]

No bio in this whole function, use req->bio instead.

Fixes: 37a5b5c6 ("jsflash: handle highmem pages");
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---

Looks like no one except for Guenters build bot cared.  I wonder if we
should just get rid of the driver given that it doesn't look in a good
shape at all based on his build logs even with the fix..

 drivers/sbus/char/jsflash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/sbus/char/jsflash.c b/drivers/sbus/char/jsflash.c
index 8520587b8d09..821367ef9dd3 100644
--- a/drivers/sbus/char/jsflash.c
+++ b/drivers/sbus/char/jsflash.c
@@ -230,7 +230,7 @@ static void jsfd_request(void)
 			goto end;
 		}
 
-		p = kmap_atomic(bio_page(bio)) + bio_offset(bio);
+		p = kmap_atomic(bio_page(req->bio)) + bio_offset(req->bio);
 		jsfd_read(p, jdp->dbase + offset, len);
 		kunmap_atomic(p);
 		err = BLK_STS_OK;
-- 
2.17.0

[PATCH] jsflash: fix compilation

[Christoph Hellwig]

No bio in this whole function, use req->bio instead.

Fixes: 37a5b5c6 ("jsflash: handle highmem pages");
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---

Looks like no one except for Guenters build bot cared.  I wonder if we
should just get rid of the driver given that it doesn't look in a good
shape at all based on his build logs even with the fix..

 drivers/sbus/char/jsflash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/sbus/char/jsflash.c b/drivers/sbus/char/jsflash.c
index 8520587b8d09..821367ef9dd3 100644
--- a/drivers/sbus/char/jsflash.c
+++ b/drivers/sbus/char/jsflash.c
@@ -230,7 +230,7 @@ static void jsfd_request(void)
 			goto end;
 		}
 
-		p = kmap_atomic(bio_page(bio)) + bio_offset(bio);
+		p = kmap_atomic(bio_page(req->bio)) + bio_offset(req->bio);
 		jsfd_read(p, jdp->dbase + offset, len);
 		kunmap_atomic(p);
 		err = BLK_STS_OK;
-- 
2.17.0

Re: [PATCH] jsflash: fix compilation

[Jens Axboe]

On 5/15/18 12:32 PM, Christoph Hellwig wrote:
> No bio in this whole function, use req->bio instead.

Applied.

> Looks like no one except for Guenters build bot cared.  I wonder if we
> should just get rid of the driver given that it doesn't look in a good
> shape at all based on his build logs even with the fix..

Needs input from the folks that actually might use it. The driver looks
abandoned, it's only getting updates through API changes etc.

-- 
Jens Axboe

Re: [PATCH] jsflash: fix compilation

[Jens Axboe]

On 5/15/18 12:32 PM, Christoph Hellwig wrote:
> No bio in this whole function, use req->bio instead.

Applied.

> Looks like no one except for Guenters build bot cared.  I wonder if we
> should just get rid of the driver given that it doesn't look in a good
> shape at all based on his build logs even with the fix..

Needs input from the folks that actually might use it. The driver looks
abandoned, it's only getting updates through API changes etc.

-- 
Jens Axboe

Re: [PATCH] jsflash: fix compilation

[David Miller]

From: Jens Axboe <axboe@kernel.dk>
Date: Tue, 15 May 2018 12:51:20 -0600

> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>> No bio in this whole function, use req->bio instead.
> 
> Applied.
> 
>> Looks like no one except for Guenters build bot cared.  I wonder if we
>> should just get rid of the driver given that it doesn't look in a good
>> shape at all based on his build logs even with the fix..
> 
> Needs input from the folks that actually might use it. The driver looks
> abandoned, it's only getting updates through API changes etc.

I don't think anyone is using it.

Re: [PATCH] jsflash: fix compilation

[David Miller]

From: Jens Axboe <axboe@kernel.dk>
Date: Tue, 15 May 2018 12:51:20 -0600

> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>> No bio in this whole function, use req->bio instead.
> 
> Applied.
> 
>> Looks like no one except for Guenters build bot cared.  I wonder if we
>> should just get rid of the driver given that it doesn't look in a good
>> shape at all based on his build logs even with the fix..
> 
> Needs input from the folks that actually might use it. The driver looks
> abandoned, it's only getting updates through API changes etc.

I don't think anyone is using it.

Re: [PATCH] jsflash: fix compilation

[Jens Axboe]

On 5/15/18 12:58 PM, David Miller wrote:
> From: Jens Axboe <axboe@kernel.dk>
> Date: Tue, 15 May 2018 12:51:20 -0600
> 
>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>> No bio in this whole function, use req->bio instead.
>>
>> Applied.
>>
>>> Looks like no one except for Guenters build bot cared.  I wonder if we
>>> should just get rid of the driver given that it doesn't look in a good
>>> shape at all based on his build logs even with the fix..
>>
>> Needs input from the folks that actually might use it. The driver looks
>> abandoned, it's only getting updates through API changes etc.
> 
> I don't think anyone is using it.

Are you fine with removing it then?

-- 
Jens Axboe

Re: [PATCH] jsflash: fix compilation

[Jens Axboe]

On 5/15/18 12:58 PM, David Miller wrote:
> From: Jens Axboe <axboe@kernel.dk>
> Date: Tue, 15 May 2018 12:51:20 -0600
> 
>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>> No bio in this whole function, use req->bio instead.
>>
>> Applied.
>>
>>> Looks like no one except for Guenters build bot cared.  I wonder if we
>>> should just get rid of the driver given that it doesn't look in a good
>>> shape at all based on his build logs even with the fix..
>>
>> Needs input from the folks that actually might use it. The driver looks
>> abandoned, it's only getting updates through API changes etc.
> 
> I don't think anyone is using it.

Are you fine with removing it then?

-- 
Jens Axboe

Re: [PATCH] jsflash: fix compilation

[David Miller]

From: Jens Axboe <axboe@kernel.dk>
Date: Tue, 15 May 2018 13:00:36 -0600

> On 5/15/18 12:58 PM, David Miller wrote:
>> From: Jens Axboe <axboe@kernel.dk>
>> Date: Tue, 15 May 2018 12:51:20 -0600
>> 
>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>>> No bio in this whole function, use req->bio instead.
>>>
>>> Applied.
>>>
>>>> Looks like no one except for Guenters build bot cared.  I wonder if we
>>>> should just get rid of the driver given that it doesn't look in a good
>>>> shape at all based on his build logs even with the fix..
>>>
>>> Needs input from the folks that actually might use it. The driver looks
>>> abandoned, it's only getting updates through API changes etc.
>> 
>> I don't think anyone is using it.
> 
> Are you fine with removing it then?

Yes, I am:

Acked-by: David S. Miller <davem@davemloft.net>

Re: [PATCH] jsflash: fix compilation

[David Miller]

From: Jens Axboe <axboe@kernel.dk>
Date: Tue, 15 May 2018 13:00:36 -0600

> On 5/15/18 12:58 PM, David Miller wrote:
>> From: Jens Axboe <axboe@kernel.dk>
>> Date: Tue, 15 May 2018 12:51:20 -0600
>> 
>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>>> No bio in this whole function, use req->bio instead.
>>>
>>> Applied.
>>>
>>>> Looks like no one except for Guenters build bot cared.  I wonder if we
>>>> should just get rid of the driver given that it doesn't look in a good
>>>> shape at all based on his build logs even with the fix..
>>>
>>> Needs input from the folks that actually might use it. The driver looks
>>> abandoned, it's only getting updates through API changes etc.
>> 
>> I don't think anyone is using it.
> 
> Are you fine with removing it then?

Yes, I am:

Acked-by: David S. Miller <davem@davemloft.net>

Re: [PATCH] jsflash: fix compilation

[Jens Axboe]

On 5/15/18 1:51 PM, David Miller wrote:
> From: Jens Axboe <axboe@kernel.dk>
> Date: Tue, 15 May 2018 13:00:36 -0600
> 
>> On 5/15/18 12:58 PM, David Miller wrote:
>>> From: Jens Axboe <axboe@kernel.dk>
>>> Date: Tue, 15 May 2018 12:51:20 -0600
>>>
>>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>>>> No bio in this whole function, use req->bio instead.
>>>>
>>>> Applied.
>>>>
>>>>> Looks like no one except for Guenters build bot cared.  I wonder if we
>>>>> should just get rid of the driver given that it doesn't look in a good
>>>>> shape at all based on his build logs even with the fix..
>>>>
>>>> Needs input from the folks that actually might use it. The driver looks
>>>> abandoned, it's only getting updates through API changes etc.
>>>
>>> I don't think anyone is using it.
>>
>> Are you fine with removing it then?
> 
> Yes, I am:
> 
> Acked-by: David S. Miller <davem@davemloft.net>

Great, done!

-- 
Jens Axboe

Re: [PATCH] jsflash: fix compilation

[Jens Axboe]

On 5/15/18 1:51 PM, David Miller wrote:
> From: Jens Axboe <axboe@kernel.dk>
> Date: Tue, 15 May 2018 13:00:36 -0600
> 
>> On 5/15/18 12:58 PM, David Miller wrote:
>>> From: Jens Axboe <axboe@kernel.dk>
>>> Date: Tue, 15 May 2018 12:51:20 -0600
>>>
>>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>>>> No bio in this whole function, use req->bio instead.
>>>>
>>>> Applied.
>>>>
>>>>> Looks like no one except for Guenters build bot cared.  I wonder if we
>>>>> should just get rid of the driver given that it doesn't look in a good
>>>>> shape at all based on his build logs even with the fix..
>>>>
>>>> Needs input from the folks that actually might use it. The driver looks
>>>> abandoned, it's only getting updates through API changes etc.
>>>
>>> I don't think anyone is using it.
>>
>> Are you fine with removing it then?
> 
> Yes, I am:
> 
> Acked-by: David S. Miller <davem@davemloft.net>

Great, done!

-- 
Jens Axboe