All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <groeck@google.com>
Cc: Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, Guenter Roeck <groeck@chromium.org>,
	"Patel, Chintan M" <chintan.m.patel@intel.com>,
	Jaroslav Kysela <perex@perex.cz>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files
Date: Wed, 23 May 2018 16:58:11 +0100	[thread overview]
Message-ID: <20180523155811.GO4828@sirena.org.uk> (raw)
In-Reply-To: <CABXOdTeCr-ExO9O3XAHK-DnNf5yLGO0TPkXgs60TB90jGNB2_Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Wed, May 23, 2018 at 08:54:18AM -0700, Guenter Roeck wrote:
> On Wed, May 23, 2018 at 6:56 AM Mark Brown <broonie@kernel.org> wrote:
> > On Wed, May 23, 2018 at 03:54:54PM +0200, Takashi Iwai wrote:

> > > And I'm wondering whether we should move these definitions to uapi
> > > headers.

> > Yes, we should.

> Are you sure ? They used to be in
>  sound/soc/intel/skylake/skl-tplg-interface.h.
> I took my clue from sound/soc/soc-topology.c, where the v4 structures are
> also
> declared locally and not in the uapi files.

I'm saying we should move them there.  They're clearly part of the
userspace ABI and therefore belong in uapi, it was a mistake to let them
be elsewhere.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <groeck@google.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"Patel, Chintan M" <chintan.m.patel@intel.com>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files
Date: Wed, 23 May 2018 16:58:11 +0100	[thread overview]
Message-ID: <20180523155811.GO4828@sirena.org.uk> (raw)
In-Reply-To: <CABXOdTeCr-ExO9O3XAHK-DnNf5yLGO0TPkXgs60TB90jGNB2_Q@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 682 bytes --]

On Wed, May 23, 2018 at 08:54:18AM -0700, Guenter Roeck wrote:
> On Wed, May 23, 2018 at 6:56 AM Mark Brown <broonie@kernel.org> wrote:
> > On Wed, May 23, 2018 at 03:54:54PM +0200, Takashi Iwai wrote:

> > > And I'm wondering whether we should move these definitions to uapi
> > > headers.

> > Yes, we should.

> Are you sure ? They used to be in
>  sound/soc/intel/skylake/skl-tplg-interface.h.
> I took my clue from sound/soc/soc-topology.c, where the v4 structures are
> also
> declared locally and not in the uapi files.

I'm saying we should move them there.  They're clearly part of the
userspace ABI and therefore belong in uapi, it was a mistake to let them
be elsewhere.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2018-05-23 15:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 16:58 [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files Guenter Roeck
2018-05-22 17:14 ` Mark Brown
2018-05-22 17:14   ` Mark Brown
2018-05-22 19:59 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-22 21:59   ` Guenter Roeck
2018-05-23  9:49     ` [alsa-devel] " Mark Brown
2018-05-23  9:49       ` Mark Brown
2018-05-23 13:15       ` Guenter Roeck
2018-05-23  8:24   ` [alsa-devel] " Mark Brown
2018-05-23  8:24     ` Mark Brown
2018-05-23 13:42     ` [alsa-devel] " Pierre-Louis Bossart
2018-05-23 13:42       ` Pierre-Louis Bossart
2018-05-23 13:56       ` [alsa-devel] " Takashi Iwai
2018-05-23 13:56         ` Takashi Iwai
2018-05-23 14:49         ` Guenter Roeck
2018-05-23 14:58           ` [alsa-devel] " Takashi Iwai
2018-05-23 14:58             ` Takashi Iwai
2018-05-23 15:52           ` [alsa-devel] " Mark Brown
2018-05-23 13:54 ` Takashi Iwai
2018-05-23 13:54   ` Takashi Iwai
2018-05-23 13:56   ` Mark Brown
2018-05-23 13:56     ` Mark Brown
2018-05-23 15:54     ` Guenter Roeck
2018-05-23 15:58       ` Mark Brown [this message]
2018-05-23 15:58         ` Mark Brown
2018-05-23 16:17         ` Guenter Roeck
2018-05-24  9:52           ` Takashi Iwai
2018-05-24  9:52             ` Takashi Iwai
2018-05-24 14:18           ` Mark Brown
2018-05-24 14:18             ` Mark Brown
2018-05-24 14:55             ` Guenter Roeck
2018-05-24 14:55               ` Guenter Roeck
2018-05-24 15:11               ` Mark Brown
2018-05-25  9:04                 ` [alsa-devel] " Lin, Mengdong
2018-05-25 13:20                   ` Guenter Roeck
2018-05-23 16:29   ` Guenter Roeck
2018-05-23 20:28 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-23 21:22   ` Guenter Roeck
2018-05-24  3:38     ` Pierre-Louis Bossart
2018-05-25 13:40     ` Shreyas NC
2018-05-25 14:09       ` Guenter Roeck
2018-05-25 17:41         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523155811.GO4828@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=chintan.m.patel@intel.com \
    --cc=groeck@chromium.org \
    --cc=groeck@google.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.