From: Guenter Roeck <groeck@google.com> To: Mark Brown <broonie@kernel.org> Cc: Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>, alsa-devel@alsa-project.org, Guenter Roeck <groeck@chromium.org>, "Patel, Chintan M" <chintan.m.patel@intel.com>, Jaroslav Kysela <perex@perex.cz>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files Date: Thu, 24 May 2018 07:55:06 -0700 [thread overview] Message-ID: <CABXOdTfKXqgRecs3xuxb-XRodJkK7+h5V0hqt889CsD6vkm5yA@mail.gmail.com> (raw) In-Reply-To: <20180524141842.GW4828@sirena.org.uk> On Thu, May 24, 2018 at 7:18 AM Mark Brown <broonie@kernel.org> wrote: > On Wed, May 23, 2018 at 09:17:23AM -0700, Guenter Roeck wrote: > > On Wed, May 23, 2018 at 8:58 AM Mark Brown <broonie@kernel.org> wrote: > > > I'm saying we should move them there. They're clearly part of the > > > userspace ABI and therefore belong in uapi, it was a mistake to let them > > > be elsewhere. > > They define a firmware file format. Not sure if I would call that userspace > > ABI. > It's a binary provided by userspace to the kernel, I'd say that's > clearly an ABI. > > I don't mind adding the structures to > > sound/soc/intel/skylake/skl-tplg-interface.h, > > but it seems a bit out of scope to tie this with moving the file to > > include/uapi/sound. > > I think that should be a separate discussion. > Is there some reason not to just do it while we're looking at this? I > don't see why we wouldn't want to do this. I don't mind doing this. However, keeping the change local and in a single patch would make it easier to backport, and I think that the ability to backport would be essential to get more than one-person test coverage. I also would have liked feedback from someone at Intel, at least for the Skylake specific structures. Anyway, what file do you have in mind for the structure definitions, both for the ones in soc-tolopogy.c and the ones needed in skl-topology.c ? Everything into asoc.h, or something else ? Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <groeck@google.com> To: Mark Brown <broonie@kernel.org> Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>, linux-kernel <linux-kernel@vger.kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, "Patel, Chintan M" <chintan.m.patel@intel.com>, Guenter Roeck <groeck@chromium.org> Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files Date: Thu, 24 May 2018 07:55:06 -0700 [thread overview] Message-ID: <CABXOdTfKXqgRecs3xuxb-XRodJkK7+h5V0hqt889CsD6vkm5yA@mail.gmail.com> (raw) In-Reply-To: <20180524141842.GW4828@sirena.org.uk> On Thu, May 24, 2018 at 7:18 AM Mark Brown <broonie@kernel.org> wrote: > On Wed, May 23, 2018 at 09:17:23AM -0700, Guenter Roeck wrote: > > On Wed, May 23, 2018 at 8:58 AM Mark Brown <broonie@kernel.org> wrote: > > > I'm saying we should move them there. They're clearly part of the > > > userspace ABI and therefore belong in uapi, it was a mistake to let them > > > be elsewhere. > > They define a firmware file format. Not sure if I would call that userspace > > ABI. > It's a binary provided by userspace to the kernel, I'd say that's > clearly an ABI. > > I don't mind adding the structures to > > sound/soc/intel/skylake/skl-tplg-interface.h, > > but it seems a bit out of scope to tie this with moving the file to > > include/uapi/sound. > > I think that should be a separate discussion. > Is there some reason not to just do it while we're looking at this? I > don't see why we wouldn't want to do this. I don't mind doing this. However, keeping the change local and in a single patch would make it easier to backport, and I think that the ability to backport would be essential to get more than one-person test coverage. I also would have liked feedback from someone at Intel, at least for the Skylake specific structures. Anyway, what file do you have in mind for the structure definitions, both for the ones in soc-tolopogy.c and the ones needed in skl-topology.c ? Everything into asoc.h, or something else ? Guenter
next prev parent reply other threads:[~2018-05-24 14:55 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-22 16:58 [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files Guenter Roeck 2018-05-22 17:14 ` Mark Brown 2018-05-22 17:14 ` Mark Brown 2018-05-22 19:59 ` [alsa-devel] " Pierre-Louis Bossart 2018-05-22 21:59 ` Guenter Roeck 2018-05-23 9:49 ` [alsa-devel] " Mark Brown 2018-05-23 9:49 ` Mark Brown 2018-05-23 13:15 ` Guenter Roeck 2018-05-23 8:24 ` [alsa-devel] " Mark Brown 2018-05-23 8:24 ` Mark Brown 2018-05-23 13:42 ` [alsa-devel] " Pierre-Louis Bossart 2018-05-23 13:42 ` Pierre-Louis Bossart 2018-05-23 13:56 ` [alsa-devel] " Takashi Iwai 2018-05-23 13:56 ` Takashi Iwai 2018-05-23 14:49 ` Guenter Roeck 2018-05-23 14:58 ` [alsa-devel] " Takashi Iwai 2018-05-23 14:58 ` Takashi Iwai 2018-05-23 15:52 ` [alsa-devel] " Mark Brown 2018-05-23 13:54 ` Takashi Iwai 2018-05-23 13:54 ` Takashi Iwai 2018-05-23 13:56 ` Mark Brown 2018-05-23 13:56 ` Mark Brown 2018-05-23 15:54 ` Guenter Roeck 2018-05-23 15:58 ` Mark Brown 2018-05-23 15:58 ` Mark Brown 2018-05-23 16:17 ` Guenter Roeck 2018-05-24 9:52 ` Takashi Iwai 2018-05-24 9:52 ` Takashi Iwai 2018-05-24 14:18 ` Mark Brown 2018-05-24 14:18 ` Mark Brown 2018-05-24 14:55 ` Guenter Roeck [this message] 2018-05-24 14:55 ` Guenter Roeck 2018-05-24 15:11 ` Mark Brown 2018-05-25 9:04 ` [alsa-devel] " Lin, Mengdong 2018-05-25 13:20 ` Guenter Roeck 2018-05-23 16:29 ` Guenter Roeck 2018-05-23 20:28 ` [alsa-devel] " Pierre-Louis Bossart 2018-05-23 21:22 ` Guenter Roeck 2018-05-24 3:38 ` Pierre-Louis Bossart 2018-05-25 13:40 ` Shreyas NC 2018-05-25 14:09 ` Guenter Roeck 2018-05-25 17:41 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CABXOdTfKXqgRecs3xuxb-XRodJkK7+h5V0hqt889CsD6vkm5yA@mail.gmail.com \ --to=groeck@google.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=chintan.m.patel@intel.com \ --cc=groeck@chromium.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.