From: Fam Zheng <famz@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Amador Pahim" <amador@pahim.org>
Subject: Re: [Qemu-devel] [PATCH 3/5] Acceptance tests: add quick VNC tests
Date: Fri, 25 May 2018 13:37:18 +0800 [thread overview]
Message-ID: <20180525053718.GB28589@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180525005839.11556-4-crosa@redhat.com>
On Thu, 05/24 20:58, Cleber Rosa wrote:
> This patch adds a few simple behavior tests for VNC. These tests
> introduce manipulation of the QEMUMachine arguments, by setting
> the arguments, instead of adding to the existing ones.
I'm confused by this. The code uses 'add_args', so it does add to the arguments,
no?
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/test_vnc.py | 50 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 tests/acceptance/test_vnc.py
>
> diff --git a/tests/acceptance/test_vnc.py b/tests/acceptance/test_vnc.py
> new file mode 100644
> index 0000000000..9d9a35cf55
> --- /dev/null
> +++ b/tests/acceptance/test_vnc.py
> @@ -0,0 +1,50 @@
Copyright header is missing here too.
Fam
> +from avocado_qemu import Test
> +
> +
> +class Vnc(Test):
Should VncTest be a better class name?
> + """
> + :avocado: enable
> + :avocado: tags=vnc,quick
> + """
> + def test_no_vnc(self):
> + self.vm.add_args('-nodefaults', '-S')
> + self.vm.launch()
> + self.assertFalse(self.vm.qmp('query-vnc')['return']['enabled'])
> +
> + def test_no_vnc_change_password(self):
> + self.vm.add_args('-nodefaults', '-S')
> + self.vm.launch()
> + self.assertFalse(self.vm.qmp('query-vnc')['return']['enabled'])
> + set_password_response = self.vm.qmp('change',
> + device='vnc',
> + target='password',
> + arg='new_password')
> + self.assertIn('error', set_password_response)
> + self.assertEqual(set_password_response['error']['class'],
> + 'GenericError')
> + self.assertEqual(set_password_response['error']['desc'],
> + 'Could not set password')
> +
> + def test_vnc_change_password_requires_a_password(self):
> + self.vm.add_args('-nodefaults', '-S', '-vnc', ':0')
> + self.vm.launch()
> + self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
> + set_password_response = self.vm.qmp('change',
> + device='vnc',
> + target='password',
> + arg='new_password')
> + self.assertIn('error', set_password_response)
> + self.assertEqual(set_password_response['error']['class'],
> + 'GenericError')
> + self.assertEqual(set_password_response['error']['desc'],
> + 'Could not set password')
> +
> + def test_vnc_change_password(self):
> + self.vm.add_args('-nodefaults', '-S', '-vnc', ':0,password')
> + self.vm.launch()
> + self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
> + set_password_response = self.vm.qmp('change',
> + device='vnc',
> + target='password',
> + arg='new_password')
> + self.assertEqual(set_password_response['return'], {})
> --
> 2.17.0
>
Fam
next prev parent reply other threads:[~2018-05-25 5:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 0:58 [Qemu-devel] [PATCH 0/5] Acceptance/functional tests Cleber Rosa
2018-05-25 0:58 ` [Qemu-devel] [PATCH 1/5] Add functional/acceptance tests infrastructure Cleber Rosa
2018-05-25 5:33 ` Fam Zheng
2018-05-25 16:15 ` Cleber Rosa
2018-05-25 0:58 ` [Qemu-devel] [PATCH 2/5] scripts/qemu.py: allow adding to the list of extra arguments Cleber Rosa
2018-05-25 0:58 ` [Qemu-devel] [PATCH 3/5] Acceptance tests: add quick VNC tests Cleber Rosa
2018-05-25 5:37 ` Fam Zheng [this message]
2018-05-25 16:27 ` Cleber Rosa
2018-05-29 14:32 ` Eduardo Habkost
2018-05-29 14:59 ` Cleber Rosa
2018-05-29 17:52 ` Eduardo Habkost
2018-05-29 19:36 ` Cleber Rosa
2018-05-25 0:58 ` [Qemu-devel] [PATCH 4/5] scripts/qemu.py: introduce set_console() method Cleber Rosa
2018-05-25 5:47 ` Fam Zheng
2018-05-25 16:57 ` Cleber Rosa
2018-05-29 19:06 ` Eduardo Habkost
2018-05-29 19:31 ` Cleber Rosa
2018-05-25 0:58 ` [Qemu-devel] [PATCH 5/5] Acceptance tests: add Linux kernel boot and console checking test Cleber Rosa
2018-05-25 1:14 ` [Qemu-devel] [PATCH 0/5] Acceptance/functional tests Cleber Rosa
2018-05-25 6:08 ` Fam Zheng
2018-05-25 17:04 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525053718.GB28589@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=amador@pahim.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.