From: Christoph Hellwig <hch@lst.de> To: Ralf Baechle <ralf@linux-mips.org>, James Hogan <jhogan@kernel.org> Cc: Kevin Cernekee <cernekee@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Huacai Chen <chenhc@lemote.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>, David Daney <david.daney@cavium.com>, Tom Bogendoerfer <tsbogend@alpha.franken.de>, linux-mips@linux-mips.org, iommu@lists.linux-foundation.org Subject: [PATCH 06/25] MIPS: loongson: remove loongson_dma_supported Date: Fri, 25 May 2018 11:20:52 +0200 [thread overview] Message-ID: <20180525092111.18516-7-hch@lst.de> (raw) In-Reply-To: <20180525092111.18516-1-hch@lst.de> swiotlb_dma_supported will always return true for the a mask large enough to be covered by wired up physical address, so this function is pointless. Signed-off-by: Christoph Hellwig <hch@lst.de> --- arch/mips/loongson64/common/dma-swiotlb.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/arch/mips/loongson64/common/dma-swiotlb.c b/arch/mips/loongson64/common/dma-swiotlb.c index 6a739f8ae110..a5e50f2ec301 100644 --- a/arch/mips/loongson64/common/dma-swiotlb.c +++ b/arch/mips/loongson64/common/dma-swiotlb.c @@ -56,13 +56,6 @@ static void loongson_dma_sync_sg_for_device(struct device *dev, mb(); } -static int loongson_dma_supported(struct device *dev, u64 mask) -{ - if (mask > DMA_BIT_MASK(loongson_sysconf.dma_mask_bits)) - return 0; - return swiotlb_dma_supported(dev, mask); -} - dma_addr_t __phys_to_dma(struct device *dev, phys_addr_t paddr) { long nid; @@ -99,7 +92,7 @@ static const struct dma_map_ops loongson_dma_map_ops = { .sync_sg_for_cpu = swiotlb_sync_sg_for_cpu, .sync_sg_for_device = loongson_dma_sync_sg_for_device, .mapping_error = swiotlb_dma_mapping_error, - .dma_supported = loongson_dma_supported, + .dma_supported = swiotlb_dma_supported, }; void __init plat_swiotlb_setup(void) -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> To: Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>, James Hogan <jhogan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, David Daney <david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>, Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Jiaxun Yang <jiaxun.yang-nEvAom26CKtBDgjK7y7TUQ@public.gmane.org>, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Tom Bogendoerfer <tsbogend-I1c7kopa9pxLokYuJOExCg@public.gmane.org>, Huacai Chen <chenhc-h23VmSynlr/QT0dZR+AlfA@public.gmane.org> Subject: [PATCH 06/25] MIPS: loongson: remove loongson_dma_supported Date: Fri, 25 May 2018 11:20:52 +0200 [thread overview] Message-ID: <20180525092111.18516-7-hch@lst.de> (raw) In-Reply-To: <20180525092111.18516-1-hch-jcswGhMUV9g@public.gmane.org> swiotlb_dma_supported will always return true for the a mask large enough to be covered by wired up physical address, so this function is pointless. Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> --- arch/mips/loongson64/common/dma-swiotlb.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/arch/mips/loongson64/common/dma-swiotlb.c b/arch/mips/loongson64/common/dma-swiotlb.c index 6a739f8ae110..a5e50f2ec301 100644 --- a/arch/mips/loongson64/common/dma-swiotlb.c +++ b/arch/mips/loongson64/common/dma-swiotlb.c @@ -56,13 +56,6 @@ static void loongson_dma_sync_sg_for_device(struct device *dev, mb(); } -static int loongson_dma_supported(struct device *dev, u64 mask) -{ - if (mask > DMA_BIT_MASK(loongson_sysconf.dma_mask_bits)) - return 0; - return swiotlb_dma_supported(dev, mask); -} - dma_addr_t __phys_to_dma(struct device *dev, phys_addr_t paddr) { long nid; @@ -99,7 +92,7 @@ static const struct dma_map_ops loongson_dma_map_ops = { .sync_sg_for_cpu = swiotlb_sync_sg_for_cpu, .sync_sg_for_device = loongson_dma_sync_sg_for_device, .mapping_error = swiotlb_dma_mapping_error, - .dma_supported = loongson_dma_supported, + .dma_supported = swiotlb_dma_supported, }; void __init plat_swiotlb_setup(void) -- 2.17.0
next prev parent reply other threads:[~2018-05-25 9:23 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-25 9:20 [RFC] switch mips to use the generic dma map ops Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 01/25] MIPS: remove a dead ifdef from mach-ath25/dma-coherence.h Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 02/25] MIPS: simplify CONFIG_DMA_NONCOHERENT ifdefs Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 03/25] MIPS: remove CONFIG_DMA_COHERENT Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 04/25] MIPS: Octeon: unexport __phys_to_dma and __dma_to_phys Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 05/25] MIPS: Octeon: refactor swiotlb code Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-30 23:25 ` Paul Burton 2018-05-30 23:25 ` Paul Burton 2018-05-30 23:25 ` Paul Burton 2018-05-31 16:38 ` Christoph Hellwig 2018-05-31 16:38 ` Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig [this message] 2018-05-25 9:20 ` [PATCH 06/25] MIPS: loongson: remove loongson_dma_supported Christoph Hellwig 2018-05-31 23:12 ` Paul Burton 2018-05-31 23:12 ` Paul Burton 2018-05-31 23:12 ` Paul Burton 2018-05-25 9:20 ` [PATCH 07/25] MIPS: consolidate the swiotlb implementations Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 08/25] MIPS: remove the mips_dma_map_ops indirection Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 09/25] MIPS: make the default mips dma implementation optional Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 10/25] MIPS: Octeon: remove mips dma-default stubs Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 11/25] MIPS: Octeon: move swiotlb declarations out of dma-coherence.h Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:20 ` [PATCH 12/25] MIPS: loongson: untangle dma implementations Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-07-11 12:46 ` Maciej W. Rozycki 2018-07-11 12:46 ` Maciej W. Rozycki 2018-07-11 12:46 ` Maciej W. Rozycki 2018-07-11 12:57 ` Christoph Hellwig 2018-07-11 12:57 ` Christoph Hellwig 2018-07-11 13:21 ` Maciej W. Rozycki 2018-07-11 13:21 ` Maciej W. Rozycki 2018-07-11 13:21 ` Maciej W. Rozycki 2018-05-25 9:20 ` [PATCH 13/25] MIPS: loongson: remove loongson-3 handling from dma-coherence.h Christoph Hellwig 2018-05-25 9:20 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 14/25] MIPS: use dma_direct_ops for coherent I/O Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 15/25] MIPS: IP27: use dma_direct_ops Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 16/25] MIPS: move coherentio setup to setup.c Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 17/25] MIPS: use generic dma noncoherent ops for simple noncoherent platforms Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 18/25] MIPS: loongson64: use generic dma noncoherent ops Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 19/25] MIPS: IP32: " Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 20/25] MIPS: ath25: " Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 21/25] MIPS: jazz: split dma mapping operations from dma-default Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 22/25] dma-noncoherent: add a arch_sync_dma_for_cpu_all hook Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 23/25] MIPS: bmips: use generic dma noncoherent ops Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 24/25] MIPS: remove the old dma-default implementation Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-05-25 9:21 ` [PATCH 25/25] MIPS: remove unneeded includes from dma-mapping.h Christoph Hellwig 2018-05-25 9:21 ` Christoph Hellwig 2018-06-15 11:08 switch mips to use the generic dma map ops v2 Christoph Hellwig 2018-06-15 11:08 ` [PATCH 06/25] MIPS: loongson: remove loongson_dma_supported Christoph Hellwig 2018-06-15 11:08 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180525092111.18516-7-hch@lst.de \ --to=hch@lst.de \ --cc=cernekee@gmail.com \ --cc=chenhc@lemote.com \ --cc=david.daney@cavium.com \ --cc=f.fainelli@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jhogan@kernel.org \ --cc=jiaxun.yang@flygoat.com \ --cc=linux-mips@linux-mips.org \ --cc=ralf@linux-mips.org \ --cc=tsbogend@alpha.franken.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.