From: Christoph Hellwig <hch@lst.de> To: Johannes Thumshirn <jthumshirn@suse.de> Cc: Christoph Hellwig <hch@lst.de>, linux-nvme@lists.infradead.org, Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>, linux-block@vger.kernel.org Subject: Re: [PATCH 08/14] nvmet: implement the changed namespaces log Date: Tue, 29 May 2018 10:17:12 +0200 [thread overview] Message-ID: <20180529081712.GD1416@lst.de> (raw) In-Reply-To: <20180528065342.hi74ewwbvkoqsj6x@linux-x5ow.site> On Mon, May 28, 2018 at 08:53:42AM +0200, Johannes Thumshirn wrote: > Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> > > As a side note, what happens if more than 1024 Namespaces are changed > (apart from setting the 1st element to 0xffffffff and zeroing out the > rest)? > > The Spec is pretty silent in this regard. The spec is completly clear on this: >From 5.14.1.4: "If more than 1024 namespaces have changed attributes since the last time the log page was read, the first entry in the log page shall be set to FFFFFFFFh and the remainder of the list shall be zero-filled." Once we don't know what changed we'll have to do a full rescan using Identify.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig) Subject: [PATCH 08/14] nvmet: implement the changed namespaces log Date: Tue, 29 May 2018 10:17:12 +0200 [thread overview] Message-ID: <20180529081712.GD1416@lst.de> (raw) In-Reply-To: <20180528065342.hi74ewwbvkoqsj6x@linux-x5ow.site> On Mon, May 28, 2018@08:53:42AM +0200, Johannes Thumshirn wrote: > Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de> > > As a side note, what happens if more than 1024 Namespaces are changed > (apart from setting the 1st element to 0xffffffff and zeroing out the > rest)? > > The Spec is pretty silent in this regard. The spec is completly clear on this: >From 5.14.1.4: "If more than 1024 namespaces have changed attributes since the last time the log page was read, the first entry in the log page shall be set to FFFFFFFFh and the remainder of the list shall be zero-filled." Once we don't know what changed we'll have to do a full rescan using Identify.
next prev parent reply other threads:[~2018-05-29 8:17 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-26 10:27 nvme/nvmet AEN and log page fixups Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-26 10:27 ` [PATCH 01/14] block: unexport check_disk_size_change Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:33 ` Johannes Thumshirn 2018-05-28 6:33 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 02/14] block: don't print a message when the device went away Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:34 ` Johannes Thumshirn 2018-05-28 6:34 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 03/14] nvme.h: untangle AEN notice definitions Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:35 ` Johannes Thumshirn 2018-05-28 6:35 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 04/14] nvme.h: add the changed namespace list log Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:35 ` Johannes Thumshirn 2018-05-28 6:35 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 05/14] nvme.h: add AER configuration symbols Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:35 ` Johannes Thumshirn 2018-05-28 6:35 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 06/14] nvmet: add a new nvmet_zero_sgl helper Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:36 ` Johannes Thumshirn 2018-05-28 6:36 ` Johannes Thumshirn 2018-05-29 8:13 ` Christoph Hellwig 2018-05-29 8:13 ` Christoph Hellwig 2018-05-26 10:27 ` [PATCH 07/14] nvmet: split log page implementation Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:38 ` Johannes Thumshirn 2018-05-28 6:38 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 08/14] nvmet: implement the changed namespaces log Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:53 ` Johannes Thumshirn 2018-05-28 6:53 ` Johannes Thumshirn 2018-05-29 8:17 ` Christoph Hellwig [this message] 2018-05-29 8:17 ` Christoph Hellwig 2018-05-29 8:16 ` Johannes Thumshirn 2018-05-29 8:16 ` Johannes Thumshirn 2018-05-29 8:24 ` Christoph Hellwig 2018-05-29 8:24 ` Christoph Hellwig 2018-05-29 16:59 ` Verkamp, Daniel 2018-05-29 16:59 ` Verkamp, Daniel 2018-05-29 17:24 ` Christoph Hellwig 2018-05-29 17:24 ` Christoph Hellwig 2018-05-29 20:44 ` Daniel Verkamp 2018-05-29 20:44 ` Daniel Verkamp 2018-05-26 10:27 ` [PATCH 09/14] nvmet: Add AEN configuration support Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:54 ` Johannes Thumshirn 2018-05-28 6:54 ` Johannes Thumshirn 2018-05-29 17:15 ` Verkamp, Daniel 2018-05-29 17:15 ` Verkamp, Daniel 2018-05-29 17:29 ` Christoph Hellwig 2018-05-29 17:29 ` Christoph Hellwig 2018-05-29 17:35 ` Verkamp, Daniel 2018-05-29 17:35 ` Verkamp, Daniel 2018-05-29 17:45 ` Christoph Hellwig 2018-05-29 17:45 ` Christoph Hellwig 2018-05-26 10:27 ` [PATCH 10/14] nvmet: mask pending AERs Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:56 ` Johannes Thumshirn 2018-05-28 6:56 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 11/14] nvme: submit AEN event configuration on startup Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:56 ` Johannes Thumshirn 2018-05-28 6:56 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 12/14] nvme: mark nvme_queue_scan static Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 6:57 ` Johannes Thumshirn 2018-05-28 6:57 ` Johannes Thumshirn 2018-05-26 10:27 ` [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-26 12:05 ` Popuri, Sriram 2018-05-26 12:05 ` Popuri, Sriram 2018-05-26 12:21 ` Christoph Hellwig 2018-05-26 12:21 ` Christoph Hellwig 2018-05-26 13:02 ` Knight, Frederick 2018-05-28 6:59 ` Johannes Thumshirn 2018-05-28 6:59 ` Johannes Thumshirn 2018-06-04 19:59 ` Keith Busch 2018-06-04 19:59 ` Keith Busch 2018-06-05 4:47 ` Christoph Hellwig 2018-06-05 4:47 ` Christoph Hellwig 2018-06-05 14:37 ` Keith Busch 2018-06-05 14:37 ` Keith Busch 2018-05-26 10:27 ` [PATCH 14/14] nvme: limit warnings from nvme_identify_ns Christoph Hellwig 2018-05-26 10:27 ` Christoph Hellwig 2018-05-28 7:00 ` Johannes Thumshirn 2018-05-28 7:00 ` Johannes Thumshirn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180529081712.GD1416@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=hare@suse.de \ --cc=jthumshirn@suse.de \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.