All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-05-30 13:19 ` Clément Péron
  0 siblings, 0 replies; 18+ messages in thread
From: Clément Péron @ 2018-05-30 13:19 UTC (permalink / raw)
  To: Florian Fainelli, linux-arm-kernel
  Cc: Russell King, linux-kernel, Tony Lindgren, Laura Abbott,
	Scott Branden, Jon Mason, Ray Jui, BCM Kernel Feedback,
	Clément Peron

From: Clément Peron <clement.peron@devialet.com>

Broadcom Iproc SoCs typically use the UART3 for
debug/console, provide a known good location for that.

Signed-off-by: Clément Peron <clement.peron@devialet.com>
---

 arch/arm/Kconfig.debug | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 199ebc1c4538..4ea9d5793b91 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -207,6 +207,14 @@ choice
 		depends on ARCH_BCM_HR2
 		select DEBUG_UART_8250
 
+	config DEBUG_BCM_IPROC_UART3
+		bool "Kernel low-level debugging on BCM IPROC UART3"
+		depends on ARCH_BCM_CYGNUS
+		select DEBUG_UART_8250
+		help
+		  Say Y here if you want the debug print routines to direct
+		  their output to the third serial port on these devices.
+
 	config DEBUG_BCM_KONA_UART
 		bool "Kernel low-level debugging messages via BCM KONA UART"
 		depends on ARCH_BCM_MOBILE
@@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
 	default 0x18000400 if DEBUG_BCM_HR2
 	default 0x18010000 if DEBUG_SIRFATLAS7_UART0
 	default 0x18020000 if DEBUG_SIRFATLAS7_UART1
+	default 0x18023000 if DEBUG_BCM_IPROC_UART3
 	default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
 	default 0x20001000 if DEBUG_HIP01_UART
 	default 0x20060000 if DEBUG_RK29_UART0
@@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
 	default 0xf1002000 if DEBUG_MT8127_UART0
 	default 0xf1006000 if DEBUG_MT6589_UART0
 	default 0xf1009000 if DEBUG_MT8135_UART3
+	default 0xf1023000 if DEBUG_BCM_IPROC_UART3
 	default 0xf11f1000 if DEBUG_VERSATILE
 	default 0xf1600000 if DEBUG_INTEGRATOR
 	default 0xf1c28000 if DEBUG_SUNXI_UART0
@@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
 		DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
 		DEBUG_ALPINE_UART0 || \
 		DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
-		DEBUG_DAVINCI_DA8XX_UART2 || \
+		DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
 		DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
 
 config DEBUG_UART_8250_PALMCHIP
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-05-30 13:19 ` Clément Péron
  0 siblings, 0 replies; 18+ messages in thread
From: Clément Péron @ 2018-05-30 13:19 UTC (permalink / raw)
  To: linux-arm-kernel

From: Cl?ment Peron <clement.peron@devialet.com>

Broadcom Iproc SoCs typically use the UART3 for
debug/console, provide a known good location for that.

Signed-off-by: Cl?ment Peron <clement.peron@devialet.com>
---

 arch/arm/Kconfig.debug | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 199ebc1c4538..4ea9d5793b91 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -207,6 +207,14 @@ choice
 		depends on ARCH_BCM_HR2
 		select DEBUG_UART_8250
 
+	config DEBUG_BCM_IPROC_UART3
+		bool "Kernel low-level debugging on BCM IPROC UART3"
+		depends on ARCH_BCM_CYGNUS
+		select DEBUG_UART_8250
+		help
+		  Say Y here if you want the debug print routines to direct
+		  their output to the third serial port on these devices.
+
 	config DEBUG_BCM_KONA_UART
 		bool "Kernel low-level debugging messages via BCM KONA UART"
 		depends on ARCH_BCM_MOBILE
@@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
 	default 0x18000400 if DEBUG_BCM_HR2
 	default 0x18010000 if DEBUG_SIRFATLAS7_UART0
 	default 0x18020000 if DEBUG_SIRFATLAS7_UART1
+	default 0x18023000 if DEBUG_BCM_IPROC_UART3
 	default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
 	default 0x20001000 if DEBUG_HIP01_UART
 	default 0x20060000 if DEBUG_RK29_UART0
@@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
 	default 0xf1002000 if DEBUG_MT8127_UART0
 	default 0xf1006000 if DEBUG_MT6589_UART0
 	default 0xf1009000 if DEBUG_MT8135_UART3
+	default 0xf1023000 if DEBUG_BCM_IPROC_UART3
 	default 0xf11f1000 if DEBUG_VERSATILE
 	default 0xf1600000 if DEBUG_INTEGRATOR
 	default 0xf1c28000 if DEBUG_SUNXI_UART0
@@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
 		DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
 		DEBUG_ALPINE_UART0 || \
 		DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
-		DEBUG_DAVINCI_DA8XX_UART2 || \
+		DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
 		DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
 
 config DEBUG_UART_8250_PALMCHIP
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 2/2] ARM: debug: fix BCM2836 order entry
  2018-05-30 13:19 ` Clément Péron
@ 2018-05-30 13:19   ` Clément Péron
  -1 siblings, 0 replies; 18+ messages in thread
From: Clément Péron @ 2018-05-30 13:19 UTC (permalink / raw)
  To: Florian Fainelli, linux-arm-kernel
  Cc: Russell King, linux-kernel, Tony Lindgren, Laura Abbott,
	Scott Branden, Jon Mason, Ray Jui, BCM Kernel Feedback,
	Clément Peron

From: Clément Peron <clement.peron@devialet.com>

Entries are sorted by their address value, except the BCM2836/KONA
which are not in the proper order.

Signed-off-by: Clément Peron <clement.peron@devialet.com>
---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 4ea9d5793b91..1571d6c8f40e 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1572,8 +1572,8 @@ config DEBUG_UART_PHYS
 	default 0x20064000 if DEBUG_RK29_UART1 || DEBUG_RK3X_UART2
 	default 0x20068000 if DEBUG_RK29_UART2 || DEBUG_RK3X_UART3
 	default 0x20201000 if DEBUG_BCM2835
-	default 0x3f201000 if DEBUG_BCM2836
 	default 0x3e000000 if DEBUG_BCM_KONA_UART
+	default 0x3f201000 if DEBUG_BCM2836
 	default 0x4000e400 if DEBUG_LL_UART_EFM32
 	default 0x40028000 if DEBUG_AT91_SAMV7_USART1
 	default 0x40081000 if DEBUG_LPC18XX_UART0
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 2/2] ARM: debug: fix BCM2836 order entry
@ 2018-05-30 13:19   ` Clément Péron
  0 siblings, 0 replies; 18+ messages in thread
From: Clément Péron @ 2018-05-30 13:19 UTC (permalink / raw)
  To: linux-arm-kernel

From: Cl?ment Peron <clement.peron@devialet.com>

Entries are sorted by their address value, except the BCM2836/KONA
which are not in the proper order.

Signed-off-by: Cl?ment Peron <clement.peron@devialet.com>
---
 arch/arm/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 4ea9d5793b91..1571d6c8f40e 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1572,8 +1572,8 @@ config DEBUG_UART_PHYS
 	default 0x20064000 if DEBUG_RK29_UART1 || DEBUG_RK3X_UART2
 	default 0x20068000 if DEBUG_RK29_UART2 || DEBUG_RK3X_UART3
 	default 0x20201000 if DEBUG_BCM2835
-	default 0x3f201000 if DEBUG_BCM2836
 	default 0x3e000000 if DEBUG_BCM_KONA_UART
+	default 0x3f201000 if DEBUG_BCM2836
 	default 0x4000e400 if DEBUG_LL_UART_EFM32
 	default 0x40028000 if DEBUG_AT91_SAMV7_USART1
 	default 0x40081000 if DEBUG_LPC18XX_UART0
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
  2018-05-30 13:19 ` Clément Péron
@ 2018-05-30 17:25   ` Ray Jui
  -1 siblings, 0 replies; 18+ messages in thread
From: Ray Jui @ 2018-05-30 17:25 UTC (permalink / raw)
  To: Clément Péron, Florian Fainelli, linux-arm-kernel
  Cc: Russell King, linux-kernel, Tony Lindgren, Laura Abbott,
	Scott Branden, Jon Mason, Ray Jui, BCM Kernel Feedback,
	Clément Peron

Hi Clément,

Correct me if I'm wrong, but I thought the trend is to move to use 
earlycon that can be activated from kernel command line for early print 
before the serial driver is loaded.

Have you tried earlcon?

Thanks,

Ray

On 5/30/2018 6:19 AM, Clément Péron wrote:
> From: Clément Peron <clement.peron@devialet.com>
> 
> Broadcom Iproc SoCs typically use the UART3 for
> debug/console, provide a known good location for that.
> 
> Signed-off-by: Clément Peron <clement.peron@devialet.com>
> ---
> 
>   arch/arm/Kconfig.debug | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 199ebc1c4538..4ea9d5793b91 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -207,6 +207,14 @@ choice
>   		depends on ARCH_BCM_HR2
>   		select DEBUG_UART_8250
>   
> +	config DEBUG_BCM_IPROC_UART3
> +		bool "Kernel low-level debugging on BCM IPROC UART3"
> +		depends on ARCH_BCM_CYGNUS
> +		select DEBUG_UART_8250
> +		help
> +		  Say Y here if you want the debug print routines to direct
> +		  their output to the third serial port on these devices.
> +
>   	config DEBUG_BCM_KONA_UART
>   		bool "Kernel low-level debugging messages via BCM KONA UART"
>   		depends on ARCH_BCM_MOBILE
> @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
>   	default 0x18000400 if DEBUG_BCM_HR2
>   	default 0x18010000 if DEBUG_SIRFATLAS7_UART0
>   	default 0x18020000 if DEBUG_SIRFATLAS7_UART1
> +	default 0x18023000 if DEBUG_BCM_IPROC_UART3
>   	default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
>   	default 0x20001000 if DEBUG_HIP01_UART
>   	default 0x20060000 if DEBUG_RK29_UART0
> @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
>   	default 0xf1002000 if DEBUG_MT8127_UART0
>   	default 0xf1006000 if DEBUG_MT6589_UART0
>   	default 0xf1009000 if DEBUG_MT8135_UART3
> +	default 0xf1023000 if DEBUG_BCM_IPROC_UART3
>   	default 0xf11f1000 if DEBUG_VERSATILE
>   	default 0xf1600000 if DEBUG_INTEGRATOR
>   	default 0xf1c28000 if DEBUG_SUNXI_UART0
> @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
>   		DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
>   		DEBUG_ALPINE_UART0 || \
>   		DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
> -		DEBUG_DAVINCI_DA8XX_UART2 || \
> +		DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
>   		DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
>   
>   config DEBUG_UART_8250_PALMCHIP
> 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-05-30 17:25   ` Ray Jui
  0 siblings, 0 replies; 18+ messages in thread
From: Ray Jui @ 2018-05-30 17:25 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Cl?ment,

Correct me if I'm wrong, but I thought the trend is to move to use 
earlycon that can be activated from kernel command line for early print 
before the serial driver is loaded.

Have you tried earlcon?

Thanks,

Ray

On 5/30/2018 6:19 AM, Cl?ment P?ron wrote:
> From: Cl?ment Peron <clement.peron@devialet.com>
> 
> Broadcom Iproc SoCs typically use the UART3 for
> debug/console, provide a known good location for that.
> 
> Signed-off-by: Cl?ment Peron <clement.peron@devialet.com>
> ---
> 
>   arch/arm/Kconfig.debug | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 199ebc1c4538..4ea9d5793b91 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -207,6 +207,14 @@ choice
>   		depends on ARCH_BCM_HR2
>   		select DEBUG_UART_8250
>   
> +	config DEBUG_BCM_IPROC_UART3
> +		bool "Kernel low-level debugging on BCM IPROC UART3"
> +		depends on ARCH_BCM_CYGNUS
> +		select DEBUG_UART_8250
> +		help
> +		  Say Y here if you want the debug print routines to direct
> +		  their output to the third serial port on these devices.
> +
>   	config DEBUG_BCM_KONA_UART
>   		bool "Kernel low-level debugging messages via BCM KONA UART"
>   		depends on ARCH_BCM_MOBILE
> @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
>   	default 0x18000400 if DEBUG_BCM_HR2
>   	default 0x18010000 if DEBUG_SIRFATLAS7_UART0
>   	default 0x18020000 if DEBUG_SIRFATLAS7_UART1
> +	default 0x18023000 if DEBUG_BCM_IPROC_UART3
>   	default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
>   	default 0x20001000 if DEBUG_HIP01_UART
>   	default 0x20060000 if DEBUG_RK29_UART0
> @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
>   	default 0xf1002000 if DEBUG_MT8127_UART0
>   	default 0xf1006000 if DEBUG_MT6589_UART0
>   	default 0xf1009000 if DEBUG_MT8135_UART3
> +	default 0xf1023000 if DEBUG_BCM_IPROC_UART3
>   	default 0xf11f1000 if DEBUG_VERSATILE
>   	default 0xf1600000 if DEBUG_INTEGRATOR
>   	default 0xf1c28000 if DEBUG_SUNXI_UART0
> @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
>   		DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
>   		DEBUG_ALPINE_UART0 || \
>   		DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
> -		DEBUG_DAVINCI_DA8XX_UART2 || \
> +		DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
>   		DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
>   
>   config DEBUG_UART_8250_PALMCHIP
> 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
  2018-05-30 17:25   ` Ray Jui
@ 2018-05-31  8:22     ` Clément Péron
  -1 siblings, 0 replies; 18+ messages in thread
From: Clément Péron @ 2018-05-31  8:22 UTC (permalink / raw)
  To: Ray Jui
  Cc: Florian Fainelli, linux-arm-kernel, Russell King, linux-kernel,
	Tony Lindgren, Laura Abbott, Scott Branden, Jon Mason, Ray Jui,
	BCM Kernel Feedback, Clément Peron

Hi Rai,

On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>
> Hi Clément,
>
> Correct me if I'm wrong, but I thought the trend is to move to use
> earlycon that can be activated from kernel command line for early print
> before the serial driver is loaded.
>
> Have you tried earlcon?
No, only tested this method.

Thanks,
Clement

>
> Thanks,
>
> Ray
>
> On 5/30/2018 6:19 AM, Clément Péron wrote:
> > From: Clément Peron <clement.peron@devialet.com>
> >
> > Broadcom Iproc SoCs typically use the UART3 for
> > debug/console, provide a known good location for that.
> >
> > Signed-off-by: Clément Peron <clement.peron@devialet.com>
> > ---
> >
> >   arch/arm/Kconfig.debug | 12 +++++++++++-
> >   1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 199ebc1c4538..4ea9d5793b91 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -207,6 +207,14 @@ choice
> >               depends on ARCH_BCM_HR2
> >               select DEBUG_UART_8250
> >
> > +     config DEBUG_BCM_IPROC_UART3
> > +             bool "Kernel low-level debugging on BCM IPROC UART3"
> > +             depends on ARCH_BCM_CYGNUS
> > +             select DEBUG_UART_8250
> > +             help
> > +               Say Y here if you want the debug print routines to direct
> > +               their output to the third serial port on these devices.
> > +
> >       config DEBUG_BCM_KONA_UART
> >               bool "Kernel low-level debugging messages via BCM KONA UART"
> >               depends on ARCH_BCM_MOBILE
> > @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
> >       default 0x18000400 if DEBUG_BCM_HR2
> >       default 0x18010000 if DEBUG_SIRFATLAS7_UART0
> >       default 0x18020000 if DEBUG_SIRFATLAS7_UART1
> > +     default 0x18023000 if DEBUG_BCM_IPROC_UART3
> >       default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
> >       default 0x20001000 if DEBUG_HIP01_UART
> >       default 0x20060000 if DEBUG_RK29_UART0
> > @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
> >       default 0xf1002000 if DEBUG_MT8127_UART0
> >       default 0xf1006000 if DEBUG_MT6589_UART0
> >       default 0xf1009000 if DEBUG_MT8135_UART3
> > +     default 0xf1023000 if DEBUG_BCM_IPROC_UART3
> >       default 0xf11f1000 if DEBUG_VERSATILE
> >       default 0xf1600000 if DEBUG_INTEGRATOR
> >       default 0xf1c28000 if DEBUG_SUNXI_UART0
> > @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
> >               DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
> >               DEBUG_ALPINE_UART0 || \
> >               DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
> > -             DEBUG_DAVINCI_DA8XX_UART2 || \
> > +             DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
> >               DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
> >
> >   config DEBUG_UART_8250_PALMCHIP
> >

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-05-31  8:22     ` Clément Péron
  0 siblings, 0 replies; 18+ messages in thread
From: Clément Péron @ 2018-05-31  8:22 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Rai,

On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>
> Hi Cl?ment,
>
> Correct me if I'm wrong, but I thought the trend is to move to use
> earlycon that can be activated from kernel command line for early print
> before the serial driver is loaded.
>
> Have you tried earlcon?
No, only tested this method.

Thanks,
Clement

>
> Thanks,
>
> Ray
>
> On 5/30/2018 6:19 AM, Cl?ment P?ron wrote:
> > From: Cl?ment Peron <clement.peron@devialet.com>
> >
> > Broadcom Iproc SoCs typically use the UART3 for
> > debug/console, provide a known good location for that.
> >
> > Signed-off-by: Cl?ment Peron <clement.peron@devialet.com>
> > ---
> >
> >   arch/arm/Kconfig.debug | 12 +++++++++++-
> >   1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 199ebc1c4538..4ea9d5793b91 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -207,6 +207,14 @@ choice
> >               depends on ARCH_BCM_HR2
> >               select DEBUG_UART_8250
> >
> > +     config DEBUG_BCM_IPROC_UART3
> > +             bool "Kernel low-level debugging on BCM IPROC UART3"
> > +             depends on ARCH_BCM_CYGNUS
> > +             select DEBUG_UART_8250
> > +             help
> > +               Say Y here if you want the debug print routines to direct
> > +               their output to the third serial port on these devices.
> > +
> >       config DEBUG_BCM_KONA_UART
> >               bool "Kernel low-level debugging messages via BCM KONA UART"
> >               depends on ARCH_BCM_MOBILE
> > @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
> >       default 0x18000400 if DEBUG_BCM_HR2
> >       default 0x18010000 if DEBUG_SIRFATLAS7_UART0
> >       default 0x18020000 if DEBUG_SIRFATLAS7_UART1
> > +     default 0x18023000 if DEBUG_BCM_IPROC_UART3
> >       default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
> >       default 0x20001000 if DEBUG_HIP01_UART
> >       default 0x20060000 if DEBUG_RK29_UART0
> > @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
> >       default 0xf1002000 if DEBUG_MT8127_UART0
> >       default 0xf1006000 if DEBUG_MT6589_UART0
> >       default 0xf1009000 if DEBUG_MT8135_UART3
> > +     default 0xf1023000 if DEBUG_BCM_IPROC_UART3
> >       default 0xf11f1000 if DEBUG_VERSATILE
> >       default 0xf1600000 if DEBUG_INTEGRATOR
> >       default 0xf1c28000 if DEBUG_SUNXI_UART0
> > @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
> >               DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
> >               DEBUG_ALPINE_UART0 || \
> >               DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
> > -             DEBUG_DAVINCI_DA8XX_UART2 || \
> > +             DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
> >               DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
> >
> >   config DEBUG_UART_8250_PALMCHIP
> >

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
  2018-05-31  8:22     ` Clément Péron
@ 2018-05-31 17:24       ` Ray Jui
  -1 siblings, 0 replies; 18+ messages in thread
From: Ray Jui @ 2018-05-31 17:24 UTC (permalink / raw)
  To: Clément Péron
  Cc: Florian Fainelli, linux-arm-kernel, Russell King, linux-kernel,
	Tony Lindgren, Laura Abbott, Scott Branden, Jon Mason, Ray Jui,
	BCM Kernel Feedback, Clément Peron



On 5/31/2018 1:22 AM, Clément Péron wrote:
> Hi Rai,
> 
> On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>>
>> Hi Clément,
>>
>> Correct me if I'm wrong, but I thought the trend is to move to use
>> earlycon that can be activated from kernel command line for early print
>> before the serial driver is loaded.
>>
>> Have you tried earlcon?
> No, only tested this method.
> 
> Thanks,
> Clement
> 

If I remember it correctly, I think the trend is to use earlycon. There 
are obvious shortcomings by making this configuration compile time based.

>>
>> Thanks,
>>
>> Ray
>>
>> On 5/30/2018 6:19 AM, Clément Péron wrote:
>>> From: Clément Peron <clement.peron@devialet.com>
>>>
>>> Broadcom Iproc SoCs typically use the UART3 for
>>> debug/console, provide a known good location for that.
>>>
>>> Signed-off-by: Clément Peron <clement.peron@devialet.com>
>>> ---
>>>
>>>    arch/arm/Kconfig.debug | 12 +++++++++++-
>>>    1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>>> index 199ebc1c4538..4ea9d5793b91 100644
>>> --- a/arch/arm/Kconfig.debug
>>> +++ b/arch/arm/Kconfig.debug
>>> @@ -207,6 +207,14 @@ choice
>>>                depends on ARCH_BCM_HR2
>>>                select DEBUG_UART_8250
>>>
>>> +     config DEBUG_BCM_IPROC_UART3
>>> +             bool "Kernel low-level debugging on BCM IPROC UART3"
>>> +             depends on ARCH_BCM_CYGNUS
>>> +             select DEBUG_UART_8250
>>> +             help
>>> +               Say Y here if you want the debug print routines to direct
>>> +               their output to the third serial port on these devices.
>>> +
>>>        config DEBUG_BCM_KONA_UART
>>>                bool "Kernel low-level debugging messages via BCM KONA UART"
>>>                depends on ARCH_BCM_MOBILE
>>> @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
>>>        default 0x18000400 if DEBUG_BCM_HR2
>>>        default 0x18010000 if DEBUG_SIRFATLAS7_UART0
>>>        default 0x18020000 if DEBUG_SIRFATLAS7_UART1
>>> +     default 0x18023000 if DEBUG_BCM_IPROC_UART3
>>>        default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
>>>        default 0x20001000 if DEBUG_HIP01_UART
>>>        default 0x20060000 if DEBUG_RK29_UART0
>>> @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
>>>        default 0xf1002000 if DEBUG_MT8127_UART0
>>>        default 0xf1006000 if DEBUG_MT6589_UART0
>>>        default 0xf1009000 if DEBUG_MT8135_UART3
>>> +     default 0xf1023000 if DEBUG_BCM_IPROC_UART3
>>>        default 0xf11f1000 if DEBUG_VERSATILE
>>>        default 0xf1600000 if DEBUG_INTEGRATOR
>>>        default 0xf1c28000 if DEBUG_SUNXI_UART0
>>> @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
>>>                DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
>>>                DEBUG_ALPINE_UART0 || \
>>>                DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
>>> -             DEBUG_DAVINCI_DA8XX_UART2 || \
>>> +             DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
>>>                DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
>>>
>>>    config DEBUG_UART_8250_PALMCHIP
>>>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-05-31 17:24       ` Ray Jui
  0 siblings, 0 replies; 18+ messages in thread
From: Ray Jui @ 2018-05-31 17:24 UTC (permalink / raw)
  To: linux-arm-kernel



On 5/31/2018 1:22 AM, Cl?ment P?ron wrote:
> Hi Rai,
> 
> On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>>
>> Hi Cl?ment,
>>
>> Correct me if I'm wrong, but I thought the trend is to move to use
>> earlycon that can be activated from kernel command line for early print
>> before the serial driver is loaded.
>>
>> Have you tried earlcon?
> No, only tested this method.
> 
> Thanks,
> Clement
> 

If I remember it correctly, I think the trend is to use earlycon. There 
are obvious shortcomings by making this configuration compile time based.

>>
>> Thanks,
>>
>> Ray
>>
>> On 5/30/2018 6:19 AM, Cl?ment P?ron wrote:
>>> From: Cl?ment Peron <clement.peron@devialet.com>
>>>
>>> Broadcom Iproc SoCs typically use the UART3 for
>>> debug/console, provide a known good location for that.
>>>
>>> Signed-off-by: Cl?ment Peron <clement.peron@devialet.com>
>>> ---
>>>
>>>    arch/arm/Kconfig.debug | 12 +++++++++++-
>>>    1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>>> index 199ebc1c4538..4ea9d5793b91 100644
>>> --- a/arch/arm/Kconfig.debug
>>> +++ b/arch/arm/Kconfig.debug
>>> @@ -207,6 +207,14 @@ choice
>>>                depends on ARCH_BCM_HR2
>>>                select DEBUG_UART_8250
>>>
>>> +     config DEBUG_BCM_IPROC_UART3
>>> +             bool "Kernel low-level debugging on BCM IPROC UART3"
>>> +             depends on ARCH_BCM_CYGNUS
>>> +             select DEBUG_UART_8250
>>> +             help
>>> +               Say Y here if you want the debug print routines to direct
>>> +               their output to the third serial port on these devices.
>>> +
>>>        config DEBUG_BCM_KONA_UART
>>>                bool "Kernel low-level debugging messages via BCM KONA UART"
>>>                depends on ARCH_BCM_MOBILE
>>> @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
>>>        default 0x18000400 if DEBUG_BCM_HR2
>>>        default 0x18010000 if DEBUG_SIRFATLAS7_UART0
>>>        default 0x18020000 if DEBUG_SIRFATLAS7_UART1
>>> +     default 0x18023000 if DEBUG_BCM_IPROC_UART3
>>>        default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
>>>        default 0x20001000 if DEBUG_HIP01_UART
>>>        default 0x20060000 if DEBUG_RK29_UART0
>>> @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
>>>        default 0xf1002000 if DEBUG_MT8127_UART0
>>>        default 0xf1006000 if DEBUG_MT6589_UART0
>>>        default 0xf1009000 if DEBUG_MT8135_UART3
>>> +     default 0xf1023000 if DEBUG_BCM_IPROC_UART3
>>>        default 0xf11f1000 if DEBUG_VERSATILE
>>>        default 0xf1600000 if DEBUG_INTEGRATOR
>>>        default 0xf1c28000 if DEBUG_SUNXI_UART0
>>> @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
>>>                DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
>>>                DEBUG_ALPINE_UART0 || \
>>>                DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
>>> -             DEBUG_DAVINCI_DA8XX_UART2 || \
>>> +             DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
>>>                DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
>>>
>>>    config DEBUG_UART_8250_PALMCHIP
>>>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
  2018-05-31 17:24       ` Ray Jui
@ 2018-05-31 22:16         ` Florian Fainelli
  -1 siblings, 0 replies; 18+ messages in thread
From: Florian Fainelli @ 2018-05-31 22:16 UTC (permalink / raw)
  To: Ray Jui, Clément Péron
  Cc: Florian Fainelli, linux-arm-kernel, Russell King, linux-kernel,
	Tony Lindgren, Laura Abbott, Scott Branden, Jon Mason, Ray Jui,
	BCM Kernel Feedback, Clément Peron



On 05/31/2018 10:24 AM, Ray Jui wrote:
> 
> 
> On 5/31/2018 1:22 AM, Clément Péron wrote:
>> Hi Rai,
>>
>> On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>>>
>>> Hi Clément,
>>>
>>> Correct me if I'm wrong, but I thought the trend is to move to use
>>> earlycon that can be activated from kernel command line for early print
>>> before the serial driver is loaded.
>>>
>>> Have you tried earlcon?
>> No, only tested this method.
>>
>> Thanks,
>> Clement
>>
> 
> If I remember it correctly, I think the trend is to use earlycon. There
> are obvious shortcomings by making this configuration compile time based.

This is true, though on ARM 32-bit kernels DEBUG_LL gets used by the
kernel self-decompressor and also before earlycon has a chance to run,
this is useful to debugging memory issues where your memory
configuration is incorrect typically.

Either way is fine with me (accepting or dropping) the patch, though
there is probably minimal impact in just accepting such a change.

-- 
Florian

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-05-31 22:16         ` Florian Fainelli
  0 siblings, 0 replies; 18+ messages in thread
From: Florian Fainelli @ 2018-05-31 22:16 UTC (permalink / raw)
  To: linux-arm-kernel



On 05/31/2018 10:24 AM, Ray Jui wrote:
> 
> 
> On 5/31/2018 1:22 AM, Cl?ment P?ron wrote:
>> Hi Rai,
>>
>> On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>>>
>>> Hi Cl?ment,
>>>
>>> Correct me if I'm wrong, but I thought the trend is to move to use
>>> earlycon that can be activated from kernel command line for early print
>>> before the serial driver is loaded.
>>>
>>> Have you tried earlcon?
>> No, only tested this method.
>>
>> Thanks,
>> Clement
>>
> 
> If I remember it correctly, I think the trend is to use earlycon. There
> are obvious shortcomings by making this configuration compile time based.

This is true, though on ARM 32-bit kernels DEBUG_LL gets used by the
kernel self-decompressor and also before earlycon has a chance to run,
this is useful to debugging memory issues where your memory
configuration is incorrect typically.

Either way is fine with me (accepting or dropping) the patch, though
there is probably minimal impact in just accepting such a change.

-- 
Florian

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
  2018-05-31 22:16         ` Florian Fainelli
@ 2018-06-01 17:54           ` Ray Jui
  -1 siblings, 0 replies; 18+ messages in thread
From: Ray Jui @ 2018-06-01 17:54 UTC (permalink / raw)
  To: Florian Fainelli, Clément Péron
  Cc: linux-arm-kernel, Russell King, linux-kernel, Tony Lindgren,
	Laura Abbott, Scott Branden, Jon Mason, Ray Jui,
	BCM Kernel Feedback, Clément Peron

Sorry Florian, I had a couple issues with my email client yesterday and 
I'm not sure if you have received my reply.

Please see my reply inline.

On 5/31/2018 3:16 PM, Florian Fainelli wrote:
> 
> 
> On 05/31/2018 10:24 AM, Ray Jui wrote:
>>
>>
>> On 5/31/2018 1:22 AM, Clément Péron wrote:
>>> Hi Rai,
>>>
>>> On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>>>>
>>>> Hi Clément,
>>>>
>>>> Correct me if I'm wrong, but I thought the trend is to move to use
>>>> earlycon that can be activated from kernel command line for early print
>>>> before the serial driver is loaded.
>>>>
>>>> Have you tried earlcon?
>>> No, only tested this method.
>>>
>>> Thanks,
>>> Clement
>>>
>>
>> If I remember it correctly, I think the trend is to use earlycon. There
>> are obvious shortcomings by making this configuration compile time based.
> 
> This is true, though on ARM 32-bit kernels DEBUG_LL gets used by the
> kernel self-decompressor and also before earlycon has a chance to run,
> this is useful to debugging memory issues where your memory
> configuration is incorrect typically.
> 

This is true.

> Either way is fine with me (accepting or dropping) the patch, though
> there is probably minimal impact in just accepting such a change.
> 

Will leave the decision to you then.

Thanks,

Ray

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-06-01 17:54           ` Ray Jui
  0 siblings, 0 replies; 18+ messages in thread
From: Ray Jui @ 2018-06-01 17:54 UTC (permalink / raw)
  To: linux-arm-kernel

Sorry Florian, I had a couple issues with my email client yesterday and 
I'm not sure if you have received my reply.

Please see my reply inline.

On 5/31/2018 3:16 PM, Florian Fainelli wrote:
> 
> 
> On 05/31/2018 10:24 AM, Ray Jui wrote:
>>
>>
>> On 5/31/2018 1:22 AM, Cl?ment P?ron wrote:
>>> Hi Rai,
>>>
>>> On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@broadcom.com> wrote:
>>>>
>>>> Hi Cl?ment,
>>>>
>>>> Correct me if I'm wrong, but I thought the trend is to move to use
>>>> earlycon that can be activated from kernel command line for early print
>>>> before the serial driver is loaded.
>>>>
>>>> Have you tried earlcon?
>>> No, only tested this method.
>>>
>>> Thanks,
>>> Clement
>>>
>>
>> If I remember it correctly, I think the trend is to use earlycon. There
>> are obvious shortcomings by making this configuration compile time based.
> 
> This is true, though on ARM 32-bit kernels DEBUG_LL gets used by the
> kernel self-decompressor and also before earlycon has a chance to run,
> this is useful to debugging memory issues where your memory
> configuration is incorrect typically.
> 

This is true.

> Either way is fine with me (accepting or dropping) the patch, though
> there is probably minimal impact in just accepting such a change.
> 

Will leave the decision to you then.

Thanks,

Ray

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
  2018-05-30 13:19 ` Clément Péron
@ 2018-06-04 21:12   ` Florian Fainelli
  -1 siblings, 0 replies; 18+ messages in thread
From: Florian Fainelli @ 2018-06-04 21:12 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Clément Péron, linux-arm-kernel
  Cc: Russell King, linux-kernel, Tony Lindgren, Laura Abbott,
	Scott Branden, Jon Mason, Ray Jui, Clément Peron

On Wed, 30 May 2018 15:19:55 +0200, Clément Péron <peron.clem@gmail.com> wrote:
> From: Clément Peron <clement.peron@devialet.com>
> 
> Broadcom Iproc SoCs typically use the UART3 for
> debug/console, provide a known good location for that.
> 
> Signed-off-by: Clément Peron <clement.peron@devialet.com>
> ---

Applied to soc/next, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses
@ 2018-06-04 21:12   ` Florian Fainelli
  0 siblings, 0 replies; 18+ messages in thread
From: Florian Fainelli @ 2018-06-04 21:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 30 May 2018 15:19:55 +0200, Cl?ment P?ron <peron.clem@gmail.com> wrote:
> From: Cl?ment Peron <clement.peron@devialet.com>
> 
> Broadcom Iproc SoCs typically use the UART3 for
> debug/console, provide a known good location for that.
> 
> Signed-off-by: Cl?ment Peron <clement.peron@devialet.com>
> ---

Applied to soc/next, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 2/2] ARM: debug: fix BCM2836 order entry
  2018-05-30 13:19   ` Clément Péron
@ 2018-06-04 21:12     ` Florian Fainelli
  -1 siblings, 0 replies; 18+ messages in thread
From: Florian Fainelli @ 2018-06-04 21:12 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Clément Péron, linux-arm-kernel
  Cc: Russell King, linux-kernel, Tony Lindgren, Laura Abbott,
	Scott Branden, Jon Mason, Ray Jui, Clément Peron

On Wed, 30 May 2018 15:19:56 +0200, Clément Péron <peron.clem@gmail.com> wrote:
> From: Clément Peron <clement.peron@devialet.com>
> 
> Entries are sorted by their address value, except the BCM2836/KONA
> which are not in the proper order.
> 
> Signed-off-by: Clément Peron <clement.peron@devialet.com>
> ---

Applied to soc/next, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 2/2] ARM: debug: fix BCM2836 order entry
@ 2018-06-04 21:12     ` Florian Fainelli
  0 siblings, 0 replies; 18+ messages in thread
From: Florian Fainelli @ 2018-06-04 21:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 30 May 2018 15:19:56 +0200, Cl?ment P?ron <peron.clem@gmail.com> wrote:
> From: Cl?ment Peron <clement.peron@devialet.com>
> 
> Entries are sorted by their address value, except the BCM2836/KONA
> which are not in the proper order.
> 
> Signed-off-by: Cl?ment Peron <clement.peron@devialet.com>
> ---

Applied to soc/next, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2018-06-04 21:12 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-30 13:19 [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses Clément Péron
2018-05-30 13:19 ` Clément Péron
2018-05-30 13:19 ` [PATCH v2 2/2] ARM: debug: fix BCM2836 order entry Clément Péron
2018-05-30 13:19   ` Clément Péron
2018-06-04 21:12   ` Florian Fainelli
2018-06-04 21:12     ` Florian Fainelli
2018-05-30 17:25 ` [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses Ray Jui
2018-05-30 17:25   ` Ray Jui
2018-05-31  8:22   ` Clément Péron
2018-05-31  8:22     ` Clément Péron
2018-05-31 17:24     ` Ray Jui
2018-05-31 17:24       ` Ray Jui
2018-05-31 22:16       ` Florian Fainelli
2018-05-31 22:16         ` Florian Fainelli
2018-06-01 17:54         ` Ray Jui
2018-06-01 17:54           ` Ray Jui
2018-06-04 21:12 ` Florian Fainelli
2018-06-04 21:12   ` Florian Fainelli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.