All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin King <colin.king@canonical.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/fmc: make struct fmc_dbgfs_sdb_dump static
Date: Fri,  1 Jun 2018 14:31:17 +0100	[thread overview]
Message-ID: <20180601133117.6511-1-colin.king@canonical.com> (raw)

From: Colin Ian King <colin.king@canonical.com>

The structure fmc_dbgfs_sdb_dump is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
drivers/fmc/fmc-debug.c:143:30: warning: symbol 'fmc_dbgfs_sdb_dump'
was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/fmc/fmc-debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 32930722770c..c96b928f0112 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -140,7 +140,7 @@ static int fmc_sdb_dump_open(struct inode *inode, struct file *file)
 }
 
 
-const struct file_operations fmc_dbgfs_sdb_dump = {
+static const struct file_operations fmc_dbgfs_sdb_dump = {
 	.owner = THIS_MODULE,
 	.open  = fmc_sdb_dump_open,
 	.read = seq_read,
-- 
2.17.0

WARNING: multiple messages have this Message-ID (diff)
From: Colin King <colin.king@canonical.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/fmc: make struct fmc_dbgfs_sdb_dump static
Date: Fri, 01 Jun 2018 13:31:17 +0000	[thread overview]
Message-ID: <20180601133117.6511-1-colin.king@canonical.com> (raw)

From: Colin Ian King <colin.king@canonical.com>

The structure fmc_dbgfs_sdb_dump is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
drivers/fmc/fmc-debug.c:143:30: warning: symbol 'fmc_dbgfs_sdb_dump'
was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/fmc/fmc-debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 32930722770c..c96b928f0112 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -140,7 +140,7 @@ static int fmc_sdb_dump_open(struct inode *inode, struct file *file)
 }
 
 
-const struct file_operations fmc_dbgfs_sdb_dump = {
+static const struct file_operations fmc_dbgfs_sdb_dump = {
 	.owner = THIS_MODULE,
 	.open  = fmc_sdb_dump_open,
 	.read = seq_read,
-- 
2.17.0


             reply	other threads:[~2018-06-01 13:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 13:31 Colin King [this message]
2018-06-01 13:31 ` [PATCH] drivers/fmc: make struct fmc_dbgfs_sdb_dump static Colin King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180601133117.6511-1-colin.king@canonical.com \
    --to=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rubini@gnudd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.