* [PATCH] drivers/fmc: make struct fmc_dbgfs_sdb_dump static
@ 2018-06-01 13:31 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2018-06-01 13:31 UTC (permalink / raw)
To: Alessandro Rubini; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The structure fmc_dbgfs_sdb_dump is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/fmc/fmc-debug.c:143:30: warning: symbol 'fmc_dbgfs_sdb_dump'
was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/fmc/fmc-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 32930722770c..c96b928f0112 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -140,7 +140,7 @@ static int fmc_sdb_dump_open(struct inode *inode, struct file *file)
}
-const struct file_operations fmc_dbgfs_sdb_dump = {
+static const struct file_operations fmc_dbgfs_sdb_dump = {
.owner = THIS_MODULE,
.open = fmc_sdb_dump_open,
.read = seq_read,
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drivers/fmc: make struct fmc_dbgfs_sdb_dump static
@ 2018-06-01 13:31 ` Colin King
0 siblings, 0 replies; 2+ messages in thread
From: Colin King @ 2018-06-01 13:31 UTC (permalink / raw)
To: Alessandro Rubini; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The structure fmc_dbgfs_sdb_dump is local to the source and does not
need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/fmc/fmc-debug.c:143:30: warning: symbol 'fmc_dbgfs_sdb_dump'
was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/fmc/fmc-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fmc/fmc-debug.c b/drivers/fmc/fmc-debug.c
index 32930722770c..c96b928f0112 100644
--- a/drivers/fmc/fmc-debug.c
+++ b/drivers/fmc/fmc-debug.c
@@ -140,7 +140,7 @@ static int fmc_sdb_dump_open(struct inode *inode, struct file *file)
}
-const struct file_operations fmc_dbgfs_sdb_dump = {
+static const struct file_operations fmc_dbgfs_sdb_dump = {
.owner = THIS_MODULE,
.open = fmc_sdb_dump_open,
.read = seq_read,
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-01 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-01 13:31 [PATCH] drivers/fmc: make struct fmc_dbgfs_sdb_dump static Colin King
2018-06-01 13:31 ` Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.