All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Fam Zheng" <famz@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Eric Blake" <eblake@redhat.com>, "John Snow" <jsnow@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default
Date: Tue, 19 Jun 2018 14:03:32 +0800	[thread overview]
Message-ID: <20180619060332.GJ16790@xz-mi> (raw)
In-Reply-To: <92641a09-a750-e4bd-bb88-d022e4c0591f@redhat.com>

On Tue, Jun 19, 2018 at 07:51:47AM +0200, Thomas Huth wrote:
> On 19.06.2018 07:34, Peter Xu wrote:
> > v4:
> > - collect some r-bs
> > - remove one extra s-o-b of mine in one patch [Thomas, Markus]
> 
> FYI: You've still got a duplicated s-o-b line in patch 3 and 4.
> 
>  Thomas

Thanks.  I think it's caused by the lines in commit messages like

"""
--- /home/peterx/git/qemu/tests/qemu-iotests/087.out
+++ /home/peterx/git/qemu/bin/tests/qemu-iotests/087.out.bad
"""

Then git-format-patch does not work as expected (so the extra s-o-bs
are not in my local tree).

I remove these lines then git-format-patch works fine.

If to repost, I'll double confirm with these matters.

Regards,

-- 
Peter Xu

      reply	other threads:[~2018-06-19  6:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19  5:34 [Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 1/7] chardev: comment details for CLOSED event Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 2/7] monitor: rename *_pop_one to *_pop_any Peter Xu
2018-06-19 11:48   ` Eric Blake
2018-06-19 13:44   ` Markus Armbruster
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED Peter Xu
2018-06-19  5:53   ` Peter Xu
2018-06-19 13:55     ` Markus Armbruster
2018-06-20  3:04       ` Peter Xu
2018-06-19 13:53   ` Markus Armbruster
2018-06-20  2:58     ` Peter Xu
2018-06-20  7:17       ` Markus Armbruster
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 4/7] tests: iotests: drop some stderr line Peter Xu
2018-06-19 13:57   ` Markus Armbruster
2018-06-20  3:06     ` Peter Xu
2018-06-20  7:12       ` Markus Armbruster
2018-06-20  7:21         ` Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 5/7] docs: mention shared state protect for OOB Peter Xu
2018-06-19 13:59   ` Markus Armbruster
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 6/7] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-06-19 14:16   ` Markus Armbruster
2018-06-20  3:15     ` Peter Xu
2018-06-20  7:20       ` Markus Armbruster
2018-06-20  7:28         ` Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 7/7] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-06-19 14:20   ` Markus Armbruster
2018-06-19  5:51 ` [Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default Thomas Huth
2018-06-19  6:03   ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180619060332.GJ16790@xz-mi \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.