All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>, "Fam Zheng" <famz@redhat.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"John Snow" <jsnow@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED
Date: Wed, 20 Jun 2018 11:04:04 +0800	[thread overview]
Message-ID: <20180620030404.GB18985@xz-mi> (raw)
In-Reply-To: <87602evq2n.fsf@dusky.pond.sub.org>

On Tue, Jun 19, 2018 at 03:55:12PM +0200, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
> > On Tue, Jun 19, 2018 at 01:34:22PM +0800, Peter Xu wrote:
> >
> > [...]
> >
> >> Fixes: 6d2d563f8c ("qmp: cleanup qmp queues properly", 2018-03-27)
> >> Suggested-by: Markus Armbruster <armbru@redhat.com>
> >> Signed-off-by: Peter Xu <peterx@redhat.com>
> >> 
> >> Signed-off-by: Peter Xu <peterx@redhat.com>
> >
> > I am pretty sure this time that this 2nd line is not there in my local
> > tree. :)
> >
> > I think it's a git-format-patch bug, otherwise I must have misused it
> > for a long time.  Instead of figuring this out and repost again, I'll
> > see how far the rest of the series can go.
> 
> Do you use git-format-patch -s, or have format.signOff set in
> .git/config or ~/.gitconfig?

Ah it's in my ~/.gitconfig!  Removing that fixes the issue.

Though I'm still not sure why the problem doesn't happen with other
patches.  After all, due to the line wrapping mess I still prefer to
drop that chunk in commit message directly.

Regards,

-- 
Peter Xu

  reply	other threads:[~2018-06-20  3:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19  5:34 [Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 1/7] chardev: comment details for CLOSED event Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 2/7] monitor: rename *_pop_one to *_pop_any Peter Xu
2018-06-19 11:48   ` Eric Blake
2018-06-19 13:44   ` Markus Armbruster
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED Peter Xu
2018-06-19  5:53   ` Peter Xu
2018-06-19 13:55     ` Markus Armbruster
2018-06-20  3:04       ` Peter Xu [this message]
2018-06-19 13:53   ` Markus Armbruster
2018-06-20  2:58     ` Peter Xu
2018-06-20  7:17       ` Markus Armbruster
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 4/7] tests: iotests: drop some stderr line Peter Xu
2018-06-19 13:57   ` Markus Armbruster
2018-06-20  3:06     ` Peter Xu
2018-06-20  7:12       ` Markus Armbruster
2018-06-20  7:21         ` Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 5/7] docs: mention shared state protect for OOB Peter Xu
2018-06-19 13:59   ` Markus Armbruster
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 6/7] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-06-19 14:16   ` Markus Armbruster
2018-06-20  3:15     ` Peter Xu
2018-06-20  7:20       ` Markus Armbruster
2018-06-20  7:28         ` Peter Xu
2018-06-19  5:34 ` [Qemu-devel] [PATCH v4 7/7] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-06-19 14:20   ` Markus Armbruster
2018-06-19  5:51 ` [Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default Thomas Huth
2018-06-19  6:03   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620030404.GB18985@xz-mi \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=dgilbert@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.