From: Yury Norov <ynorov@caviumnetworks.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Mike Snitzer <snitzer@redhat.com>, mika.westerberg@linux.intel.com, Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-input@vger.kernel.org, Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>, Shaohua Li <shli@kernel.org>, Alasdair Kergon <agk@redhat.com> Subject: Re: [PATCH v3 0/5] bitmap: Introduce alloc/free helpers Date: Wed, 20 Jun 2018 10:33:41 +0300 [thread overview] Message-ID: <20180620072721.GA19364@yury-thinkpad> (raw) In-Reply-To: <20180618131003.88110-1-andriy.shevchenko@linux.intel.com> On Mon, Jun 18, 2018 at 04:09:58PM +0300, Andy Shevchenko wrote: > External Email > > A lot of code is using allocation of bitmaps using BITS_PER_LONG() macro and > sizeof(unsigned long) operator. The readability suffers because of this. > > The series introduces three helpers, i.e. bitmap_alloc(), bitmap_zalloc() and > bitmap_free(), to make it more cleaner. tools/include/linux/bitmap.h already has bitmap_alloc(), and it corresponds to bitmap_zalloc() in this patch. It may cause problems in future if people will copy functions that use bitmap_alloc between kernel code and tools. So I think we have to propagate this API to tools and update existing users of bitmap_alloc() in tools. What about code that calls specific alloc functions, like memblock_virt_alloc() and pcpu_mem_zalloc() in mm/percpu.c, or devm_kcalloc() in drivers/dma/edma.c? If we are going to unify bitmap allocations in kernel, we should think about unification of that cases too. Should it be additional flag or optional pointer to the exact allocator in bitmap_{,z}alloc()? Yury > Patch 1 is a preparatory to avoid namespace collisions between bitmap API and > MD bitmap. No functional changes intended. > > Patch 2 is just orphaned from previous release cycle. > > Patch 3 introduces new helpers. > > Patches 4 and 5 is just an example how to use new helpers. Locally I have like > dozen of them against different subsystems and drivers. > > Ideally it would go through Input subsystem, thus, needs an Ack from MD maintainer(s). > > Since v2: > - fix compilation issue in MD bitmap code > - elaborate changes in commit message of patch 5 > > Since v1: > - added namespace fix patch against MD bitmap API > - moved functions to lib/bitmap.c to avoid circular dependencies > - appended Dmitry's tags > > Andy Shevchenko (5): > md: Avoid namespace collision with bitmap API > bitmap: Drop unnecessary 0 check for u32 array operations > bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free() > Input: gpio-keys - Switch to bitmap_zalloc() > Input: evdev - Switch to bitmap API > > drivers/input/evdev.c | 16 +- > drivers/input/keyboard/gpio_keys.c | 8 +- > drivers/md/dm-raid.c | 6 +- > drivers/md/md-bitmap.c | 301 +++++++++--------- > drivers/md/md-bitmap.h | 46 +-- > drivers/md/md-cluster.c | 16 +- > drivers/md/md.c | 44 +-- > .../md/persistent-data/dm-space-map-common.c | 12 +- > drivers/md/raid1.c | 20 +- > drivers/md/raid10.c | 26 +- > drivers/md/raid5-cache.c | 2 +- > drivers/md/raid5.c | 24 +- > include/linux/bitmap.h | 8 + > lib/bitmap.c | 28 +- > 14 files changed, 283 insertions(+), 274 deletions(-) > > -- > 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <ynorov@caviumnetworks.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, Shaohua Li <shli@kernel.org>, linux-raid@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, Joe Perches <joe@perches.com> Subject: Re: [PATCH v3 0/5] bitmap: Introduce alloc/free helpers Date: Wed, 20 Jun 2018 10:33:41 +0300 [thread overview] Message-ID: <20180620072721.GA19364@yury-thinkpad> (raw) In-Reply-To: <20180618131003.88110-1-andriy.shevchenko@linux.intel.com> On Mon, Jun 18, 2018 at 04:09:58PM +0300, Andy Shevchenko wrote: > External Email > > A lot of code is using allocation of bitmaps using BITS_PER_LONG() macro and > sizeof(unsigned long) operator. The readability suffers because of this. > > The series introduces three helpers, i.e. bitmap_alloc(), bitmap_zalloc() and > bitmap_free(), to make it more cleaner. tools/include/linux/bitmap.h already has bitmap_alloc(), and it corresponds to bitmap_zalloc() in this patch. It may cause problems in future if people will copy functions that use bitmap_alloc between kernel code and tools. So I think we have to propagate this API to tools and update existing users of bitmap_alloc() in tools. What about code that calls specific alloc functions, like memblock_virt_alloc() and pcpu_mem_zalloc() in mm/percpu.c, or devm_kcalloc() in drivers/dma/edma.c? If we are going to unify bitmap allocations in kernel, we should think about unification of that cases too. Should it be additional flag or optional pointer to the exact allocator in bitmap_{,z}alloc()? Yury > Patch 1 is a preparatory to avoid namespace collisions between bitmap API and > MD bitmap. No functional changes intended. > > Patch 2 is just orphaned from previous release cycle. > > Patch 3 introduces new helpers. > > Patches 4 and 5 is just an example how to use new helpers. Locally I have like > dozen of them against different subsystems and drivers. > > Ideally it would go through Input subsystem, thus, needs an Ack from MD maintainer(s). > > Since v2: > - fix compilation issue in MD bitmap code > - elaborate changes in commit message of patch 5 > > Since v1: > - added namespace fix patch against MD bitmap API > - moved functions to lib/bitmap.c to avoid circular dependencies > - appended Dmitry's tags > > Andy Shevchenko (5): > md: Avoid namespace collision with bitmap API > bitmap: Drop unnecessary 0 check for u32 array operations > bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free() > Input: gpio-keys - Switch to bitmap_zalloc() > Input: evdev - Switch to bitmap API > > drivers/input/evdev.c | 16 +- > drivers/input/keyboard/gpio_keys.c | 8 +- > drivers/md/dm-raid.c | 6 +- > drivers/md/md-bitmap.c | 301 +++++++++--------- > drivers/md/md-bitmap.h | 46 +-- > drivers/md/md-cluster.c | 16 +- > drivers/md/md.c | 44 +-- > .../md/persistent-data/dm-space-map-common.c | 12 +- > drivers/md/raid1.c | 20 +- > drivers/md/raid10.c | 26 +- > drivers/md/raid5-cache.c | 2 +- > drivers/md/raid5.c | 24 +- > include/linux/bitmap.h | 8 + > lib/bitmap.c | 28 +- > 14 files changed, 283 insertions(+), 274 deletions(-) > > -- > 2.17.1
next prev parent reply other threads:[~2018-06-20 7:33 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-18 13:09 [PATCH v3 0/5] bitmap: Introduce alloc/free helpers Andy Shevchenko 2018-06-18 13:09 ` [PATCH v3 1/5] md: Avoid namespace collision with bitmap API Andy Shevchenko 2018-06-18 13:44 ` Mike Snitzer 2018-06-18 13:57 ` Andy Shevchenko 2018-06-18 13:10 ` [PATCH v3 2/5] bitmap: Drop unnecessary 0 check for u32 array operations Andy Shevchenko 2018-06-18 13:10 ` [PATCH v3 3/5] bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free() Andy Shevchenko 2018-06-18 21:14 ` Andrew Morton 2018-06-18 22:01 ` Dmitry Torokhov 2018-06-18 22:52 ` Andy Shevchenko 2018-06-18 23:10 ` Andrew Morton 2018-06-18 23:18 ` Andy Shevchenko 2018-06-21 2:13 ` Andy Shevchenko 2018-06-22 18:46 ` Dmitry Torokhov 2018-06-26 11:13 ` Andy Shevchenko 2018-06-18 13:10 ` [PATCH v3 4/5] Input: gpio-keys - Switch to bitmap_zalloc() Andy Shevchenko 2018-06-18 13:10 ` [PATCH v3 5/5] Input: evdev - Switch to bitmap API Andy Shevchenko 2018-06-20 7:33 ` Yury Norov [this message] 2018-06-20 7:33 ` [PATCH v3 0/5] bitmap: Introduce alloc/free helpers Yury Norov 2018-06-20 10:16 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180620072721.GA19364@yury-thinkpad \ --to=ynorov@caviumnetworks.com \ --cc=agk@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=dm-devel@redhat.com \ --cc=dmitry.torokhov@gmail.com \ --cc=joe@perches.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=shli@kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.