All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: srikar@linux.vnet.ibm.com, oleg@redhat.com, rostedt@goodmis.org,
	mhiramat@kernel.org
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org,
	corbet@lwn.net, linux-doc@vger.kernel.org,
	ananth@linux.vnet.ibm.com, alexis.berlemont@gmail.com,
	naveen.n.rao@linux.vnet.ibm.com,
	linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
	linux@armlinux.org.uk, ralf@linux-mips.org, paul.burton@mips.com,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: [PATCH v5 04/10] Uprobe: Change set_orig_insn definition
Date: Thu, 28 Jun 2018 10:52:03 +0530	[thread overview]
Message-ID: <20180628052209.13056-5-ravi.bangoria@linux.ibm.com> (raw)
In-Reply-To: <20180628052209.13056-1-ravi.bangoria@linux.ibm.com>

Instead of arch_uprobe, pass uprobe object to set_orig_insn(). We
need this in later set of patches.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
---
 include/linux/uprobes.h | 2 +-
 kernel/events/uprobes.c | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 7a77bd57c9e7..85db5918f675 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -141,7 +141,7 @@ struct uprobes_state {
 };
 
 extern int set_swbp(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr);
-extern int set_orig_insn(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);
+extern int set_orig_insn(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr);
 extern bool is_swbp_insn(uprobe_opcode_t *insn);
 extern bool is_trap_insn(uprobe_opcode_t *insn);
 extern unsigned long uprobe_get_swbp_addr(struct pt_regs *regs);
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 8de52bcd1a18..04fe80057331 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -333,16 +333,17 @@ int __weak set_swbp(struct uprobe *uprobe, struct mm_struct *mm, unsigned long v
 /**
  * set_orig_insn - Restore the original instruction.
  * @mm: the probed process address space.
- * @auprobe: arch specific probepoint information.
+ * @uprobe: uprobe object.
  * @vaddr: the virtual address to insert the opcode.
  *
  * For mm @mm, restore the original opcode (opcode) at @vaddr.
  * Return 0 (success) or a negative errno.
  */
 int __weak
-set_orig_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, unsigned long vaddr)
+set_orig_insn(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr)
 {
-	return uprobe_write_opcode(mm, vaddr, *(uprobe_opcode_t *)&auprobe->insn);
+	return uprobe_write_opcode(mm, vaddr,
+			*(uprobe_opcode_t *)&(uprobe->arch.insn));
 }
 
 static struct uprobe *get_uprobe(struct uprobe *uprobe)
@@ -655,7 +656,7 @@ static int
 remove_breakpoint(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr)
 {
 	set_bit(MMF_RECALC_UPROBES, &mm->flags);
-	return set_orig_insn(&uprobe->arch, mm, vaddr);
+	return set_orig_insn(uprobe, mm, vaddr);
 }
 
 static inline bool uprobe_is_active(struct uprobe *uprobe)
-- 
2.14.4


WARNING: multiple messages have this Message-ID (diff)
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: srikar@linux.vnet.ibm.com, oleg@redhat.com, rostedt@goodmis.org,
	mhiramat@kernel.org
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org,
	corbet@lwn.net, linux-doc@vger.kernel.org,
	ananth@linux.vnet.ibm.com, alexis.berlemont@gmail.com,
	naveen.n.rao@linux.vnet.ibm.com,
	linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
	linux@armlinux.org.uk, ralf@linux-mips.org, paul.burton@mips.com,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: [PATCH v5 04/10] Uprobe: Change set_orig_insn definition
Date: Thu, 28 Jun 2018 10:52:03 +0530	[thread overview]
Message-ID: <20180628052209.13056-5-ravi.bangoria@linux.ibm.com> (raw)
In-Reply-To: <20180628052209.13056-1-ravi.bangoria@linux.ibm.com>

Instead of arch_uprobe, pass uprobe object to set_orig_insn(). We
need this in later set of patches.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
---
 include/linux/uprobes.h | 2 +-
 kernel/events/uprobes.c | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 7a77bd57c9e7..85db5918f675 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -141,7 +141,7 @@ struct uprobes_state {
 };
 
 extern int set_swbp(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr);
-extern int set_orig_insn(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);
+extern int set_orig_insn(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr);
 extern bool is_swbp_insn(uprobe_opcode_t *insn);
 extern bool is_trap_insn(uprobe_opcode_t *insn);
 extern unsigned long uprobe_get_swbp_addr(struct pt_regs *regs);
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 8de52bcd1a18..04fe80057331 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -333,16 +333,17 @@ int __weak set_swbp(struct uprobe *uprobe, struct mm_struct *mm, unsigned long v
 /**
  * set_orig_insn - Restore the original instruction.
  * @mm: the probed process address space.
- * @auprobe: arch specific probepoint information.
+ * @uprobe: uprobe object.
  * @vaddr: the virtual address to insert the opcode.
  *
  * For mm @mm, restore the original opcode (opcode) at @vaddr.
  * Return 0 (success) or a negative errno.
  */
 int __weak
-set_orig_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, unsigned long vaddr)
+set_orig_insn(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr)
 {
-	return uprobe_write_opcode(mm, vaddr, *(uprobe_opcode_t *)&auprobe->insn);
+	return uprobe_write_opcode(mm, vaddr,
+			*(uprobe_opcode_t *)&(uprobe->arch.insn));
 }
 
 static struct uprobe *get_uprobe(struct uprobe *uprobe)
@@ -655,7 +656,7 @@ static int
 remove_breakpoint(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr)
 {
 	set_bit(MMF_RECALC_UPROBES, &mm->flags);
-	return set_orig_insn(&uprobe->arch, mm, vaddr);
+	return set_orig_insn(uprobe, mm, vaddr);
 }
 
 static inline bool uprobe_is_active(struct uprobe *uprobe)
-- 
2.14.4

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: ravi.bangoria@linux.ibm.com (Ravi Bangoria)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 04/10] Uprobe: Change set_orig_insn definition
Date: Thu, 28 Jun 2018 10:52:03 +0530	[thread overview]
Message-ID: <20180628052209.13056-5-ravi.bangoria@linux.ibm.com> (raw)
In-Reply-To: <20180628052209.13056-1-ravi.bangoria@linux.ibm.com>

Instead of arch_uprobe, pass uprobe object to set_orig_insn(). We
need this in later set of patches.

Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
---
 include/linux/uprobes.h | 2 +-
 kernel/events/uprobes.c | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 7a77bd57c9e7..85db5918f675 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -141,7 +141,7 @@ struct uprobes_state {
 };
 
 extern int set_swbp(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr);
-extern int set_orig_insn(struct arch_uprobe *aup, struct mm_struct *mm, unsigned long vaddr);
+extern int set_orig_insn(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr);
 extern bool is_swbp_insn(uprobe_opcode_t *insn);
 extern bool is_trap_insn(uprobe_opcode_t *insn);
 extern unsigned long uprobe_get_swbp_addr(struct pt_regs *regs);
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 8de52bcd1a18..04fe80057331 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -333,16 +333,17 @@ int __weak set_swbp(struct uprobe *uprobe, struct mm_struct *mm, unsigned long v
 /**
  * set_orig_insn - Restore the original instruction.
  * @mm: the probed process address space.
- * @auprobe: arch specific probepoint information.
+ * @uprobe: uprobe object.
  * @vaddr: the virtual address to insert the opcode.
  *
  * For mm @mm, restore the original opcode (opcode) at @vaddr.
  * Return 0 (success) or a negative errno.
  */
 int __weak
-set_orig_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, unsigned long vaddr)
+set_orig_insn(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr)
 {
-	return uprobe_write_opcode(mm, vaddr, *(uprobe_opcode_t *)&auprobe->insn);
+	return uprobe_write_opcode(mm, vaddr,
+			*(uprobe_opcode_t *)&(uprobe->arch.insn));
 }
 
 static struct uprobe *get_uprobe(struct uprobe *uprobe)
@@ -655,7 +656,7 @@ static int
 remove_breakpoint(struct uprobe *uprobe, struct mm_struct *mm, unsigned long vaddr)
 {
 	set_bit(MMF_RECALC_UPROBES, &mm->flags);
-	return set_orig_insn(&uprobe->arch, mm, vaddr);
+	return set_orig_insn(uprobe, mm, vaddr);
 }
 
 static inline bool uprobe_is_active(struct uprobe *uprobe)
-- 
2.14.4

  parent reply	other threads:[~2018-06-28  5:22 UTC|newest]

Thread overview: 152+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28  5:21 [PATCH v5 00/10] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-06-28  5:21 ` Ravi Bangoria
2018-06-28  5:21 ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 01/10] Uprobes: Move uprobe structure to uprobe.h Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 02/10] Uprobes: Simplify uprobe_register() body Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 03/10] Uprobe: Change set_swbp definition Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22 ` Ravi Bangoria [this message]
2018-06-28  5:22   ` [PATCH v5 04/10] Uprobe: Change set_orig_insn definition Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 05/10] Uprobe: Change uprobe_write_opcode definition Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28 19:51   ` Oleg Nesterov
2018-06-28 19:51     ` Oleg Nesterov
2018-06-28 19:51     ` Oleg Nesterov
2018-06-29  3:23     ` Ravi Bangoria
2018-06-29  3:23       ` Ravi Bangoria
2018-06-29  3:23       ` Ravi Bangoria
2018-07-01 21:09   ` Oleg Nesterov
2018-07-01 21:09     ` Oleg Nesterov
2018-07-01 21:09     ` Oleg Nesterov
2018-07-02  5:16     ` Ravi Bangoria
2018-07-02  5:16       ` Ravi Bangoria
2018-07-02  5:16       ` Ravi Bangoria
2018-07-02 18:01       ` Oleg Nesterov
2018-07-02 18:01         ` Oleg Nesterov
2018-07-02 18:01         ` Oleg Nesterov
2018-07-03  5:30         ` Ravi Bangoria
2018-07-03  5:30           ` Ravi Bangoria
2018-07-03  5:30           ` Ravi Bangoria
2018-07-03  6:16           ` Srikar Dronamraju
2018-07-03  6:16             ` Srikar Dronamraju
2018-07-03  6:16             ` Srikar Dronamraju
2018-07-03  7:43             ` Ravi Bangoria
2018-07-03  7:43               ` Ravi Bangoria
2018-07-03  7:43               ` Ravi Bangoria
2018-07-04  9:16               ` Srikar Dronamraju
2018-07-04  9:16                 ` Srikar Dronamraju
2018-07-04  9:16                 ` Srikar Dronamraju
2018-07-04  9:24                 ` Ravi Bangoria
2018-07-04  9:24                   ` Ravi Bangoria
2018-07-04  9:24                   ` Ravi Bangoria
2018-07-03  8:11           ` Ravi Bangoria
2018-07-03  8:11             ` Ravi Bangoria
2018-07-03  8:11             ` Ravi Bangoria
2018-07-03 16:36           ` Oleg Nesterov
2018-07-03 16:36             ` Oleg Nesterov
2018-07-03 16:36             ` Oleg Nesterov
2018-07-03 17:25             ` Oleg Nesterov
2018-07-03 17:25               ` Oleg Nesterov
2018-07-03 17:25               ` Oleg Nesterov
2018-07-04  4:53               ` Ravi Bangoria
2018-07-04  4:53                 ` Ravi Bangoria
2018-07-04  4:53                 ` Ravi Bangoria
2018-07-10 15:25                 ` Oleg Nesterov
2018-07-10 15:25                   ` Oleg Nesterov
2018-07-10 15:25                   ` Oleg Nesterov
2018-07-11  8:44                   ` Ravi Bangoria
2018-07-11  8:44                     ` Ravi Bangoria
2018-07-11  8:44                     ` Ravi Bangoria
2018-07-11  9:52                     ` Ravi Bangoria
2018-07-11  9:52                       ` Ravi Bangoria
2018-07-11  9:52                       ` Ravi Bangoria
2018-07-12 14:58                     ` Oleg Nesterov
2018-07-12 14:58                       ` Oleg Nesterov
2018-07-12 14:58                       ` Oleg Nesterov
2018-07-12 19:53                       ` Song Liu
2018-07-12 19:53                         ` Song Liu
2018-07-12 19:53                         ` Song Liu
2018-07-12 19:53                         ` Song Liu
2018-07-13  7:55                         ` Ravi Bangoria
2018-07-13  7:55                           ` Ravi Bangoria
2018-07-13  7:55                           ` Ravi Bangoria
2018-07-13 23:50                           ` Song Liu
2018-07-13 23:50                             ` Song Liu
2018-07-13 23:50                             ` Song Liu
2018-07-13 23:50                             ` Song Liu
2018-07-16  8:20                             ` Ravi Bangoria
2018-07-16  8:20                               ` Ravi Bangoria
2018-07-16  8:20                               ` Ravi Bangoria
2018-07-16  8:51                             ` Ravi Bangoria
2018-07-16  8:51                               ` Ravi Bangoria
2018-07-16  8:51                               ` Ravi Bangoria
2018-07-13  5:39                       ` Ravi Bangoria
2018-07-13  5:39                         ` Ravi Bangoria
2018-07-13  5:39                         ` Ravi Bangoria
2018-07-04  4:49             ` Ravi Bangoria
2018-07-04  4:49               ` Ravi Bangoria
2018-07-04  4:49               ` Ravi Bangoria
2018-07-03 17:12           ` Oleg Nesterov
2018-07-03 17:12             ` Oleg Nesterov
2018-07-03 17:12             ` Oleg Nesterov
2018-07-03 18:23             ` Oleg Nesterov
2018-07-03 18:23               ` Oleg Nesterov
2018-07-03 18:23               ` Oleg Nesterov
2018-07-04  5:25               ` Ravi Bangoria
2018-07-04  5:25                 ` Ravi Bangoria
2018-07-04  5:25                 ` Ravi Bangoria
2018-07-02 16:01   ` Srikar Dronamraju
2018-07-02 16:01     ` Srikar Dronamraju
2018-07-02 16:01     ` Srikar Dronamraju
2018-07-02 18:05     ` Oleg Nesterov
2018-07-02 18:05       ` Oleg Nesterov
2018-07-02 18:05       ` Oleg Nesterov
2018-07-03  6:29     ` Ravi Bangoria
2018-07-03  6:29       ` Ravi Bangoria
2018-07-03  6:29       ` Ravi Bangoria
2018-07-03 19:26       ` Oleg Nesterov
2018-07-03 19:26         ` Oleg Nesterov
2018-07-03 19:26         ` Oleg Nesterov
2018-07-04  5:26         ` Ravi Bangoria
2018-07-04  5:26           ` Ravi Bangoria
2018-07-04  5:26           ` Ravi Bangoria
2018-07-04  6:07     ` Ravi Bangoria
2018-07-04  6:07       ` Ravi Bangoria
2018-07-04  6:07       ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 07/10] trace_uprobe/sdt: Prevent multiple reference counter for same uprobe Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 08/10] Uprobes/sdt: " Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 09/10] Uprobes/sdt: Document about reference counter Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-07-02 14:54   ` Srikar Dronamraju
2018-07-02 14:54     ` Srikar Dronamraju
2018-07-02 14:54     ` Srikar Dronamraju
2018-07-03  7:50     ` Ravi Bangoria
2018-07-03  7:50       ` Ravi Bangoria
2018-07-03  7:50       ` Ravi Bangoria
2018-06-28  5:22 ` [PATCH v5 10/10] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-06-28  5:22   ` Ravi Bangoria
2018-07-02 14:45   ` Srikar Dronamraju
2018-07-02 14:45     ` Srikar Dronamraju
2018-07-02 14:45     ` Srikar Dronamraju
2018-07-02 14:57   ` Srikar Dronamraju
2018-07-02 14:57     ` Srikar Dronamraju
2018-07-02 14:57     ` Srikar Dronamraju
2018-07-03  8:00     ` Ravi Bangoria
2018-07-03  8:00       ` Ravi Bangoria
2018-07-03  8:00       ` Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628052209.13056-5-ravi.bangoria@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexis.berlemont@gmail.com \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=corbet@lwn.net \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux@armlinux.org.uk \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=oleg@redhat.com \
    --cc=paul.burton@mips.com \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.