From: Oleg Nesterov <oleg@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: srikar@linux.vnet.ibm.com, rostedt@goodmis.org,
mhiramat@kernel.org, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org, ananth@linux.vnet.ibm.com,
alexis.berlemont@gmail.com, naveen.n.rao@linux.vnet.ibm.com,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
linux@armlinux.org.uk, ralf@linux-mips.org, paul.burton@mips.com
Subject: Re: [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore)
Date: Tue, 3 Jul 2018 19:25:43 +0200 [thread overview]
Message-ID: <20180703172543.GC23144@redhat.com> (raw)
In-Reply-To: <20180703163645.GA23144@redhat.com>
On 07/03, Oleg Nesterov wrote:
>
> In short. There is a 1:1 relationship between uprobe_write_opcode(is_register => 1)
> and install_breakpoint(), and between uprobe_write_opcode(is_register => 0) and
> remove_breakpoint(). Whatever uprobe_write_opcode() can do if is_register == 1 can be
> done in install_breakpoint(), the same for is_register == 0 and remove_breakpont().
>
> What have I missed?
Ah. I missed the fact that uprobe_write_opcode() doesn't do update_ref_ctr() if
verify_opcode() returns false.
Now I understand what did you mean by "for each consumer". So if we move this logic
into install/remove_breakpoint as I tried to suggest, we will also need another error
code for the case when verify_opcode() returns false.
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: srikar@linux.vnet.ibm.com, rostedt@goodmis.org,
mhiramat@kernel.org, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, alexander.shishkin@linux.intel.com,
jolsa@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org, ananth@linux.vnet.ibm.com,
alexis.berlemont@gmail.com, naveen.n.rao@linux.vnet.ibm.com,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
linux@armlinux.org.uk, ralf@linux-mips.org, paul.burton@mips.com
Subject: Re: [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore)
Date: Tue, 3 Jul 2018 19:25:43 +0200 [thread overview]
Message-ID: <20180703172543.GC23144@redhat.com> (raw)
In-Reply-To: <20180703163645.GA23144@redhat.com>
On 07/03, Oleg Nesterov wrote:
>
> In short. There is a 1:1 relationship between uprobe_write_opcode(is_register => 1)
> and install_breakpoint(), and between uprobe_write_opcode(is_register => 0) and
> remove_breakpoint(). Whatever uprobe_write_opcode() can do if is_register == 1 can be
> done in install_breakpoint(), the same for is_register == 0 and remove_breakpont().
>
> What have I missed?
Ah. I missed the fact that uprobe_write_opcode() doesn't do update_ref_ctr() if
verify_opcode() returns false.
Now I understand what did you mean by "for each consumer". So if we move this logic
into install/remove_breakpoint as I tried to suggest, we will also need another error
code for the case when verify_opcode() returns false.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: oleg@redhat.com (Oleg Nesterov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore)
Date: Tue, 3 Jul 2018 19:25:43 +0200 [thread overview]
Message-ID: <20180703172543.GC23144@redhat.com> (raw)
In-Reply-To: <20180703163645.GA23144@redhat.com>
On 07/03, Oleg Nesterov wrote:
>
> In short. There is a 1:1 relationship between uprobe_write_opcode(is_register => 1)
> and install_breakpoint(), and between uprobe_write_opcode(is_register => 0) and
> remove_breakpoint(). Whatever uprobe_write_opcode() can do if is_register == 1 can be
> done in install_breakpoint(), the same for is_register == 0 and remove_breakpont().
>
> What have I missed?
Ah. I missed the fact that uprobe_write_opcode() doesn't do update_ref_ctr() if
verify_opcode() returns false.
Now I understand what did you mean by "for each consumer". So if we move this logic
into install/remove_breakpoint as I tried to suggest, we will also need another error
code for the case when verify_opcode() returns false.
Oleg.
next prev parent reply other threads:[~2018-07-03 17:25 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 5:21 [PATCH v5 00/10] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-06-28 5:21 ` Ravi Bangoria
2018-06-28 5:21 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 01/10] Uprobes: Move uprobe structure to uprobe.h Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 02/10] Uprobes: Simplify uprobe_register() body Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 03/10] Uprobe: Change set_swbp definition Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 04/10] Uprobe: Change set_orig_insn definition Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 05/10] Uprobe: Change uprobe_write_opcode definition Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 19:51 ` Oleg Nesterov
2018-06-28 19:51 ` Oleg Nesterov
2018-06-28 19:51 ` Oleg Nesterov
2018-06-29 3:23 ` Ravi Bangoria
2018-06-29 3:23 ` Ravi Bangoria
2018-06-29 3:23 ` Ravi Bangoria
2018-07-01 21:09 ` Oleg Nesterov
2018-07-01 21:09 ` Oleg Nesterov
2018-07-01 21:09 ` Oleg Nesterov
2018-07-02 5:16 ` Ravi Bangoria
2018-07-02 5:16 ` Ravi Bangoria
2018-07-02 5:16 ` Ravi Bangoria
2018-07-02 18:01 ` Oleg Nesterov
2018-07-02 18:01 ` Oleg Nesterov
2018-07-02 18:01 ` Oleg Nesterov
2018-07-03 5:30 ` Ravi Bangoria
2018-07-03 5:30 ` Ravi Bangoria
2018-07-03 5:30 ` Ravi Bangoria
2018-07-03 6:16 ` Srikar Dronamraju
2018-07-03 6:16 ` Srikar Dronamraju
2018-07-03 6:16 ` Srikar Dronamraju
2018-07-03 7:43 ` Ravi Bangoria
2018-07-03 7:43 ` Ravi Bangoria
2018-07-03 7:43 ` Ravi Bangoria
2018-07-04 9:16 ` Srikar Dronamraju
2018-07-04 9:16 ` Srikar Dronamraju
2018-07-04 9:16 ` Srikar Dronamraju
2018-07-04 9:24 ` Ravi Bangoria
2018-07-04 9:24 ` Ravi Bangoria
2018-07-04 9:24 ` Ravi Bangoria
2018-07-03 8:11 ` Ravi Bangoria
2018-07-03 8:11 ` Ravi Bangoria
2018-07-03 8:11 ` Ravi Bangoria
2018-07-03 16:36 ` Oleg Nesterov
2018-07-03 16:36 ` Oleg Nesterov
2018-07-03 16:36 ` Oleg Nesterov
2018-07-03 17:25 ` Oleg Nesterov [this message]
2018-07-03 17:25 ` Oleg Nesterov
2018-07-03 17:25 ` Oleg Nesterov
2018-07-04 4:53 ` Ravi Bangoria
2018-07-04 4:53 ` Ravi Bangoria
2018-07-04 4:53 ` Ravi Bangoria
2018-07-10 15:25 ` Oleg Nesterov
2018-07-10 15:25 ` Oleg Nesterov
2018-07-10 15:25 ` Oleg Nesterov
2018-07-11 8:44 ` Ravi Bangoria
2018-07-11 8:44 ` Ravi Bangoria
2018-07-11 8:44 ` Ravi Bangoria
2018-07-11 9:52 ` Ravi Bangoria
2018-07-11 9:52 ` Ravi Bangoria
2018-07-11 9:52 ` Ravi Bangoria
2018-07-12 14:58 ` Oleg Nesterov
2018-07-12 14:58 ` Oleg Nesterov
2018-07-12 14:58 ` Oleg Nesterov
2018-07-12 19:53 ` Song Liu
2018-07-12 19:53 ` Song Liu
2018-07-12 19:53 ` Song Liu
2018-07-12 19:53 ` Song Liu
2018-07-13 7:55 ` Ravi Bangoria
2018-07-13 7:55 ` Ravi Bangoria
2018-07-13 7:55 ` Ravi Bangoria
2018-07-13 23:50 ` Song Liu
2018-07-13 23:50 ` Song Liu
2018-07-13 23:50 ` Song Liu
2018-07-13 23:50 ` Song Liu
2018-07-16 8:20 ` Ravi Bangoria
2018-07-16 8:20 ` Ravi Bangoria
2018-07-16 8:20 ` Ravi Bangoria
2018-07-16 8:51 ` Ravi Bangoria
2018-07-16 8:51 ` Ravi Bangoria
2018-07-16 8:51 ` Ravi Bangoria
2018-07-13 5:39 ` Ravi Bangoria
2018-07-13 5:39 ` Ravi Bangoria
2018-07-13 5:39 ` Ravi Bangoria
2018-07-04 4:49 ` Ravi Bangoria
2018-07-04 4:49 ` Ravi Bangoria
2018-07-04 4:49 ` Ravi Bangoria
2018-07-03 17:12 ` Oleg Nesterov
2018-07-03 17:12 ` Oleg Nesterov
2018-07-03 17:12 ` Oleg Nesterov
2018-07-03 18:23 ` Oleg Nesterov
2018-07-03 18:23 ` Oleg Nesterov
2018-07-03 18:23 ` Oleg Nesterov
2018-07-04 5:25 ` Ravi Bangoria
2018-07-04 5:25 ` Ravi Bangoria
2018-07-04 5:25 ` Ravi Bangoria
2018-07-02 16:01 ` Srikar Dronamraju
2018-07-02 16:01 ` Srikar Dronamraju
2018-07-02 16:01 ` Srikar Dronamraju
2018-07-02 18:05 ` Oleg Nesterov
2018-07-02 18:05 ` Oleg Nesterov
2018-07-02 18:05 ` Oleg Nesterov
2018-07-03 6:29 ` Ravi Bangoria
2018-07-03 6:29 ` Ravi Bangoria
2018-07-03 6:29 ` Ravi Bangoria
2018-07-03 19:26 ` Oleg Nesterov
2018-07-03 19:26 ` Oleg Nesterov
2018-07-03 19:26 ` Oleg Nesterov
2018-07-04 5:26 ` Ravi Bangoria
2018-07-04 5:26 ` Ravi Bangoria
2018-07-04 5:26 ` Ravi Bangoria
2018-07-04 6:07 ` Ravi Bangoria
2018-07-04 6:07 ` Ravi Bangoria
2018-07-04 6:07 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 07/10] trace_uprobe/sdt: Prevent multiple reference counter for same uprobe Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 08/10] Uprobes/sdt: " Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 09/10] Uprobes/sdt: Document about reference counter Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-07-02 14:54 ` Srikar Dronamraju
2018-07-02 14:54 ` Srikar Dronamraju
2018-07-02 14:54 ` Srikar Dronamraju
2018-07-03 7:50 ` Ravi Bangoria
2018-07-03 7:50 ` Ravi Bangoria
2018-07-03 7:50 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 10/10] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-06-28 5:22 ` Ravi Bangoria
2018-07-02 14:45 ` Srikar Dronamraju
2018-07-02 14:45 ` Srikar Dronamraju
2018-07-02 14:45 ` Srikar Dronamraju
2018-07-02 14:57 ` Srikar Dronamraju
2018-07-02 14:57 ` Srikar Dronamraju
2018-07-02 14:57 ` Srikar Dronamraju
2018-07-03 8:00 ` Ravi Bangoria
2018-07-03 8:00 ` Ravi Bangoria
2018-07-03 8:00 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703172543.GC23144@redhat.com \
--to=oleg@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexis.berlemont@gmail.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@armlinux.org.uk \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paul.burton@mips.com \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.