All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janusz Krzysztofik <jmkrzyszt@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>
Subject: [PATCH v2] gpiolib: Defer on non-DT find_chip_by_name() failure
Date: Wed,  4 Jul 2018 00:18:19 +0200	[thread overview]
Message-ID: <20180703221819.1825-1-jmkrzyszt@gmail.com> (raw)
In-Reply-To: <20180703172635.32508-1-jmkrzyszt@gmail.com>

Avoid replication of error code conversion in non-DT GPIO consumers'
code by returning -EPROBE_DEFER from gpiod_find() in case a chip
identified by its label in a registered lookup table is not ready.

See https://lkml.org/lkml/2018/5/30/176 for example case.

Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
Changelog
v2: fix typo (latar -> later) - thanks Boris and Andy for catching this

I'm not sure if adding both Suggested-by: and Reviewed-by: heades both
with the same person name is in line with good practices, please remove
one if not.

Thanks,
Janusz

 drivers/gpio/gpiolib.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e11a3bb03820..01295c03b315 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -3639,9 +3639,16 @@ static struct gpio_desc *gpiod_find(struct device *dev, const char *con_id,
 		chip = find_chip_by_name(p->chip_label);
 
 		if (!chip) {
-			dev_err(dev, "cannot find GPIO chip %s\n",
-				p->chip_label);
-			return ERR_PTR(-ENODEV);
+			/*
+			 * As the lookup table indicates a chip with
+			 * p->chip_label should exist, assume it may
+			 * still appear later and let the interested
+			 * consumer be probed again or let the Deferred
+			 * Probe infrastructure handle the error.
+			 */
+			dev_warn(dev, "cannot find GPIO chip %s, deferring\n",
+				 p->chip_label);
+			return ERR_PTR(-EPROBE_DEFER);
 		}
 
 		if (chip->ngpio <= p->chip_hwnum) {
-- 
2.16.4

  parent reply	other threads:[~2018-07-03 22:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 17:26 [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure Janusz Krzysztofik
2018-07-03 17:31 ` Boris Brezillon
2018-07-04 19:13   ` Janusz Krzysztofik
2018-07-05  5:23     ` Uwe Kleine-König
2018-07-05  5:50     ` Lee Jones
2018-07-05  5:50       ` Lee Jones
2018-07-05 20:56       ` Janusz Krzysztofik
2018-07-06  6:06         ` Lee Jones
2018-07-06  9:03         ` Richard Fitzgerald
2018-07-06 18:58           ` Janusz Krzysztofik
2018-07-03 20:06 ` Andy Shevchenko
2018-07-03 22:18 ` Janusz Krzysztofik [this message]
2018-07-04  7:17   ` [PATCH v2] " Boris Brezillon
2018-07-09 13:18   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703221819.1825-1-jmkrzyszt@gmail.com \
    --to=jmkrzyszt@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.