All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Boris Brezillon <boris.brezillon@bootlin.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure
Date: Tue, 3 Jul 2018 23:06:11 +0300	[thread overview]
Message-ID: <CAHp75Vf5XC=RNiid12WXYtiT-SSPoH45VpakRrNV=T0qQCecdg@mail.gmail.com> (raw)
In-Reply-To: <20180703172635.32508-1-jmkrzyszt@gmail.com>

On Tue, Jul 3, 2018 at 8:26 PM, Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:
> Avoid replication of error code conversion in non-DT GPIO consumers'
> code by returning -EPROBE_DEFER from gpiod_find() in case a chip
> identified by its label in a registered lookup table is not ready.
>
> See https://lkml.org/lkml/2018/5/30/176 for example case.

> +                       /*
> +                        * As the lookup table indicates a chip with
> +                        * p->chip_label should exist, assume it may
> +                        * still appear latar and let the interested

latar -> later

> +                        * consumer be probed again or let the Deferred
> +                        * Probe infrastructure handle the error.
> +                        */
> +                       dev_warn(dev, "cannot find GPIO chip %s, deferring\n",
> +                                p->chip_label);
> +                       return ERR_PTR(-EPROBE_DEFER);
>                 }

-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2018-07-03 20:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 17:26 [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure Janusz Krzysztofik
2018-07-03 17:31 ` Boris Brezillon
2018-07-04 19:13   ` Janusz Krzysztofik
2018-07-05  5:23     ` Uwe Kleine-König
2018-07-05  5:50     ` Lee Jones
2018-07-05  5:50       ` Lee Jones
2018-07-05 20:56       ` Janusz Krzysztofik
2018-07-06  6:06         ` Lee Jones
2018-07-06  9:03         ` Richard Fitzgerald
2018-07-06 18:58           ` Janusz Krzysztofik
2018-07-03 20:06 ` Andy Shevchenko [this message]
2018-07-03 22:18 ` [PATCH v2] " Janusz Krzysztofik
2018-07-04  7:17   ` Boris Brezillon
2018-07-09 13:18   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vf5XC=RNiid12WXYtiT-SSPoH45VpakRrNV=T0qQCecdg@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=jmkrzyszt@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.