From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] gpiolib: Defer on non-DT find_chip_by_name() failure
Date: Wed, 4 Jul 2018 09:17:22 +0200 [thread overview]
Message-ID: <20180704091722.29f86ae3@bbrezillon> (raw)
In-Reply-To: <20180703221819.1825-1-jmkrzyszt@gmail.com>
On Wed, 4 Jul 2018 00:18:19 +0200
Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:
> Avoid replication of error code conversion in non-DT GPIO consumers'
> code by returning -EPROBE_DEFER from gpiod_find() in case a chip
> identified by its label in a registered lookup table is not ready.
>
> See https://lkml.org/lkml/2018/5/30/176 for example case.
>
> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changelog
> v2: fix typo (latar -> later) - thanks Boris and Andy for catching this
>
> I'm not sure if adding both Suggested-by: and Reviewed-by: heades both
> with the same person name is in line with good practices, please remove
> one if not.
I don't think that's a problem. Suggesting a solution and agreeing on
the implementation are 2 different things, so both are not mutually
exclusive IMO.
next prev parent reply other threads:[~2018-07-04 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 17:26 [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure Janusz Krzysztofik
2018-07-03 17:31 ` Boris Brezillon
2018-07-04 19:13 ` Janusz Krzysztofik
2018-07-05 5:23 ` Uwe Kleine-König
2018-07-05 5:50 ` Lee Jones
2018-07-05 5:50 ` Lee Jones
2018-07-05 20:56 ` Janusz Krzysztofik
2018-07-06 6:06 ` Lee Jones
2018-07-06 9:03 ` Richard Fitzgerald
2018-07-06 18:58 ` Janusz Krzysztofik
2018-07-03 20:06 ` Andy Shevchenko
2018-07-03 22:18 ` [PATCH v2] " Janusz Krzysztofik
2018-07-04 7:17 ` Boris Brezillon [this message]
2018-07-09 13:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704091722.29f86ae3@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=jmkrzyszt@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.