From: Vinod Koul <vkoul@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Mathieu Malaterre <malat@debian.org>,
Daniel Silsby <dansilsby@gmail.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: [04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC
Date: Mon, 9 Jul 2018 22:40:32 +0530 [thread overview]
Message-ID: <20180709171032.GJ22377@vkoul-mobl> (raw)
On 03-07-18, 14:32, Paul Cercueil wrote:
> +static inline void jz4780_dma_chan_disable(struct jz4780_dma_dev *jzdma,
> + unsigned int chn)
> +{
> + if (jzdma->version == ID_JZ4770)
> + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKEC, BIT(chn));
> +}
this sounds as hardware behaviour, so why not describe as a property in
DT?
> +
> static struct jz4780_dma_desc *jz4780_dma_desc_alloc(
> struct jz4780_dma_chan *jzchan, unsigned int count,
> enum dma_transaction_type type)
> @@ -228,8 +246,15 @@ static void jz4780_dma_desc_free(struct virt_dma_desc *vdesc)
> kfree(desc);
> }
>
> -static uint32_t jz4780_dma_transfer_size(unsigned long val, uint32_t *shift)
> +static const unsigned int jz4780_dma_ord_max[] = {
> + [ID_JZ4770] = 6,
> + [ID_JZ4780] = 7,
> +};
So this gives the transfer length supported?
WARNING: multiple messages have this Message-ID (diff)
From: Vinod <vkoul@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Mathieu Malaterre <malat@debian.org>,
Daniel Silsby <dansilsby@gmail.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC
Date: Mon, 9 Jul 2018 22:40:32 +0530 [thread overview]
Message-ID: <20180709171032.GJ22377@vkoul-mobl> (raw)
In-Reply-To: <20180703123214.23090-5-paul@crapouillou.net>
On 03-07-18, 14:32, Paul Cercueil wrote:
> +static inline void jz4780_dma_chan_disable(struct jz4780_dma_dev *jzdma,
> + unsigned int chn)
> +{
> + if (jzdma->version == ID_JZ4770)
> + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKEC, BIT(chn));
> +}
this sounds as hardware behaviour, so why not describe as a property in
DT?
> +
> static struct jz4780_dma_desc *jz4780_dma_desc_alloc(
> struct jz4780_dma_chan *jzchan, unsigned int count,
> enum dma_transaction_type type)
> @@ -228,8 +246,15 @@ static void jz4780_dma_desc_free(struct virt_dma_desc *vdesc)
> kfree(desc);
> }
>
> -static uint32_t jz4780_dma_transfer_size(unsigned long val, uint32_t *shift)
> +static const unsigned int jz4780_dma_ord_max[] = {
> + [ID_JZ4770] = 6,
> + [ID_JZ4780] = 7,
> +};
So this gives the transfer length supported?
--
~Vinod
next reply other threads:[~2018-07-09 17:10 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 17:10 Vinod Koul [this message]
2018-07-09 17:10 ` [PATCH 04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC Vinod
-- strict thread matches above, loose matches on Subject: below --
2018-07-18 5:27 [05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC Vinod Koul
2018-07-18 5:27 ` [PATCH 05/14] " Vinod
2018-07-18 5:27 ` Vinod
2018-07-17 17:40 [05/14] " Rob Herring
2018-07-17 17:40 ` [PATCH 05/14] " Rob Herring
2018-07-17 17:40 ` Rob Herring
2018-07-17 15:34 [05/14] " Vinod Koul
2018-07-17 15:34 ` [PATCH 05/14] " Vinod
2018-07-17 11:00 [05/14] " Paul Cercueil
2018-07-17 11:00 ` [PATCH 05/14] " Paul Cercueil
2018-07-16 21:33 [05/14] " Rob Herring
2018-07-16 21:33 ` [PATCH 05/14] " Rob Herring
2018-07-16 21:28 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Rob Herring
2018-07-16 21:28 ` [PATCH 02/14] " Rob Herring
2018-07-11 23:27 [02/14] " Paul Burton
2018-07-11 23:27 ` [PATCH 02/14] " Paul Burton
2018-07-11 23:13 [06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC Paul Cercueil
2018-07-11 23:13 ` [PATCH 06/14] " Paul Cercueil
2018-07-11 23:13 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Paul Cercueil
2018-07-11 23:13 ` [PATCH 02/14] " Paul Cercueil
2018-07-11 12:18 [06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC Vinod Koul
2018-07-11 12:18 ` [PATCH 06/14] " Vinod
2018-07-11 12:16 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Vinod Koul
2018-07-11 12:16 ` [PATCH 02/14] " Vinod
2018-07-11 12:14 [01/14] dmaengine: dma-jz4780: Avoid hardcoding number of channels Vinod Koul
2018-07-11 12:14 ` [PATCH 01/14] " Vinod
2018-07-10 15:45 [06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC Paul Cercueil
2018-07-10 15:45 ` [PATCH 06/14] " Paul Cercueil
2018-07-10 15:41 [04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC Paul Cercueil
2018-07-10 15:41 ` [PATCH 04/14] " Paul Cercueil
2018-07-10 15:36 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Paul Cercueil
2018-07-10 15:36 ` [PATCH 02/14] " Paul Cercueil
2018-07-09 17:14 [06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC Vinod Koul
2018-07-09 17:14 ` [PATCH 06/14] " Vinod
2018-07-09 17:12 [05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC Vinod Koul
2018-07-09 17:12 ` [PATCH 05/14] " Vinod
2018-07-09 17:03 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Vinod Koul
2018-07-09 17:03 ` [PATCH 02/14] " Vinod
2018-07-07 11:01 [01/14] dmaengine: dma-jz4780: Avoid hardcoding number of channels Paul Cercueil
2018-07-07 11:01 ` [PATCH 01/14] " Paul Cercueil
2018-07-07 11:01 ` Paul Cercueil
2018-07-07 7:34 [01/14] " PrasannaKumar Muralidharan
2018-07-07 7:34 ` [PATCH 01/14] " PrasannaKumar Muralidharan
2018-07-07 7:34 ` PrasannaKumar Muralidharan
2018-07-07 7:27 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers PrasannaKumar Muralidharan
2018-07-07 7:27 ` [PATCH 02/14] " PrasannaKumar Muralidharan
2018-07-07 7:27 ` PrasannaKumar Muralidharan
2018-07-05 21:45 [02/14] " Paul Cercueil
2018-07-05 21:45 ` [PATCH 02/14] " Paul Cercueil
2018-07-05 21:45 ` Paul Cercueil
2018-07-05 18:26 [01/14] dmaengine: dma-jz4780: Avoid hardcoding number of channels Paul Cercueil
2018-07-05 18:26 ` [PATCH 01/14] " Paul Cercueil
2018-07-05 18:26 ` Paul Cercueil
2018-07-05 18:23 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Paul Cercueil
2018-07-05 18:23 ` [PATCH 02/14] " Paul Cercueil
2018-07-04 17:00 [07/14] dmaengine: dma-jz4780: Enable Fast DMA to the AIC PrasannaKumar Muralidharan
2018-07-04 17:00 ` [PATCH 07/14] " PrasannaKumar Muralidharan
2018-07-04 17:00 ` PrasannaKumar Muralidharan
2018-07-04 16:55 [06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC PrasannaKumar Muralidharan
2018-07-04 16:55 ` [PATCH 06/14] " PrasannaKumar Muralidharan
2018-07-04 16:55 ` PrasannaKumar Muralidharan
2018-07-04 16:52 [05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC PrasannaKumar Muralidharan
2018-07-04 16:52 ` [PATCH 05/14] " PrasannaKumar Muralidharan
2018-07-04 16:52 ` PrasannaKumar Muralidharan
2018-07-04 16:40 [03/14] dmaengine: dma-jz4780: Use 4-word descriptors PrasannaKumar Muralidharan
2018-07-04 16:40 ` [PATCH 03/14] " PrasannaKumar Muralidharan
2018-07-04 16:40 ` PrasannaKumar Muralidharan
2018-07-04 16:35 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers PrasannaKumar Muralidharan
2018-07-04 16:35 ` [PATCH 02/14] " PrasannaKumar Muralidharan
2018-07-04 16:35 ` PrasannaKumar Muralidharan
2018-07-04 16:28 [01/14] dmaengine: dma-jz4780: Avoid hardcoding number of channels PrasannaKumar Muralidharan
2018-07-04 16:28 ` [PATCH 01/14] " PrasannaKumar Muralidharan
2018-07-04 16:28 ` PrasannaKumar Muralidharan
2018-07-03 16:53 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Paul Burton
2018-07-03 16:53 ` [PATCH 02/14] " Paul Burton
2018-07-03 12:32 [14/14] MIPS: JZ4770: DTS: Add DMA nodes Paul Cercueil
2018-07-03 12:32 ` [PATCH 14/14] " Paul Cercueil
2018-07-03 12:32 [13/14] MIPS: JZ4780: DTS: Update DMA node to match driver changes Paul Cercueil
2018-07-03 12:32 ` [PATCH 13/14] " Paul Cercueil
2018-07-03 12:32 [12/14] dmaengine: dma-jz4780: Use dma_set_residue() Paul Cercueil
2018-07-03 12:32 ` [PATCH 12/14] " Paul Cercueil
2018-07-03 12:32 [11/14] dmaengine: dma-jz4780: Further residue status fix Paul Cercueil
2018-07-03 12:32 ` [PATCH 11/14] " Paul Cercueil
2018-07-03 12:32 [10/14] dmaengine: dma-jz4780: Set DTCn register explicitly Paul Cercueil
2018-07-03 12:32 ` [PATCH 10/14] " Paul Cercueil
2018-07-03 12:32 [09/14] dmaengine: dma-jz4780: Simplify jz4780_dma_desc_residue() Paul Cercueil
2018-07-03 12:32 ` [PATCH 09/14] " Paul Cercueil
2018-07-03 12:32 [08/14] dmaengine: dma-jz4780: Add missing residue DTC mask Paul Cercueil
2018-07-03 12:32 ` [PATCH 08/14] " Paul Cercueil
2018-07-03 12:32 [07/14] dmaengine: dma-jz4780: Enable Fast DMA to the AIC Paul Cercueil
2018-07-03 12:32 ` [PATCH 07/14] " Paul Cercueil
2018-07-03 12:32 [06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC Paul Cercueil
2018-07-03 12:32 ` [PATCH 06/14] " Paul Cercueil
2018-07-03 12:32 [05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC Paul Cercueil
2018-07-03 12:32 ` [PATCH 05/14] " Paul Cercueil
2018-07-03 12:32 [04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC Paul Cercueil
2018-07-03 12:32 ` [PATCH 04/14] " Paul Cercueil
2018-07-03 12:32 [03/14] dmaengine: dma-jz4780: Use 4-word descriptors Paul Cercueil
2018-07-03 12:32 ` [PATCH 03/14] " Paul Cercueil
2018-07-03 12:32 [02/14] dmaengine: dma-jz4780: Separate chan/ctrl registers Paul Cercueil
2018-07-03 12:32 ` [PATCH 02/14] " Paul Cercueil
2018-07-03 12:32 [PATCH 00/14] dma-jz4780 improvements Paul Cercueil
2018-07-03 12:32 ` [01/14] dmaengine: dma-jz4780: Avoid hardcoding number of channels Paul Cercueil
2018-07-03 12:32 ` [PATCH 01/14] " Paul Cercueil
2018-07-09 16:59 ` [01/14] " Vinod Koul
2018-07-09 16:59 ` [PATCH 01/14] " Vinod
2018-07-10 15:29 ` Paul Cercueil
2018-07-03 19:32 ` [PATCH 00/14] dma-jz4780 improvements Mathieu Malaterre
2018-07-03 19:32 ` Mathieu Malaterre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709171032.GJ22377@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=dansilsby@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.