From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lukasz Tyrala <ltyrala@cadence.com>,
Alan Douglas <adouglas@cadence.com>
Subject: Re: [PATCH 02/31] usb: usbssp: Added some decoding functions.
Date: Thu, 12 Jul 2018 08:35:06 +0200 [thread overview]
Message-ID: <20180712063506.GA25007@kroah.com> (raw)
In-Reply-To: <BYAPR07MB4709D8EB760716D0F9B0F4FBDD590@BYAPR07MB4709.namprd07.prod.outlook.com>
On Thu, Jul 12, 2018 at 06:28:33AM +0000, Pawel Laszczak wrote:
> > > This patch add additional functions that converts some fields to string.
> > >
> > > For example function usbssp_trb_comp_code_string take completion c ode
> > > value and return string describing completion code.
> >
> > Odd line-wrapping :(
> Do you mean additional space character between "c" and "ode"
It wrapped lines at that point for me, yes.
> > And why do you want a string for these things? Who cares about them?
> It will be used in next version of driver. I have plan to add gadget-debugfs.c file.
> At this moment this functions can be useful during debugging driver if someone want to display
> some debug information.
>
> Should I remove this function ?
If no one is using it now, yes, it does not need to be there, right? We
don't have dead code around for no reason, otherwise someone will come
along and remove it :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lukasz Tyrala <ltyrala@cadence.com>,
Alan Douglas <adouglas@cadence.com>
Subject: [02/31] usb: usbssp: Added some decoding functions.
Date: Thu, 12 Jul 2018 08:35:06 +0200 [thread overview]
Message-ID: <20180712063506.GA25007@kroah.com> (raw)
On Thu, Jul 12, 2018 at 06:28:33AM +0000, Pawel Laszczak wrote:
> > > This patch add additional functions that converts some fields to string.
> > >
> > > For example function usbssp_trb_comp_code_string take completion c ode
> > > value and return string describing completion code.
> >
> > Odd line-wrapping :(
> Do you mean additional space character between "c" and "ode"
It wrapped lines at that point for me, yes.
> > And why do you want a string for these things? Who cares about them?
> It will be used in next version of driver. I have plan to add gadget-debugfs.c file.
> At this moment this functions can be useful during debugging driver if someone want to display
> some debug information.
>
> Should I remove this function ?
If no one is using it now, yes, it does not need to be there, right? We
don't have dead code around for no reason, otherwise someone will come
along and remove it :)
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-12 6:35 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 5:46 [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver Pawel Laszczak
2018-07-12 5:46 ` [PATCH 01/31] usb: usbssp: Defined register maps and other useful structures Pawel Laszczak
2018-07-12 5:46 ` [01/31] " Pawel Laszczak
2018-07-12 6:09 ` [PATCH 01/31] " Greg Kroah-Hartman
2018-07-12 6:09 ` [01/31] " Greg Kroah-Hartman
2018-07-12 9:19 ` [PATCH 01/31] " Pawel Laszczak
2018-07-12 9:19 ` [01/31] " Pawel Laszczak
2018-07-12 19:20 ` [PATCH 01/31] " Pawel Laszczak
2018-07-12 19:20 ` [01/31] " Pawel Laszczak
2018-07-12 5:46 ` [PATCH 02/31] usb: usbssp: Added some decoding functions Pawel Laszczak
2018-07-12 5:46 ` [02/31] " Pawel Laszczak
2018-07-12 6:10 ` [PATCH 02/31] " Greg Kroah-Hartman
2018-07-12 6:10 ` [02/31] " Greg Kroah-Hartman
2018-07-12 6:28 ` [PATCH 02/31] " Pawel Laszczak
2018-07-12 6:28 ` [02/31] " Pawel Laszczak
2018-07-12 6:35 ` Greg Kroah-Hartman [this message]
2018-07-12 6:35 ` Greg Kroah-Hartman
2018-07-12 16:43 ` [PATCH 02/31] " Pawel Laszczak
2018-07-12 16:43 ` [02/31] " Pawel Laszczak
2018-07-12 17:07 ` [PATCH 02/31] " Greg Kroah-Hartman
2018-07-12 17:07 ` [02/31] " Greg Kroah-Hartman
2018-07-12 5:47 ` [PATCH 03/31] usb: usbssp: Add trace events used in driver Pawel Laszczak
2018-07-12 5:47 ` [03/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 04/31] usb: usbssp: Added USBSSP platform driver Pawel Laszczak
2018-07-12 5:47 ` [04/31] " Pawel Laszczak
2018-07-12 6:21 ` [PATCH 04/31] " Greg Kroah-Hartman
2018-07-12 6:21 ` [04/31] " Greg Kroah-Hartman
2018-07-12 10:40 ` [PATCH 04/31] " Pawel Laszczak
2018-07-12 10:40 ` [04/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 05/31] usb: usbssp: Added first part of initialization sequence Pawel Laszczak
2018-07-12 5:47 ` [05/31] " Pawel Laszczak
2018-07-12 6:27 ` [PATCH 05/31] " Greg Kroah-Hartman
2018-07-12 6:27 ` [05/31] " Greg Kroah-Hartman
2018-07-12 9:03 ` [PATCH 05/31] " Pawel Laszczak
2018-07-12 9:03 ` [05/31] " Pawel Laszczak
2018-07-12 9:09 ` [PATCH 05/31] " Greg Kroah-Hartman
2018-07-12 9:09 ` [05/31] " Greg Kroah-Hartman
2018-07-12 9:47 ` [PATCH 05/31] " Pawel Laszczak
2018-07-12 9:47 ` [05/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 06/31] usb: usbssp: added template functions used by upper layer Pawel Laszczak
2018-07-12 5:47 ` [06/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 07/31] usb: usbssp: Initialization - added usbssp_mem_init Pawel Laszczak
2018-07-12 5:47 ` [07/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 08/31] usb: usbssp: Added ring and segment handling functions Pawel Laszczak
2018-07-12 5:47 ` [08/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 09/31] usb: usbssp: add implementation of usbssp_mem_cleanup Pawel Laszczak
2018-07-12 5:47 ` [09/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 10/31] usb: usbssp: added usbssp_trb_in_td function Pawel Laszczak
2018-07-12 5:47 ` [10/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 11/31] usb: usbssp: added function for stopping driver Pawel Laszczak
2018-07-12 5:47 ` [11/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 12/31] usb: usbssp: added functions for queuing commands Pawel Laszczak
2018-07-12 5:47 ` [12/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 13/31] usb: usbssp: addec procedure for handlin Port Status Change events Pawel Laszczak
2018-07-12 5:47 ` [13/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 14/31] usb: usbssp: added procedure handling command completion events Pawel Laszczak
2018-07-12 5:47 ` [14/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 15/31] usb: usbssp: added device controller error, transfer and SETUP completion event Pawel Laszczak
2018-07-12 5:47 ` [15/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 16/31] usb: usbssp: added connect/disconnect procedures Pawel Laszczak
2018-07-12 5:47 ` [16/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 17/31] usb: usbssp: added implementation of usbssp_halt_endpoint function Pawel Laszczak
2018-07-12 5:47 ` [17/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 18/31] usb: usbssp: added handling of Port Reset event Pawel Laszczak
2018-07-12 5:47 ` [18/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 19/31] usb: usbssp: added support for USB enumeration process Pawel Laszczak
2018-07-12 5:47 ` [19/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 20/31] usb: usbssp: added queuing procedure for control transfer Pawel Laszczak
2018-07-12 5:47 ` [20/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 21/31] usb: usbssp: added queuing procedure for BULK and INT transfer Pawel Laszczak
2018-07-12 5:47 ` [21/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 22/31] usb: usbssp: added procedure removing request from transfer ring Pawel Laszczak
2018-07-12 5:47 ` [22/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 23/31] usb: usbssp: added implementation of transfer events Pawel Laszczak
2018-07-12 5:47 ` [23/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 24/31] usb: usbssp: added detecting command timeout Pawel Laszczak
2018-07-12 5:47 ` [24/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 25/31] usb: usbssp: added implementation of usbssp interface Pawel Laszczak
2018-07-12 5:47 ` [25/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 26/31] usb: usbssp: added endpoint configuration functionality Pawel Laszczak
2018-07-12 5:47 ` [26/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 27/31] usb: usbssp: implements usbssp_gadget_ep_enable function Pawel Laszczak
2018-07-12 5:47 ` [27/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 28/31] usb: usbssp: implemented usbssp_gadget_ep_disable function Pawel Laszczak
2018-07-12 5:47 ` [28/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 29/31] usb: usbssp: added support for LPM Pawel Laszczak
2018-07-12 5:47 ` [29/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 30/31] usb: usbssp: added support for TEST_MODE Pawel Laszczak
2018-07-12 5:47 ` [30/31] " Pawel Laszczak
2018-07-12 5:47 ` [PATCH 31/31] usb: usbssp: add pci to platform driver wrapper Pawel Laszczak
2018-07-12 5:47 ` [31/31] " Pawel Laszczak
2018-07-19 17:57 [PATCH 00/31] Introduced new Cadence USBSSP DRD Driver Pawel Laszczak
2018-07-19 17:57 ` [PATCH 02/31] usb: usbssp: Added some decoding functions Pawel Laszczak
2018-09-10 18:18 ` Greg Kroah-Hartman
2018-09-11 5:48 ` Felipe Balbi
2018-09-11 8:12 ` Greg Kroah-Hartman
2018-09-11 9:01 ` Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712063506.GA25007@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adouglas@cadence.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltyrala@cadence.com \
--cc=pawell@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.