* [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put
@ 2018-07-16 7:46 Thomas Zimmermann
2018-07-16 9:07 ` Souptick Joarder
2018-08-09 12:46 ` Daniel Vetter
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2018-07-16 7:46 UTC (permalink / raw)
To: daniel.vetter, airlied, briannorris, mawilcox, cakturk,
dan.carpenter, jrdr.linux, dri-devel
Cc: Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting
of struct drm_device. The resulting code is more aligned with the rest
of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 0e5620f76ee0..ec6af8b920da 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -504,7 +504,7 @@ static int __init vgem_init(void)
static void __exit vgem_exit(void)
{
drm_dev_unregister(&vgem_device->drm);
- drm_dev_unref(&vgem_device->drm);
+ drm_dev_put(&vgem_device->drm);
}
module_init(vgem_init);
--
2.18.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put
2018-07-16 7:46 [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put Thomas Zimmermann
@ 2018-07-16 9:07 ` Souptick Joarder
2018-07-16 9:12 ` Thomas Zimmermann
2018-08-09 12:46 ` Daniel Vetter
1 sibling, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2018-07-16 9:07 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: mawilcox, airlied, Daniel Vetter, briannorris, dri-devel,
Cihangir Aktürk, dan.carpenter
On Mon, Jul 16, 2018 at 1:16 PM, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> This patch unifies the naming of DRM functions for reference counting
> of struct drm_device. The resulting code is more aligned with the rest
> of the Linux kernel interfaces.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index 0e5620f76ee0..ec6af8b920da 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -504,7 +504,7 @@ static int __init vgem_init(void)
> static void __exit vgem_exit(void)
> {
> drm_dev_unregister(&vgem_device->drm);
> - drm_dev_unref(&vgem_device->drm);
> + drm_dev_put(&vgem_device->drm);
> }
>
> module_init(vgem_init);
> --
> 2.18.0
>
There are other gpu/drm drivers where drm_dev_unref is used.
Do we need to replace drm_dev_unref with drm_dev_put in
other places as well ?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put
2018-07-16 9:07 ` Souptick Joarder
@ 2018-07-16 9:12 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2018-07-16 9:12 UTC (permalink / raw)
To: Souptick Joarder
Cc: mawilcox, airlied, Daniel Vetter, briannorris, dri-devel,
Cihangir Aktürk, dan.carpenter
[-- Attachment #1.1.1: Type: text/plain, Size: 659 bytes --]
Hi
> There are other gpu/drm drivers where drm_dev_unref is used.
> Do we need to replace drm_dev_unref with drm_dev_put in
> other places as well ?
Yes. This is some overall clean-up work that I do as a side project. I
already have patches for all drivers, but I found that sending them
one-by-one gives a much better chance of getting them applied.
Best regards
Thomas
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nürnberg
Tel: +49-911-74053-0; Fax: +49-911-7417755; https://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard,
Graham Norton, HRB 21284 (AG Nürnberg)
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put
2018-07-16 7:46 [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put Thomas Zimmermann
2018-07-16 9:07 ` Souptick Joarder
@ 2018-08-09 12:46 ` Daniel Vetter
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-08-09 12:46 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: mawilcox, airlied, daniel.vetter, briannorris, dri-devel,
cakturk, jrdr.linux, dan.carpenter
On Mon, Jul 16, 2018 at 09:46:24AM +0200, Thomas Zimmermann wrote:
> This patch unifies the naming of DRM functions for reference counting
> of struct drm_device. The resulting code is more aligned with the rest
> of the Linux kernel interfaces.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Applied to drm-misc-next, thanks for your patch.
-Daniel
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index 0e5620f76ee0..ec6af8b920da 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -504,7 +504,7 @@ static int __init vgem_init(void)
> static void __exit vgem_exit(void)
> {
> drm_dev_unregister(&vgem_device->drm);
> - drm_dev_unref(&vgem_device->drm);
> + drm_dev_put(&vgem_device->drm);
> }
>
> module_init(vgem_init);
> --
> 2.18.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-09 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-16 7:46 [PATCH] drm/vgem: Replace drm_dev_unref with drm_dev_put Thomas Zimmermann
2018-07-16 9:07 ` Souptick Joarder
2018-07-16 9:12 ` Thomas Zimmermann
2018-08-09 12:46 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.