All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
@ 2018-07-19 11:19 Magnus Damm
  2018-07-19 12:59 ` Niklas Söderlund
  2018-07-20  8:21 ` Simon Horman
  0 siblings, 2 replies; 8+ messages in thread
From: Magnus Damm @ 2018-07-19 11:19 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Magnus Damm

From: Magnus Damm <damm+renesas@opensource.se>

Browsing the DTS for all the R-Car SoCs with similar part numbers
makes my head hurt, so to improve the user friendliness of the
DTS code base include R-Car product name in each DTSI file.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 Based on renesas-drivers-2018-07-17-v4.18-rc5

 arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi |    2 +-
 arch/arm64/boot/dts/renesas/r8a7795.dtsi     |    2 +-
 arch/arm64/boot/dts/renesas/r8a7796.dtsi     |    2 +-
 arch/arm64/boot/dts/renesas/r8a77965.dtsi    |    2 +-
 arch/arm64/boot/dts/renesas/r8a77970.dtsi    |    2 +-
 arch/arm64/boot/dts/renesas/r8a77980.dtsi    |    2 +-
 arch/arm64/boot/dts/renesas/r8a77990.dtsi    |    2 +-
 arch/arm64/boot/dts/renesas/r8a77995.dtsi    |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

--- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi	2018-07-19 20:04:10.900607110 +0900
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a7795 ES1.x SoC
+ * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
  *
  * Copyright (C) 2015 Renesas Electronics Corp.
  */
--- 0001/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi	2018-07-19 20:04:21.030607110 +0900
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a7795 SoC
+ * Device Tree Source for the R-Car H3 (R8A77950) SoC
  *
  * Copyright (C) 2015 Renesas Electronics Corp.
  */
--- 0001/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a7796.dtsi	2018-07-19 20:04:53.310607110 +0900
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a7796 SoC
+ * Device Tree Source for the R-Car M3-W (R8A77960) SoC
  *
  * Copyright (C) 2016-2017 Renesas Electronics Corp.
  */
--- 0001/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a77965.dtsi	2018-07-19 20:05:24.380607110 +0900
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77965 SoC
+ * Device Tree Source for the R-Car M3-N (R8A77965) SoC
  *
  * Copyright (C) 2018 Jacopo Mondi <jacopo+renesas@jmondi.org>
  *
--- 0001/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a77970.dtsi	2018-07-19 20:06:31.090607110 +0900
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77970 SoC
+ * Device Tree Source for the R-Car V3M (R8A77970) SoC
  *
  * Copyright (C) 2016-2017 Renesas Electronics Corp.
  * Copyright (C) 2017 Cogent Embedded, Inc.
--- 0001/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a77980.dtsi	2018-07-19 20:06:16.310607110 +0900
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77980 SoC
+ * Device Tree Source for the R-Car V3H (R8A77980) SoC
  *
  * Copyright (C) 2018 Renesas Electronics Corp.
  * Copyright (C) 2018 Cogent Embedded, Inc.
--- 0001/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a77990.dtsi	2018-07-19 20:06:58.970607110 +0900
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Device Tree Source for the r8a77990 SoC
+ * Device Tree Source for the R-Car E3 (R8A77990) SoC
  *
  * Copyright (C) 2018 Renesas Electronics Corp.
  */
--- 0005/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a77995.dtsi	2018-07-19 20:07:20.150607110 +0900
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77995 SoC
+ * Device Tree Source for the R-Car D3 (R8A77995) SoC
  *
  * Copyright (C) 2016 Renesas Electronics Corp.
  * Copyright (C) 2017 Glider bvba

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
  2018-07-19 11:19 [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files Magnus Damm
@ 2018-07-19 12:59 ` Niklas Söderlund
  2018-07-19 17:16   ` Magnus Damm
  2018-07-20  8:21 ` Simon Horman
  1 sibling, 1 reply; 8+ messages in thread
From: Niklas Söderlund @ 2018-07-19 12:59 UTC (permalink / raw)
  To: Magnus Damm; +Cc: linux-renesas-soc

Hi Magnus,

Thanks for your patch.

On 2018-07-19 20:19:50 +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Browsing the DTS for all the R-Car SoCs with similar part numbers
> makes my head hurt, so to improve the user friendliness of the
> DTS code base include R-Car product name in each DTSI file.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
> 
>  Based on renesas-drivers-2018-07-17-v4.18-rc5
> 
>  arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi |    2 +-
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi     |    2 +-
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi     |    2 +-
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi    |    2 +-
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi    |    2 +-
>  arch/arm64/boot/dts/renesas/r8a77980.dtsi    |    2 +-
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi    |    2 +-
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi    |    2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi	2018-07-19 20:04:10.900607110 +0900
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree Source for the r8a7795 ES1.x SoC
> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC

I'm just curies why do you append a extra 0 to the part number here and 
for M3-W? Other then I think this change is good and will help me as 
well to map part number to product name :-)

>   *
>   * Copyright (C) 2015 Renesas Electronics Corp.
>   */
> --- 0001/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi	2018-07-19 20:04:21.030607110 +0900
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree Source for the r8a7795 SoC
> + * Device Tree Source for the R-Car H3 (R8A77950) SoC
>   *
>   * Copyright (C) 2015 Renesas Electronics Corp.
>   */
> --- 0001/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7796.dtsi	2018-07-19 20:04:53.310607110 +0900
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree Source for the r8a7796 SoC
> + * Device Tree Source for the R-Car M3-W (R8A77960) SoC
>   *
>   * Copyright (C) 2016-2017 Renesas Electronics Corp.
>   */
> --- 0001/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77965.dtsi	2018-07-19 20:05:24.380607110 +0900
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree Source for the r8a77965 SoC
> + * Device Tree Source for the R-Car M3-N (R8A77965) SoC
>   *
>   * Copyright (C) 2018 Jacopo Mondi <jacopo+renesas@jmondi.org>
>   *
> --- 0001/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77970.dtsi	2018-07-19 20:06:31.090607110 +0900
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree Source for the r8a77970 SoC
> + * Device Tree Source for the R-Car V3M (R8A77970) SoC
>   *
>   * Copyright (C) 2016-2017 Renesas Electronics Corp.
>   * Copyright (C) 2017 Cogent Embedded, Inc.
> --- 0001/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77980.dtsi	2018-07-19 20:06:16.310607110 +0900
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree Source for the r8a77980 SoC
> + * Device Tree Source for the R-Car V3H (R8A77980) SoC
>   *
>   * Copyright (C) 2018 Renesas Electronics Corp.
>   * Copyright (C) 2018 Cogent Embedded, Inc.
> --- 0001/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77990.dtsi	2018-07-19 20:06:58.970607110 +0900
> @@ -1,6 +1,6 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  /*
> - * Device Tree Source for the r8a77990 SoC
> + * Device Tree Source for the R-Car E3 (R8A77990) SoC
>   *
>   * Copyright (C) 2018 Renesas Electronics Corp.
>   */
> --- 0005/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a77995.dtsi	2018-07-19 20:07:20.150607110 +0900
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree Source for the r8a77995 SoC
> + * Device Tree Source for the R-Car D3 (R8A77995) SoC
>   *
>   * Copyright (C) 2016 Renesas Electronics Corp.
>   * Copyright (C) 2017 Glider bvba

-- 
Regards,
Niklas S�derlund

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
  2018-07-19 12:59 ` Niklas Söderlund
@ 2018-07-19 17:16   ` Magnus Damm
  2018-07-19 17:37     ` Geert Uytterhoeven
  2018-07-24 12:15     ` Simon Horman
  0 siblings, 2 replies; 8+ messages in thread
From: Magnus Damm @ 2018-07-19 17:16 UTC (permalink / raw)
  To: Niklas Söderlund; +Cc: Linux-Renesas

Hi Niklas,

On Thu, Jul 19, 2018 at 9:59 PM, Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> Hi Magnus,
>
> Thanks for your patch.
>
> On 2018-07-19 20:19:50 +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm+renesas@opensource.se>
>>
>> Browsing the DTS for all the R-Car SoCs with similar part numbers
>> makes my head hurt, so to improve the user friendliness of the
>> DTS code base include R-Car product name in each DTSI file.
>>
>> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>> ---
>>
>>  Based on renesas-drivers-2018-07-17-v4.18-rc5
>>
>>  arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi |    2 +-
>>  arch/arm64/boot/dts/renesas/r8a7795.dtsi     |    2 +-
>>  arch/arm64/boot/dts/renesas/r8a7796.dtsi     |    2 +-
>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi    |    2 +-
>>  arch/arm64/boot/dts/renesas/r8a77970.dtsi    |    2 +-
>>  arch/arm64/boot/dts/renesas/r8a77980.dtsi    |    2 +-
>>  arch/arm64/boot/dts/renesas/r8a77990.dtsi    |    2 +-
>>  arch/arm64/boot/dts/renesas/r8a77995.dtsi    |    2 +-
>>  8 files changed, 8 insertions(+), 8 deletions(-)
>>
>> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
>> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi 2018-07-19 20:04:10.900607110 +0900
>> @@ -1,6 +1,6 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  /*
>> - * Device Tree Source for the r8a7795 ES1.x SoC
>> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
>
> I'm just curies why do you append a extra 0 to the part number here and
> for M3-W? Other then I think this change is good and will help me as
> well to map part number to product name :-)

Good question!

I should probably have mentioned in the patch description that the
names and part numbers come from the file
Documentation/devicetree/bindings/arm/shmobile.txt.

Thanks for the feedback!

Cheers,

/ magnus

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
  2018-07-19 17:16   ` Magnus Damm
@ 2018-07-19 17:37     ` Geert Uytterhoeven
  2018-07-20  3:05       ` Magnus Damm
  2018-07-24 12:15     ` Simon Horman
  1 sibling, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2018-07-19 17:37 UTC (permalink / raw)
  To: Magnus Damm; +Cc: Niklas Söderlund, Linux-Renesas

Hi Magnus,

On Thu, Jul 19, 2018 at 7:16 PM Magnus Damm <magnus.damm@gmail.com> wrote:
> On Thu, Jul 19, 2018 at 9:59 PM, Niklas Söderlund
> <niklas.soderlund@ragnatech.se> wrote:
> > On 2018-07-19 20:19:50 +0900, Magnus Damm wrote:
> >> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> >> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi 2018-07-19 20:04:10.900607110 +0900
> >> @@ -1,6 +1,6 @@
> >>  // SPDX-License-Identifier: GPL-2.0
> >>  /*
> >> - * Device Tree Source for the r8a7795 ES1.x SoC
> >> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
> >
> > I'm just curies why do you append a extra 0 to the part number here and
> > for M3-W? Other then I think this change is good and will help me as
> > well to map part number to product name :-)
>
> Good question!
>
> I should probably have mentioned in the patch description that the
> names and part numbers come from the file
> Documentation/devicetree/bindings/arm/shmobile.txt.

To add to the confusion: R-Car H3 ES2.0 is actually R8A77951...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
  2018-07-19 17:37     ` Geert Uytterhoeven
@ 2018-07-20  3:05       ` Magnus Damm
  2018-07-20  7:31         ` Geert Uytterhoeven
  0 siblings, 1 reply; 8+ messages in thread
From: Magnus Damm @ 2018-07-20  3:05 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Niklas Söderlund, Linux-Renesas

Hi Geert,

On Fri, Jul 20, 2018 at 2:37 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Thu, Jul 19, 2018 at 7:16 PM Magnus Damm <magnus.damm@gmail.com> wrote:
>> On Thu, Jul 19, 2018 at 9:59 PM, Niklas Söderlund
>> <niklas.soderlund@ragnatech.se> wrote:
>> > On 2018-07-19 20:19:50 +0900, Magnus Damm wrote:
>> >> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
>> >> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi 2018-07-19 20:04:10.900607110 +0900
>> >> @@ -1,6 +1,6 @@
>> >>  // SPDX-License-Identifier: GPL-2.0
>> >>  /*
>> >> - * Device Tree Source for the r8a7795 ES1.x SoC
>> >> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
>> >
>> > I'm just curies why do you append a extra 0 to the part number here and
>> > for M3-W? Other then I think this change is good and will help me as
>> > well to map part number to product name :-)
>>
>> Good question!
>>
>> I should probably have mentioned in the patch description that the
>> names and part numbers come from the file
>> Documentation/devicetree/bindings/arm/shmobile.txt.
>
> To add to the confusion: R-Car H3 ES2.0 is actually R8A77951...

What a mess! I wonder what ES3.0 is?

Cheers,

/ magnus

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
  2018-07-20  3:05       ` Magnus Damm
@ 2018-07-20  7:31         ` Geert Uytterhoeven
  0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2018-07-20  7:31 UTC (permalink / raw)
  To: Magnus Damm; +Cc: Niklas Söderlund, Linux-Renesas

Hi Magnus,

On Fri, Jul 20, 2018 at 5:05 AM Magnus Damm <magnus.damm@gmail.com> wrote:
> On Fri, Jul 20, 2018 at 2:37 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Thu, Jul 19, 2018 at 7:16 PM Magnus Damm <magnus.damm@gmail.com> wrote:
> >> On Thu, Jul 19, 2018 at 9:59 PM, Niklas Söderlund
> >> <niklas.soderlund@ragnatech.se> wrote:
> >> > On 2018-07-19 20:19:50 +0900, Magnus Damm wrote:
> >> >> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> >> >> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi 2018-07-19 20:04:10.900607110 +0900
> >> >> @@ -1,6 +1,6 @@
> >> >>  // SPDX-License-Identifier: GPL-2.0
> >> >>  /*
> >> >> - * Device Tree Source for the r8a7795 ES1.x SoC
> >> >> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
> >> >
> >> > I'm just curies why do you append a extra 0 to the part number here and
> >> > for M3-W? Other then I think this change is good and will help me as
> >> > well to map part number to product name :-)
> >>
> >> Good question!
> >>
> >> I should probably have mentioned in the patch description that the
> >> names and part numbers come from the file
> >> Documentation/devicetree/bindings/arm/shmobile.txt.
> >
> > To add to the confusion: R-Car H3 ES2.0 is actually R8A77951...
>
> What a mess! I wonder what ES3.0 is?

I expect R-Car H3 ES3.0 to be an incremental (bug fix) evolution of R-Car
H3 ES2.0 (which is IMHO a different SoC than R-Car H3 ES1.x).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
  2018-07-19 11:19 [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files Magnus Damm
  2018-07-19 12:59 ` Niklas Söderlund
@ 2018-07-20  8:21 ` Simon Horman
  1 sibling, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-07-20  8:21 UTC (permalink / raw)
  To: Magnus Damm; +Cc: linux-renesas-soc

On Thu, Jul 19, 2018 at 08:19:50PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Browsing the DTS for all the R-Car SoCs with similar part numbers
> makes my head hurt, so to improve the user friendliness of the
> DTS code base include R-Car product name in each DTSI file.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

Thanks Magnus,

I'm glad to hear its not just me!  This looks good but I will wait to see
if there are other reviews before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files
  2018-07-19 17:16   ` Magnus Damm
  2018-07-19 17:37     ` Geert Uytterhoeven
@ 2018-07-24 12:15     ` Simon Horman
  1 sibling, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-07-24 12:15 UTC (permalink / raw)
  To: Magnus Damm; +Cc: Niklas Söderlund, Linux-Renesas

On Fri, Jul 20, 2018 at 02:16:13AM +0900, Magnus Damm wrote:
> Hi Niklas,
> 
> On Thu, Jul 19, 2018 at 9:59 PM, Niklas Söderlund
> <niklas.soderlund@ragnatech.se> wrote:
> > Hi Magnus,
> >
> > Thanks for your patch.
> >
> > On 2018-07-19 20:19:50 +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm+renesas@opensource.se>
> >>
> >> Browsing the DTS for all the R-Car SoCs with similar part numbers
> >> makes my head hurt, so to improve the user friendliness of the
> >> DTS code base include R-Car product name in each DTSI file.
> >>
> >> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> >> ---
> >>
> >>  Based on renesas-drivers-2018-07-17-v4.18-rc5
> >>
> >>  arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi |    2 +-
> >>  arch/arm64/boot/dts/renesas/r8a7795.dtsi     |    2 +-
> >>  arch/arm64/boot/dts/renesas/r8a7796.dtsi     |    2 +-
> >>  arch/arm64/boot/dts/renesas/r8a77965.dtsi    |    2 +-
> >>  arch/arm64/boot/dts/renesas/r8a77970.dtsi    |    2 +-
> >>  arch/arm64/boot/dts/renesas/r8a77980.dtsi    |    2 +-
> >>  arch/arm64/boot/dts/renesas/r8a77990.dtsi    |    2 +-
> >>  arch/arm64/boot/dts/renesas/r8a77995.dtsi    |    2 +-
> >>  8 files changed, 8 insertions(+), 8 deletions(-)
> >>
> >> --- 0001/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
> >> +++ work/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi 2018-07-19 20:04:10.900607110 +0900
> >> @@ -1,6 +1,6 @@
> >>  // SPDX-License-Identifier: GPL-2.0
> >>  /*
> >> - * Device Tree Source for the r8a7795 ES1.x SoC
> >> + * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
> >
> > I'm just curies why do you append a extra 0 to the part number here and
> > for M3-W? Other then I think this change is good and will help me as
> > well to map part number to product name :-)
> 
> Good question!
> 
> I should probably have mentioned in the patch description that the
> names and part numbers come from the file
> Documentation/devicetree/bindings/arm/shmobile.txt.

Thanks, I have applied the following for v4.20.

From: Magnus Damm <damm+renesas@opensource.se>
Subject: [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files

Browsing the DTS for all the R-Car SoCs with similar part numbers
makes my head hurt, so to improve the user friendliness of the
DTS code base include R-Car product name in each DTSI file.

Product names are derived from
Documentation/devicetree/bindings/arm/shmobile.txt

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 2 +-
 arch/arm64/boot/dts/renesas/r8a7795.dtsi     | 2 +-
 arch/arm64/boot/dts/renesas/r8a7796.dtsi     | 2 +-
 arch/arm64/boot/dts/renesas/r8a77965.dtsi    | 2 +-
 arch/arm64/boot/dts/renesas/r8a77970.dtsi    | 2 +-
 arch/arm64/boot/dts/renesas/r8a77980.dtsi    | 2 +-
 arch/arm64/boot/dts/renesas/r8a77990.dtsi    | 2 +-
 arch/arm64/boot/dts/renesas/r8a77995.dtsi    | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi b/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
index 7b2fbaec9aef..d915cff5b1b0 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a7795 ES1.x SoC
+ * Device Tree Source for the R-Car H3 (R8A77950) ES1.x SoC
  *
  * Copyright (C) 2015 Renesas Electronics Corp.
  */
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index fb9d08ad7659..aa0d4c8f6b04 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a7795 SoC
+ * Device Tree Source for the R-Car H3 (R8A77950) SoC
  *
  * Copyright (C) 2015 Renesas Electronics Corp.
  */
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index cbd35c00b4af..b93596c9c6b1 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a7796 SoC
+ * Device Tree Source for the R-Car M3-W (R8A77960) SoC
  *
  * Copyright (C) 2016-2017 Renesas Electronics Corp.
  */
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 0cd44461a0bd..9c4f40589cbd 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77965 SoC
+ * Device Tree Source for the R-Car M3-N (R8A77965) SoC
  *
  * Copyright (C) 2018 Jacopo Mondi <jacopo+renesas@jmondi.org>
  *
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 954168858fed..18d1aafe2e30 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77970 SoC
+ * Device Tree Source for the R-Car V3M (R8A77970) SoC
  *
  * Copyright (C) 2016-2017 Renesas Electronics Corp.
  * Copyright (C) 2017 Cogent Embedded, Inc.
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 4a1097e32551..d3532fd4c94a 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77980 SoC
+ * Device Tree Source for the R-Car V3H (R8A77980) SoC
  *
  * Copyright (C) 2018 Renesas Electronics Corp.
  * Copyright (C) 2018 Cogent Embedded, Inc.
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index ae89260baad9..2c8f1194e6b5 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Device Tree Source for the r8a77990 SoC
+ * Device Tree Source for the R-Car E3 (R8A77990) SoC
  *
  * Copyright (C) 2018 Renesas Electronics Corp.
  */
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index fe77bc43c447..c94513ce5b9b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Device Tree Source for the r8a77995 SoC
+ * Device Tree Source for the R-Car D3 (R8A77995) SoC
  *
  * Copyright (C) 2016 Renesas Electronics Corp.
  * Copyright (C) 2017 Glider bvba
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-07-24 13:21 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 11:19 [PATCH] arm64: dts: renesas: Include R-Car product name in DTSI files Magnus Damm
2018-07-19 12:59 ` Niklas Söderlund
2018-07-19 17:16   ` Magnus Damm
2018-07-19 17:37     ` Geert Uytterhoeven
2018-07-20  3:05       ` Magnus Damm
2018-07-20  7:31         ` Geert Uytterhoeven
2018-07-24 12:15     ` Simon Horman
2018-07-20  8:21 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.