* [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
@ 2018-07-27 15:57 ` Anton Vasilyev
0 siblings, 0 replies; 6+ messages in thread
From: Anton Vasilyev @ 2018-07-27 15:57 UTC (permalink / raw)
To: Andrew Lunn
Cc: Anton Vasilyev, Florian Fainelli, David S. Miller, Ray Jui,
Scott Branden, Jon Mason, bcm-kernel-feedback-list, netdev,
linux-arm-kernel, linux-kernel, ldv-project
mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
in device, whereas mdio_mux_iproc_remove() restores md pointer by
dev_get_platdata(&pdev->dev). This leads to wrong resources release.
The patch replaces getter to platform_get_drvdata.
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
drivers/net/phy/mdio-mux-bcm-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c
index 0831b7142df7..0c5b68e7da51 100644
--- a/drivers/net/phy/mdio-mux-bcm-iproc.c
+++ b/drivers/net/phy/mdio-mux-bcm-iproc.c
@@ -218,7 +218,7 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
static int mdio_mux_iproc_remove(struct platform_device *pdev)
{
- struct iproc_mdiomux_desc *md = dev_get_platdata(&pdev->dev);
+ struct iproc_mdiomux_desc *md = platform_get_drvdata(pdev);
mdio_mux_uninit(md->mux_handle);
mdiobus_unregister(md->mii_bus);
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
@ 2018-07-27 15:57 ` Anton Vasilyev
0 siblings, 0 replies; 6+ messages in thread
From: Anton Vasilyev @ 2018-07-27 15:57 UTC (permalink / raw)
To: linux-arm-kernel
mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
in device, whereas mdio_mux_iproc_remove() restores md pointer by
dev_get_platdata(&pdev->dev). This leads to wrong resources release.
The patch replaces getter to platform_get_drvdata.
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
drivers/net/phy/mdio-mux-bcm-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c
index 0831b7142df7..0c5b68e7da51 100644
--- a/drivers/net/phy/mdio-mux-bcm-iproc.c
+++ b/drivers/net/phy/mdio-mux-bcm-iproc.c
@@ -218,7 +218,7 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
static int mdio_mux_iproc_remove(struct platform_device *pdev)
{
- struct iproc_mdiomux_desc *md = dev_get_platdata(&pdev->dev);
+ struct iproc_mdiomux_desc *md = platform_get_drvdata(pdev);
mdio_mux_uninit(md->mux_handle);
mdiobus_unregister(md->mii_bus);
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
2018-07-27 15:57 ` Anton Vasilyev
@ 2018-07-27 16:17 ` Andrew Lunn
-1 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2018-07-27 16:17 UTC (permalink / raw)
To: Anton Vasilyev
Cc: Florian Fainelli, David S. Miller, Ray Jui, Scott Branden,
Jon Mason, bcm-kernel-feedback-list, netdev, linux-arm-kernel,
linux-kernel, ldv-project
On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
> in device, whereas mdio_mux_iproc_remove() restores md pointer by
> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
>
> The patch replaces getter to platform_get_drvdata.
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
@ 2018-07-27 16:17 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2018-07-27 16:17 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
> in device, whereas mdio_mux_iproc_remove() restores md pointer by
> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
>
> The patch replaces getter to platform_get_drvdata.
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
2018-07-27 16:17 ` Andrew Lunn
@ 2018-07-29 2:08 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-07-29 2:08 UTC (permalink / raw)
To: andrew
Cc: vasilyev, f.fainelli, rjui, sbranden, jonmason,
bcm-kernel-feedback-list, netdev, linux-arm-kernel, linux-kernel,
ldv-project
From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 27 Jul 2018 18:17:07 +0200
> On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
>> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
>> in device, whereas mdio_mux_iproc_remove() restores md pointer by
>> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
>>
>> The patch replaces getter to platform_get_drvdata.
>>
>> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
>
> Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
@ 2018-07-29 2:08 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-07-29 2:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 27 Jul 2018 18:17:07 +0200
> On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
>> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
>> in device, whereas mdio_mux_iproc_remove() restores md pointer by
>> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
>>
>> The patch replaces getter to platform_get_drvdata.
>>
>> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
>
> Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-29 2:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 15:57 [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair Anton Vasilyev
2018-07-27 15:57 ` Anton Vasilyev
2018-07-27 16:17 ` Andrew Lunn
2018-07-27 16:17 ` Andrew Lunn
2018-07-29 2:08 ` David Miller
2018-07-29 2:08 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.