* [PATCH] drm/i915/execlists: Terminate the context image with BB_END
@ 2018-07-30 16:28 Chris Wilson
2018-07-30 16:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Chris Wilson @ 2018-07-30 16:28 UTC (permalink / raw)
To: intel-gfx
In the aub trace utility, the context images are terminated with a
MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
Do the same for our protocontext image for completeness, and in passing
apply the magic bit for gen10 to mark the end of the context image.
Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
Let's see what breaks!
-Chris
---
drivers/gpu/drm/i915/intel_lrc.c | 4 ++++
drivers/gpu/drm/i915/intel_lrc_reg.h | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index fad689efb67a..1904d2e27019 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -2653,6 +2653,10 @@ static void execlists_init_reg_state(u32 *regs,
i915_oa_init_reg_state(engine, ctx, regs);
}
+
+ regs[CTX_BBE_END] = MI_BATCH_BUFFER_END;
+ if (INTEL_GEN(dev_priv) >= 10)
+ regs[CTX_BBE_END] |= BIT(0);
}
static int
diff --git a/drivers/gpu/drm/i915/intel_lrc_reg.h b/drivers/gpu/drm/i915/intel_lrc_reg.h
index 169a2239d6c7..b08bdbfc96f1 100644
--- a/drivers/gpu/drm/i915/intel_lrc_reg.h
+++ b/drivers/gpu/drm/i915/intel_lrc_reg.h
@@ -37,7 +37,7 @@
#define CTX_PDP0_LDW 0x32
#define CTX_LRI_HEADER_2 0x41
#define CTX_R_PWR_CLK_STATE 0x42
-#define CTX_GPGPU_CSR_BASE_ADDRESS 0x44
+#define CTX_BB_END 0x44
#define CTX_REG(reg_state, pos, reg, val) do { \
u32 *reg_state__ = (reg_state); \
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/execlists: Terminate the context image with BB_END
2018-07-30 16:28 [PATCH] drm/i915/execlists: Terminate the context image with BB_END Chris Wilson
@ 2018-07-30 16:38 ` Patchwork
2018-07-30 16:43 ` [PATCH] " Chris Wilson
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-07-30 16:38 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Terminate the context image with BB_END
URL : https://patchwork.freedesktop.org/series/47439/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/intel_lrc.o
drivers/gpu/drm/i915/intel_lrc.c: In function ‘execlists_init_reg_state’:
drivers/gpu/drm/i915/intel_lrc.c:2657:7: error: ‘CTX_BBE_END’ undeclared (first use in this function); did you mean ‘CTX_BB_END’?
regs[CTX_BBE_END] = MI_BATCH_BUFFER_END;
^~~~~~~~~~~
CTX_BB_END
drivers/gpu/drm/i915/intel_lrc.c:2657:7: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:317: recipe for target 'drivers/gpu/drm/i915/intel_lrc.o' failed
make[4]: *** [drivers/gpu/drm/i915/intel_lrc.o] Error 1
scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1029: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/i915/execlists: Terminate the context image with BB_END
2018-07-30 16:28 [PATCH] drm/i915/execlists: Terminate the context image with BB_END Chris Wilson
2018-07-30 16:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-07-30 16:43 ` Chris Wilson
2018-07-31 12:47 ` Lionel Landwerlin
2018-07-30 17:31 ` ✓ Fi.CI.BAT: success for drm/i915/execlists: Terminate the context image with BB_END (rev2) Patchwork
2018-07-30 19:52 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2018-07-30 16:43 UTC (permalink / raw)
To: intel-gfx
In the aub trace utility, the context images are terminated with a
MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
Do the same for our protocontext image for completeness, and in passing
apply the magic bit for gen10 to mark the end of the context image.
Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 4 ++++
drivers/gpu/drm/i915/intel_lrc_reg.h | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index fad689efb67a..b0be180c6294 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -2653,6 +2653,10 @@ static void execlists_init_reg_state(u32 *regs,
i915_oa_init_reg_state(engine, ctx, regs);
}
+
+ regs[CTX_END] = MI_BATCH_BUFFER_END;
+ if (INTEL_GEN(dev_priv) >= 10)
+ regs[CTX_END] |= BIT(0);
}
static int
diff --git a/drivers/gpu/drm/i915/intel_lrc_reg.h b/drivers/gpu/drm/i915/intel_lrc_reg.h
index 169a2239d6c7..5ef932d810a7 100644
--- a/drivers/gpu/drm/i915/intel_lrc_reg.h
+++ b/drivers/gpu/drm/i915/intel_lrc_reg.h
@@ -37,7 +37,7 @@
#define CTX_PDP0_LDW 0x32
#define CTX_LRI_HEADER_2 0x41
#define CTX_R_PWR_CLK_STATE 0x42
-#define CTX_GPGPU_CSR_BASE_ADDRESS 0x44
+#define CTX_END 0x44
#define CTX_REG(reg_state, pos, reg, val) do { \
u32 *reg_state__ = (reg_state); \
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/execlists: Terminate the context image with BB_END (rev2)
2018-07-30 16:28 [PATCH] drm/i915/execlists: Terminate the context image with BB_END Chris Wilson
2018-07-30 16:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-07-30 16:43 ` [PATCH] " Chris Wilson
@ 2018-07-30 17:31 ` Patchwork
2018-07-30 19:52 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-07-30 17:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Terminate the context image with BB_END (rev2)
URL : https://patchwork.freedesktop.org/series/47439/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4595 -> Patchwork_9814 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9814 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9814, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47439/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9814:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_evict:
fi-cnl-psr: SKIP -> PASS +9
== Known issues ==
Here are the changes found in Patchwork_9814 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_objects:
fi-cnl-psr: SKIP -> DMESG-FAIL (fdo#107398)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: NOTRUN -> INCOMPLETE (fdo#103713)
{igt@kms_psr@primary_mmap_gtt}:
fi-cnl-psr: PASS -> DMESG-WARN (fdo#107372)
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@drv_selftest@live_coherency:
{fi-icl-u}: DMESG-FAIL -> PASS
igt@drv_selftest@live_requests:
{fi-bsw-kefka}: INCOMPLETE (fdo#105876) -> PASS
igt@drv_selftest@live_workarounds:
{fi-bsw-kefka}: DMESG-FAIL (fdo#107292) -> PASS
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: FAIL (fdo#103841) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105876 https://bugs.freedesktop.org/show_bug.cgi?id=105876
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107398 https://bugs.freedesktop.org/show_bug.cgi?id=107398
== Participating hosts (52 -> 46) ==
Additional (1): fi-byt-j1900
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4595 -> Patchwork_9814
CI_DRM_4595: f133adaa57cf7118381b5ffc081bba3bbb1dbc83 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4581: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9814: 6f1fa738117c5003025c11afe31eafeeca1f7617 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6f1fa738117c drm/i915/execlists: Terminate the context image with BB_END
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9814/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/execlists: Terminate the context image with BB_END (rev2)
2018-07-30 16:28 [PATCH] drm/i915/execlists: Terminate the context image with BB_END Chris Wilson
` (2 preceding siblings ...)
2018-07-30 17:31 ` ✓ Fi.CI.BAT: success for drm/i915/execlists: Terminate the context image with BB_END (rev2) Patchwork
@ 2018-07-30 19:52 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-07-30 19:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Terminate the context image with BB_END (rev2)
URL : https://patchwork.freedesktop.org/series/47439/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4595_full -> Patchwork_9814_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9814_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9814_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9814_full:
=== IGT changes ===
==== Warnings ====
igt@kms_atomic_transition@plane-all-transition-nonblocking:
shard-snb: PASS -> SKIP +2
== Known issues ==
Here are the changes found in Patchwork_9814_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
shard-glk: PASS -> FAIL (fdo#103375)
==== Possible fixes ====
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: FAIL (fdo#102887) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-kbl: FAIL (fdo#105363, fdo#102887) -> PASS
igt@kms_flip@plain-flip-ts-check:
shard-glk: FAIL (fdo#100368) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4595 -> Patchwork_9814
CI_DRM_4595: f133adaa57cf7118381b5ffc081bba3bbb1dbc83 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4581: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9814: 6f1fa738117c5003025c11afe31eafeeca1f7617 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9814/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/execlists: Terminate the context image with BB_END
2018-07-30 16:43 ` [PATCH] " Chris Wilson
@ 2018-07-31 12:47 ` Lionel Landwerlin
2018-07-31 21:58 ` Chris Wilson
2018-08-01 16:03 ` Chris Wilson
0 siblings, 2 replies; 8+ messages in thread
From: Lionel Landwerlin @ 2018-07-31 12:47 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 30/07/18 17:43, Chris Wilson wrote:
> In the aub trace utility, the context images are terminated with a
> MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
> Do the same for our protocontext image for completeness, and in passing
> apply the magic bit for gen10 to mark the end of the context image.
>
> Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Doesn't look like anything exploded.
Have you noticed any improvement maybe in the benchmarks?
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 4 ++++
> drivers/gpu/drm/i915/intel_lrc_reg.h | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index fad689efb67a..b0be180c6294 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -2653,6 +2653,10 @@ static void execlists_init_reg_state(u32 *regs,
>
> i915_oa_init_reg_state(engine, ctx, regs);
> }
> +
> + regs[CTX_END] = MI_BATCH_BUFFER_END;
> + if (INTEL_GEN(dev_priv) >= 10)
> + regs[CTX_END] |= BIT(0);
> }
>
> static int
> diff --git a/drivers/gpu/drm/i915/intel_lrc_reg.h b/drivers/gpu/drm/i915/intel_lrc_reg.h
> index 169a2239d6c7..5ef932d810a7 100644
> --- a/drivers/gpu/drm/i915/intel_lrc_reg.h
> +++ b/drivers/gpu/drm/i915/intel_lrc_reg.h
> @@ -37,7 +37,7 @@
> #define CTX_PDP0_LDW 0x32
> #define CTX_LRI_HEADER_2 0x41
> #define CTX_R_PWR_CLK_STATE 0x42
> -#define CTX_GPGPU_CSR_BASE_ADDRESS 0x44
> +#define CTX_END 0x44
>
> #define CTX_REG(reg_state, pos, reg, val) do { \
> u32 *reg_state__ = (reg_state); \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/execlists: Terminate the context image with BB_END
2018-07-31 12:47 ` Lionel Landwerlin
@ 2018-07-31 21:58 ` Chris Wilson
2018-08-01 16:03 ` Chris Wilson
1 sibling, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-07-31 21:58 UTC (permalink / raw)
To: Lionel Landwerlin, intel-gfx
Quoting Lionel Landwerlin (2018-07-31 13:47:32)
> On 30/07/18 17:43, Chris Wilson wrote:
> > In the aub trace utility, the context images are terminated with a
> > MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
> > Do the same for our protocontext image for completeness, and in passing
> > apply the magic bit for gen10 to mark the end of the context image.
> >
> > Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> Doesn't look like anything exploded.
> Have you noticed any improvement maybe in the benchmarks?
Haven't found anything that shows a difference. I expect that after the
first save, the context image has grown the BB_END.
I was going to dissect the default context image to see if that was
true.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/execlists: Terminate the context image with BB_END
2018-07-31 12:47 ` Lionel Landwerlin
2018-07-31 21:58 ` Chris Wilson
@ 2018-08-01 16:03 ` Chris Wilson
1 sibling, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-08-01 16:03 UTC (permalink / raw)
To: Lionel Landwerlin, intel-gfx
Quoting Lionel Landwerlin (2018-07-31 13:47:32)
> On 30/07/18 17:43, Chris Wilson wrote:
> > In the aub trace utility, the context images are terminated with a
> > MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
> > Do the same for our protocontext image for completeness, and in passing
> > apply the magic bit for gen10 to mark the end of the context image.
> >
> > Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> Doesn't look like anything exploded.
> Have you noticed any improvement maybe in the benchmarks?
In practice, it is replaced by HW state, so it only applies to the very
first context load on which it is meant to be suppressed. Interesting to
note that the HW only terminates RCS with a BB_END.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-08-01 16:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 16:28 [PATCH] drm/i915/execlists: Terminate the context image with BB_END Chris Wilson
2018-07-30 16:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-07-30 16:43 ` [PATCH] " Chris Wilson
2018-07-31 12:47 ` Lionel Landwerlin
2018-07-31 21:58 ` Chris Wilson
2018-08-01 16:03 ` Chris Wilson
2018-07-30 17:31 ` ✓ Fi.CI.BAT: success for drm/i915/execlists: Terminate the context image with BB_END (rev2) Patchwork
2018-07-30 19:52 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.