All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj
@ 2018-08-01 17:04 Chris Wilson
  2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
                   ` (6 more replies)
  0 siblings, 7 replies; 10+ messages in thread
From: Chris Wilson @ 2018-08-01 17:04 UTC (permalink / raw)
  To: intel-gfx

We used to reset last_adj to 0 on crossing a power domain boundary, to
slow down our rate of change. However, commit 60548c554be2 ("drm/i915:
Interactive RPS mode") accidentally caused it to be reset on every
frequency update, nerfing the fast response granted by the slow start
algorithm.

Fixes: 60548c554be2 ("drm/i915: Interactive RPS mode")
Testcase: igt/pm_rps/mix-max-config-loaded
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2531eb75bdce..f90a3c7f1c40 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6371,7 +6371,6 @@ static void gen6_set_rps_thresholds(struct drm_i915_private *dev_priv, u8 val)
 		new_power = HIGH_POWER;
 	rps_set_power(dev_priv, new_power);
 	mutex_unlock(&rps->power.mutex);
-	rps->last_adj = 0;
 }
 
 void intel_rps_mark_interactive(struct drm_i915_private *i915, bool interactive)
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-08-02  9:19 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
2018-08-01 20:28   ` Chris Wilson
2018-08-02  6:05   ` [PATCH] " Chris Wilson
2018-08-01 18:09 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj Patchwork
2018-08-01 19:48 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-02  6:37 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2) Patchwork
2018-08-02  7:27 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-08-02  8:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-02  9:19 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.