* [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj
@ 2018-08-01 17:04 Chris Wilson
2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Chris Wilson @ 2018-08-01 17:04 UTC (permalink / raw)
To: intel-gfx
We used to reset last_adj to 0 on crossing a power domain boundary, to
slow down our rate of change. However, commit 60548c554be2 ("drm/i915:
Interactive RPS mode") accidentally caused it to be reset on every
frequency update, nerfing the fast response granted by the slow start
algorithm.
Fixes: 60548c554be2 ("drm/i915: Interactive RPS mode")
Testcase: igt/pm_rps/mix-max-config-loaded
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2531eb75bdce..f90a3c7f1c40 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6371,7 +6371,6 @@ static void gen6_set_rps_thresholds(struct drm_i915_private *dev_priv, u8 val)
new_power = HIGH_POWER;
rps_set_power(dev_priv, new_power);
mutex_unlock(&rps->power.mutex);
- rps->last_adj = 0;
}
void intel_rps_mark_interactive(struct drm_i915_private *i915, bool interactive)
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] drm/i915: Dampen RPS slow start
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
@ 2018-08-01 17:04 ` Chris Wilson
2018-08-01 20:28 ` Chris Wilson
2018-08-02 6:05 ` [PATCH] " Chris Wilson
2018-08-01 18:09 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj Patchwork
` (5 subsequent siblings)
6 siblings, 2 replies; 10+ messages in thread
From: Chris Wilson @ 2018-08-01 17:04 UTC (permalink / raw)
To: intel-gfx; +Cc: Mika Kuoppala
Currently, we note congestion for the slow start ramping up of RPS only
when we overshoot the target workload and have to reverse direction for
our reclocking. That is, if we have a period where the current GPU
frequency is enough to sustain the workload within our target
utilisation, we should not trigger any RPS EI interrupts, and then may
continue again with the previous last_adj after multiple periods causing
us to dramatically overreact. To prevent us not noticing a period where
the system is behaving correctly, we can schedule an extra interrupt
that will not be associated with either an up or down event causing to
reset last_adj back to zero, cancelling the slow start due to the
congestion.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 13 +++++++++----
drivers/gpu/drm/i915/intel_pm.c | 15 +++++++++++----
2 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 90628a47ae17..e2ee1e13cec7 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1297,6 +1297,7 @@ static void gen6_pm_rps_work(struct work_struct *work)
goto out;
mutex_lock(&dev_priv->pcu_lock);
+ dev_priv->pm_rps_events &= ~GEN6_PM_RP_DOWN_EI_EXPIRED;
pm_iir |= vlv_wa_c0_ei(dev_priv, pm_iir);
@@ -1310,10 +1311,12 @@ static void gen6_pm_rps_work(struct work_struct *work)
new_delay = rps->boost_freq;
adj = 0;
} else if (pm_iir & GEN6_PM_RP_UP_THRESHOLD) {
- if (adj > 0)
+ if (adj > 0) {
+ dev_priv->pm_rps_events |= GEN6_PM_RP_DOWN_EI_EXPIRED;
adj *= 2;
- else /* CHV needs even encode values */
+ } else { /* CHV needs even encode values */
adj = IS_CHERRYVIEW(dev_priv) ? 2 : 1;
+ }
if (new_delay >= rps->max_freq_softlimit)
adj = 0;
@@ -1326,10 +1329,12 @@ static void gen6_pm_rps_work(struct work_struct *work)
new_delay = rps->min_freq_softlimit;
adj = 0;
} else if (pm_iir & GEN6_PM_RP_DOWN_THRESHOLD) {
- if (adj < 0)
+ if (adj < 0) {
+ dev_priv->pm_rps_events |= GEN6_PM_RP_DOWN_EI_EXPIRED;
adj *= 2;
- else /* CHV needs even encode values */
+ } else { /* CHV needs even encode values */
adj = IS_CHERRYVIEW(dev_priv) ? -2 : -1;
+ }
if (new_delay <= rps->min_freq_softlimit)
adj = 0;
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index f90a3c7f1c40..321a0acd274a 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6397,10 +6397,17 @@ static u32 gen6_rps_pm_mask(struct drm_i915_private *dev_priv, u8 val)
u32 mask = 0;
/* We use UP_EI_EXPIRED interupts for both up/down in manual mode */
- if (val > rps->min_freq_softlimit)
- mask |= GEN6_PM_RP_UP_EI_EXPIRED | GEN6_PM_RP_DOWN_THRESHOLD | GEN6_PM_RP_DOWN_TIMEOUT;
- if (val < rps->max_freq_softlimit)
- mask |= GEN6_PM_RP_UP_EI_EXPIRED | GEN6_PM_RP_UP_THRESHOLD;
+ if (val > rps->min_freq_softlimit) {
+ mask |= (GEN6_PM_RP_UP_EI_EXPIRED |
+ GEN6_PM_RP_DOWN_EI_EXPIRED |
+ GEN6_PM_RP_DOWN_THRESHOLD |
+ GEN6_PM_RP_DOWN_TIMEOUT);
+ }
+ if (val < rps->max_freq_softlimit) {
+ mask |= (GEN6_PM_RP_UP_EI_EXPIRED |
+ GEN6_PM_RP_DOWN_EI_EXPIRED |
+ GEN6_PM_RP_UP_THRESHOLD);
+ }
mask &= dev_priv->pm_rps_events;
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
@ 2018-08-01 18:09 ` Patchwork
2018-08-01 19:48 ` ✓ Fi.CI.IGT: " Patchwork
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-08-01 18:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj
URL : https://patchwork.freedesktop.org/series/47554/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605 -> Patchwork_9835 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47554/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9835 that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@drv_selftest@live_workarounds:
{fi-bdw-samus}: DMESG-FAIL (fdo#107292) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
== Participating hosts (50 -> 44) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4605 -> Patchwork_9835
CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9835: 140a049019abb2f9d885440a23f68a1a6aa86988 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
140a049019ab drm/i915: Dampen RPS slow start
8661d09c44ff drm/i915: Drop stray clearing of rps->last_adj
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9835/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
2018-08-01 18:09 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj Patchwork
@ 2018-08-01 19:48 ` Patchwork
2018-08-02 6:37 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2) Patchwork
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-08-01 19:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj
URL : https://patchwork.freedesktop.org/series/47554/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605_full -> Patchwork_9835_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_9835_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
shard-kbl: PASS -> DMESG-FAIL (fdo#106560, fdo#106947)
igt@gem_eio@in-flight-10ms:
shard-snb: PASS -> FAIL (fdo#107404)
igt@gem_userptr_blits@create-destroy-sync:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_flip_tiling@flip-yf-tiled:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
==== Possible fixes ====
igt@pm_rps@min-max-config-loaded:
shard-apl: FAIL (fdo#102250) -> PASS
shard-glk: FAIL -> PASS
fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107404 https://bugs.freedesktop.org/show_bug.cgi?id=107404
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4605 -> Patchwork_9835
CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9835: 140a049019abb2f9d885440a23f68a1a6aa86988 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9835/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] drm/i915: Dampen RPS slow start
2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
@ 2018-08-01 20:28 ` Chris Wilson
2018-08-02 6:05 ` [PATCH] " Chris Wilson
1 sibling, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-08-01 20:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Mika Kuoppala
Quoting Chris Wilson (2018-08-01 18:04:19)
> Currently, we note congestion for the slow start ramping up of RPS only
> when we overshoot the target workload and have to reverse direction for
> our reclocking. That is, if we have a period where the current GPU
> frequency is enough to sustain the workload within our target
> utilisation, we should not trigger any RPS EI interrupts, and then may
> continue again with the previous last_adj after multiple periods causing
> us to dramatically overreact. To prevent us not noticing a period where
> the system is behaving correctly, we can schedule an extra interrupt
> that will not be associated with either an up or down event causing to
> reset last_adj back to zero, cancelling the slow start due to the
> congestion.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 13 +++++++++----
> drivers/gpu/drm/i915/intel_pm.c | 15 +++++++++++----
> 2 files changed, 20 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 90628a47ae17..e2ee1e13cec7 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1297,6 +1297,7 @@ static void gen6_pm_rps_work(struct work_struct *work)
> goto out;
>
> mutex_lock(&dev_priv->pcu_lock);
> + dev_priv->pm_rps_events &= ~GEN6_PM_RP_DOWN_EI_EXPIRED;
>
> pm_iir |= vlv_wa_c0_ei(dev_priv, pm_iir);
>
> @@ -1310,10 +1311,12 @@ static void gen6_pm_rps_work(struct work_struct *work)
> new_delay = rps->boost_freq;
> adj = 0;
> } else if (pm_iir & GEN6_PM_RP_UP_THRESHOLD) {
> - if (adj > 0)
> + if (adj > 0) {
> + dev_priv->pm_rps_events |= GEN6_PM_RP_DOWN_EI_EXPIRED;
> adj *= 2;
The original plan was to use UP/DOWN EI as the danger is that the two
evaluation intervals are not aligned and so not we may falsely detect
congestion in the middle of the ramp. The reason I didn't was we do use
UP_EI_EXPIRED for the manual calcs for vlv.
Hmm, still it would be better not to mix the wrong EI.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] drm/i915: Dampen RPS slow start
2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
2018-08-01 20:28 ` Chris Wilson
@ 2018-08-02 6:05 ` Chris Wilson
1 sibling, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2018-08-02 6:05 UTC (permalink / raw)
To: intel-gfx; +Cc: Mika Kuoppala
Currently, we note congestion for the slow start ramping up of RPS only
when we overshoot the target workload and have to reverse direction for
our reclocking. That is, if we have a period where the current GPU
frequency is enough to sustain the workload within our target
utilisation, we should not trigger any RPS EI interrupts, and then may
continue again with the previous last_adj after multiple periods causing
us to dramatically overreact. To prevent us not noticing a period where
the system is behaving correctly, we can schedule an extra interrupt
that will not be associated with either an up or down event causing to
reset last_adj back to zero, cancelling the slow start due to the
congestion.
v2: Separate up/down EI
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 26 ++++++++++++++++++++------
drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++++----
2 files changed, 30 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 90628a47ae17..272d8a3421aa 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1298,7 +1298,13 @@ static void gen6_pm_rps_work(struct work_struct *work)
mutex_lock(&dev_priv->pcu_lock);
- pm_iir |= vlv_wa_c0_ei(dev_priv, pm_iir);
+ dev_priv->pm_rps_events &=
+ ~(GEN6_PM_RP_DOWN_EI_EXPIRED | GEN6_PM_RP_UP_EI_EXPIRED);
+
+ if (IS_VALLEYVIEW(dev_priv)) {
+ dev_priv->pm_rps_events |= GEN6_PM_RP_UP_EI_EXPIRED;
+ pm_iir |= vlv_wa_c0_ei(dev_priv, pm_iir);
+ }
adj = rps->last_adj;
new_delay = rps->cur_freq;
@@ -1310,10 +1316,12 @@ static void gen6_pm_rps_work(struct work_struct *work)
new_delay = rps->boost_freq;
adj = 0;
} else if (pm_iir & GEN6_PM_RP_UP_THRESHOLD) {
- if (adj > 0)
+ if (adj > 0) {
+ dev_priv->pm_rps_events |= GEN6_PM_RP_UP_EI_EXPIRED;
adj *= 2;
- else /* CHV needs even encode values */
+ } else { /* CHV needs even encode values */
adj = IS_CHERRYVIEW(dev_priv) ? 2 : 1;
+ }
if (new_delay >= rps->max_freq_softlimit)
adj = 0;
@@ -1326,15 +1334,21 @@ static void gen6_pm_rps_work(struct work_struct *work)
new_delay = rps->min_freq_softlimit;
adj = 0;
} else if (pm_iir & GEN6_PM_RP_DOWN_THRESHOLD) {
- if (adj < 0)
+ if (adj < 0) {
+ dev_priv->pm_rps_events |= GEN6_PM_RP_DOWN_EI_EXPIRED;
adj *= 2;
- else /* CHV needs even encode values */
+ } else { /* CHV needs even encode values */
adj = IS_CHERRYVIEW(dev_priv) ? -2 : -1;
+ }
if (new_delay <= rps->min_freq_softlimit)
adj = 0;
- } else { /* unknown event */
+ } else if (pm_iir & GEN6_PM_RP_UP_THRESHOLD && adj > 0) {
+ adj = 0;
+ } else if (pm_iir & GEN6_PM_RP_DOWN_THRESHOLD && adj < 0) {
adj = 0;
+ } else {
+ /* unknown event */
}
rps->last_adj = adj;
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index f90a3c7f1c40..d71a498ee3a1 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6397,10 +6397,16 @@ static u32 gen6_rps_pm_mask(struct drm_i915_private *dev_priv, u8 val)
u32 mask = 0;
/* We use UP_EI_EXPIRED interupts for both up/down in manual mode */
- if (val > rps->min_freq_softlimit)
- mask |= GEN6_PM_RP_UP_EI_EXPIRED | GEN6_PM_RP_DOWN_THRESHOLD | GEN6_PM_RP_DOWN_TIMEOUT;
- if (val < rps->max_freq_softlimit)
- mask |= GEN6_PM_RP_UP_EI_EXPIRED | GEN6_PM_RP_UP_THRESHOLD;
+ if (val > rps->min_freq_softlimit) {
+ mask |= (GEN6_PM_RP_UP_EI_EXPIRED |
+ GEN6_PM_RP_DOWN_EI_EXPIRED |
+ GEN6_PM_RP_DOWN_THRESHOLD |
+ GEN6_PM_RP_DOWN_TIMEOUT);
+ }
+ if (val < rps->max_freq_softlimit) {
+ mask |= (GEN6_PM_RP_UP_EI_EXPIRED |
+ GEN6_PM_RP_UP_THRESHOLD);
+ }
mask &= dev_priv->pm_rps_events;
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
` (2 preceding siblings ...)
2018-08-01 19:48 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-08-02 6:37 ` Patchwork
2018-08-02 7:27 ` ✗ Fi.CI.IGT: failure " Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-08-02 6:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
URL : https://patchwork.freedesktop.org/series/47554/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605 -> Patchwork_9838 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47554/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_9838 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_guc:
fi-skl-guc: NOTRUN -> DMESG-WARN (fdo#107258, fdo#107175)
igt@drv_selftest@live_hangcheck:
fi-kbl-7567u: PASS -> DMESG-FAIL (fdo#106947, fdo#106560)
igt@drv_selftest@live_workarounds:
{fi-cfl-8109u}: PASS -> DMESG-FAIL (fdo#107292)
fi-cnl-psr: PASS -> DMESG-FAIL (fdo#107292)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
fi-skl-guc: NOTRUN -> FAIL (fdo#103191)
==== Possible fixes ====
igt@drv_selftest@live_workarounds:
{fi-bdw-samus}: DMESG-FAIL (fdo#107292) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107175 https://bugs.freedesktop.org/show_bug.cgi?id=107175
fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
== Participating hosts (50 -> 45) ==
Additional (1): fi-skl-guc
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4605 -> Patchwork_9838
CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9838: ccc958dd42f806e8a6a4b700ec69a3e4ba12994b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ccc958dd42f8 drm/i915: Dampen RPS slow start
80434eb1d9cf drm/i915: Drop stray clearing of rps->last_adj
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9838/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
` (3 preceding siblings ...)
2018-08-02 6:37 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2) Patchwork
@ 2018-08-02 7:27 ` Patchwork
2018-08-02 8:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-02 9:19 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-08-02 7:27 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
URL : https://patchwork.freedesktop.org/series/47554/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4605_full -> Patchwork_9838_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9838_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9838_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9838_full:
=== Piglit changes ===
==== Possible regressions ====
spec@ext_texture_array@fbo-depth-array stencil-draw:
pig-glk-j5005: NOTRUN -> INCOMPLETE +3
== Known issues ==
Here are the changes found in Patchwork_9838_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_eio@throttle:
shard-kbl: PASS -> INCOMPLETE (fdo#103665) +5
igt@gem_exec_schedule@preempt-queue-contexts-vebox:
shard-apl: PASS -> INCOMPLETE (fdo#103927) +2
igt@gem_userptr_blits@create-destroy-sync:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
==== Possible fixes ====
igt@pm_rps@min-max-config-loaded:
shard-apl: FAIL (fdo#102250) -> PASS
shard-glk: FAIL -> PASS
fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
== Participating hosts (5 -> 6) ==
Additional (1): pig-glk-j5005
== Build changes ==
* Linux: CI_DRM_4605 -> Patchwork_9838
CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9838: ccc958dd42f806e8a6a4b700ec69a3e4ba12994b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9838/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
` (4 preceding siblings ...)
2018-08-02 7:27 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-08-02 8:29 ` Patchwork
2018-08-02 9:19 ` ✓ Fi.CI.IGT: " Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-08-02 8:29 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
URL : https://patchwork.freedesktop.org/series/47554/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605 -> Patchwork_9840 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47554/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_9840 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@debugfs_test@read_all_entries:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107396)
igt@drv_selftest@live_guc:
fi-skl-guc: NOTRUN -> DMESG-WARN (fdo#107258, fdo#107175)
igt@drv_selftest@live_hangcheck:
{fi-icl-u}: NOTRUN -> INCOMPLETE (fdo#107399)
igt@drv_selftest@live_workarounds:
fi-cnl-psr: PASS -> DMESG-FAIL (fdo#107292)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107382) +4
{igt@kms_psr@primary_page_flip}:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107383) +3
==== Possible fixes ====
igt@drv_selftest@live_workarounds:
{fi-bdw-samus}: DMESG-FAIL (fdo#107292) -> PASS
{igt@kms_psr@primary_mmap_gtt}:
fi-cnl-psr: DMESG-WARN (fdo#107372) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107175 https://bugs.freedesktop.org/show_bug.cgi?id=107175
fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107382 https://bugs.freedesktop.org/show_bug.cgi?id=107382
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
fdo#107396 https://bugs.freedesktop.org/show_bug.cgi?id=107396
fdo#107399 https://bugs.freedesktop.org/show_bug.cgi?id=107399
== Participating hosts (50 -> 46) ==
Additional (2): fi-skl-guc fi-icl-u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4605 -> Patchwork_9840
CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9840: 698d0f043aef58678566c46bfc1a2238e5a5ff30 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
698d0f043aef drm/i915: Dampen RPS slow start
c7ae4f0e91be drm/i915: Drop stray clearing of rps->last_adj
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9840/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
` (5 preceding siblings ...)
2018-08-02 8:29 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-08-02 9:19 ` Patchwork
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2018-08-02 9:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2)
URL : https://patchwork.freedesktop.org/series/47554/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605_full -> Patchwork_9840_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_9840_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-apl: PASS -> INCOMPLETE (fdo#106886, fdo#103927)
igt@gem_sync@basic-store-all:
shard-apl: PASS -> INCOMPLETE (fdo#103927) +4
igt@gem_userptr_blits@create-destroy-sync:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_vblank@pipe-a-wait-forked-busy:
shard-kbl: PASS -> INCOMPLETE (fdo#103665) +4
==== Possible fixes ====
igt@pm_rps@min-max-config-loaded:
shard-apl: FAIL (fdo#102250) -> PASS
shard-glk: FAIL -> PASS
fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4605 -> Patchwork_9840
CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9840: 698d0f043aef58678566c46bfc1a2238e5a5ff30 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9840/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-08-02 9:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 17:04 [PATCH 1/2] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
2018-08-01 17:04 ` [PATCH 2/2] drm/i915: Dampen RPS slow start Chris Wilson
2018-08-01 20:28 ` Chris Wilson
2018-08-02 6:05 ` [PATCH] " Chris Wilson
2018-08-01 18:09 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj Patchwork
2018-08-01 19:48 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-02 6:37 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Drop stray clearing of rps->last_adj (rev2) Patchwork
2018-08-02 7:27 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-08-02 8:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-02 9:19 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.