All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail
@ 2018-07-02 11:16 Mahesh Kumar
  2018-07-02 11:27 ` Maarten Lankhorst
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Mahesh Kumar @ 2018-07-02 11:16 UTC (permalink / raw)
  To: intel-gfx

Now crc-core framework verifies the source string passed by the user.
So setting bad-source will fail. Expect file write to fail in bad-source
subtest of kms_pipe_crc_basic.

Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
---
 tests/kms_pipe_crc_basic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 235fdc38..2d4dfee8 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -48,8 +48,7 @@ static struct {
 
 static void test_bad_source(data_t *data)
 {
-	igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo"));
-	igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1);
+	igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo"));
 }
 
 #define N_CRCS	3
-- 
2.16.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-08-02 13:53 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-02 11:16 [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail Mahesh Kumar
2018-07-02 11:27 ` Maarten Lankhorst
2018-07-03  6:04   ` Kumar, Mahesh
2018-08-02 10:42   ` Maarten Lankhorst
2018-08-02 10:43     ` Maarten Lankhorst
2018-08-02 11:05       ` Kumar, Mahesh
2018-08-02 13:03     ` Chris Wilson
2018-08-02 13:53       ` Maarten Lankhorst
2018-07-02 15:43 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-08-02 11:41 ` ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) Patchwork
2018-08-02 13:41 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.