* [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail @ 2018-07-02 11:16 Mahesh Kumar 2018-07-02 11:27 ` Maarten Lankhorst ` (3 more replies) 0 siblings, 4 replies; 11+ messages in thread From: Mahesh Kumar @ 2018-07-02 11:16 UTC (permalink / raw) To: intel-gfx Now crc-core framework verifies the source string passed by the user. So setting bad-source will fail. Expect file write to fail in bad-source subtest of kms_pipe_crc_basic. Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> --- tests/kms_pipe_crc_basic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index 235fdc38..2d4dfee8 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -48,8 +48,7 @@ static struct { static void test_bad_source(data_t *data) { - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); } #define N_CRCS 3 -- 2.16.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-07-02 11:16 [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail Mahesh Kumar @ 2018-07-02 11:27 ` Maarten Lankhorst 2018-07-03 6:04 ` Kumar, Mahesh 2018-08-02 10:42 ` Maarten Lankhorst 2018-07-02 15:43 ` ✗ Fi.CI.BAT: failure for " Patchwork ` (2 subsequent siblings) 3 siblings, 2 replies; 11+ messages in thread From: Maarten Lankhorst @ 2018-07-02 11:27 UTC (permalink / raw) To: Mahesh Kumar, intel-gfx Op 02-07-18 om 13:16 schreef Mahesh Kumar: > Now crc-core framework verifies the source string passed by the user. > So setting bad-source will fail. Expect file write to fail in bad-source > subtest of kms_pipe_crc_basic. > > Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> > --- > tests/kms_pipe_crc_basic.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index 235fdc38..2d4dfee8 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -48,8 +48,7 @@ static struct { > > static void test_bad_source(data_t *data) > { > - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); > + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > } > > #define N_CRCS 3 New behavior makes more sense. Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Do you have igt commit rights? _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-07-02 11:27 ` Maarten Lankhorst @ 2018-07-03 6:04 ` Kumar, Mahesh 2018-08-02 10:42 ` Maarten Lankhorst 1 sibling, 0 replies; 11+ messages in thread From: Kumar, Mahesh @ 2018-07-03 6:04 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx Hi, On 7/2/2018 4:57 PM, Maarten Lankhorst wrote: > Op 02-07-18 om 13:16 schreef Mahesh Kumar: >> Now crc-core framework verifies the source string passed by the user. >> So setting bad-source will fail. Expect file write to fail in bad-source >> subtest of kms_pipe_crc_basic. >> >> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> >> --- >> tests/kms_pipe_crc_basic.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >> index 235fdc38..2d4dfee8 100644 >> --- a/tests/kms_pipe_crc_basic.c >> +++ b/tests/kms_pipe_crc_basic.c >> @@ -48,8 +48,7 @@ static struct { >> >> static void test_bad_source(data_t *data) >> { >> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >> + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >> } >> >> #define N_CRCS 3 > New behavior makes more sense. > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Do you have igt commit rights? thanks for review. I don't have commit rights -Mahesh _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-07-02 11:27 ` Maarten Lankhorst 2018-07-03 6:04 ` Kumar, Mahesh @ 2018-08-02 10:42 ` Maarten Lankhorst 2018-08-02 10:43 ` Maarten Lankhorst 2018-08-02 13:03 ` Chris Wilson 1 sibling, 2 replies; 11+ messages in thread From: Maarten Lankhorst @ 2018-08-02 10:42 UTC (permalink / raw) To: Mahesh Kumar, intel-gfx Op 02-07-18 om 13:27 schreef Maarten Lankhorst: > Op 02-07-18 om 13:16 schreef Mahesh Kumar: >> Now crc-core framework verifies the source string passed by the user. >> So setting bad-source will fail. Expect file write to fail in bad-source >> subtest of kms_pipe_crc_basic. >> >> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> >> --- >> tests/kms_pipe_crc_basic.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >> index 235fdc38..2d4dfee8 100644 >> --- a/tests/kms_pipe_crc_basic.c >> +++ b/tests/kms_pipe_crc_basic.c >> @@ -48,8 +48,7 @@ static struct { >> >> static void test_bad_source(data_t *data) >> { >> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >> + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >> } >> >> #define N_CRCS 3 > New behavior makes more sense. > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Do you have igt commit rights? > Any objections if we change this to allow both behaviors? diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index 235fdc386ba2..91909fa42f2f 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -48,8 +48,11 @@ static struct { static void test_bad_source(data_t *data) { - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); + errno = 0; + if (igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")) + igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); + else + igt_assert_eq(errno, EINVAL); } #define N_CRCS 3 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-08-02 10:42 ` Maarten Lankhorst @ 2018-08-02 10:43 ` Maarten Lankhorst 2018-08-02 11:05 ` Kumar, Mahesh 2018-08-02 13:03 ` Chris Wilson 1 sibling, 1 reply; 11+ messages in thread From: Maarten Lankhorst @ 2018-08-02 10:43 UTC (permalink / raw) To: Mahesh Kumar, intel-gfx Op 02-08-18 om 12:42 schreef Maarten Lankhorst: > Op 02-07-18 om 13:27 schreef Maarten Lankhorst: >> Op 02-07-18 om 13:16 schreef Mahesh Kumar: >>> Now crc-core framework verifies the source string passed by the user. >>> So setting bad-source will fail. Expect file write to fail in bad-source >>> subtest of kms_pipe_crc_basic. >>> >>> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> >>> --- >>> tests/kms_pipe_crc_basic.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >>> index 235fdc38..2d4dfee8 100644 >>> --- a/tests/kms_pipe_crc_basic.c >>> +++ b/tests/kms_pipe_crc_basic.c >>> @@ -48,8 +48,7 @@ static struct { >>> >>> static void test_bad_source(data_t *data) >>> { >>> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >>> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >>> + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >>> } >>> >>> #define N_CRCS 3 >> New behavior makes more sense. >> >> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> >> Do you have igt commit rights? >> > Any objections if we change this to allow both behaviors? > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index 235fdc386ba2..91909fa42f2f 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -48,8 +48,11 @@ static struct { > > static void test_bad_source(data_t *data) > { > - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); > + errno = 0; > + if (igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")) > + igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); > + else > + igt_assert_eq(errno, EINVAL); > } > > #define N_CRCS 3 > Hm without the else, errno should be EINVAL in any case.. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-08-02 10:43 ` Maarten Lankhorst @ 2018-08-02 11:05 ` Kumar, Mahesh 0 siblings, 0 replies; 11+ messages in thread From: Kumar, Mahesh @ 2018-08-02 11:05 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2164 bytes --] Hi, On 8/2/2018 4:13 PM, Maarten Lankhorst wrote: > Op 02-08-18 om 12:42 schreef Maarten Lankhorst: >> Op 02-07-18 om 13:27 schreef Maarten Lankhorst: >>> Op 02-07-18 om 13:16 schreef Mahesh Kumar: >>>> Now crc-core framework verifies the source string passed by the user. >>>> So setting bad-source will fail. Expect file write to fail in bad-source >>>> subtest of kms_pipe_crc_basic. >>>> >>>> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> >>>> --- >>>> tests/kms_pipe_crc_basic.c | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >>>> index 235fdc38..2d4dfee8 100644 >>>> --- a/tests/kms_pipe_crc_basic.c >>>> +++ b/tests/kms_pipe_crc_basic.c >>>> @@ -48,8 +48,7 @@ static struct { >>>> >>>> static void test_bad_source(data_t *data) >>>> { >>>> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >>>> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >>>> + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >>>> } >>>> >>>> #define N_CRCS 3 >>> New behavior makes more sense. >>> >>> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >>> >>> Do you have igt commit rights? >>> >> Any objections if we change this to allow both behaviors? >> >> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >> index 235fdc386ba2..91909fa42f2f 100644 >> --- a/tests/kms_pipe_crc_basic.c >> +++ b/tests/kms_pipe_crc_basic.c >> @@ -48,8 +48,11 @@ static struct { >> >> static void test_bad_source(data_t *data) >> { >> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >> + errno = 0; >> + if (igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")) >> + igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >> + else >> + igt_assert_eq(errno, EINVAL); >> } >> >> #define N_CRCS 3 >> > Hm without the else, errno should be EINVAL in any case.. agree, with this change Reviewed-by: Mahesh Kumar <mahesh1.kumar@intel.com> [-- Attachment #1.2: Type: text/html, Size: 3113 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-08-02 10:42 ` Maarten Lankhorst 2018-08-02 10:43 ` Maarten Lankhorst @ 2018-08-02 13:03 ` Chris Wilson 2018-08-02 13:53 ` Maarten Lankhorst 1 sibling, 1 reply; 11+ messages in thread From: Chris Wilson @ 2018-08-02 13:03 UTC (permalink / raw) To: Maarten Lankhorst, Mahesh Kumar, intel-gfx Quoting Maarten Lankhorst (2018-08-02 11:42:32) > Op 02-07-18 om 13:27 schreef Maarten Lankhorst: > > Op 02-07-18 om 13:16 schreef Mahesh Kumar: > >> Now crc-core framework verifies the source string passed by the user. > >> So setting bad-source will fail. Expect file write to fail in bad-source > >> subtest of kms_pipe_crc_basic. > >> > >> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> > >> --- > >> tests/kms_pipe_crc_basic.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > >> index 235fdc38..2d4dfee8 100644 > >> --- a/tests/kms_pipe_crc_basic.c > >> +++ b/tests/kms_pipe_crc_basic.c > >> @@ -48,8 +48,7 @@ static struct { > >> > >> static void test_bad_source(data_t *data) > >> { > >> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > >> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); > >> + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > >> } > >> > >> #define N_CRCS 3 > > New behavior makes more sense. > > > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > Do you have igt commit rights? > > > Any objections if we change this to allow both behaviors? > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index 235fdc386ba2..91909fa42f2f 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -48,8 +48,11 @@ static struct { > > static void test_bad_source(data_t *data) > { > - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); > - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); > + errno = 0; > + if (igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")) > + igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); > + else > + igt_assert_eq(errno, EINVAL); Current errno is EIO https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4585/fi-bsw-n3050/igt@kms_pipe_crc_basic@bad-source.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4585/fi-kbl-x1275/igt@kms_pipe_crc_basic@bad-source.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4585/fi-kbl-guc/igt@kms_pipe_crc_basic@bad-source.html -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-08-02 13:03 ` Chris Wilson @ 2018-08-02 13:53 ` Maarten Lankhorst 0 siblings, 0 replies; 11+ messages in thread From: Maarten Lankhorst @ 2018-08-02 13:53 UTC (permalink / raw) To: Chris Wilson, Mahesh Kumar, intel-gfx Op 02-08-18 om 15:03 schreef Chris Wilson: > Quoting Maarten Lankhorst (2018-08-02 11:42:32) >> Op 02-07-18 om 13:27 schreef Maarten Lankhorst: >>> Op 02-07-18 om 13:16 schreef Mahesh Kumar: >>>> Now crc-core framework verifies the source string passed by the user. >>>> So setting bad-source will fail. Expect file write to fail in bad-source >>>> subtest of kms_pipe_crc_basic. >>>> >>>> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com> >>>> --- >>>> tests/kms_pipe_crc_basic.c | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >>>> index 235fdc38..2d4dfee8 100644 >>>> --- a/tests/kms_pipe_crc_basic.c >>>> +++ b/tests/kms_pipe_crc_basic.c >>>> @@ -48,8 +48,7 @@ static struct { >>>> >>>> static void test_bad_source(data_t *data) >>>> { >>>> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >>>> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >>>> + igt_assert(!igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >>>> } >>>> >>>> #define N_CRCS 3 >>> New behavior makes more sense. >>> >>> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >>> >>> Do you have igt commit rights? >>> >> Any objections if we change this to allow both behaviors? >> >> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c >> index 235fdc386ba2..91909fa42f2f 100644 >> --- a/tests/kms_pipe_crc_basic.c >> +++ b/tests/kms_pipe_crc_basic.c >> @@ -48,8 +48,11 @@ static struct { >> >> static void test_bad_source(data_t *data) >> { >> - igt_assert(igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")); >> - igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >> + errno = 0; >> + if (igt_sysfs_set(data->debugfs, "crtc-0/crc/control", "foo")) >> + igt_assert(openat(data->debugfs, "crtc-0/crc/data", O_WRONLY) == -1); >> + else >> + igt_assert_eq(errno, EINVAL); > Current errno is EIO > https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4585/fi-bsw-n3050/igt@kms_pipe_crc_basic@bad-source.html > https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4585/fi-kbl-x1275/igt@kms_pipe_crc_basic@bad-source.html > https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4585/fi-kbl-guc/igt@kms_pipe_crc_basic@bad-source.html > -Chris Ugh, my bad, messed up. https://patchwork.freedesktop.org/patch/242410/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.BAT: failure for tests/kms_pipe_crc_basic: expect setting bad source to fail 2018-07-02 11:16 [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail Mahesh Kumar 2018-07-02 11:27 ` Maarten Lankhorst @ 2018-07-02 15:43 ` Patchwork 2018-08-02 11:41 ` ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) Patchwork 2018-08-02 13:41 ` ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-07-02 15:43 UTC (permalink / raw) To: Mahesh Kumar; +Cc: intel-gfx == Series Details == Series: tests/kms_pipe_crc_basic: expect setting bad source to fail URL : https://patchwork.freedesktop.org/series/45768/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4404 -> IGTPW_1521 = == Summary - FAILURE == Serious unknown changes coming with IGTPW_1521 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_1521, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/45768/revisions/1/mbox/ == Possible new issues == Here are the unknown changes that may have been introduced in IGTPW_1521: === IGT changes === ==== Possible regressions ==== igt@kms_pipe_crc_basic@bad-source: {fi-cfl-8109u}: PASS -> FAIL fi-pnv-d510: PASS -> FAIL fi-skl-6770hq: PASS -> FAIL fi-bdw-5557u: PASS -> FAIL fi-bwr-2160: PASS -> FAIL fi-snb-2520m: PASS -> FAIL fi-elk-e7500: PASS -> FAIL fi-hsw-4770r: PASS -> FAIL fi-glk-j4005: PASS -> FAIL fi-cfl-8700k: PASS -> FAIL fi-hsw-peppy: PASS -> FAIL fi-bdw-gvtdvm: PASS -> FAIL fi-ilk-650: PASS -> FAIL fi-kbl-7567u: PASS -> FAIL fi-skl-guc: PASS -> FAIL fi-whl-u: PASS -> FAIL fi-cfl-guc: PASS -> FAIL fi-bxt-j4205: PASS -> FAIL fi-skl-6700hq: PASS -> FAIL fi-ivb-3520m: PASS -> FAIL fi-skl-gvtdvm: PASS -> FAIL fi-gdg-551: PASS -> FAIL fi-kbl-7500u: PASS -> FAIL {fi-kbl-x1275}: PASS -> FAIL fi-kbl-guc: PASS -> FAIL fi-skl-6600u: PASS -> FAIL fi-glk-dsi: PASS -> FAIL fi-blb-e6850: PASS -> FAIL fi-ivb-3770: PASS -> FAIL fi-skl-6700k2: PASS -> FAIL fi-bsw-n3050: PASS -> FAIL fi-snb-2600: PASS -> FAIL fi-hsw-4770: PASS -> FAIL fi-kbl-7560u: PASS -> FAIL fi-bxt-dsi: PASS -> FAIL fi-byt-n2820: PASS -> FAIL fi-skl-6260u: PASS -> FAIL fi-kbl-r: PASS -> FAIL fi-byt-j1900: PASS -> FAIL fi-cfl-s3: PASS -> FAIL ==== Warnings ==== igt@kms_pipe_crc_basic@read-crc-pipe-b: {fi-cfl-8109u}: PASS -> SKIP +36 {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). == Participating hosts (45 -> 40) == Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u == Build changes == * IGT: IGT_4531 -> IGTPW_1521 CI_DRM_4404: ceaab659002c938f1788b7458d5081fadc3c1ddc @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_1521: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1521/ IGT_4531: a14bc8b4d69eaca189665de505e6b10cbfbb7730 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1521/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) 2018-07-02 11:16 [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail Mahesh Kumar 2018-07-02 11:27 ` Maarten Lankhorst 2018-07-02 15:43 ` ✗ Fi.CI.BAT: failure for " Patchwork @ 2018-08-02 11:41 ` Patchwork 2018-08-02 13:41 ` ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-08-02 11:41 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: intel-gfx == Series Details == Series: tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) URL : https://patchwork.freedesktop.org/series/45768/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4605 -> IGTPW_1677 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/45768/revisions/2/mbox/ == Known issues == Here are the changes found in IGTPW_1677 that come from known issues: === IGT changes === ==== Issues hit ==== igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713) ==== Possible fixes ==== igt@prime_vgem@basic-fence-flip: fi-ilk-650: FAIL (fdo#104008) -> PASS fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008 == Participating hosts (50 -> 43) == Additional (1): fi-skl-guc Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper == Build changes == * IGT: IGT_4582 -> IGTPW_1677 CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_1677: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1677/ IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1677/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.IGT: success for tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) 2018-07-02 11:16 [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail Mahesh Kumar ` (2 preceding siblings ...) 2018-08-02 11:41 ` ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) Patchwork @ 2018-08-02 13:41 ` Patchwork 3 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2018-08-02 13:41 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: intel-gfx == Series Details == Series: tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) URL : https://patchwork.freedesktop.org/series/45768/ State : success == Summary == = CI Bug Log - changes from IGT_4582_full -> IGTPW_1677_full = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/45768/revisions/2/mbox/ == Known issues == Here are the changes found in IGTPW_1677_full that come from known issues: === IGT changes === ==== Issues hit ==== igt@drv_suspend@shrink: shard-snb: PASS -> INCOMPLETE (fdo#106886, fdo#105411) igt@gem_sync@basic-store-each: shard-snb: PASS -> INCOMPLETE (fdo#105411) igt@kms_cursor_crc@cursor-256x256-suspend: shard-glk: PASS -> FAIL (fdo#103375) igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic: shard-glk: PASS -> FAIL (fdo#106765) igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: NOTRUN -> FAIL (fdo#106509) igt@kms_rotation_crc@sprite-rotation-180: shard-hsw: PASS -> FAIL (fdo#103925) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) shard-kbl: PASS -> FAIL (fdo#99912) igt@perf@polling: shard-hsw: PASS -> FAIL (fdo#102252) ==== Possible fixes ==== igt@gem_userptr_blits@create-destroy-sync: shard-snb: INCOMPLETE (fdo#105411) -> PASS igt@kms_available_modes_crc@available_mode_test_crc: shard-snb: FAIL (fdo#106641) -> PASS igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: shard-kbl: INCOMPLETE (fdo#103665) -> PASS igt@kms_rotation_crc@sprite-rotation-180: shard-snb: FAIL (fdo#103925) -> PASS igt@pm_rpm@drm-resources-equal: shard-kbl: FAIL (fdo#106539) -> PASS shard-hsw: FAIL (fdo#106539) -> PASS shard-glk: FAIL (fdo#106539) -> PASS shard-apl: FAIL (fdo#106539) -> PASS igt@testdisplay: shard-glk: INCOMPLETE (fdo#103359, k.org#198133, fdo#107093) -> PASS fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252 fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359 fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#106539 https://bugs.freedesktop.org/show_bug.cgi?id=106539 fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641 fdo#106765 https://bugs.freedesktop.org/show_bug.cgi?id=106765 fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886 fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * IGT: IGT_4582 -> IGTPW_1677 * Linux: CI_DRM_4600 -> CI_DRM_4605 CI_DRM_4600: 308427119c70d0aaa90433b05969a0317165b122 @ git://anongit.freedesktop.org/gfx-ci/linux CI_DRM_4605: 50098198da758bdd54245d511f4f97236c296c72 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_1677: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1677/ IGT_4582: 263ca16e4d8909f475d32a28fc0e5972bac214fb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1677/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-08-02 13:53 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-07-02 11:16 [PATCH i-g-t] tests/kms_pipe_crc_basic: expect setting bad source to fail Mahesh Kumar 2018-07-02 11:27 ` Maarten Lankhorst 2018-07-03 6:04 ` Kumar, Mahesh 2018-08-02 10:42 ` Maarten Lankhorst 2018-08-02 10:43 ` Maarten Lankhorst 2018-08-02 11:05 ` Kumar, Mahesh 2018-08-02 13:03 ` Chris Wilson 2018-08-02 13:53 ` Maarten Lankhorst 2018-07-02 15:43 ` ✗ Fi.CI.BAT: failure for " Patchwork 2018-08-02 11:41 ` ✓ Fi.CI.BAT: success for tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2) Patchwork 2018-08-02 13:41 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.