* [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
@ 2018-08-15 9:25 ` Chris Wilson
0 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2018-08-15 9:25 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/pm_rpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 65489bcdb..a4f9f783e 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
teardown_environment();
igt_subtest("module-reload") {
+ teardown_environment();
+
igt_debug("Reload w/o display\n");
igt_i915_driver_unload();
igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
@ 2018-08-15 9:25 ` Chris Wilson
0 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2018-08-15 9:25 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/pm_rpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 65489bcdb..a4f9f783e 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
teardown_environment();
igt_subtest("module-reload") {
+ teardown_environment();
+
igt_debug("Reload w/o display\n");
igt_i915_driver_unload();
igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Close local fd before trying to unload module
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
(?)
@ 2018-08-15 10:48 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-08-15 10:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/pm_rpm: Close local fd before trying to unload module
URL : https://patchwork.freedesktop.org/series/48235/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4669 -> IGTPW_1715 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48235/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1715 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
{fi-skl-iommu}: PASS -> DMESG-FAIL (fdo#107174, fdo#106560)
igt@drv_selftest@live_workarounds:
{fi-cfl-8109u}: PASS -> DMESG-FAIL (fdo#107292)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107382) +4
{igt@kms_psr@primary_mmap_gtt}:
fi-cnl-psr: PASS -> DMESG-WARN (fdo#107372)
{igt@kms_psr@primary_page_flip}:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107383) +3
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-skl-guc: DMESG-FAIL (fdo#107174) -> PASS
igt@drv_selftest@live_workarounds:
fi-cnl-psr: DMESG-FAIL (fdo#107292) -> PASS
fi-kbl-7560u: DMESG-FAIL (fdo#107292) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107382 https://bugs.freedesktop.org/show_bug.cgi?id=107382
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
== Participating hosts (53 -> 49) ==
Additional (1): fi-icl-u
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4597 -> IGTPW_1715
CI_DRM_4669: aea12ded40860145c23f1c1a28a386fb97ae6e4e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1715: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1715/
IGT_4597: 347a07ba3d7796f7f701baed1599319fe3fc1958 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1715/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
@ 2018-08-15 11:01 ` Imre Deak
-1 siblings, 0 replies; 18+ messages in thread
From: Imre Deak @ 2018-08-15 11:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote:
> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/pm_rpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 65489bcdb..a4f9f783e 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> teardown_environment();
>
> igt_subtest("module-reload") {
> + teardown_environment();
> +
Why isn't the teardown_environment(); under igt_fixture enough?
> igt_debug("Reload w/o display\n");
> igt_i915_driver_unload();
> igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> --
> 2.18.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
@ 2018-08-15 11:01 ` Imre Deak
0 siblings, 0 replies; 18+ messages in thread
From: Imre Deak @ 2018-08-15 11:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote:
> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/pm_rpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 65489bcdb..a4f9f783e 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> teardown_environment();
>
> igt_subtest("module-reload") {
> + teardown_environment();
> +
Why isn't the teardown_environment(); under igt_fixture enough?
> igt_debug("Reload w/o display\n");
> igt_i915_driver_unload();
> igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> --
> 2.18.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
2018-08-15 11:01 ` [Intel-gfx] " Imre Deak
@ 2018-08-15 11:04 ` Chris Wilson
-1 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2018-08-15 11:04 UTC (permalink / raw)
To: Imre Deak; +Cc: igt-dev, intel-gfx
Quoting Imre Deak (2018-08-15 12:01:31)
> On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote:
> > Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/pm_rpm.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index 65489bcdb..a4f9f783e 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> > teardown_environment();
> >
> > igt_subtest("module-reload") {
> > + teardown_environment();
> > +
>
> Why isn't the teardown_environment(); under igt_fixture enough?
Hmm, looks like I thought about it earlier. I guess we leak an fd...
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
@ 2018-08-15 11:04 ` Chris Wilson
0 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2018-08-15 11:04 UTC (permalink / raw)
To: Imre Deak; +Cc: igt-dev, intel-gfx
Quoting Imre Deak (2018-08-15 12:01:31)
> On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote:
> > Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/pm_rpm.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index 65489bcdb..a4f9f783e 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> > teardown_environment();
> >
> > igt_subtest("module-reload") {
> > + teardown_environment();
> > +
>
> Why isn't the teardown_environment(); under igt_fixture enough?
Hmm, looks like I thought about it earlier. I guess we leak an fd...
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2018-08-15 11:08 ` Chris Wilson
2018-08-15 20:58 ` Chris Wilson
-1 siblings, 1 reply; 18+ messages in thread
From: Chris Wilson @ 2018-08-15 11:08 UTC (permalink / raw)
To: igt-dev
Make sure everything we open in setup_environment() is paired to
teardown_environment().
Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/pm_rpm.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 65489bcdb..c0212ed70 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -717,21 +717,23 @@ out:
return wait_for_suspended();
}
-static void restore_environment(void)
+static void teardown_environment(void)
{
+ close(msr_fd);
+ if (has_pc8)
+ close(pc8_status_fd);
+
+ igt_restore_runtime_pm();
+
igt_pm_restore_sata_link_power_management(pm_data);
free(pm_data);
-}
-static void teardown_environment(void)
-{
- restore_environment();
fini_mode_set_data(&ms_data);
+
close(debugfs);
- drmClose(drm_fd);
- close(msr_fd);
- if (has_pc8)
- close(pc8_status_fd);
+ close(drm_fd);
+
+ has_runtime_pm = false;
}
static void basic_subtest(void)
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/pm_rpm: Close local fd before trying to unload module
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
` (3 preceding siblings ...)
(?)
@ 2018-08-15 11:45 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-08-15 11:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/pm_rpm: Close local fd before trying to unload module
URL : https://patchwork.freedesktop.org/series/48235/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4597_full -> IGTPW_1715_full =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48235/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1715_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt:
shard-glk: PASS -> FAIL (fdo#103167)
igt@testdisplay:
shard-glk: PASS -> INCOMPLETE (fdo#107093, k.org#198133, fdo#103359)
==== Possible fixes ====
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_busy@extended-modeset-hang-oldfb-render-e:
shard-snb: INCOMPLETE (fdo#105411) -> SKIP
igt@kms_plane@pixel-format-pipe-a-planes:
shard-snb: FAIL (fdo#107161) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4597 -> IGTPW_1715
* Linux: CI_DRM_4668 -> CI_DRM_4669
CI_DRM_4668: 8bae517a4dd2ab6ba57b880835fd253e169779f2 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4669: aea12ded40860145c23f1c1a28a386fb97ae6e4e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1715: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1715/
IGT_4597: 347a07ba3d7796f7f701baed1599319fe3fc1958 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1715/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Close local fd before trying to unload module (rev2)
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
` (4 preceding siblings ...)
(?)
@ 2018-08-15 16:11 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-08-15 16:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/pm_rpm: Close local fd before trying to unload module (rev2)
URL : https://patchwork.freedesktop.org/series/48235/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4669 -> IGTPW_1717 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48235/revisions/2/mbox/
== Known issues ==
Here are the changes found in IGTPW_1717 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-bxt-dsi: PASS -> DMESG-FAIL (fdo#106560)
igt@drv_selftest@live_workarounds:
{fi-cfl-8109u}: PASS -> DMESG-FAIL (fdo#107292)
igt@kms_chamelium@dp-crc-fast:
fi-kbl-7500u: PASS -> DMESG-FAIL (fdo#103841)
{igt@kms_psr@primary_mmap_gtt}:
fi-cnl-psr: PASS -> DMESG-WARN (fdo#107372)
==== Possible fixes ====
igt@drv_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@drv_selftest@live_hangcheck:
fi-skl-guc: DMESG-FAIL (fdo#107174) -> PASS
igt@drv_selftest@live_workarounds:
fi-cnl-psr: DMESG-FAIL (fdo#107292) -> PASS
fi-kbl-7560u: DMESG-FAIL (fdo#107292) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
== Participating hosts (53 -> 48) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4597 -> IGTPW_1717
CI_DRM_4669: aea12ded40860145c23f1c1a28a386fb97ae6e4e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1717: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1717/
IGT_4597: 347a07ba3d7796f7f701baed1599319fe3fc1958 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1717/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/pm_rpm: Close local fd before trying to unload module (rev2)
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
` (5 preceding siblings ...)
(?)
@ 2018-08-15 20:53 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2018-08-15 20:53 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/pm_rpm: Close local fd before trying to unload module (rev2)
URL : https://patchwork.freedesktop.org/series/48235/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4597_full -> IGTPW_1717_full =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48235/revisions/2/mbox/
== Known issues ==
Here are the changes found in IGTPW_1717_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_vblank@pipe-a-ts-continuation-suspend:
shard-glk: PASS -> FAIL (fdo#103375)
igt@prime_busy@after-bsd1:
shard-snb: SKIP -> INCOMPLETE (fdo#105411)
==== Possible fixes ====
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_busy@extended-modeset-hang-oldfb-render-e:
shard-snb: INCOMPLETE (fdo#105411) -> SKIP
igt@kms_plane@pixel-format-pipe-a-planes:
shard-snb: FAIL (fdo#107161) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4597 -> IGTPW_1717
* Linux: CI_DRM_4668 -> CI_DRM_4669
CI_DRM_4668: 8bae517a4dd2ab6ba57b880835fd253e169779f2 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4669: aea12ded40860145c23f1c1a28a386fb97ae6e4e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1717: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1717/
IGT_4597: 347a07ba3d7796f7f701baed1599319fe3fc1958 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1717/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
2018-08-15 11:08 ` Chris Wilson
@ 2018-08-15 20:58 ` Chris Wilson
0 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2018-08-15 20:58 UTC (permalink / raw)
To: igt-dev
Quoting Chris Wilson (2018-08-15 12:08:25)
> Make sure everything we open in setup_environment() is paired to
> teardown_environment().
Still more:
pm_rpm:1800) DEBUG: Reload w/o display
(pm_rpm:1800) igt_kmod-DEBUG: Could not remove module i915 (Resource temporarily unavailable)
(pm_rpm:1800) igt_kmod-WARNING: Could not unload i915
(pm_rpm:1800) igt_kmod-INFO: Module Used by
(pm_rpm:1800) igt_kmod-INFO: vgem
(pm_rpm:1800) igt_kmod-INFO: snd_hda_codec_hdmi
(pm_rpm:1800) igt_kmod-INFO: x86_pkg_temp_thermal
(pm_rpm:1800) igt_kmod-INFO: coretemp
(pm_rpm:1800) igt_kmod-INFO: i915
(pm_rpm:1800) igt_kmod-INFO: crct10dif_pclmul
(pm_rpm:1800) igt_kmod-INFO: crc32_pclmul
(pm_rpm:1800) igt_kmod-INFO: ghash_clmulni_intel
(pm_rpm:1800) igt_kmod-INFO: snd_hda_codec_realtek
(pm_rpm:1800) igt_kmod-INFO: snd_hda_codec_generic snd_hda_codec_realtek
(pm_rpm:1800) igt_kmod-INFO: r8169
(pm_rpm:1800) igt_kmod-INFO: mii r8169
(pm_rpm:1800) igt_kmod-INFO: snd_hda_codec snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_codec_realtek
(pm_rpm:1800) igt_kmod-INFO: snd_hwdep snd_hda_codec
(pm_rpm:1800) igt_kmod-INFO: snd_hda_core snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_codec,snd_hda_codec_realtek
(pm_rpm:1800) igt_kmod-INFO: mei_me
(pm_rpm:1800) igt_kmod-INFO: snd_pcm snd_hda_codec_hdmi,snd_hda_codec,snd_hda_core
(pm_rpm:1800) igt_kmod-INFO: mei mei_me
(pm_rpm:1800) igt_kmod-INFO: lpc_ich
(pm_rpm:1800) igt_kmod-INFO: prime_numbers i915
(pm_rpm:1800) igt_aux-INFO: COMM PID Type UID GID Size Filename
(pm_rpm:1800) igt_aux-INFO: pm_rpm 1800 character 0 44 0 bytes /dev/dri/card0
Oh, this will be the at_exit_drm_fd. Grr.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
@ 2018-08-17 17:29 ` Antonio Argenziano
-1 siblings, 0 replies; 18+ messages in thread
From: Antonio Argenziano @ 2018-08-17 17:29 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: intel-gfx
On 15/08/18 02:25, Chris Wilson wrote:
> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/pm_rpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 65489bcdb..a4f9f783e 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> teardown_environment();
>
> igt_subtest("module-reload") {
> + teardown_environment();
There is already a fixture with a call to 'teardown_environment()'
surrounding this test, is it missing a couple of subtests groups?
Antonio
> +
> igt_debug("Reload w/o display\n");
> igt_i915_driver_unload();
> igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
@ 2018-08-17 17:29 ` Antonio Argenziano
0 siblings, 0 replies; 18+ messages in thread
From: Antonio Argenziano @ 2018-08-17 17:29 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: intel-gfx
On 15/08/18 02:25, Chris Wilson wrote:
> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/pm_rpm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 65489bcdb..a4f9f783e 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> teardown_environment();
>
> igt_subtest("module-reload") {
> + teardown_environment();
There is already a fixture with a call to 'teardown_environment()'
surrounding this test, is it missing a couple of subtests groups?
Antonio
> +
> igt_debug("Reload w/o display\n");
> igt_i915_driver_unload();
> igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
2018-08-17 17:29 ` Antonio Argenziano
@ 2018-08-17 17:49 ` Chris Wilson
-1 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2018-08-17 17:49 UTC (permalink / raw)
To: Antonio Argenziano, igt-dev; +Cc: intel-gfx
Quoting Antonio Argenziano (2018-08-17 18:29:09)
>
>
> On 15/08/18 02:25, Chris Wilson wrote:
> > Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/pm_rpm.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index 65489bcdb..a4f9f783e 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> > teardown_environment();
> >
> > igt_subtest("module-reload") {
> > + teardown_environment();
>
> There is already a fixture with a call to 'teardown_environment()'
> surrounding this test, is it missing a couple of subtests groups?
It was intended for sequential execution (and I had forgotten that I had
purposely placed it after the teardown_environment -- the confusion was
caused by teardown_environment being incomplete). Adding a subtest group
for the preceding bunch would have the debatable consequence of module-
reload reporting a FAIL if something else caused a wakeref leak. My
opinion is to prefer SKIP for external artefacts so that it is clear when
a test failed of its own accord (and so be useful for debugging). It just
so happens that this test was to reproduce the trigger for the external
failures elsewhere and so detect the wakeref leak.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
@ 2018-08-17 17:49 ` Chris Wilson
0 siblings, 0 replies; 18+ messages in thread
From: Chris Wilson @ 2018-08-17 17:49 UTC (permalink / raw)
To: Antonio Argenziano, igt-dev; +Cc: intel-gfx
Quoting Antonio Argenziano (2018-08-17 18:29:09)
>
>
> On 15/08/18 02:25, Chris Wilson wrote:
> > Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/pm_rpm.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index 65489bcdb..a4f9f783e 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
> > teardown_environment();
> >
> > igt_subtest("module-reload") {
> > + teardown_environment();
>
> There is already a fixture with a call to 'teardown_environment()'
> surrounding this test, is it missing a couple of subtests groups?
It was intended for sequential execution (and I had forgotten that I had
purposely placed it after the teardown_environment -- the confusion was
caused by teardown_environment being incomplete). Adding a subtest group
for the preceding bunch would have the debatable consequence of module-
reload reporting a FAIL if something else caused a wakeref leak. My
opinion is to prefer SKIP for external artefacts so that it is clear when
a test failed of its own accord (and so be useful for debugging). It just
so happens that this test was to reproduce the trigger for the external
failures elsewhere and so detect the wakeref leak.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
2018-08-17 17:49 ` Chris Wilson
@ 2018-08-17 18:27 ` Antonio Argenziano
-1 siblings, 0 replies; 18+ messages in thread
From: Antonio Argenziano @ 2018-08-17 18:27 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: intel-gfx
On 17/08/18 10:49, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-08-17 18:29:09)
>>
>>
>> On 15/08/18 02:25, Chris Wilson wrote:
>>> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>> tests/pm_rpm.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
>>> index 65489bcdb..a4f9f783e 100644
>>> --- a/tests/pm_rpm.c
>>> +++ b/tests/pm_rpm.c
>>> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
>>> teardown_environment();
>>>
>>> igt_subtest("module-reload") {
>>> + teardown_environment();
>>
>> There is already a fixture with a call to 'teardown_environment()'
>> surrounding this test, is it missing a couple of subtests groups?
>
> It was intended for sequential execution (and I had forgotten that I had
> purposely placed it after the teardown_environment -- the confusion was
> caused by teardown_environment being incomplete). Adding a subtest group
> for the preceding bunch would have the debatable consequence of module-
> reload reporting a FAIL if something else caused a wakeref leak. My
> opinion is to prefer SKIP for external artefacts so that it is clear when
> a test failed of its own accord (and so be useful for debugging). It just
> so happens that this test was to reproduce the trigger for the external
> failures elsewhere and so detect the wakeref leak.
Agreed. Maybe a comment would help, your choice.
Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
@ 2018-08-17 18:27 ` Antonio Argenziano
0 siblings, 0 replies; 18+ messages in thread
From: Antonio Argenziano @ 2018-08-17 18:27 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: intel-gfx
On 17/08/18 10:49, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-08-17 18:29:09)
>>
>>
>> On 15/08/18 02:25, Chris Wilson wrote:
>>> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>> tests/pm_rpm.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
>>> index 65489bcdb..a4f9f783e 100644
>>> --- a/tests/pm_rpm.c
>>> +++ b/tests/pm_rpm.c
>>> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
>>> teardown_environment();
>>>
>>> igt_subtest("module-reload") {
>>> + teardown_environment();
>>
>> There is already a fixture with a call to 'teardown_environment()'
>> surrounding this test, is it missing a couple of subtests groups?
>
> It was intended for sequential execution (and I had forgotten that I had
> purposely placed it after the teardown_environment -- the confusion was
> caused by teardown_environment being incomplete). Adding a subtest group
> for the preceding bunch would have the debatable consequence of module-
> reload reporting a FAIL if something else caused a wakeref leak. My
> opinion is to prefer SKIP for external artefacts so that it is clear when
> a test failed of its own accord (and so be useful for debugging). It just
> so happens that this test was to reproduce the trigger for the external
> failures elsewhere and so detect the wakeref leak.
Agreed. Maybe a comment would help, your choice.
Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>
> -Chris
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2018-08-17 18:27 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 9:25 [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module Chris Wilson
2018-08-15 9:25 ` [Intel-gfx] " Chris Wilson
2018-08-15 10:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-15 11:01 ` [igt-dev] [PATCH i-g-t] " Imre Deak
2018-08-15 11:01 ` [Intel-gfx] " Imre Deak
2018-08-15 11:04 ` Chris Wilson
2018-08-15 11:04 ` Chris Wilson
2018-08-15 11:08 ` Chris Wilson
2018-08-15 20:58 ` Chris Wilson
2018-08-15 11:45 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2018-08-15 16:11 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Close local fd before trying to unload module (rev2) Patchwork
2018-08-15 20:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-08-17 17:29 ` [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module Antonio Argenziano
2018-08-17 17:29 ` Antonio Argenziano
2018-08-17 17:49 ` Chris Wilson
2018-08-17 17:49 ` Chris Wilson
2018-08-17 18:27 ` Antonio Argenziano
2018-08-17 18:27 ` Antonio Argenziano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.