All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: linux-nvdimm@lists.01.org
Cc: Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, linux-fsdevel@vger.kernel.org
Subject: Snapshot target and DAX-capable devices
Date: Mon, 27 Aug 2018 18:07:44 +0200	[thread overview]
Message-ID: <20180827160744.GE4002@quack2.suse.cz> (raw)

Hi,

I've been analyzing why fstest generic/081 fails when the backing device is
capable of DAX. The problem boils down to the failure of:

lvm vgcreate -f vg0 /dev/pmem0
lvm lvcreate -L 128M -n lv0 vg0
lvm lvcreate -s -L 4M -n snap0 vg0/lv0

The last command fails like:

  device-mapper: reload ioctl on (253:0) failed: Invalid argument
  Failed to lock logical volume vg0/lv0.
  Aborting. Manual intervention required.

And the core of the problem is that volume vg0/lv0 is originally of
DM_TYPE_DAX_BIO_BASED type but when the snapshot gets created, we try to
switch it to DM_TYPE_BIO_BASED because now the device stops supporting DAX.
The problem seems to be introduced by Ross' commit dbc626597 "dm: prevent
DAX mounts if not supported".

The question is whether / how this should be fixed. The current inability
to create snapshots of DAX-capable devices looks weird and the cryptic
failure makes it even worse (it took me quite a while to understand what is
failing and why). OTOH I see the rationale behind Ross' change as well.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: linux-nvdimm@lists.01.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
	linux-fsdevel@vger.kernel.org, Toshi Kani <toshi.kani@hpe.com>,
	Dan Williams <dan.j.williams@intel.com>
Subject: Snapshot target and DAX-capable devices
Date: Mon, 27 Aug 2018 18:07:44 +0200	[thread overview]
Message-ID: <20180827160744.GE4002@quack2.suse.cz> (raw)

Hi,

I've been analyzing why fstest generic/081 fails when the backing device is
capable of DAX. The problem boils down to the failure of:

lvm vgcreate -f vg0 /dev/pmem0
lvm lvcreate -L 128M -n lv0 vg0
lvm lvcreate -s -L 4M -n snap0 vg0/lv0

The last command fails like:

  device-mapper: reload ioctl on (253:0) failed: Invalid argument
  Failed to lock logical volume vg0/lv0.
  Aborting. Manual intervention required.

And the core of the problem is that volume vg0/lv0 is originally of
DM_TYPE_DAX_BIO_BASED type but when the snapshot gets created, we try to
switch it to DM_TYPE_BIO_BASED because now the device stops supporting DAX.
The problem seems to be introduced by Ross' commit dbc626597 "dm: prevent
DAX mounts if not supported".

The question is whether / how this should be fixed. The current inability
to create snapshots of DAX-capable devices looks weird and the cryptic
failure makes it even worse (it took me quite a while to understand what is
failing and why). OTOH I see the rationale behind Ross' change as well.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
To: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
Cc: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Snapshot target and DAX-capable devices
Date: Mon, 27 Aug 2018 18:07:44 +0200	[thread overview]
Message-ID: <20180827160744.GE4002@quack2.suse.cz> (raw)

Hi,

I've been analyzing why fstest generic/081 fails when the backing device is
capable of DAX. The problem boils down to the failure of:

lvm vgcreate -f vg0 /dev/pmem0
lvm lvcreate -L 128M -n lv0 vg0
lvm lvcreate -s -L 4M -n snap0 vg0/lv0

The last command fails like:

  device-mapper: reload ioctl on (253:0) failed: Invalid argument
  Failed to lock logical volume vg0/lv0.
  Aborting. Manual intervention required.

And the core of the problem is that volume vg0/lv0 is originally of
DM_TYPE_DAX_BIO_BASED type but when the snapshot gets created, we try to
switch it to DM_TYPE_BIO_BASED because now the device stops supporting DAX.
The problem seems to be introduced by Ross' commit dbc626597 "dm: prevent
DAX mounts if not supported".

The question is whether / how this should be fixed. The current inability
to create snapshots of DAX-capable devices looks weird and the cryptic
failure makes it even worse (it took me quite a while to understand what is
failing and why). OTOH I see the rationale behind Ross' change as well.

								Honza
-- 
Jan Kara <jack-IBi9RG/b67k@public.gmane.org>
SUSE Labs, CR

             reply	other threads:[~2018-08-27 16:07 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 16:07 Jan Kara [this message]
2018-08-27 16:07 ` Snapshot target and DAX-capable devices Jan Kara
2018-08-27 16:07 ` Jan Kara
2018-08-27 16:43 ` Kani, Toshi
2018-08-27 16:43   ` Kani, Toshi
2018-08-27 16:43   ` Kani, Toshi
2018-08-28  7:50   ` Jan Kara
2018-08-28  7:50     ` Jan Kara
2018-08-28  7:50     ` Jan Kara
2018-08-28 17:56     ` Mike Snitzer
2018-08-28 17:56       ` Mike Snitzer
2018-08-28 17:56       ` Mike Snitzer
2018-08-28 22:38       ` Kani, Toshi
2018-08-28 22:38         ` Kani, Toshi
2018-08-28 22:38         ` Kani, Toshi
2018-08-30  9:30       ` Jan Kara
2018-08-30  9:30         ` Jan Kara
2018-08-30  9:30         ` Jan Kara
2018-08-30 18:49         ` Mike Snitzer
2018-08-30 18:49           ` Mike Snitzer
2018-08-30 18:49           ` Mike Snitzer
2018-08-30 19:32           ` Jeff Moyer
2018-08-30 19:32             ` Jeff Moyer
2018-08-30 19:32             ` Jeff Moyer
2018-08-30 19:47             ` Mikulas Patocka
2018-08-30 19:47               ` Mikulas Patocka
2018-08-30 19:47               ` Mikulas Patocka
2018-08-30 19:53               ` Jeff Moyer
2018-08-30 19:53                 ` Jeff Moyer
2018-08-30 19:53                 ` Jeff Moyer
2018-08-30 23:38               ` Dave Chinner
2018-08-30 23:38                 ` Dave Chinner
2018-08-30 23:38                 ` Dave Chinner
2018-08-31  9:42                 ` Jan Kara
2018-08-31  9:42                   ` Jan Kara
2018-08-31  9:42                   ` Jan Kara
2018-09-05  1:25                   ` Dave Chinner
2018-09-05  1:25                     ` Dave Chinner
2018-09-05  1:25                     ` Dave Chinner
2018-12-12 16:11                   ` Huaisheng Ye
2018-12-12 16:11                     ` Huaisheng Ye
2018-12-12 16:11                     ` Huaisheng Ye
2018-12-12 16:12                     ` Christoph Hellwig
2018-12-12 16:12                       ` Christoph Hellwig
2018-12-12 16:12                       ` Christoph Hellwig
2018-12-12 17:50                       ` Mike Snitzer
2018-12-12 17:50                         ` Mike Snitzer
2018-12-12 17:50                         ` Mike Snitzer
2018-12-12 19:49                         ` Kani, Toshi
2018-12-12 19:49                           ` Kani, Toshi
2018-12-12 19:49                           ` Kani, Toshi
2018-12-12 21:15                         ` Theodore Y. Ts'o
2018-12-12 21:15                           ` Theodore Y. Ts'o
2018-12-12 22:43                           ` Mike Snitzer
2018-12-12 22:43                             ` Mike Snitzer
2018-12-12 22:43                             ` Mike Snitzer
2018-12-14  4:11                             ` [dm-devel] " Theodore Y. Ts'o
2018-12-14  4:11                               ` Theodore Y. Ts'o
2018-12-14  4:11                               ` Theodore Y. Ts'o
2018-12-14  8:24                             ` [External] " Huaisheng HS1 Ye
2018-12-14  8:24                               ` Huaisheng HS1 Ye
2018-12-14  8:24                               ` Huaisheng HS1 Ye
2018-12-18 19:49                               ` Mike Snitzer
2018-12-18 19:49                                 ` Mike Snitzer
2018-12-18 19:49                                 ` Mike Snitzer
2018-08-30 19:44           ` Mikulas Patocka
2018-08-30 19:44             ` Mikulas Patocka
2018-08-30 19:44             ` Mikulas Patocka
2018-08-31 10:01             ` Jan Kara
2018-08-31 10:01               ` Jan Kara
2018-08-31 10:01               ` Jan Kara
2018-08-30 22:55           ` Dave Chinner
2018-08-30 22:55             ` Dave Chinner
2018-08-30 22:55             ` Dave Chinner
2018-08-31  9:54           ` Jan Kara
2018-08-31  9:54             ` Jan Kara
2018-08-31  9:54             ` Jan Kara
2018-08-30 19:17         ` [dm-devel] " Jeff Moyer
2018-08-30 19:17           ` Jeff Moyer
2018-08-30 19:17           ` Jeff Moyer
2018-08-31  9:14           ` Jan Kara
2018-08-31  9:14             ` Jan Kara
2018-08-31  9:14             ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180827160744.GE4002@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=dm-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.