All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default compatible string
@ 2018-08-29 12:58 Niklas Cassel
  2018-08-29 12:58 ` [PATCH 2/2] arm64: dts: db820c: Add qcom,apq8096 to " Niklas Cassel
  2018-09-03 19:27 ` [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default " Bjorn Andersson
  0 siblings, 2 replies; 4+ messages in thread
From: Niklas Cassel @ 2018-08-29 12:58 UTC (permalink / raw)
  To: Andy Gross, David Brown, Rob Herring, Mark Rutland
  Cc: Niklas Cassel, linux-arm-msm, linux-soc, devicetree, linux-kernel

Add a default compatible string.
This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt
and matches how it's done in arch/arm64/boot/dts/qcom/msm8916.dtsi

Usually the dts overrides this compatible property, however, if the dts
doesn't specify a compatible, this compatible string will be used.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index cd3865e7a270..354d3f900f72 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -17,6 +17,7 @@
 
 / {
 	model = "Qualcomm Technologies, Inc. MSM8996";
+	compatible = "qcom,msm8996";
 
 	interrupt-parent = <&intc>;
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: db820c: Add qcom,apq8096 to compatible string
  2018-08-29 12:58 [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default compatible string Niklas Cassel
@ 2018-08-29 12:58 ` Niklas Cassel
  2018-09-03 19:27   ` Bjorn Andersson
  2018-09-03 19:27 ` [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default " Bjorn Andersson
  1 sibling, 1 reply; 4+ messages in thread
From: Niklas Cassel @ 2018-08-29 12:58 UTC (permalink / raw)
  To: Andy Gross, David Brown, Rob Herring, Mark Rutland
  Cc: Niklas Cassel, linux-arm-msm, linux-soc, devicetree, linux-kernel

Add qcom,apq8096 to compatible string.
This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt
and is needed for e.g. drivers/cpufreq/qcom-cpufreq-kryo.c to be probed
correctly (and for drivers/cpufreq/cpufreq-dt-platdev.c to work properly).

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index 230e9c8484ac..da23bdafbd33 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -17,5 +17,5 @@
 
 / {
 	model = "Qualcomm Technologies, Inc. DB820c";
-	compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc";
+	compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc", "qcom,apq8096";
 };
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default compatible string
  2018-08-29 12:58 [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default compatible string Niklas Cassel
  2018-08-29 12:58 ` [PATCH 2/2] arm64: dts: db820c: Add qcom,apq8096 to " Niklas Cassel
@ 2018-09-03 19:27 ` Bjorn Andersson
  1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-09-03 19:27 UTC (permalink / raw)
  To: Niklas Cassel
  Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
	linux-arm-msm, linux-soc, devicetree, linux-kernel

On Wed 29 Aug 05:58 PDT 2018, Niklas Cassel wrote:

> Add a default compatible string.
> This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt
> and matches how it's done in arch/arm64/boot/dts/qcom/msm8916.dtsi
> 
> Usually the dts overrides this compatible property, however, if the dts
> doesn't specify a compatible, this compatible string will be used.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

I think we should just say that the board dts must specify a compatible.

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index cd3865e7a270..354d3f900f72 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -17,6 +17,7 @@
>  
>  / {
>  	model = "Qualcomm Technologies, Inc. MSM8996";
> +	compatible = "qcom,msm8996";
>  
>  	interrupt-parent = <&intc>;
>  
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm64: dts: db820c: Add qcom,apq8096 to compatible string
  2018-08-29 12:58 ` [PATCH 2/2] arm64: dts: db820c: Add qcom,apq8096 to " Niklas Cassel
@ 2018-09-03 19:27   ` Bjorn Andersson
  0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2018-09-03 19:27 UTC (permalink / raw)
  To: Niklas Cassel
  Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
	linux-arm-msm, linux-soc, devicetree, linux-kernel

On Wed 29 Aug 05:58 PDT 2018, Niklas Cassel wrote:

> Add qcom,apq8096 to compatible string.
> This compatible is defined in Documentation/devicetree/bindings/arm/qcom.txt
> and is needed for e.g. drivers/cpufreq/qcom-cpufreq-kryo.c to be probed
> correctly (and for drivers/cpufreq/cpufreq-dt-platdev.c to work properly).
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

@Andy, please pick this independently of 1/2

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 230e9c8484ac..da23bdafbd33 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -17,5 +17,5 @@
>  
>  / {
>  	model = "Qualcomm Technologies, Inc. DB820c";
> -	compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc";
> +	compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc", "qcom,apq8096";
>  };
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-09-03 19:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 12:58 [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default compatible string Niklas Cassel
2018-08-29 12:58 ` [PATCH 2/2] arm64: dts: db820c: Add qcom,apq8096 to " Niklas Cassel
2018-09-03 19:27   ` Bjorn Andersson
2018-09-03 19:27 ` [PATCH 1/2] arm64: dts: qcom: msm8996: Add a default " Bjorn Andersson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.