[PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
 tests/pm_rpm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index e3bb6227a..91aef0889 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
 	igt_subtest("module-reload") {
 		igt_debug("Reload w/o display\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
 
 		igt_debug("Reload as normal\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load(NULL), 0);
+		igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
 		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
 			drm_resources_equal_subtest();
 		teardown_environment();
+
+		/* Remove our mmio_debugging module */
+		igt_i915_driver_unload();
 	}
 
 	igt_exit();
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
 tests/pm_rpm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index e3bb6227a..91aef0889 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
 	igt_subtest("module-reload") {
 		igt_debug("Reload w/o display\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
 
 		igt_debug("Reload as normal\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load(NULL), 0);
+		igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
 		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
 			drm_resources_equal_subtest();
 		teardown_environment();
+
+		/* Remove our mmio_debugging module */
+		igt_i915_driver_unload();
 	}
 
 	igt_exit();
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/pm_rpm: Reload the module with full mmio debugging (rev2)

[Patchwork]

== Series Details ==

Series: lib/pm_rpm: Reload the module with full mmio debugging (rev2)
URL   : https://patchwork.freedesktop.org/series/48390/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4763 -> IGTPW_1782 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48390/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1782 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_psr@primary_page_flip:
      fi-cnl-psr:         PASS -> FAIL (fdo#107336)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-skl-guc:         FAIL (fdo#103191) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     FAIL (fdo#107362, fdo#103191) -> PASS

    igt@pm_rpm@module-reload:
      fi-bsw-kefka:       DMESG-WARN (fdo#107704) -> PASS
      fi-glk-dsi:         WARN (fdo#107708, fdo#107602) -> PASS
      fi-byt-clapper:     WARN (fdo#107708, fdo#107602) -> PASS
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> PASS
      fi-kbl-x1275:       WARN (fdo#107708, fdo#107602) -> PASS
      fi-cnl-psr:         WARN (fdo#107708, fdo#107602) -> PASS
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> PASS
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708


== Participating hosts (52 -> 45) ==

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4622 -> IGTPW_1782

  CI_DRM_4763: 1f8c06844acac7a349fb80471afcc09f33c6cfc0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1782: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1782/
  IGT_4622: 022be555443eaa3317da6a9a451cf2c9dfcd6ab8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1782/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✓ Fi.CI.BAT: success for lib/pm_rpm: Reload the module with full mmio debugging (rev2)

[Chris Wilson]

Quoting Patchwork (2018-09-04 12:01:51)
> == Series Details ==
> 
> Series: lib/pm_rpm: Reload the module with full mmio debugging (rev2)
> URL   : https://patchwork.freedesktop.org/series/48390/
> State : success
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_4763 -> IGTPW_1782 =
> 
> == Summary - SUCCESS ==
> 
>   No regressions found.
> 
>   External URL: https://patchwork.freedesktop.org/api/1.0/series/48390/revisions/2/mbox/
> 
> == Known issues ==
> 
>   Here are the changes found in IGTPW_1782 that come from known issues:
> 
>   === IGT changes ===
> 
>     ==== Issues hit ====
> 
>     igt@kms_frontbuffer_tracking@basic:
>       fi-byt-clapper:     PASS -> FAIL (fdo#103167)
> 
>     igt@kms_psr@primary_page_flip:
>       fi-cnl-psr:         PASS -> FAIL (fdo#107336)
> 
>     
>     ==== Possible fixes ====
> 
>     igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
>       fi-skl-guc:         FAIL (fdo#103191) -> PASS
> 
>     igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
>       fi-byt-clapper:     FAIL (fdo#107362, fdo#103191) -> PASS
> 
>     igt@pm_rpm@module-reload:
>       fi-bsw-kefka:       DMESG-WARN (fdo#107704) -> PASS
>       fi-glk-dsi:         WARN (fdo#107708, fdo#107602) -> PASS
>       fi-byt-clapper:     WARN (fdo#107708, fdo#107602) -> PASS
>       fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> PASS
>       fi-kbl-x1275:       WARN (fdo#107708, fdo#107602) -> PASS
>       fi-cnl-psr:         WARN (fdo#107708, fdo#107602) -> PASS
>       fi-byt-j1900:       DMESG-WARN (fdo#107704) -> PASS
>       fi-byt-n2820:       DMESG-WARN (fdo#107704) -> PASS

Hmm. I think this means that the unclaimed mmio is outside of our
driver. The warnings in stock are generated by
intel_uncore_arm_unclaimed_mmio_detection() at driver unload time, but
we shortcircuit that function if mmio debugging is already enabled.
Since the debug is already enabled and didn't catch anything, it is not
one of our regular register accesses.

Annoying, but ignorance is bliss.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Imre Deak]

On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> Our unclaimed mmio access debugging is lazy, doing cheap checks
> periodically and only if they fail do a full check around every mmio
> access. When testing for runtime pm, enable the full mmio debugging from
> the initial load.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> ---
>  tests/pm_rpm.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index e3bb6227a..91aef0889 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
>  	igt_subtest("module-reload") {
>  		igt_debug("Reload w/o display\n");
>  		igt_i915_driver_unload();
> -		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> +		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
>  
>  		igt_assert(setup_environment());
>  		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
>  
>  		igt_debug("Reload as normal\n");
>  		igt_i915_driver_unload();
> -		igt_assert_eq(igt_i915_driver_load(NULL), 0);
> +		igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);

Could've been in hex.

>  
>  		igt_assert(setup_environment());
>  		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
>  		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
>  			drm_resources_equal_subtest();
>  		teardown_environment();
> +
> +		/* Remove our mmio_debugging module */
> +		igt_i915_driver_unload();

What loads it again?

>  	}
>  
>  	igt_exit();
> -- 
> 2.19.0.rc1
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Imre Deak]

On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> Our unclaimed mmio access debugging is lazy, doing cheap checks
> periodically and only if they fail do a full check around every mmio
> access. When testing for runtime pm, enable the full mmio debugging from
> the initial load.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> ---
>  tests/pm_rpm.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index e3bb6227a..91aef0889 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
>  	igt_subtest("module-reload") {
>  		igt_debug("Reload w/o display\n");
>  		igt_i915_driver_unload();
> -		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> +		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
>  
>  		igt_assert(setup_environment());
>  		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
>  
>  		igt_debug("Reload as normal\n");
>  		igt_i915_driver_unload();
> -		igt_assert_eq(igt_i915_driver_load(NULL), 0);
> +		igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);

Could've been in hex.

>  
>  		igt_assert(setup_environment());
>  		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
>  		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
>  			drm_resources_equal_subtest();
>  		teardown_environment();
> +
> +		/* Remove our mmio_debugging module */
> +		igt_i915_driver_unload();

What loads it again?

>  	}
>  
>  	igt_exit();
> -- 
> 2.19.0.rc1
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Quoting Imre Deak (2018-09-04 15:14:06)
> On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > periodically and only if they fail do a full check around every mmio
> > access. When testing for runtime pm, enable the full mmio debugging from
> > the initial load.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@intel.com>
> > ---
> >  tests/pm_rpm.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index e3bb6227a..91aef0889 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> >       igt_subtest("module-reload") {
> >               igt_debug("Reload w/o display\n");
> >               igt_i915_driver_unload();
> > -             igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > +             igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> >  
> >               igt_assert(setup_environment());
> >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> >  
> >               igt_debug("Reload as normal\n");
> >               igt_i915_driver_unload();
> > -             igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > +             igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
> 
> Could've been in hex.
-1 should work as well as INT_MAX, I was just a bit dubious about that
claim at the time. But the kernel looks to be happy enough to start
counting down from -1.

> >               igt_assert(setup_environment());
> >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> >               if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> >                       drm_resources_equal_subtest();
> >               teardown_environment();
> > +
> > +             /* Remove our mmio_debugging module */
> > +             igt_i915_driver_unload();
> 
> What loads it again?

We automatically load it upon a failed drm_driver_open(). We have a list
of modules to try and modprobe if we find no matching /dev/dri/* fd.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Quoting Imre Deak (2018-09-04 15:14:06)
> On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > periodically and only if they fail do a full check around every mmio
> > access. When testing for runtime pm, enable the full mmio debugging from
> > the initial load.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@intel.com>
> > ---
> >  tests/pm_rpm.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index e3bb6227a..91aef0889 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> >       igt_subtest("module-reload") {
> >               igt_debug("Reload w/o display\n");
> >               igt_i915_driver_unload();
> > -             igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > +             igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> >  
> >               igt_assert(setup_environment());
> >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> >  
> >               igt_debug("Reload as normal\n");
> >               igt_i915_driver_unload();
> > -             igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > +             igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
> 
> Could've been in hex.
-1 should work as well as INT_MAX, I was just a bit dubious about that
claim at the time. But the kernel looks to be happy enough to start
counting down from -1.

> >               igt_assert(setup_environment());
> >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> >               if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> >                       drm_resources_equal_subtest();
> >               teardown_environment();
> > +
> > +             /* Remove our mmio_debugging module */
> > +             igt_i915_driver_unload();
> 
> What loads it again?

We automatically load it upon a failed drm_driver_open(). We have a list
of modules to try and modprobe if we find no matching /dev/dri/* fd.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Imre Deak]

On Tue, Sep 04, 2018 at 03:21:09PM +0100, Chris Wilson wrote:
> Quoting Imre Deak (2018-09-04 15:14:06)
> > On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > > periodically and only if they fail do a full check around every mmio
> > > access. When testing for runtime pm, enable the full mmio debugging from
> > > the initial load.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > ---
> > >  tests/pm_rpm.c | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > > index e3bb6227a..91aef0889 100644
> > > --- a/tests/pm_rpm.c
> > > +++ b/tests/pm_rpm.c
> > > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> > >       igt_subtest("module-reload") {
> > >               igt_debug("Reload w/o display\n");
> > >               igt_i915_driver_unload();
> > > -             igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > > +             igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> > >  
> > >               igt_assert(setup_environment());
> > >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> > >  
> > >               igt_debug("Reload as normal\n");
> > >               igt_i915_driver_unload();
> > > -             igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > > +             igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
> > 
> > Could've been in hex.
> -1 should work as well as INT_MAX, I was just a bit dubious about that
> claim at the time. But the kernel looks to be happy enough to start
> counting down from -1.
> 
> > >               igt_assert(setup_environment());
> > >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > >               if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> > >                       drm_resources_equal_subtest();
> > >               teardown_environment();
> > > +
> > > +             /* Remove our mmio_debugging module */
> > > +             igt_i915_driver_unload();
> > 
> > What loads it again?
> 
> We automatically load it upon a failed drm_driver_open(). We have a list
> of modules to try and modprobe if we find no matching /dev/dri/* fd.

Ok, missed that. Looks ok:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Imre Deak]

On Tue, Sep 04, 2018 at 03:21:09PM +0100, Chris Wilson wrote:
> Quoting Imre Deak (2018-09-04 15:14:06)
> > On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > > periodically and only if they fail do a full check around every mmio
> > > access. When testing for runtime pm, enable the full mmio debugging from
> > > the initial load.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > ---
> > >  tests/pm_rpm.c | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > > index e3bb6227a..91aef0889 100644
> > > --- a/tests/pm_rpm.c
> > > +++ b/tests/pm_rpm.c
> > > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> > >       igt_subtest("module-reload") {
> > >               igt_debug("Reload w/o display\n");
> > >               igt_i915_driver_unload();
> > > -             igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > > +             igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> > >  
> > >               igt_assert(setup_environment());
> > >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> > >  
> > >               igt_debug("Reload as normal\n");
> > >               igt_i915_driver_unload();
> > > -             igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > > +             igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
> > 
> > Could've been in hex.
> -1 should work as well as INT_MAX, I was just a bit dubious about that
> claim at the time. But the kernel looks to be happy enough to start
> counting down from -1.
> 
> > >               igt_assert(setup_environment());
> > >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > >               if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> > >                       drm_resources_equal_subtest();
> > >               teardown_environment();
> > > +
> > > +             /* Remove our mmio_debugging module */
> > > +             igt_i915_driver_unload();
> > 
> > What loads it again?
> 
> We automatically load it upon a failed drm_driver_open(). We have a list
> of modules to try and modprobe if we find no matching /dev/dri/* fd.

Ok, missed that. Looks ok:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH i-g-t] igt/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
---
 tests/pm_rpm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index e3bb6227a..c24fd95bb 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
 	igt_subtest("module-reload") {
 		igt_debug("Reload w/o display\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=-1"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
 
 		igt_debug("Reload as normal\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load(NULL), 0);
+		igt_assert_eq(igt_i915_driver_load("mmio_debug=-1"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
 		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
 			drm_resources_equal_subtest();
 		teardown_environment();
+
+		/* Remove our mmio_debugging module */
+		igt_i915_driver_unload();
 	}
 
 	igt_exit();
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for igt/pm_rpm: Reload the module with full mmio debugging

[Patchwork]

== Series Details ==

Series: igt/pm_rpm: Reload the module with full mmio debugging
URL   : https://patchwork.freedesktop.org/series/49138/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4766 -> IGTPW_1785 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49138/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1785 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_chamelium@hdmi-hpd-fast:
      fi-kbl-7500u:       SKIP -> FAIL (fdo#103841, fdo#102672)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-cfl-8109u:       PASS -> INCOMPLETE (fdo#106070)

    
    ==== Possible fixes ====

    igt@pm_rpm@module-reload:
      fi-bsw-kefka:       DMESG-WARN (fdo#107704) -> PASS
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> PASS
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> PASS
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> PASS

    
  fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (49 -> 44) ==

  Additional (1): fi-hsw-4770r 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 


== Build changes ==

    * IGT: IGT_4625 -> IGTPW_1785

  CI_DRM_4766: 0d35b9d0b3a74c41ac1ffe1a34aa9c98d2a3a0b9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1785: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1785/
  IGT_4625: 67fbe2967889484f1248d851c068e1021f2dc332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1785/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for igt/pm_rpm: Reload the module with full mmio debugging

[Patchwork]

== Series Details ==

Series: igt/pm_rpm: Reload the module with full mmio debugging
URL   : https://patchwork.freedesktop.org/series/49138/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4625_full -> IGTPW_1785_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49138/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1785_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-hsw:          PASS -> INCOMPLETE (fdo#106886, fdo#103540)

    igt@kms_color@pipe-b-ctm-0-75:
      shard-apl:          PASS -> DMESG-WARN (fdo#103558, fdo#105602) +10

    igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
      shard-glk:          PASS -> FAIL (fdo#103167) +1

    igt@testdisplay:
      shard-glk:          PASS -> INCOMPLETE (fdo#107093, k.org#198133, fdo#103359)

    
    ==== Possible fixes ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          FAIL (fdo#106641) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu:
      shard-glk:          FAIL (fdo#103167) -> PASS +2

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#107749) -> PASS

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4625 -> IGTPW_1785
    * Linux: CI_DRM_4763 -> CI_DRM_4766

  CI_DRM_4763: 1f8c06844acac7a349fb80471afcc09f33c6cfc0 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4766: 0d35b9d0b3a74c41ac1ffe1a34aa9c98d2a3a0b9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1785: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1785/
  IGT_4625: 67fbe2967889484f1248d851c068e1021f2dc332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1785/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] ✓ Fi.CI.IGT: success for lib/pm_rpm: Reload the module with full mmio debugging (rev2)

[Patchwork]

== Series Details ==

Series: lib/pm_rpm: Reload the module with full mmio debugging (rev2)
URL   : https://patchwork.freedesktop.org/series/48390/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4622_full -> IGTPW_1782_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1782_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1782_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48390/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1782_full:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
      shard-snb:          SKIP -> PASS

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1782_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_schedule@pi-ringfull-bsd2:
      shard-kbl:          NOTRUN -> FAIL (fdo#103158)

    igt@gem_pwrite_pread@display-copy-performance:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@perf_pmu@most-busy-check-all-vcs1:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-hsw:          INCOMPLETE (fdo#106886, fdo#103540) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#106023, fdo#103665) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt:
      shard-glk:          FAIL (fdo#103167) -> PASS

    
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4622 -> IGTPW_1782
    * Linux: CI_DRM_4757 -> CI_DRM_4763

  CI_DRM_4757: 1465de895e2b5d9e74e9a85189c9075155efa30d @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4763: 1f8c06844acac7a349fb80471afcc09f33c6cfc0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1782: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1782/
  IGT_4622: 022be555443eaa3317da6a9a451cf2c9dfcd6ab8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1782/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
 tests/pm_rpm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index bbe36e59e..249530691 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2042,7 +2042,7 @@ int main(int argc, char *argv[])
 	igt_subtest("module-reload") {
 		igt_debug("Reload w/o display\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2050,13 +2050,16 @@ int main(int argc, char *argv[])
 
 		igt_debug("Reload as normal\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load(NULL), 0);
+		igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
 		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
 			drm_resources_equal_subtest();
 		teardown_environment();
+
+		/* Remove our mmio_debugging module */
+		igt_i915_driver_unload();
 	}
 
 	igt_exit();
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx