From: Anup Patel <anup@brainfault.org> To: Palmer Dabbelt <palmer@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com> Cc: Atish Patra <atish.patra@wdc.com>, Christoph Hellwig <hch@infradead.org>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Anup Patel <anup@brainfault.org> Subject: [RFC PATCH 2/5] RISC-V: No need to pass scause as arg to do_IRQ() Date: Tue, 4 Sep 2018 18:15:11 +0530 [thread overview] Message-ID: <20180904124514.6290-3-anup@brainfault.org> (raw) In-Reply-To: <20180904124514.6290-1-anup@brainfault.org> The scause is already part of pt_regs so no need to pass scause as separate arg to do_IRQ(). Signed-off-by: Anup Patel <anup@brainfault.org> --- arch/riscv/kernel/entry.S | 1 - arch/riscv/kernel/irq.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S index fa2c08e3c05e..6eaacfa5b63d 100644 --- a/arch/riscv/kernel/entry.S +++ b/arch/riscv/kernel/entry.S @@ -168,7 +168,6 @@ ENTRY(handle_exception) /* Handle interrupts */ move a0, sp /* pt_regs */ - move a1, s4 /* scause */ tail do_IRQ 1: /* Exceptions run with interrupts enabled */ diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c index 5532e7cedaec..c51c9b402e87 100644 --- a/arch/riscv/kernel/irq.c +++ b/arch/riscv/kernel/irq.c @@ -26,11 +26,11 @@ */ #define INTERRUPT_CAUSE_FLAG (1UL << (__riscv_xlen - 1)) -asmlinkage void __irq_entry do_IRQ(struct pt_regs *regs, unsigned long cause) +asmlinkage void __irq_entry do_IRQ(struct pt_regs *regs) { struct pt_regs *old_regs; - switch (cause & ~INTERRUPT_CAUSE_FLAG) { + switch (regs->scause & ~INTERRUPT_CAUSE_FLAG) { case INTERRUPT_CAUSE_TIMER: old_regs = set_irq_regs(regs); irq_enter(); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: anup@brainfault.org (Anup Patel) To: linux-riscv@lists.infradead.org Subject: [RFC PATCH 2/5] RISC-V: No need to pass scause as arg to do_IRQ() Date: Tue, 4 Sep 2018 18:15:11 +0530 [thread overview] Message-ID: <20180904124514.6290-3-anup@brainfault.org> (raw) In-Reply-To: <20180904124514.6290-1-anup@brainfault.org> The scause is already part of pt_regs so no need to pass scause as separate arg to do_IRQ(). Signed-off-by: Anup Patel <anup@brainfault.org> --- arch/riscv/kernel/entry.S | 1 - arch/riscv/kernel/irq.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S index fa2c08e3c05e..6eaacfa5b63d 100644 --- a/arch/riscv/kernel/entry.S +++ b/arch/riscv/kernel/entry.S @@ -168,7 +168,6 @@ ENTRY(handle_exception) /* Handle interrupts */ move a0, sp /* pt_regs */ - move a1, s4 /* scause */ tail do_IRQ 1: /* Exceptions run with interrupts enabled */ diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c index 5532e7cedaec..c51c9b402e87 100644 --- a/arch/riscv/kernel/irq.c +++ b/arch/riscv/kernel/irq.c @@ -26,11 +26,11 @@ */ #define INTERRUPT_CAUSE_FLAG (1UL << (__riscv_xlen - 1)) -asmlinkage void __irq_entry do_IRQ(struct pt_regs *regs, unsigned long cause) +asmlinkage void __irq_entry do_IRQ(struct pt_regs *regs) { struct pt_regs *old_regs; - switch (cause & ~INTERRUPT_CAUSE_FLAG) { + switch (regs->scause & ~INTERRUPT_CAUSE_FLAG) { case INTERRUPT_CAUSE_TIMER: old_regs = set_irq_regs(regs); irq_enter(); -- 2.17.1
next prev parent reply other threads:[~2018-09-04 12:45 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-04 12:45 [RFC PATCH 0/5] New RISC-V Local Interrupt Controller Driver Anup Patel 2018-09-04 12:45 ` Anup Patel 2018-09-04 12:45 ` [RFC PATCH 1/5] RISC-V: Make IPI triggering flexible Anup Patel 2018-09-04 12:45 ` Anup Patel 2018-09-04 18:50 ` Christoph Hellwig 2018-09-04 18:50 ` Christoph Hellwig 2018-09-05 4:36 ` Anup Patel 2018-09-05 4:36 ` Anup Patel 2018-09-05 18:56 ` Christoph Hellwig 2018-09-05 18:56 ` Christoph Hellwig 2018-09-06 9:45 ` Palmer Dabbelt 2018-09-06 9:45 ` Palmer Dabbelt 2018-09-06 10:45 ` Anup Patel 2018-09-06 10:45 ` Anup Patel 2018-09-10 13:34 ` Christoph Hellwig 2018-09-10 13:34 ` Christoph Hellwig 2018-09-11 3:37 ` Anup Patel 2018-09-11 3:37 ` Anup Patel 2018-09-29 1:45 ` Palmer Dabbelt 2018-09-29 1:45 ` Palmer Dabbelt 2018-09-29 1:45 ` Palmer Dabbelt 2018-09-29 7:06 ` Anup Patel 2018-09-29 7:06 ` Anup Patel 2018-09-29 7:06 ` Anup Patel 2018-09-04 12:45 ` Anup Patel [this message] 2018-09-04 12:45 ` [RFC PATCH 2/5] RISC-V: No need to pass scause as arg to do_IRQ() Anup Patel 2018-09-04 18:50 ` Christoph Hellwig 2018-09-04 18:50 ` Christoph Hellwig 2018-09-04 12:45 ` [RFC PATCH 3/5] RISC-V: Select useful GENERIC_IRQ kconfig options Anup Patel 2018-09-04 12:45 ` Anup Patel 2018-09-04 18:56 ` Christoph Hellwig 2018-09-04 18:56 ` Christoph Hellwig 2018-09-05 4:52 ` Anup Patel 2018-09-05 4:52 ` Anup Patel 2018-09-05 18:57 ` Christoph Hellwig 2018-09-05 18:57 ` Christoph Hellwig 2018-09-04 12:45 ` [RFC PATCH 4/5] irqchip: RISC-V Local Interrupt Controller Driver Anup Patel 2018-09-04 12:45 ` Anup Patel 2018-09-04 18:57 ` Christoph Hellwig 2018-09-04 18:57 ` Christoph Hellwig 2018-09-05 6:09 ` Anup Patel 2018-09-05 6:09 ` Anup Patel 2018-09-05 18:58 ` Christoph Hellwig 2018-09-05 18:58 ` Christoph Hellwig 2018-09-06 11:53 ` Anup Patel 2018-09-06 11:53 ` Anup Patel 2018-09-10 13:35 ` Christoph Hellwig 2018-09-10 13:35 ` Christoph Hellwig 2018-09-04 12:45 ` [RFC PATCH 5/5] clocksource: riscv_timer: Make timer interrupt as a per-CPU interrupt Anup Patel 2018-09-04 12:45 ` Anup Patel 2018-09-04 18:58 ` Christoph Hellwig 2018-09-04 18:58 ` Christoph Hellwig 2018-09-05 8:21 ` Anup Patel 2018-09-05 8:21 ` Anup Patel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180904124514.6290-3-anup@brainfault.org \ --to=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=atish.patra@wdc.com \ --cc=daniel.lezcano@linaro.org \ --cc=hch@infradead.org \ --cc=jason@lakedaemon.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=palmer@sifive.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.