All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <anup@brainfault.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Palmer Dabbelt <palmer@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Atish Patra <atish.patra@wdc.com>,
	linux-riscv@lists.infradead.org,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/5] RISC-V: Select useful GENERIC_IRQ kconfig options
Date: Wed, 5 Sep 2018 11:57:24 -0700	[thread overview]
Message-ID: <20180905185724.GB15741@infradead.org> (raw)
In-Reply-To: <CAAhSdy3qUkDmV5deoy9x3sqdv8xTq37od6SzgF0hmN1JPThGgw@mail.gmail.com>

On Wed, Sep 05, 2018 at 10:22:27AM +0530, Anup Patel wrote:
> I am sure we will see both Level and Edge triggered interrupts
> in RISC-V system. The MMIO device interrupts will be mostly
> Level triggered and PCI MSIs will be mapped as Edge triggered
> by MSI controller.
> 
> We should definitely select GENERIC_IRQ_SHOW_LEVEL
> so that nature of IRQ interrupt line is evident in /proc/interrupts.

Please settle the argument with Thomas and Marc on what the default
for this option should be - in the end it just shows another line
in procfs, and I see no reason for RISC-V to ever deviated from the
global Linux default here, whatever that default is.

> >> HANDLE_DOMAIN_IRQ
> >
> > We aren't using handle_domain_irq anywhere in RISC-V, no need to
> > build this.
> 
> The new RISC-V local interrupt controller driver introduced by
> this patchset uses handle_domain_irq().

So select it in the patch that needs it, not anywhere else.

WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [RFC PATCH 3/5] RISC-V: Select useful GENERIC_IRQ kconfig options
Date: Wed, 5 Sep 2018 11:57:24 -0700	[thread overview]
Message-ID: <20180905185724.GB15741@infradead.org> (raw)
In-Reply-To: <CAAhSdy3qUkDmV5deoy9x3sqdv8xTq37od6SzgF0hmN1JPThGgw@mail.gmail.com>

On Wed, Sep 05, 2018 at 10:22:27AM +0530, Anup Patel wrote:
> I am sure we will see both Level and Edge triggered interrupts
> in RISC-V system. The MMIO device interrupts will be mostly
> Level triggered and PCI MSIs will be mapped as Edge triggered
> by MSI controller.
> 
> We should definitely select GENERIC_IRQ_SHOW_LEVEL
> so that nature of IRQ interrupt line is evident in /proc/interrupts.

Please settle the argument with Thomas and Marc on what the default
for this option should be - in the end it just shows another line
in procfs, and I see no reason for RISC-V to ever deviated from the
global Linux default here, whatever that default is.

> >> HANDLE_DOMAIN_IRQ
> >
> > We aren't using handle_domain_irq anywhere in RISC-V, no need to
> > build this.
> 
> The new RISC-V local interrupt controller driver introduced by
> this patchset uses handle_domain_irq().

So select it in the patch that needs it, not anywhere else.

  reply	other threads:[~2018-09-05 18:57 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 12:45 [RFC PATCH 0/5] New RISC-V Local Interrupt Controller Driver Anup Patel
2018-09-04 12:45 ` Anup Patel
2018-09-04 12:45 ` [RFC PATCH 1/5] RISC-V: Make IPI triggering flexible Anup Patel
2018-09-04 12:45   ` Anup Patel
2018-09-04 18:50   ` Christoph Hellwig
2018-09-04 18:50     ` Christoph Hellwig
2018-09-05  4:36     ` Anup Patel
2018-09-05  4:36       ` Anup Patel
2018-09-05 18:56       ` Christoph Hellwig
2018-09-05 18:56         ` Christoph Hellwig
2018-09-06  9:45     ` Palmer Dabbelt
2018-09-06  9:45       ` Palmer Dabbelt
2018-09-06 10:45       ` Anup Patel
2018-09-06 10:45         ` Anup Patel
2018-09-10 13:34         ` Christoph Hellwig
2018-09-10 13:34           ` Christoph Hellwig
2018-09-11  3:37           ` Anup Patel
2018-09-11  3:37             ` Anup Patel
2018-09-29  1:45           ` Palmer Dabbelt
2018-09-29  1:45             ` Palmer Dabbelt
2018-09-29  1:45             ` Palmer Dabbelt
2018-09-29  7:06             ` Anup Patel
2018-09-29  7:06               ` Anup Patel
2018-09-29  7:06               ` Anup Patel
2018-09-04 12:45 ` [RFC PATCH 2/5] RISC-V: No need to pass scause as arg to do_IRQ() Anup Patel
2018-09-04 12:45   ` Anup Patel
2018-09-04 18:50   ` Christoph Hellwig
2018-09-04 18:50     ` Christoph Hellwig
2018-09-04 12:45 ` [RFC PATCH 3/5] RISC-V: Select useful GENERIC_IRQ kconfig options Anup Patel
2018-09-04 12:45   ` Anup Patel
2018-09-04 18:56   ` Christoph Hellwig
2018-09-04 18:56     ` Christoph Hellwig
2018-09-05  4:52     ` Anup Patel
2018-09-05  4:52       ` Anup Patel
2018-09-05 18:57       ` Christoph Hellwig [this message]
2018-09-05 18:57         ` Christoph Hellwig
2018-09-04 12:45 ` [RFC PATCH 4/5] irqchip: RISC-V Local Interrupt Controller Driver Anup Patel
2018-09-04 12:45   ` Anup Patel
2018-09-04 18:57   ` Christoph Hellwig
2018-09-04 18:57     ` Christoph Hellwig
2018-09-05  6:09     ` Anup Patel
2018-09-05  6:09       ` Anup Patel
2018-09-05 18:58       ` Christoph Hellwig
2018-09-05 18:58         ` Christoph Hellwig
2018-09-06 11:53         ` Anup Patel
2018-09-06 11:53           ` Anup Patel
2018-09-10 13:35           ` Christoph Hellwig
2018-09-10 13:35             ` Christoph Hellwig
2018-09-04 12:45 ` [RFC PATCH 5/5] clocksource: riscv_timer: Make timer interrupt as a per-CPU interrupt Anup Patel
2018-09-04 12:45   ` Anup Patel
2018-09-04 18:58   ` Christoph Hellwig
2018-09-04 18:58     ` Christoph Hellwig
2018-09-05  8:21     ` Anup Patel
2018-09-05  8:21       ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905185724.GB15741@infradead.org \
    --to=hch@infradead.org \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=palmer@sifive.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.