* [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
@ 2018-09-02 7:30 ` Andreas Kemnade
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2018-09-02 7:30 UTC (permalink / raw)
To: ulf.hansson, kishon, wsa+renesas, linux-mmc, linux-omap,
linux-kernel, Tony Lindgren, Discussions about the Letux Kernel
Cc: Andreas Kemnade
after unbinding mmc I get things like this:
[ 185.294067] mmc1: card 0001 removed
[ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
The wakeirq stays in /proc-interrupts
rebinding shows this:
[ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
[ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
[ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
That bug seems to be introduced by switching from devm_request_irq()
to generic wakeirq handling.
So let us cleanup at removal.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
---
drivers/mmc/host/omap_hsmmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 071693ebfe18..68760d4a5d3d 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2177,6 +2177,7 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
dma_release_channel(host->tx_chan);
dma_release_channel(host->rx_chan);
+ dev_pm_clear_wake_irq(host->dev);
pm_runtime_dont_use_autosuspend(host->dev);
pm_runtime_put_sync(host->dev);
pm_runtime_disable(host->dev);
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
@ 2018-09-02 7:30 ` Andreas Kemnade
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2018-09-02 7:30 UTC (permalink / raw)
To: ulf.hansson, kishon, wsa+renesas, linux-mmc, linux-omap,
linux-kernel, Tony Lindgren, Discussions about the Letux Kernel
Cc: Andreas Kemnade
after unbinding mmc I get things like this:
[ 185.294067] mmc1: card 0001 removed
[ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
The wakeirq stays in /proc-interrupts
rebinding shows this:
[ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
[ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
[ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
That bug seems to be introduced by switching from devm_request_irq()
to generic wakeirq handling.
So let us cleanup at removal.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
---
drivers/mmc/host/omap_hsmmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 071693ebfe18..68760d4a5d3d 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2177,6 +2177,7 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
dma_release_channel(host->tx_chan);
dma_release_channel(host->rx_chan);
+ dev_pm_clear_wake_irq(host->dev);
pm_runtime_dont_use_autosuspend(host->dev);
pm_runtime_put_sync(host->dev);
pm_runtime_disable(host->dev);
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
2018-09-02 7:30 ` Andreas Kemnade
@ 2018-09-04 14:34 ` Ulf Hansson
-1 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2018-09-04 14:34 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Kishon, Wolfram Sang, linux-mmc, linux-omap,
Linux Kernel Mailing List, Tony Lindgren,
Discussions about the Letux Kernel
On 2 September 2018 at 09:30, Andreas Kemnade <andreas@kemnade.info> wrote:
> after unbinding mmc I get things like this:
> [ 185.294067] mmc1: card 0001 removed
> [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
>
> The wakeirq stays in /proc-interrupts
>
> rebinding shows this:
> [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
> [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
> [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
>
> That bug seems to be introduced by switching from devm_request_irq()
> to generic wakeirq handling.
>
> So let us cleanup at removal.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
Applied for fixes, and added a stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/omap_hsmmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 071693ebfe18..68760d4a5d3d 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2177,6 +2177,7 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
> dma_release_channel(host->tx_chan);
> dma_release_channel(host->rx_chan);
>
> + dev_pm_clear_wake_irq(host->dev);
> pm_runtime_dont_use_autosuspend(host->dev);
> pm_runtime_put_sync(host->dev);
> pm_runtime_disable(host->dev);
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
@ 2018-09-04 14:34 ` Ulf Hansson
0 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2018-09-04 14:34 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Kishon, Wolfram Sang, linux-mmc, linux-omap,
Linux Kernel Mailing List, Tony Lindgren,
Discussions about the Letux Kernel
On 2 September 2018 at 09:30, Andreas Kemnade <andreas@kemnade.info> wrote:
> after unbinding mmc I get things like this:
> [ 185.294067] mmc1: card 0001 removed
> [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
>
> The wakeirq stays in /proc-interrupts
>
> rebinding shows this:
> [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
> [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
> [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
>
> That bug seems to be introduced by switching from devm_request_irq()
> to generic wakeirq handling.
>
> So let us cleanup at removal.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
Applied for fixes, and added a stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/omap_hsmmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 071693ebfe18..68760d4a5d3d 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2177,6 +2177,7 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
> dma_release_channel(host->tx_chan);
> dma_release_channel(host->rx_chan);
>
> + dev_pm_clear_wake_irq(host->dev);
> pm_runtime_dont_use_autosuspend(host->dev);
> pm_runtime_put_sync(host->dev);
> pm_runtime_disable(host->dev);
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
2018-09-04 14:34 ` Ulf Hansson
@ 2018-09-04 15:38 ` Tony Lindgren
-1 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2018-09-04 15:38 UTC (permalink / raw)
To: Ulf Hansson
Cc: Andreas Kemnade, Kishon, Wolfram Sang, linux-mmc, linux-omap,
Linux Kernel Mailing List, Discussions about the Letux Kernel
* Ulf Hansson <ulf.hansson@linaro.org> [180904 14:39]:
> On 2 September 2018 at 09:30, Andreas Kemnade <andreas@kemnade.info> wrote:
> > after unbinding mmc I get things like this:
> > [ 185.294067] mmc1: card 0001 removed
> > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
> >
> > The wakeirq stays in /proc-interrupts
> >
> > rebinding shows this:
> > [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
> > [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
> > [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
> >
> > That bug seems to be introduced by switching from devm_request_irq()
> > to generic wakeirq handling.
> >
> > So let us cleanup at removal.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
Ooops sorry about that.
> Applied for fixes, and added a stable tag, thanks!
OK and thanks for fixing this Andreas!
Regards,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
@ 2018-09-04 15:38 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2018-09-04 15:38 UTC (permalink / raw)
To: Ulf Hansson
Cc: Andreas Kemnade, Kishon, Wolfram Sang, linux-mmc, linux-omap,
Linux Kernel Mailing List, Discussions about the Letux Kernel
* Ulf Hansson <ulf.hansson@linaro.org> [180904 14:39]:
> On 2 September 2018 at 09:30, Andreas Kemnade <andreas@kemnade.info> wrote:
> > after unbinding mmc I get things like this:
> > [ 185.294067] mmc1: card 0001 removed
> > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
> >
> > The wakeirq stays in /proc-interrupts
> >
> > rebinding shows this:
> > [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
> > [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
> > [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
> >
> > That bug seems to be introduced by switching from devm_request_irq()
> > to generic wakeirq handling.
> >
> > So let us cleanup at removal.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
Ooops sorry about that.
> Applied for fixes, and added a stable tag, thanks!
OK and thanks for fixing this Andreas!
Regards,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
2018-09-04 14:34 ` Ulf Hansson
@ 2018-09-04 20:11 ` Andreas Kemnade
-1 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2018-09-04 20:11 UTC (permalink / raw)
To: Ulf Hansson
Cc: Kishon, Wolfram Sang, linux-mmc, linux-omap,
Linux Kernel Mailing List, Tony Lindgren,
Discussions about the Letux Kernel
[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]
Hi,
On Tue, 4 Sep 2018 16:34:56 +0200
Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 2 September 2018 at 09:30, Andreas Kemnade <andreas@kemnade.info> wrote:
> > after unbinding mmc I get things like this:
> > [ 185.294067] mmc1: card 0001 removed
> > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
> >
> > The wakeirq stays in /proc-interrupts
> >
> > rebinding shows this:
> > [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
> > [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
> > [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
> >
> > That bug seems to be introduced by switching from devm_request_irq()
> > to generic wakeirq handling.
> >
> > So let us cleanup at removal.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
>
> Applied for fixes, and added a stable tag, thanks!
>
What also might be critical (still analyzing) of that patch I am fixing
is:
It keeps the wakeup irq also enabled when the sdio irq is disabled.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal
@ 2018-09-04 20:11 ` Andreas Kemnade
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2018-09-04 20:11 UTC (permalink / raw)
To: Ulf Hansson
Cc: Kishon, Wolfram Sang, linux-mmc, linux-omap,
Linux Kernel Mailing List, Tony Lindgren,
Discussions about the Letux Kernel
[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]
Hi,
On Tue, 4 Sep 2018 16:34:56 +0200
Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 2 September 2018 at 09:30, Andreas Kemnade <andreas@kemnade.info> wrote:
> > after unbinding mmc I get things like this:
> > [ 185.294067] mmc1: card 0001 removed
> > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
> >
> > The wakeirq stays in /proc-interrupts
> >
> > rebinding shows this:
> > [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
> > [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
> > [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
> >
> > That bug seems to be introduced by switching from devm_request_irq()
> > to generic wakeirq handling.
> >
> > So let us cleanup at removal.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
>
> Applied for fixes, and added a stable tag, thanks!
>
What also might be critical (still analyzing) of that patch I am fixing
is:
It keeps the wakeup irq also enabled when the sdio irq is disabled.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-04 20:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-02 7:30 [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal Andreas Kemnade
2018-09-02 7:30 ` Andreas Kemnade
2018-09-04 14:34 ` Ulf Hansson
2018-09-04 14:34 ` Ulf Hansson
2018-09-04 15:38 ` Tony Lindgren
2018-09-04 15:38 ` Tony Lindgren
2018-09-04 20:11 ` Andreas Kemnade
2018-09-04 20:11 ` Andreas Kemnade
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.