From: Daniel Vetter <daniel@ffwll.ch>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Gustavo Padovan <gustavo@padovan.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm: Remove set but not used variable 'config'
Date: Tue, 11 Sep 2018 09:34:39 +0200 [thread overview]
Message-ID: <20180911073438.GG19774@phenom.ffwll.local> (raw)
In-Reply-To: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com>
On Tue, Sep 11, 2018 at 06:20:14AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res':
> drivers/gpu/drm/drm_plane.c:475:26: warning:
> variable 'config' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_plane.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> index 36bf3fe..4a72c68 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> struct drm_file *file_priv)
> {
> struct drm_mode_get_plane_res *plane_resp = data;
> - struct drm_mode_config *config;
> struct drm_plane *plane;
> uint32_t __user *plane_ptr;
> int count = 0;
> @@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> if (!drm_core_check_feature(dev, DRIVER_MODESET))
> return -EINVAL;
>
> - config = &dev->mode_config;
> plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr);
>
> /*
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: YueHaibing <yuehaibing@huawei.com>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH -next] drm: Remove set but not used variable 'config'
Date: Tue, 11 Sep 2018 07:34:39 +0000 [thread overview]
Message-ID: <20180911073438.GG19774@phenom.ffwll.local> (raw)
In-Reply-To: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com>
On Tue, Sep 11, 2018 at 06:20:14AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res':
> drivers/gpu/drm/drm_plane.c:475:26: warning:
> variable 'config' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_plane.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> index 36bf3fe..4a72c68 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> struct drm_file *file_priv)
> {
> struct drm_mode_get_plane_res *plane_resp = data;
> - struct drm_mode_config *config;
> struct drm_plane *plane;
> uint32_t __user *plane_ptr;
> int count = 0;
> @@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> if (!drm_core_check_feature(dev, DRIVER_MODESET))
> return -EINVAL;
>
> - config = &dev->mode_config;
> plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr);
>
> /*
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: YueHaibing <yuehaibing@huawei.com>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH -next] drm: Remove set but not used variable 'config'
Date: Tue, 11 Sep 2018 09:34:39 +0200 [thread overview]
Message-ID: <20180911073438.GG19774@phenom.ffwll.local> (raw)
In-Reply-To: <1536646814-186429-1-git-send-email-yuehaibing@huawei.com>
On Tue, Sep 11, 2018 at 06:20:14AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/drm_plane.c: In function 'drm_mode_getplane_res':
> drivers/gpu/drm/drm_plane.c:475:26: warning:
> variable 'config' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_plane.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c
> index 36bf3fe..4a72c68 100644
> --- a/drivers/gpu/drm/drm_plane.c
> +++ b/drivers/gpu/drm/drm_plane.c
> @@ -472,7 +472,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> struct drm_file *file_priv)
> {
> struct drm_mode_get_plane_res *plane_resp = data;
> - struct drm_mode_config *config;
> struct drm_plane *plane;
> uint32_t __user *plane_ptr;
> int count = 0;
> @@ -480,7 +479,6 @@ int drm_mode_getplane_res(struct drm_device *dev, void *data,
> if (!drm_core_check_feature(dev, DRIVER_MODESET))
> return -EINVAL;
>
> - config = &dev->mode_config;
> plane_ptr = u64_to_user_ptr(plane_resp->plane_id_ptr);
>
> /*
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-11 7:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 6:20 [PATCH -next] drm: Remove set but not used variable 'config' YueHaibing
2018-09-11 6:20 ` YueHaibing
2018-09-11 7:34 ` Daniel Vetter [this message]
2018-09-11 7:34 ` Daniel Vetter
2018-09-11 7:34 ` Daniel Vetter
2019-02-15 3:35 [PATCH -next] drm: Remove set but not used variable 'gem' YueHaibing
2019-02-15 3:35 ` YueHaibing
2019-02-15 3:35 ` YueHaibing
2019-02-16 0:53 ` Eric Anholt
2019-02-16 0:53 ` Eric Anholt
2019-02-16 0:53 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911073438.GG19774@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=sean@poorly.run \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.