All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>, Laura Abbott <labbott@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Colin Cross <ccross@android.com>,
	Jason Baron <jbaron@akamai.com>, Tony Luck <tony.luck@intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Joe Perches <joe@perches.com>, Jim Cromie <jim.cromie@gmail.com>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.orglinux
Subject: Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations
Date: Tue, 18 Sep 2018 12:47:27 +0100	[thread overview]
Message-ID: <20180918114727.GE16498@arm.com> (raw)
In-Reply-To: <c6470671-3abf-c296-586e-cca5131cc437@codeaurora.org>

On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote:
> On 9/18/2018 5:09 AM, Steven Rostedt wrote:
> >On Sun,  9 Sep 2018 01:57:06 +0530
> >Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> wrote:
> >
> >>The new asm-generic/io-instrumented.h will keep arch code
> >>clean and separate from instrumented version which traces
> >>io register accesses. This instrumented header can later
> >>be included in arm as well for tracing io register accesses.
> >>
> >
> >Looks good to me.
> >
> >Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> >-- Steve
> 
> Thanks for the ack Steve.
> 
> @Will/Mark/Robin Let me know if you have any review comments, thanks.

As I said before, the arm64 bits looks fine to me. I just don't really want
to Ack the thing because the patch also contains the asm-generic changes.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>, Laura Abbott <labbott@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Colin Cross <ccross@android.com>,
	Jason Baron <jbaron@akamai.com>, Tony Luck <tony.luck@intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Joe Perches <joe@perches.com>, Jim Cromie <jim.cromie@gmail.com>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Vivek Gautam <vivek.gautam@codeaurora.org>,
	Sibi Sankar <sibis@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Prasad Sodagudi <psodagud@codeaurora.org>,
	tsoni@codeaurora.org, Bryan Huntsman <bryanh@codeaurora.org>,
	Tingwei Zhang <tingwei@codeaurora.org>,
	mark.rutland@arm.com, robin.murphy@arm.com
Subject: Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations
Date: Tue, 18 Sep 2018 12:47:27 +0100	[thread overview]
Message-ID: <20180918114727.GE16498@arm.com> (raw)
In-Reply-To: <c6470671-3abf-c296-586e-cca5131cc437@codeaurora.org>

On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote:
> On 9/18/2018 5:09 AM, Steven Rostedt wrote:
> >On Sun,  9 Sep 2018 01:57:06 +0530
> >Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> wrote:
> >
> >>The new asm-generic/io-instrumented.h will keep arch code
> >>clean and separate from instrumented version which traces
> >>io register accesses. This instrumented header can later
> >>be included in arm as well for tracing io register accesses.
> >>
> >
> >Looks good to me.
> >
> >Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> >-- Steve
> 
> Thanks for the ack Steve.
> 
> @Will/Mark/Robin Let me know if you have any review comments, thanks.

As I said before, the arm64 bits looks fine to me. I just don't really want
to Ack the thing because the patch also contains the asm-generic changes.

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations
Date: Tue, 18 Sep 2018 12:47:27 +0100	[thread overview]
Message-ID: <20180918114727.GE16498@arm.com> (raw)
In-Reply-To: <c6470671-3abf-c296-586e-cca5131cc437@codeaurora.org>

On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote:
> On 9/18/2018 5:09 AM, Steven Rostedt wrote:
> >On Sun,  9 Sep 2018 01:57:06 +0530
> >Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> wrote:
> >
> >>The new asm-generic/io-instrumented.h will keep arch code
> >>clean and separate from instrumented version which traces
> >>io register accesses. This instrumented header can later
> >>be included in arm as well for tracing io register accesses.
> >>
> >
> >Looks good to me.
> >
> >Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> >-- Steve
> 
> Thanks for the ack Steve.
> 
> @Will/Mark/Robin Let me know if you have any review comments, thanks.

As I said before, the arm64 bits looks fine to me. I just don't really want
to Ack the thing because the patch also contains the asm-generic changes.

Will

  reply	other threads:[~2018-09-18 11:47 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-08 20:27 [PATCH 0/6] Tracing register accesses with pstore and dynamic debug Sai Prakash Ranjan
2018-09-08 20:27 ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 1/6] dt-bindings: ramoops: Add event-size property Sai Prakash Ranjan
2018-09-08 20:27   ` Sai Prakash Ranjan
2018-09-17  5:45   ` Rob Herring
2018-09-17  5:45     ` Rob Herring
2018-09-17 17:15     ` Sai Prakash Ranjan
2018-09-17 17:15       ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 2/6] pstore: Add event tracing support Sai Prakash Ranjan
2018-09-08 20:27   ` Sai Prakash Ranjan
2018-09-11 10:46   ` Sai Prakash Ranjan
2018-09-11 10:46     ` Sai Prakash Ranjan
2018-09-17 17:38     ` Stephen Boyd
2018-09-17 17:38       ` Stephen Boyd
2018-09-17 19:43       ` Sai Prakash Ranjan
2018-09-17 19:43         ` Sai Prakash Ranjan
2018-09-16  7:07   ` Sai Prakash Ranjan
2018-09-16  7:07     ` Sai Prakash Ranjan
2018-09-16 13:55     ` Joel Fernandes
2018-09-17 14:54       ` Kees Cook
2018-09-17 14:54         ` Kees Cook
2018-09-17 14:54         ` Kees Cook
2018-09-17 17:17         ` Sai Prakash Ranjan
2018-09-17 17:17           ` Sai Prakash Ranjan
2018-09-17 17:17           ` Sai Prakash Ranjan
2018-09-17 17:13       ` Sai Prakash Ranjan
2018-09-17 17:13         ` Sai Prakash Ranjan
2018-09-17 17:13         ` Sai Prakash Ranjan
2018-09-17 23:04     ` Steven Rostedt
2018-09-17 23:04       ` Steven Rostedt
2018-09-17 23:04       ` Steven Rostedt
2018-09-18  6:24       ` Sai Prakash Ranjan
2018-09-18  6:24         ` Sai Prakash Ranjan
2018-09-18  6:24         ` Sai Prakash Ranjan
2018-09-17 23:34   ` Steven Rostedt
2018-09-17 23:34     ` Steven Rostedt
2018-09-17 23:34     ` Steven Rostedt
2018-09-18 17:52     ` Sai Prakash Ranjan
2018-09-18 17:52       ` Sai Prakash Ranjan
2018-09-18 17:52       ` Sai Prakash Ranjan
2018-09-18 20:44       ` Steven Rostedt
2018-09-18 20:44         ` Steven Rostedt
2018-09-18 20:44         ` Steven Rostedt
2018-09-18 21:13         ` Sai Prakash Ranjan
2018-09-18 21:13           ` Sai Prakash Ranjan
2018-09-18 21:13           ` Sai Prakash Ranjan
2018-09-22  6:48           ` Sai Prakash Ranjan
2018-09-22  6:48             ` Sai Prakash Ranjan
2018-09-22  6:48             ` Sai Prakash Ranjan
2018-09-22  9:05   ` Joel Fernandes
2018-09-22  9:05     ` Joel Fernandes
2018-09-22  9:05     ` Joel Fernandes
2018-09-22 16:37     ` Sai Prakash Ranjan
2018-09-22 16:37       ` Sai Prakash Ranjan
2018-09-22 16:37       ` Sai Prakash Ranjan
2018-09-22 17:32       ` Sai Prakash Ranjan
2018-09-22 17:32         ` Sai Prakash Ranjan
2018-09-22 17:32         ` Sai Prakash Ranjan
2018-09-22 17:45       ` Sai Prakash Ranjan
2018-09-22 17:45         ` Sai Prakash Ranjan
2018-09-22 17:45         ` Sai Prakash Ranjan
2018-09-23 15:33       ` Sai Prakash Ranjan
2018-09-23 15:33         ` Sai Prakash Ranjan
2018-09-23 15:33         ` Sai Prakash Ranjan
2018-09-25 20:37         ` Joel Fernandes
2018-09-25 20:37           ` Joel Fernandes
2018-09-25 20:37           ` Joel Fernandes
2018-09-25 20:39           ` Joel Fernandes
2018-09-25 20:39             ` Joel Fernandes
2018-09-25 20:39             ` Joel Fernandes
2018-09-25 20:40             ` Joel Fernandes
2018-09-25 20:40               ` Joel Fernandes
2018-09-25 20:40               ` Joel Fernandes
2018-09-26  9:52               ` Sai Prakash Ranjan
2018-09-26  9:52                 ` Sai Prakash Ranjan
2018-09-26  9:52                 ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 3/6] tracing: Add tp_pstore cmdline to have tracepoints go to pstore Sai Prakash Ranjan
2018-09-08 20:27   ` Sai Prakash Ranjan
2018-09-25 21:25   ` Joel Fernandes
2018-09-25 21:25     ` Joel Fernandes
2018-09-25 21:25     ` Joel Fernandes
2018-09-26  9:46     ` Sai Prakash Ranjan
2018-09-26  9:46       ` Sai Prakash Ranjan
2018-09-26  9:46       ` Sai Prakash Ranjan
2018-10-08 14:16       ` Sai Prakash Ranjan
2018-10-08 14:16         ` Sai Prakash Ranjan
2018-10-08 14:16         ` Sai Prakash Ranjan
2018-10-08 14:36         ` Steven Rostedt
2018-10-08 14:36           ` Steven Rostedt
2018-10-08 14:36           ` Steven Rostedt
2018-10-08 22:40           ` Joel Fernandes
2018-10-08 22:40             ` Joel Fernandes
2018-10-08 22:40             ` Joel Fernandes
2018-10-09 18:22             ` Sai Prakash Ranjan
2018-10-09 18:22               ` Sai Prakash Ranjan
2018-10-09 18:22               ` Sai Prakash Ranjan
2018-10-10 19:37               ` Steven Rostedt
2018-10-10 19:37                 ` Steven Rostedt
2018-10-10 19:37                 ` Steven Rostedt
2018-09-08 20:27 ` [PATCH 4/6] arm64/io: Add tracepoint for register accesses Sai Prakash Ranjan
2018-09-08 20:27   ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 5/6] arm64/io: Add header for instrumentation of io operations Sai Prakash Ranjan
2018-09-08 20:27   ` Sai Prakash Ranjan
2018-09-17 23:39   ` Steven Rostedt
2018-09-17 23:39     ` Steven Rostedt
2018-09-17 23:39     ` Steven Rostedt
2018-09-18  7:10     ` Sai Prakash Ranjan
2018-09-18  7:10       ` Sai Prakash Ranjan
2018-09-18  7:10       ` Sai Prakash Ranjan
2018-09-18 11:47       ` Will Deacon [this message]
2018-09-18 11:47         ` Will Deacon
2018-09-18 11:47         ` Will Deacon
2018-09-18 12:43         ` Sai Prakash Ranjan
2018-09-18 12:43           ` Sai Prakash Ranjan
2018-09-18 12:43           ` Sai Prakash Ranjan
2018-09-08 20:27 ` [PATCH 6/6] dynamic_debug: Add flag for dynamic event tracing Sai Prakash Ranjan
2018-09-08 20:27   ` Sai Prakash Ranjan
2018-09-11 15:11 ` [PATCH 0/6] Tracing register accesses with pstore and dynamic debug Will Deacon
2018-09-11 15:11   ` Will Deacon
2018-09-11 15:11   ` Will Deacon
2018-09-11 16:11   ` Sai Prakash Ranjan
2018-09-11 16:11     ` Sai Prakash Ranjan
2018-09-11 16:11     ` Sai Prakash Ranjan
2018-10-20  5:25 ` Joel Fernandes
2018-10-20  5:25   ` Joel Fernandes
2018-10-20  5:25   ` Joel Fernandes
2018-10-20  6:32   ` Sai Prakash Ranjan
2018-10-20  6:32     ` Sai Prakash Ranjan
2018-10-20  6:32     ` Sai Prakash Ranjan
2018-10-20 16:27     ` Joel Fernandes
2018-10-20 16:27       ` Joel Fernandes
2018-10-20 16:27       ` Joel Fernandes
2018-10-21  3:46       ` Sai Prakash Ranjan
2018-10-21  3:46         ` Sai Prakash Ranjan
2018-10-21  3:46         ` Sai Prakash Ranjan
2018-10-21  4:59         ` Sai Prakash Ranjan
2018-10-21  4:59           ` Sai Prakash Ranjan
2018-10-21  4:59           ` Sai Prakash Ranjan
2018-10-21  5:09         ` Joel Fernandes
2018-10-21  5:09           ` Joel Fernandes
2018-10-21  5:09           ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180918114727.GE16498@arm.com \
    --to=will.deacon@arm.com \
    --cc=anton@enomsg.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=ccross@android.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbaron@akamai.com \
    --cc=jim.cromie@gmail.com \
    --cc=joe@perches.com \
    --cc=joel@joelfernandes.org \
    --cc=keescook@chromium.org \
    --cc=labbott@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.orglinux \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=sibis@codeaurora.org \
    --cc=tony.luck@intel.com \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.