* [PATCH] grub-install: Mention *efibootmgr* in no-nvram description
@ 2018-09-06 13:54 Paul Menzel
2018-09-06 14:02 ` [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description Paul Menzel
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2018-09-06 13:54 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]
Date: Thu, 6 Sep 2018 15:15:45 +0200
If executing `efibootmgr` fails, for example, because the system is booted in
legacy mode, but with a mounted EFI System Partition, the error message
mentions *efibootmgr*. To make it easier for users to work around that
problem by skipping running `efibootmgr`, add the word to the description of
the switch *no-nvram*, which skips the efibootmgr execution.
---
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
{"skip-fs-probe",'s',0, 0,
N_("do not probe for filesystems in DEVICE"), 0},
--
2.17.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description
2018-09-06 13:54 [PATCH] grub-install: Mention *efibootmgr* in no-nvram description Paul Menzel
@ 2018-09-06 14:02 ` Paul Menzel
2018-09-06 17:37 ` Vladimir 'phcoder' Serbinenko
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2018-09-06 14:02 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
Date: Thu, 6 Sep 2018 15:15:45 +0200
If executing `efibootmgr` fails, for example, because the system is
booted in legacy mode, but with a mounted EFI System Partition, the
error message mentions *efibootmgr*. To make it easier for users to work
around that problem by skipping running `efibootmgr`, add the word to
the description of the switch *no-nvram*, which skips the efibootmgr
execution.
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
v2: Add Signed-off-by line
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
{"skip-fs-probe",'s',0, 0,
N_("do not probe for filesystems in DEVICE"), 0},
--
2.17.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description
2018-09-06 14:02 ` [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description Paul Menzel
@ 2018-09-06 17:37 ` Vladimir 'phcoder' Serbinenko
2018-09-19 14:08 ` Daniel Kiper
0 siblings, 1 reply; 6+ messages in thread
From: Vladimir 'phcoder' Serbinenko @ 2018-09-06 17:37 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]
On Thu, 6 Sep 2018, 17:03 Paul Menzel, <pmenzel@molgen.mpg.de> wrote:
> Date: Thu, 6 Sep 2018 15:15:45 +0200
>
> If executing `efibootmgr` fails, for example, because the system is
> booted in legacy mode, but with a mounted EFI System Partition, the
> error message mentions *efibootmgr*. To make it easier for users to work
> around that problem by skipping running `efibootmgr`, add the word to
> the description of the switch *no-nvram*, which skips the efibootmgr
> execution.
>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> v2: Add Signed-off-by line
>
> util/grub-install.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/grub-install.c b/util/grub-install.c
> index a44858198..335662a58 100644
> --- a/util/grub-install.c
> +++ b/util/grub-install.c
> @@ -276,7 +276,7 @@ static struct argp_option options[] = {
> N_("disk module to use (biosdisk or native). "
> "This option is only available on BIOS target."), 2},
> {"no-nvram", OPTION_NO_NVRAM, 0, 0,
> - N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
> + N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM
> variables. "
> "This option is only available on EFI and IEEE1275 targets."), 2},
>
In case of ieee1275 this has nothing to do with efibootmgr
> {"skip-fs-probe",'s',0, 0,
> N_("do not probe for filesystems in DEVICE"), 0},
> --
> 2.17.1
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: Type: text/html, Size: 2424 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description
2018-09-06 17:37 ` Vladimir 'phcoder' Serbinenko
@ 2018-09-19 14:08 ` Daniel Kiper
2018-09-19 14:18 ` Paul Menzel
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Kiper @ 2018-09-19 14:08 UTC (permalink / raw)
To: pmenzel; +Cc: The development of GNU GRUB, phcoder
On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote:
> On Thu, 6 Sep 2018, 17:03 Paul Menzel, <pmenzel@molgen.mpg.de> wrote:
>
> > Date: Thu, 6 Sep 2018 15:15:45 +0200
> >
> > If executing `efibootmgr` fails, for example, because the system is
> > booted in legacy mode, but with a mounted EFI System Partition, the
> > error message mentions *efibootmgr*. To make it easier for users to work
> > around that problem by skipping running `efibootmgr`, add the word to
> > the description of the switch *no-nvram*, which skips the efibootmgr
> > execution.
> >
> > Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> > ---
> > v2: Add Signed-off-by line
> >
> > util/grub-install.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/util/grub-install.c b/util/grub-install.c
> > index a44858198..335662a58 100644
> > --- a/util/grub-install.c
> > +++ b/util/grub-install.c
> > @@ -276,7 +276,7 @@ static struct argp_option options[] = {
> > N_("disk module to use (biosdisk or native). "
> > "This option is only available on BIOS target."), 2},
> > {"no-nvram", OPTION_NO_NVRAM, 0, 0,
> > - N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
> > + N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM
> > variables. "
> > "This option is only available on EFI and IEEE1275 targets."), 2},
> >
> In case of ieee1275 this has nothing to do with efibootmgr
Paul, are you going to repost the patch with relevant change in the code
and commit message or should I fix it just before push?
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description
2018-09-19 14:08 ` Daniel Kiper
@ 2018-09-19 14:18 ` Paul Menzel
2018-09-21 17:58 ` Daniel Kiper
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2018-09-19 14:18 UTC (permalink / raw)
To: Daniel Kiper; +Cc: grub-devel, Vladimir 'phcoder' Serbinenko
[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]
Dear Daniel,
On 09/19/18 16:08, Daniel Kiper wrote:
> On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote:
>> On Thu, 6 Sep 2018, 17:03 Paul Menzel, <pmenzel@molgen.mpg.de> wrote:
>>
>>> Date: Thu, 6 Sep 2018 15:15:45 +0200
>>>
>>> If executing `efibootmgr` fails, for example, because the system is
>>> booted in legacy mode, but with a mounted EFI System Partition, the
>>> error message mentions *efibootmgr*. To make it easier for users to work
>>> around that problem by skipping running `efibootmgr`, add the word to
>>> the description of the switch *no-nvram*, which skips the efibootmgr
>>> execution.
>>>
>>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>>> ---
>>> v2: Add Signed-off-by line
>>>
>>> util/grub-install.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/util/grub-install.c b/util/grub-install.c
>>> index a44858198..335662a58 100644
>>> --- a/util/grub-install.c
>>> +++ b/util/grub-install.c
>>> @@ -276,7 +276,7 @@ static struct argp_option options[] = {
>>> N_("disk module to use (biosdisk or native). "
>>> "This option is only available on BIOS target."), 2},
>>> {"no-nvram", OPTION_NO_NVRAM, 0, 0,
>>> - N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
>>> + N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM
>>> variables. "
>>> "This option is only available on EFI and IEEE1275 targets."), 2},
>>>
>> In case of ieee1275 this has nothing to do with efibootmgr
>
> Paul, are you going to repost the patch with relevant change in the code
> and commit message or should I fix it just before push?
I am still thinking how to phrase it. Maybe, just add efibootmanager
after EFI?
> don’t update the `boot-device'/`Boot*' NVRAM variables. This option
> is only available on EFI (efibootmgr) and IEEE1275 targets.
Kind regards,
Paul
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description
2018-09-19 14:18 ` Paul Menzel
@ 2018-09-21 17:58 ` Daniel Kiper
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kiper @ 2018-09-21 17:58 UTC (permalink / raw)
To: Paul Menzel
Cc: Daniel Kiper, grub-devel, Vladimir 'phcoder' Serbinenko
On Wed, Sep 19, 2018 at 04:18:45PM +0200, Paul Menzel wrote:
> Dear Daniel,
>
>
> On 09/19/18 16:08, Daniel Kiper wrote:
> > On Thu, Sep 06, 2018 at 08:37:50PM +0300, Vladimir 'phcoder' Serbinenko wrote:
> >> On Thu, 6 Sep 2018, 17:03 Paul Menzel, <pmenzel@molgen.mpg.de> wrote:
> >>
> >>> Date: Thu, 6 Sep 2018 15:15:45 +0200
> >>>
> >>> If executing `efibootmgr` fails, for example, because the system is
> >>> booted in legacy mode, but with a mounted EFI System Partition, the
> >>> error message mentions *efibootmgr*. To make it easier for users to work
> >>> around that problem by skipping running `efibootmgr`, add the word to
> >>> the description of the switch *no-nvram*, which skips the efibootmgr
> >>> execution.
> >>>
> >>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> >>> ---
> >>> v2: Add Signed-off-by line
> >>>
> >>> util/grub-install.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/util/grub-install.c b/util/grub-install.c
> >>> index a44858198..335662a58 100644
> >>> --- a/util/grub-install.c
> >>> +++ b/util/grub-install.c
> >>> @@ -276,7 +276,7 @@ static struct argp_option options[] = {
> >>> N_("disk module to use (biosdisk or native). "
> >>> "This option is only available on BIOS target."), 2},
> >>> {"no-nvram", OPTION_NO_NVRAM, 0, 0,
> >>> - N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
> >>> + N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM
> >>> variables. "
> >>> "This option is only available on EFI and IEEE1275 targets."), 2},
> >>>
> >> In case of ieee1275 this has nothing to do with efibootmgr
> >
> > Paul, are you going to repost the patch with relevant change in the code
> > and commit message or should I fix it just before push?
>
> I am still thinking how to phrase it. Maybe, just add efibootmanager
> after EFI?
What about "don't update, e.g. using efibootmgr, the `boot-device'/`Boot*' NVRAM variables. "?
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-21 17:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-06 13:54 [PATCH] grub-install: Mention *efibootmgr* in no-nvram description Paul Menzel
2018-09-06 14:02 ` [PATCH v2] grub-install: Mention *efibootmgr* in `no-nvram` description Paul Menzel
2018-09-06 17:37 ` Vladimir 'phcoder' Serbinenko
2018-09-19 14:08 ` Daniel Kiper
2018-09-19 14:18 ` Paul Menzel
2018-09-21 17:58 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.