* [PATCH v2 0/3] Add can support to RZ/G2M @ 2018-09-10 10:43 Fabrizio Castro 2018-09-10 10:43 ` [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration Fabrizio Castro ` (3 more replies) 0 siblings, 4 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-10 10:43 UTC (permalink / raw) To: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland Cc: Fabrizio Castro, David S. Miller, Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson, linux-can, netdev, devicetree, linux-renesas-soc, linux-kernel, Geert Uytterhoeven, Biju Das Dear All, this series contains all that's necessary to add CAN support for RZ/G2M (a.k.a. r8a774a1). v1-v2: * applied Geert's comments Thanks, Fab Chris Paterson (1): arm64: dts: renesas: r8a774a1: Add CAN nodes Fabrizio Castro (2): can: rcar_can: Fix erroneous registration dt-bindings: can: rcar_can: Add r8a774a1 support .../devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++----- arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++ drivers/net/can/rcar/rcar_can.c | 5 ++++- 3 files changed, 41 insertions(+), 6 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration 2018-09-10 10:43 [PATCH v2 0/3] Add can support to RZ/G2M Fabrizio Castro @ 2018-09-10 10:43 ` Fabrizio Castro 2018-09-11 13:31 ` Simon Horman 2018-11-08 12:39 ` Fabrizio Castro 2018-09-10 10:43 ` [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro ` (2 subsequent siblings) 3 siblings, 2 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-10 10:43 UTC (permalink / raw) To: Wolfgang Grandegger, Marc Kleine-Budde Cc: Fabrizio Castro, David S. Miller, Sergei Shtylyov, Chris Paterson, linux-can, netdev, Simon Horman, Geert Uytterhoeven, Biju Das, linux-renesas-soc Assigning 2 to "renesas,can-clock-select" tricks the driver into registering the CAN interface, even though we don't want that. This patch improves one of the checks to prevent that from happening. Fixes: 862e2b6af9413b43 ("can: rcar_can: support all input clocks") Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> --- v1->v2: * dropped id specific data as per Geert's comments This patch applies on top of linux-can-next-for-4.19-20180727. drivers/net/can/rcar/rcar_can.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c index 11662f4..771a460 100644 --- a/drivers/net/can/rcar/rcar_can.c +++ b/drivers/net/can/rcar/rcar_can.c @@ -24,6 +24,9 @@ #define RCAR_CAN_DRV_NAME "rcar_can" +#define RCAR_SUPPORTED_CLOCKS (BIT(CLKR_CLKP1) | BIT(CLKR_CLKP2) | \ + BIT(CLKR_CLKEXT)) + /* Mailbox configuration: * mailbox 60 - 63 - Rx FIFO mailboxes * mailbox 56 - 59 - Tx FIFO mailboxes @@ -789,7 +792,7 @@ static int rcar_can_probe(struct platform_device *pdev) goto fail_clk; } - if (clock_select >= ARRAY_SIZE(clock_names)) { + if (!(BIT(clock_select) & RCAR_SUPPORTED_CLOCKS)) { err = -EINVAL; dev_err(&pdev->dev, "invalid CAN clock selected\n"); goto fail_clk; -- 2.7.4 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration 2018-09-10 10:43 ` [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration Fabrizio Castro @ 2018-09-11 13:31 ` Simon Horman 2018-11-08 12:39 ` Fabrizio Castro 1 sibling, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-09-11 13:31 UTC (permalink / raw) To: Fabrizio Castro Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller, Sergei Shtylyov, Chris Paterson, linux-can, netdev, Geert Uytterhoeven, Biju Das, linux-renesas-soc On Mon, Sep 10, 2018 at 11:43:13AM +0100, Fabrizio Castro wrote: > Assigning 2 to "renesas,can-clock-select" tricks the driver into > registering the CAN interface, even though we don't want that. > This patch improves one of the checks to prevent that from happening. > > Fixes: 862e2b6af9413b43 ("can: rcar_can: support all input clocks") > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> ^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration 2018-09-10 10:43 ` [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration Fabrizio Castro 2018-09-11 13:31 ` Simon Horman @ 2018-11-08 12:39 ` Fabrizio Castro 2018-11-08 13:20 ` Simon Horman 1 sibling, 1 reply; 30+ messages in thread From: Fabrizio Castro @ 2018-11-08 12:39 UTC (permalink / raw) To: Fabrizio Castro, Wolfgang Grandegger, Marc Kleine-Budde Cc: David S. Miller, Sergei Shtylyov, Chris Paterson, linux-can, netdev, Simon Horman, Geert Uytterhoeven, Biju Das, linux-renesas-soc Dear All, Is this patch ok? Thanks, Fab > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Sent: 10 September 2018 11:43 > Subject: [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration > > Assigning 2 to "renesas,can-clock-select" tricks the driver into > registering the CAN interface, even though we don't want that. > This patch improves one of the checks to prevent that from happening. > > Fixes: 862e2b6af9413b43 ("can: rcar_can: support all input clocks") > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > --- > > v1->v2: > * dropped id specific data as per Geert's comments > > This patch applies on top of linux-can-next-for-4.19-20180727. > > drivers/net/can/rcar/rcar_can.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c > index 11662f4..771a460 100644 > --- a/drivers/net/can/rcar/rcar_can.c > +++ b/drivers/net/can/rcar/rcar_can.c > @@ -24,6 +24,9 @@ > > #define RCAR_CAN_DRV_NAME"rcar_can" > > +#define RCAR_SUPPORTED_CLOCKS(BIT(CLKR_CLKP1) | BIT(CLKR_CLKP2) | \ > + BIT(CLKR_CLKEXT)) > + > /* Mailbox configuration: > * mailbox 60 - 63 - Rx FIFO mailboxes > * mailbox 56 - 59 - Tx FIFO mailboxes > @@ -789,7 +792,7 @@ static int rcar_can_probe(struct platform_device *pdev) > goto fail_clk; > } > > -if (clock_select >= ARRAY_SIZE(clock_names)) { > +if (!(BIT(clock_select) & RCAR_SUPPORTED_CLOCKS)) { > err = -EINVAL; > dev_err(&pdev->dev, "invalid CAN clock selected\n"); > goto fail_clk; > -- > 2.7.4 Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration 2018-11-08 12:39 ` Fabrizio Castro @ 2018-11-08 13:20 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-11-08 13:20 UTC (permalink / raw) To: Fabrizio Castro Cc: Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller, Sergei Shtylyov, Chris Paterson, linux-can, netdev, Geert Uytterhoeven, Biju Das, linux-renesas-soc On Thu, Nov 08, 2018 at 12:39:00PM +0000, Fabrizio Castro wrote: > Dear All, > > Is this patch ok? It looks ok to me. Reviewed-by: Simon Horman <horms+renesas@verge.net.au> ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support 2018-09-10 10:43 [PATCH v2 0/3] Add can support to RZ/G2M Fabrizio Castro 2018-09-10 10:43 ` [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration Fabrizio Castro @ 2018-09-10 10:43 ` Fabrizio Castro 2018-09-11 13:31 ` Simon Horman ` (2 more replies) 2018-09-10 10:43 ` Fabrizio Castro 2018-09-27 10:45 ` [PATCH v2 0/3] Add can support to RZ/G2M Marc Kleine-Budde 3 siblings, 3 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-10 10:43 UTC (permalink / raw) To: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland Cc: Fabrizio Castro, David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc Document RZ/G2M (r8a774a1) SoC specific bindings. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> --- v1->v2: * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description as per Geert's comments. This patch applies on top of next-20180910. Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt index 94a7f33..f3b160c 100644 --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings Required properties: - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. @@ -16,15 +17,21 @@ Required properties: "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 compatible device. - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 + compatible device. When compatible with the generic version, nodes must list the SoC-specific version corresponding to the platform first followed by the generic version. - reg: physical base address and size of the R-Car CAN register map. - interrupts: interrupt specifier for the sole interrupt. -- clocks: phandles and clock specifiers for 3 CAN clock inputs. -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". +- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2 + devices. + phandles and clock specifiers for 3 CAN clock inputs for every other + SoC. +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk". + 3 clock input name strings for every other SoC: "clkp1", "clkp2", + "can_clk". - pinctrl-0: pin control group to be used for this controller. - pinctrl-names: must be "default". @@ -41,8 +48,9 @@ using the below properties: Optional properties: - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: <0x0> (default) : Peripheral clock (clkp1) - <0x1> : Peripheral clock (clkp2) - <0x3> : Externally input clock + <0x1> : Peripheral clock (clkp2) (not supported by + RZ/G2 devices) + <0x3> : External input clock Example ------- -- 2.7.4 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support 2018-09-10 10:43 ` [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro @ 2018-09-11 13:31 ` Simon Horman 2018-09-24 16:17 ` Rob Herring 2018-11-08 11:25 ` Fabrizio Castro 2 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-09-11 13:31 UTC (permalink / raw) To: Fabrizio Castro Cc: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland, David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc On Mon, Sep 10, 2018 at 11:43:14AM +0100, Fabrizio Castro wrote: > Document RZ/G2M (r8a774a1) SoC specific bindings. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > v1->v2: > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > as per Geert's comments. Reviewed-by: Simon Horman <horms+renesas@verge.net.au> ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support 2018-09-10 10:43 ` [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro 2018-09-11 13:31 ` Simon Horman @ 2018-09-24 16:17 ` Rob Herring 2018-11-08 11:25 ` Fabrizio Castro 2 siblings, 0 replies; 30+ messages in thread From: Rob Herring @ 2018-09-24 16:17 UTC (permalink / raw) To: Fabrizio Castro Cc: Wolfgang Grandegger, Marc Kleine-Budde, Mark Rutland, David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc On Mon, Sep 10, 2018 at 11:43:14AM +0100, Fabrizio Castro wrote: > Document RZ/G2M (r8a774a1) SoC specific bindings. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > v1->v2: > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > as per Geert's comments. > > This patch applies on top of next-20180910. > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support 2018-09-10 10:43 ` [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro @ 2018-11-08 11:25 ` Fabrizio Castro 2018-09-24 16:17 ` Rob Herring 2018-11-08 11:25 ` Fabrizio Castro 2 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-11-08 11:25 UTC (permalink / raw) To: Fabrizio Castro, Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland Cc: David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc Dear All, Who is the best person to take this patch? Thanks, Fab > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Sent: 10 September 2018 11:43 > Subject: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > Document RZ/G2M (r8a774a1) SoC specific bindings. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > v1->v2: > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > as per Geert's comments. > > This patch applies on top of next-20180910. > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt > index 94a7f33..f3b160c 100644 > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings > Required properties: > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. > @@ -16,15 +17,21 @@ Required properties: > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > compatible device. > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 > + compatible device. > When compatible with the generic version, nodes must list the > SoC-specific version corresponding to the platform first > followed by the generic version. > > - reg: physical base address and size of the R-Car CAN register map. > - interrupts: interrupt specifier for the sole interrupt. > -- clocks: phandles and clock specifiers for 3 CAN clock inputs. > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". > +- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2 > + devices. > + phandles and clock specifiers for 3 CAN clock inputs for every other > + SoC. > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk". > + 3 clock input name strings for every other SoC: "clkp1", "clkp2", > + "can_clk". > - pinctrl-0: pin control group to be used for this controller. > - pinctrl-names: must be "default". > > @@ -41,8 +48,9 @@ using the below properties: > Optional properties: > - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: > <0x0> (default) : Peripheral clock (clkp1) > - <0x1> : Peripheral clock (clkp2) > - <0x3> : Externally input clock > + <0x1> : Peripheral clock (clkp2) (not supported by > + RZ/G2 devices) > + <0x3> : External input clock > > Example > ------- > -- > 2.7.4 Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support @ 2018-11-08 11:25 ` Fabrizio Castro 0 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-11-08 11:25 UTC (permalink / raw) To: Fabrizio Castro, Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland Cc: David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc Dear All, Who is the best person to take this patch? Thanks, Fab > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Sent: 10 September 2018 11:43 > Subject: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > Document RZ/G2M (r8a774a1) SoC specific bindings. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > v1->v2: > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > as per Geert's comments. > > This patch applies on top of next-20180910. > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt > index 94a7f33..f3b160c 100644 > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings > Required properties: > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. > @@ -16,15 +17,21 @@ Required properties: > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > compatible device. > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 > + compatible device. > When compatible with the generic version, nodes must list the > SoC-specific version corresponding to the platform first > followed by the generic version. > > - reg: physical base address and size of the R-Car CAN register map. > - interrupts: interrupt specifier for the sole interrupt. > -- clocks: phandles and clock specifiers for 3 CAN clock inputs. > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". > +- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2 > + devices. > + phandles and clock specifiers for 3 CAN clock inputs for every other > + SoC. > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk". > + 3 clock input name strings for every other SoC: "clkp1", "clkp2", > + "can_clk". > - pinctrl-0: pin control group to be used for this controller. > - pinctrl-names: must be "default". > > @@ -41,8 +48,9 @@ using the below properties: > Optional properties: > - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: > <0x0> (default) : Peripheral clock (clkp1) > - <0x1> : Peripheral clock (clkp2) > - <0x3> : Externally input clock > + <0x1> : Peripheral clock (clkp2) (not supported by > + RZ/G2 devices) > + <0x3> : External input clock > > Example > ------- > -- > 2.7.4 Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support 2018-11-08 11:25 ` Fabrizio Castro @ 2018-11-08 12:46 ` Simon Horman -1 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-11-08 12:46 UTC (permalink / raw) To: Fabrizio Castro Cc: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland, David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc On Thu, Nov 08, 2018 at 11:25:23AM +0000, Fabrizio Castro wrote: > Dear All, > > Who is the best person to take this patch? I believe this one is for Marc. > Thanks, > Fab > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Sent: 10 September 2018 11:43 > > Subject: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > > > Document RZ/G2M (r8a774a1) SoC specific bindings. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > v1->v2: > > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > > as per Geert's comments. > > > > This patch applies on top of next-20180910. > > > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > index 94a7f33..f3b160c 100644 > > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings > > Required properties: > > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. > > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. > > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. > > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. > > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. > > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. > > @@ -16,15 +17,21 @@ Required properties: > > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > > compatible device. > > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. > > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 > > + compatible device. > > When compatible with the generic version, nodes must list the > > SoC-specific version corresponding to the platform first > > followed by the generic version. > > > > - reg: physical base address and size of the R-Car CAN register map. > > - interrupts: interrupt specifier for the sole interrupt. > > -- clocks: phandles and clock specifiers for 3 CAN clock inputs. > > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". > > +- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2 > > + devices. > > + phandles and clock specifiers for 3 CAN clock inputs for every other > > + SoC. > > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk". > > + 3 clock input name strings for every other SoC: "clkp1", "clkp2", > > + "can_clk". > > - pinctrl-0: pin control group to be used for this controller. > > - pinctrl-names: must be "default". > > > > @@ -41,8 +48,9 @@ using the below properties: > > Optional properties: > > - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: > > <0x0> (default) : Peripheral clock (clkp1) > > - <0x1> : Peripheral clock (clkp2) > > - <0x3> : Externally input clock > > + <0x1> : Peripheral clock (clkp2) (not supported by > > + RZ/G2 devices) > > + <0x3> : External input clock > > > > Example > > ------- > > -- > > 2.7.4 > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. > ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support @ 2018-11-08 12:46 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-11-08 12:46 UTC (permalink / raw) To: Fabrizio Castro Cc: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland, David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc On Thu, Nov 08, 2018 at 11:25:23AM +0000, Fabrizio Castro wrote: > Dear All, > > Who is the best person to take this patch? I believe this one is for Marc. > Thanks, > Fab > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Sent: 10 September 2018 11:43 > > Subject: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > > > Document RZ/G2M (r8a774a1) SoC specific bindings. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > v1->v2: > > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > > as per Geert's comments. > > > > This patch applies on top of next-20180910. > > > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > index 94a7f33..f3b160c 100644 > > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings > > Required properties: > > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. > > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. > > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. > > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. > > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. > > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. > > @@ -16,15 +17,21 @@ Required properties: > > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > > compatible device. > > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. > > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 > > + compatible device. > > When compatible with the generic version, nodes must list the > > SoC-specific version corresponding to the platform first > > followed by the generic version. > > > > - reg: physical base address and size of the R-Car CAN register map. > > - interrupts: interrupt specifier for the sole interrupt. > > -- clocks: phandles and clock specifiers for 3 CAN clock inputs. > > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". > > +- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2 > > + devices. > > + phandles and clock specifiers for 3 CAN clock inputs for every other > > + SoC. > > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk". > > + 3 clock input name strings for every other SoC: "clkp1", "clkp2", > > + "can_clk". > > - pinctrl-0: pin control group to be used for this controller. > > - pinctrl-names: must be "default". > > > > @@ -41,8 +48,9 @@ using the below properties: > > Optional properties: > > - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: > > <0x0> (default) : Peripheral clock (clkp1) > > - <0x1> : Peripheral clock (clkp2) > > - <0x3> : Externally input clock > > + <0x1> : Peripheral clock (clkp2) (not supported by > > + RZ/G2 devices) > > + <0x3> : External input clock > > > > Example > > ------- > > -- > > 2.7.4 > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. > ^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support 2018-11-08 12:46 ` Simon Horman @ 2018-11-08 14:05 ` Fabrizio Castro -1 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-11-08 14:05 UTC (permalink / raw) To: Simon Horman, Marc Kleine-Budde, Rob Herring Cc: Wolfgang Grandegger, Mark Rutland, David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc Thank you Simon for getting back to me. Marc, does this patch look ok to you? Thanks, Fab > Subject: Re: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > On Thu, Nov 08, 2018 at 11:25:23AM +0000, Fabrizio Castro wrote: > > Dear All, > > > > Who is the best person to take this patch? > > I believe this one is for Marc. > > > Thanks, > > Fab > > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Sent: 10 September 2018 11:43 > > > Subject: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > > > > > Document RZ/G2M (r8a774a1) SoC specific bindings. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > v1->v2: > > > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > > > as per Geert's comments. > > > > > > This patch applies on top of next-20180910. > > > > > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- > > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt > b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > > index 94a7f33..f3b160c 100644 > > > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > > > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings > > > Required properties: > > > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. > > > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. > > > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. > > > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. > > > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. > > > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. > > > @@ -16,15 +17,21 @@ Required properties: > > > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > > > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > > > compatible device. > > > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. > > > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 > > > + compatible device. > > > When compatible with the generic version, nodes must list the > > > SoC-specific version corresponding to the platform first > > > followed by the generic version. > > > > > > - reg: physical base address and size of the R-Car CAN register map. > > > - interrupts: interrupt specifier for the sole interrupt. > > > -- clocks: phandles and clock specifiers for 3 CAN clock inputs. > > > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". > > > +- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2 > > > + devices. > > > + phandles and clock specifiers for 3 CAN clock inputs for every other > > > + SoC. > > > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk". > > > + 3 clock input name strings for every other SoC: "clkp1", "clkp2", > > > + "can_clk". > > > - pinctrl-0: pin control group to be used for this controller. > > > - pinctrl-names: must be "default". > > > > > > @@ -41,8 +48,9 @@ using the below properties: > > > Optional properties: > > > - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: > > > <0x0> (default) : Peripheral clock (clkp1) > > > - <0x1> : Peripheral clock (clkp2) > > > - <0x3> : Externally input clock > > > + <0x1> : Peripheral clock (clkp2) (not supported by > > > + RZ/G2 devices) > > > + <0x3> : External input clock > > > > > > Example > > > ------- > > > -- > > > 2.7.4 > > > > > > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England > & Wales under Registered No. 04586709. > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support @ 2018-11-08 14:05 ` Fabrizio Castro 0 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-11-08 14:05 UTC (permalink / raw) To: Simon Horman, Marc Kleine-Budde, Rob Herring Cc: Wolfgang Grandegger, Mark Rutland, David S. Miller, Sergei Shtylyov, linux-can, linux-kernel, netdev, devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc Thank you Simon for getting back to me. Marc, does this patch look ok to you? Thanks, Fab > Subject: Re: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > On Thu, Nov 08, 2018 at 11:25:23AM +0000, Fabrizio Castro wrote: > > Dear All, > > > > Who is the best person to take this patch? > > I believe this one is for Marc. > > > Thanks, > > Fab > > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Sent: 10 September 2018 11:43 > > > Subject: [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support > > > > > > Document RZ/G2M (r8a774a1) SoC specific bindings. > > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Signed-off-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > v1->v2: > > > * dropped "renesas,rzg-gen2-can" and fixed "clocks" property description > > > as per Geert's comments. > > > > > > This patch applies on top of next-20180910. > > > > > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 18 +++++++++++++----- > > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt > b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > > index 94a7f33..f3b160c 100644 > > > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt > > > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt > > > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings > > > Required properties: > > > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC. > > > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC. > > > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC. > > > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC. > > > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC. > > > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC. > > > @@ -16,15 +17,21 @@ Required properties: > > > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device. > > > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1 > > > compatible device. > > > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device. > > > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2 > > > + compatible device. > > > When compatible with the generic version, nodes must list the > > > SoC-specific version corresponding to the platform first > > > followed by the generic version. > > > > > > - reg: physical base address and size of the R-Car CAN register map. > > > - interrupts: interrupt specifier for the sole interrupt. > > > -- clocks: phandles and clock specifiers for 3 CAN clock inputs. > > > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk". > > > +- clocks: phandles and clock specifiers for 2 CAN clock inputs for RZ/G2 > > > + devices. > > > + phandles and clock specifiers for 3 CAN clock inputs for every other > > > + SoC. > > > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk". > > > + 3 clock input name strings for every other SoC: "clkp1", "clkp2", > > > + "can_clk". > > > - pinctrl-0: pin control group to be used for this controller. > > > - pinctrl-names: must be "default". > > > > > > @@ -41,8 +48,9 @@ using the below properties: > > > Optional properties: > > > - renesas,can-clock-select: R-Car CAN Clock Source Select. Valid values are: > > > <0x0> (default) : Peripheral clock (clkp1) > > > - <0x1> : Peripheral clock (clkp2) > > > - <0x3> : Externally input clock > > > + <0x1> : Peripheral clock (clkp2) (not supported by > > > + RZ/G2 devices) > > > + <0x3> : External input clock > > > > > > Example > > > ------- > > > -- > > > 2.7.4 > > > > > > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England > & Wales under Registered No. 04586709. > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes 2018-09-10 10:43 [PATCH v2 0/3] Add can support to RZ/G2M Fabrizio Castro 2018-09-10 10:43 ` [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration Fabrizio Castro @ 2018-09-10 10:43 ` Fabrizio Castro 2018-09-10 10:43 ` Fabrizio Castro 2018-09-27 10:45 ` [PATCH v2 0/3] Add can support to RZ/G2M Marc Kleine-Budde 3 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-10 10:43 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon Cc: Fabrizio Castro, devicetree, Chris Paterson, Geert Uytterhoeven, Sergei Shtylyov, Magnus Damm, Biju Das, linux-renesas-soc, Simon Horman, linux-arm-kernel From: Chris Paterson <chris.paterson2@renesas.com> Add the device nodes for both RZ/G2M CAN channels. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> --- v1->v2: * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per Geert's comment. This patch applies on top of renesas-devel-20180906-v4.19-rc2. arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index 046fc93..867e875 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -874,6 +874,30 @@ status = "disabled"; }; + can0: can@e6c30000 { + compatible = "renesas,can-r8a774a1", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c30000 0 0x1000>; + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 916>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 916>; + status = "disabled"; + }; + + can1: can@e6c38000 { + compatible = "renesas,can-r8a774a1", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c38000 0 0x1000>; + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 915>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 915>; + status = "disabled"; + }; + pwm0: pwm@e6e30000 { compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; reg = <0 0xe6e30000 0 0x8>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-09-10 10:43 ` Fabrizio Castro 0 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-10 10:43 UTC (permalink / raw) To: linux-arm-kernel From: Chris Paterson <chris.paterson2@renesas.com> Add the device nodes for both RZ/G2M CAN channels. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> --- v1->v2: * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per Geert's comment. This patch applies on top of renesas-devel-20180906-v4.19-rc2. arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index 046fc93..867e875 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -874,6 +874,30 @@ status = "disabled"; }; + can0: can at e6c30000 { + compatible = "renesas,can-r8a774a1", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c30000 0 0x1000>; + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 916>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 916>; + status = "disabled"; + }; + + can1: can at e6c38000 { + compatible = "renesas,can-r8a774a1", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c38000 0 0x1000>; + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 915>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 915>; + status = "disabled"; + }; + pwm0: pwm at e6e30000 { compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; reg = <0 0xe6e30000 0 0x8>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-09-10 10:43 ` Fabrizio Castro 0 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-10 10:43 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon Cc: Chris Paterson, Sergei Shtylyov, Simon Horman, Magnus Damm, linux-renesas-soc, linux-arm-kernel, devicetree, Geert Uytterhoeven, Chris Paterson, Biju Das, Fabrizio Castro From: Chris Paterson <chris.paterson2@renesas.com> Add the device nodes for both RZ/G2M CAN channels. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> --- v1->v2: * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per Geert's comment. This patch applies on top of renesas-devel-20180906-v4.19-rc2. arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index 046fc93..867e875 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -874,6 +874,30 @@ status = "disabled"; }; + can0: can@e6c30000 { + compatible = "renesas,can-r8a774a1", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c30000 0 0x1000>; + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 916>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 916>; + status = "disabled"; + }; + + can1: can@e6c38000 { + compatible = "renesas,can-r8a774a1", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c38000 0 0x1000>; + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 915>, <&can_clk>; + clock-names = "clkp1", "can_clk"; + power-domains = <&sysc 32>; + resets = <&cpg 915>; + status = "disabled"; + }; + pwm0: pwm@e6e30000 { compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; reg = <0 0xe6e30000 0 0x8>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes 2018-09-10 10:43 ` Fabrizio Castro (?) @ 2018-09-11 13:32 ` Simon Horman -1 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-09-11 13:32 UTC (permalink / raw) To: Fabrizio Castro Cc: Mark Rutland, devicetree, Chris Paterson, Magnus Damm, Geert Uytterhoeven, Sergei Shtylyov, Catalin Marinas, Will Deacon, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > From: Chris Paterson <chris.paterson2@renesas.com> > > Add the device nodes for both RZ/G2M CAN channels. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > > v1->v2: > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > Geert's comment. > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. Thanks Fabrizio, I would like to waif for the bindings to be accepted before accepting this patch. > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > index 046fc93..867e875 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > @@ -874,6 +874,30 @@ > status = "disabled"; > }; > > + can0: can@e6c30000 { > + compatible = "renesas,can-r8a774a1", > + "renesas,rcar-gen3-can"; > + reg = <0 0xe6c30000 0 0x1000>; > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 916>, <&can_clk>; > + clock-names = "clkp1", "can_clk"; > + power-domains = <&sysc 32>; > + resets = <&cpg 916>; > + status = "disabled"; > + }; > + > + can1: can@e6c38000 { > + compatible = "renesas,can-r8a774a1", > + "renesas,rcar-gen3-can"; > + reg = <0 0xe6c38000 0 0x1000>; > + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 915>, <&can_clk>; > + clock-names = "clkp1", "can_clk"; > + power-domains = <&sysc 32>; > + resets = <&cpg 915>; > + status = "disabled"; > + }; > + > pwm0: pwm@e6e30000 { > compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; > reg = <0 0xe6e30000 0 0x8>; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-09-11 13:32 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-09-11 13:32 UTC (permalink / raw) To: linux-arm-kernel On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > From: Chris Paterson <chris.paterson2@renesas.com> > > Add the device nodes for both RZ/G2M CAN channels. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > > v1->v2: > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > Geert's comment. > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. Thanks Fabrizio, I would like to waif for the bindings to be accepted before accepting this patch. > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > index 046fc93..867e875 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > @@ -874,6 +874,30 @@ > status = "disabled"; > }; > > + can0: can at e6c30000 { > + compatible = "renesas,can-r8a774a1", > + "renesas,rcar-gen3-can"; > + reg = <0 0xe6c30000 0 0x1000>; > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 916>, <&can_clk>; > + clock-names = "clkp1", "can_clk"; > + power-domains = <&sysc 32>; > + resets = <&cpg 916>; > + status = "disabled"; > + }; > + > + can1: can at e6c38000 { > + compatible = "renesas,can-r8a774a1", > + "renesas,rcar-gen3-can"; > + reg = <0 0xe6c38000 0 0x1000>; > + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 915>, <&can_clk>; > + clock-names = "clkp1", "can_clk"; > + power-domains = <&sysc 32>; > + resets = <&cpg 915>; > + status = "disabled"; > + }; > + > pwm0: pwm at e6e30000 { > compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; > reg = <0 0xe6e30000 0 0x8>; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-09-11 13:32 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-09-11 13:32 UTC (permalink / raw) To: Fabrizio Castro Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Chris Paterson, Sergei Shtylyov, Magnus Damm, linux-renesas-soc, linux-arm-kernel, devicetree, Geert Uytterhoeven, Biju Das On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > From: Chris Paterson <chris.paterson2@renesas.com> > > Add the device nodes for both RZ/G2M CAN channels. > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > > v1->v2: > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > Geert's comment. > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. Thanks Fabrizio, I would like to waif for the bindings to be accepted before accepting this patch. > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > index 046fc93..867e875 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > @@ -874,6 +874,30 @@ > status = "disabled"; > }; > > + can0: can@e6c30000 { > + compatible = "renesas,can-r8a774a1", > + "renesas,rcar-gen3-can"; > + reg = <0 0xe6c30000 0 0x1000>; > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 916>, <&can_clk>; > + clock-names = "clkp1", "can_clk"; > + power-domains = <&sysc 32>; > + resets = <&cpg 916>; > + status = "disabled"; > + }; > + > + can1: can@e6c38000 { > + compatible = "renesas,can-r8a774a1", > + "renesas,rcar-gen3-can"; > + reg = <0 0xe6c38000 0 0x1000>; > + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 915>, <&can_clk>; > + clock-names = "clkp1", "can_clk"; > + power-domains = <&sysc 32>; > + resets = <&cpg 915>; > + status = "disabled"; > + }; > + > pwm0: pwm@e6e30000 { > compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; > reg = <0 0xe6e30000 0 0x8>; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes 2018-09-11 13:32 ` Simon Horman (?) @ 2018-09-27 10:53 ` Fabrizio Castro -1 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-27 10:53 UTC (permalink / raw) To: Simon Horman Cc: Mark Rutland, devicetree, Chris Paterson, Magnus Damm, Geert Uytterhoeven, Sergei Shtylyov, Catalin Marinas, Will Deacon, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel Hello Simon, > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > > > v1->v2: > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > Geert's comment. > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > Thanks Fabrizio, > > I would like to waif for the bindings to be accepted before accepting this > patch. Marc has taken the bindings, I guess we can unblock this patch now? Thanks, Fab > > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > index 046fc93..867e875 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > @@ -874,6 +874,30 @@ > > status = "disabled"; > > }; > > > > +can0: can@e6c30000 { > > +compatible = "renesas,can-r8a774a1", > > + "renesas,rcar-gen3-can"; > > +reg = <0 0xe6c30000 0 0x1000>; > > +interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 916>, <&can_clk>; > > +clock-names = "clkp1", "can_clk"; > > +power-domains = <&sysc 32>; > > +resets = <&cpg 916>; > > +status = "disabled"; > > +}; > > + > > +can1: can@e6c38000 { > > +compatible = "renesas,can-r8a774a1", > > + "renesas,rcar-gen3-can"; > > +reg = <0 0xe6c38000 0 0x1000>; > > +interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 915>, <&can_clk>; > > +clock-names = "clkp1", "can_clk"; > > +power-domains = <&sysc 32>; > > +resets = <&cpg 915>; > > +status = "disabled"; > > +}; > > + > > pwm0: pwm@e6e30000 { > > compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; > > reg = <0 0xe6e30000 0 0x8>; > > -- > > 2.7.4 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-09-27 10:53 ` Fabrizio Castro 0 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-27 10:53 UTC (permalink / raw) To: linux-arm-kernel Hello Simon, > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > > > v1->v2: > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > Geert's comment. > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > Thanks Fabrizio, > > I would like to waif for the bindings to be accepted before accepting this > patch. Marc has taken the bindings, I guess we can unblock this patch now? Thanks, Fab > > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > index 046fc93..867e875 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > @@ -874,6 +874,30 @@ > > status = "disabled"; > > }; > > > > +can0: can at e6c30000 { > > +compatible = "renesas,can-r8a774a1", > > + "renesas,rcar-gen3-can"; > > +reg = <0 0xe6c30000 0 0x1000>; > > +interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 916>, <&can_clk>; > > +clock-names = "clkp1", "can_clk"; > > +power-domains = <&sysc 32>; > > +resets = <&cpg 916>; > > +status = "disabled"; > > +}; > > + > > +can1: can at e6c38000 { > > +compatible = "renesas,can-r8a774a1", > > + "renesas,rcar-gen3-can"; > > +reg = <0 0xe6c38000 0 0x1000>; > > +interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 915>, <&can_clk>; > > +clock-names = "clkp1", "can_clk"; > > +power-domains = <&sysc 32>; > > +resets = <&cpg 915>; > > +status = "disabled"; > > +}; > > + > > pwm0: pwm at e6e30000 { > > compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; > > reg = <0 0xe6e30000 0 0x8>; > > -- > > 2.7.4 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* RE: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-09-27 10:53 ` Fabrizio Castro 0 siblings, 0 replies; 30+ messages in thread From: Fabrizio Castro @ 2018-09-27 10:53 UTC (permalink / raw) To: Simon Horman Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Chris Paterson, Sergei Shtylyov, Magnus Damm, linux-renesas-soc, linux-arm-kernel, devicetree, Geert Uytterhoeven, Biju Das Hello Simon, > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > > > v1->v2: > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > Geert's comment. > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > Thanks Fabrizio, > > I would like to waif for the bindings to be accepted before accepting this > patch. Marc has taken the bindings, I guess we can unblock this patch now? Thanks, Fab > > > > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > index 046fc93..867e875 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > > @@ -874,6 +874,30 @@ > > status = "disabled"; > > }; > > > > +can0: can@e6c30000 { > > +compatible = "renesas,can-r8a774a1", > > + "renesas,rcar-gen3-can"; > > +reg = <0 0xe6c30000 0 0x1000>; > > +interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 916>, <&can_clk>; > > +clock-names = "clkp1", "can_clk"; > > +power-domains = <&sysc 32>; > > +resets = <&cpg 916>; > > +status = "disabled"; > > +}; > > + > > +can1: can@e6c38000 { > > +compatible = "renesas,can-r8a774a1", > > + "renesas,rcar-gen3-can"; > > +reg = <0 0xe6c38000 0 0x1000>; > > +interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 915>, <&can_clk>; > > +clock-names = "clkp1", "can_clk"; > > +power-domains = <&sysc 32>; > > +resets = <&cpg 915>; > > +status = "disabled"; > > +}; > > + > > pwm0: pwm@e6e30000 { > > compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar"; > > reg = <0 0xe6e30000 0 0x8>; > > -- > > 2.7.4 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes 2018-09-27 10:53 ` Fabrizio Castro (?) @ 2018-10-01 12:44 ` Simon Horman -1 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-10-01 12:44 UTC (permalink / raw) To: Fabrizio Castro Cc: Mark Rutland, devicetree, Chris Paterson, Magnus Damm, Geert Uytterhoeven, Sergei Shtylyov, Catalin Marinas, Will Deacon, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel On Thu, Sep 27, 2018 at 10:53:41AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > > > > v1->v2: > > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > > Geert's comment. > > > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > > > Thanks Fabrizio, > > > > I would like to waif for the bindings to be accepted before accepting this > > patch. > > Marc has taken the bindings, I guess we can unblock this patch now? Thanks, applied for v4.21. ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-10-01 12:44 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-10-01 12:44 UTC (permalink / raw) To: linux-arm-kernel On Thu, Sep 27, 2018 at 10:53:41AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > > > > v1->v2: > > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > > Geert's comment. > > > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > > > Thanks Fabrizio, > > > > I would like to waif for the bindings to be accepted before accepting this > > patch. > > Marc has taken the bindings, I guess we can unblock this patch now? Thanks, applied for v4.21. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-10-01 12:44 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-10-01 12:44 UTC (permalink / raw) To: Fabrizio Castro Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Chris Paterson, Sergei Shtylyov, Magnus Damm, linux-renesas-soc, linux-arm-kernel, devicetree, Geert Uytterhoeven, Biju Das On Thu, Sep 27, 2018 at 10:53:41AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > > > > v1->v2: > > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > > Geert's comment. > > > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > > > Thanks Fabrizio, > > > > I would like to waif for the bindings to be accepted before accepting this > > patch. > > Marc has taken the bindings, I guess we can unblock this patch now? Thanks, applied for v4.21. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes 2018-09-27 10:53 ` Fabrizio Castro (?) @ 2018-10-18 13:18 ` Simon Horman -1 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-10-18 13:18 UTC (permalink / raw) To: Fabrizio Castro Cc: Mark Rutland, devicetree, Chris Paterson, Magnus Damm, Geert Uytterhoeven, Sergei Shtylyov, Catalin Marinas, Will Deacon, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel On Thu, Sep 27, 2018 at 10:53:41AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > > > > v1->v2: > > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > > Geert's comment. > > > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > > > Thanks Fabrizio, > > > > I would like to waif for the bindings to be accepted before accepting this > > patch. > > Marc has taken the bindings, I guess we can unblock this patch now? Sorry for letting this slip. Yes, applied for v4.21. ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-10-18 13:18 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-10-18 13:18 UTC (permalink / raw) To: linux-arm-kernel On Thu, Sep 27, 2018 at 10:53:41AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > > > > v1->v2: > > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > > Geert's comment. > > > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > > > Thanks Fabrizio, > > > > I would like to waif for the bindings to be accepted before accepting this > > patch. > > Marc has taken the bindings, I guess we can unblock this patch now? Sorry for letting this slip. Yes, applied for v4.21. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes @ 2018-10-18 13:18 ` Simon Horman 0 siblings, 0 replies; 30+ messages in thread From: Simon Horman @ 2018-10-18 13:18 UTC (permalink / raw) To: Fabrizio Castro Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon, Chris Paterson, Sergei Shtylyov, Magnus Damm, linux-renesas-soc, linux-arm-kernel, devicetree, Geert Uytterhoeven, Biju Das On Thu, Sep 27, 2018 at 10:53:41AM +0000, Fabrizio Castro wrote: > Hello Simon, > > > Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes > > > > On Mon, Sep 10, 2018 at 11:43:15AM +0100, Fabrizio Castro wrote: > > > From: Chris Paterson <chris.paterson2@renesas.com> > > > > > > Add the device nodes for both RZ/G2M CAN channels. > > > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > > --- > > > > > > v1->v2: > > > * replaced "renesas,rzg-gen2-can" with "renesas,rcar-gen3-can" as per > > > Geert's comment. > > > > > > This patch applies on top of renesas-devel-20180906-v4.19-rc2. > > > > Thanks Fabrizio, > > > > I would like to waif for the bindings to be accepted before accepting this > > patch. > > Marc has taken the bindings, I guess we can unblock this patch now? Sorry for letting this slip. Yes, applied for v4.21. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH v2 0/3] Add can support to RZ/G2M 2018-09-10 10:43 [PATCH v2 0/3] Add can support to RZ/G2M Fabrizio Castro ` (2 preceding siblings ...) 2018-09-10 10:43 ` Fabrizio Castro @ 2018-09-27 10:45 ` Marc Kleine-Budde 3 siblings, 0 replies; 30+ messages in thread From: Marc Kleine-Budde @ 2018-09-27 10:45 UTC (permalink / raw) To: Fabrizio Castro, Wolfgang Grandegger, Rob Herring, Mark Rutland Cc: David S. Miller, Sergei Shtylyov, Simon Horman, Magnus Damm, Chris Paterson, linux-can, netdev, devicetree, linux-renesas-soc, linux-kernel, Geert Uytterhoeven, Biju Das [-- Attachment #1.1: Type: text/plain, Size: 532 bytes --] On 09/10/2018 12:43 PM, Fabrizio Castro wrote: > Dear All, > > this series contains all that's necessary to add CAN support > for RZ/G2M (a.k.a. r8a774a1). > > v1-v2: > * applied Geert's comments Added 1/3 and 2/3 to linux-can. Tnx. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2018-11-08 14:05 UTC | newest] Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-09-10 10:43 [PATCH v2 0/3] Add can support to RZ/G2M Fabrizio Castro 2018-09-10 10:43 ` [PATCH v2 1/3][can-next] can: rcar_can: Fix erroneous registration Fabrizio Castro 2018-09-11 13:31 ` Simon Horman 2018-11-08 12:39 ` Fabrizio Castro 2018-11-08 13:20 ` Simon Horman 2018-09-10 10:43 ` [PATCH v2 2/3] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro 2018-09-11 13:31 ` Simon Horman 2018-09-24 16:17 ` Rob Herring 2018-11-08 11:25 ` Fabrizio Castro 2018-11-08 11:25 ` Fabrizio Castro 2018-11-08 12:46 ` Simon Horman 2018-11-08 12:46 ` Simon Horman 2018-11-08 14:05 ` Fabrizio Castro 2018-11-08 14:05 ` Fabrizio Castro 2018-09-10 10:43 ` [PATCH v2 3/3] arm64: dts: renesas: r8a774a1: Add CAN nodes Fabrizio Castro 2018-09-10 10:43 ` Fabrizio Castro 2018-09-10 10:43 ` Fabrizio Castro 2018-09-11 13:32 ` Simon Horman 2018-09-11 13:32 ` Simon Horman 2018-09-11 13:32 ` Simon Horman 2018-09-27 10:53 ` Fabrizio Castro 2018-09-27 10:53 ` Fabrizio Castro 2018-09-27 10:53 ` Fabrizio Castro 2018-10-01 12:44 ` Simon Horman 2018-10-01 12:44 ` Simon Horman 2018-10-01 12:44 ` Simon Horman 2018-10-18 13:18 ` Simon Horman 2018-10-18 13:18 ` Simon Horman 2018-10-18 13:18 ` Simon Horman 2018-09-27 10:45 ` [PATCH v2 0/3] Add can support to RZ/G2M Marc Kleine-Budde
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.