From: Borislav Petkov <bp@alien8.de> To: "Luck, Tony" <tony.luck@intel.com> Cc: Justin Ernst <justin.ernst@hpe.com>, russ.anderson@hpe.com, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Raise maximum number of memory controllers Date: Tue, 25 Sep 2018 20:07:33 +0200 [thread overview] Message-ID: <20180925180458.GG23986@zn.tnic> (raw) In-Reply-To: <20180925175023.GA16725@agluck-desk> On Tue, Sep 25, 2018 at 10:50:23AM -0700, Luck, Tony wrote: > There are way too many places where we use the identifier "bus" > in the edac core and drivers. But I'm not sure that we need a > static array mc_bus[EDAC_MAX_MCS]. That, of course, is another way of looking at it which I didn't think of. > Why can't we: > > > - mci->bus = &mc_bus[mci->mc_idx]; > + mci->bus = kmalloc(sizeof *(mci->bus), GFP_KERNEL); > > and then figure out where to kfree(mci->bus) on driver removal? AFAICT, in _edac_mc_free(). We free there mci itself so kfree(mci->bus) can happen directly before it. > Do we every do arithmetic on different mci->bus pointers that > assume they are all part of a single array? AFAICT, we use that thing for the bus_reg/unreg functions and we hand it back'n'forth in edac_mc_sysfs.c, see $ git grep -E "mci.*bus" drivers/edac/ drivers/edac/edac_mc.c:763: mci->bus = &mc_bus[mci->mc_idx]; drivers/edac/edac_mc_sysfs.c:408: csrow->dev.bus = mci->bus; drivers/edac/edac_mc_sysfs.c:639: dimm->dev.bus = mci->bus; drivers/edac/edac_mc_sysfs.c:928: mci->bus->name = name; drivers/edac/edac_mc_sysfs.c:930: edac_dbg(0, "creating bus %s\n", mci->bus->name); drivers/edac/edac_mc_sysfs.c:932: err = bus_register(mci->bus); drivers/edac/edac_mc_sysfs.c:943: mci->dev.bus = mci->bus; drivers/edac/edac_mc_sysfs.c:1002: bus_unregister(mci->bus); drivers/edac/edac_mc_sysfs.c:1035: struct bus_type *bus = mci->bus; drivers/edac/edac_mc_sysfs.c:1036: const char *name = mci->bus->name; drivers/edac/edac_mc_sysfs.c:1071: mci_pdev->bus = edac_get_sysfs_subsys(); drivers/edac/i5100_edac.c:967: priv->debugfs = edac_debugfs_create_dir_at(mci->bus->name, i5100_debugfs); drivers/edac/i7core_edac.c:1170: pvt->addrmatch_dev->bus = mci->dev.bus; drivers/edac/i7core_edac.c:1191: pvt->chancounts_dev->bus = mci->dev.bus; HOWEVER, look at 88d84ac97378 ("EDAC: Fix lockdep splat") Now I remember. I did that for lockdep because it wants statically allocated memory. I'll try to think of something tomorrow. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de> To: "Luck, Tony" <tony.luck@intel.com> Cc: Justin Ernst <justin.ernst@hpe.com>, russ.anderson@hpe.com, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Raise maximum number of memory controllers Date: Tue, 25 Sep 2018 20:07:33 +0200 [thread overview] Message-ID: <20180925180458.GG23986@zn.tnic> (raw) On Tue, Sep 25, 2018 at 10:50:23AM -0700, Luck, Tony wrote: > There are way too many places where we use the identifier "bus" > in the edac core and drivers. But I'm not sure that we need a > static array mc_bus[EDAC_MAX_MCS]. That, of course, is another way of looking at it which I didn't think of. > Why can't we: > > > - mci->bus = &mc_bus[mci->mc_idx]; > + mci->bus = kmalloc(sizeof *(mci->bus), GFP_KERNEL); > > and then figure out where to kfree(mci->bus) on driver removal? AFAICT, in _edac_mc_free(). We free there mci itself so kfree(mci->bus) can happen directly before it. > Do we every do arithmetic on different mci->bus pointers that > assume they are all part of a single array? AFAICT, we use that thing for the bus_reg/unreg functions and we hand it back'n'forth in edac_mc_sysfs.c, see $ git grep -E "mci.*bus" drivers/edac/ drivers/edac/edac_mc.c:763: mci->bus = &mc_bus[mci->mc_idx]; drivers/edac/edac_mc_sysfs.c:408: csrow->dev.bus = mci->bus; drivers/edac/edac_mc_sysfs.c:639: dimm->dev.bus = mci->bus; drivers/edac/edac_mc_sysfs.c:928: mci->bus->name = name; drivers/edac/edac_mc_sysfs.c:930: edac_dbg(0, "creating bus %s\n", mci->bus->name); drivers/edac/edac_mc_sysfs.c:932: err = bus_register(mci->bus); drivers/edac/edac_mc_sysfs.c:943: mci->dev.bus = mci->bus; drivers/edac/edac_mc_sysfs.c:1002: bus_unregister(mci->bus); drivers/edac/edac_mc_sysfs.c:1035: struct bus_type *bus = mci->bus; drivers/edac/edac_mc_sysfs.c:1036: const char *name = mci->bus->name; drivers/edac/edac_mc_sysfs.c:1071: mci_pdev->bus = edac_get_sysfs_subsys(); drivers/edac/i5100_edac.c:967: priv->debugfs = edac_debugfs_create_dir_at(mci->bus->name, i5100_debugfs); drivers/edac/i7core_edac.c:1170: pvt->addrmatch_dev->bus = mci->dev.bus; drivers/edac/i7core_edac.c:1191: pvt->chancounts_dev->bus = mci->dev.bus; HOWEVER, look at 88d84ac97378 ("EDAC: Fix lockdep splat") Now I remember. I did that for lockdep because it wants statically allocated memory. I'll try to think of something tomorrow. Thx.
next prev parent reply other threads:[~2018-09-25 18:07 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-25 14:34 [PATCH] Raise maximum number of memory controllers Justin Ernst 2018-09-25 14:34 ` Justin Ernst 2018-09-25 15:26 ` [PATCH] " Borislav Petkov 2018-09-25 15:26 ` Borislav Petkov 2018-09-25 17:50 ` [PATCH] " Luck, Tony 2018-09-25 17:50 ` Luck, Tony 2018-09-25 18:07 ` Borislav Petkov [this message] 2018-09-25 18:07 ` Borislav Petkov 2018-09-26 9:35 ` [PATCH] " Borislav Petkov 2018-09-26 9:35 ` Borislav Petkov 2018-09-26 15:27 ` [PATCH] " Borislav Petkov 2018-09-26 15:27 ` Borislav Petkov 2018-09-26 16:03 ` [PATCH] " Mauro Carvalho Chehab 2018-09-26 16:03 ` Mauro Carvalho Chehab 2018-09-26 16:17 ` [PATCH] " Borislav Petkov 2018-09-26 16:17 ` Borislav Petkov 2018-09-26 17:39 ` [PATCH] " Mauro Carvalho Chehab 2018-09-26 17:39 ` Mauro Carvalho Chehab 2018-09-26 18:10 ` [PATCH] " Luck, Tony 2018-09-26 18:10 ` Luck, Tony 2018-09-26 18:23 ` [PATCH] " Russ Anderson 2018-09-26 18:23 ` Russ Anderson 2018-09-26 23:02 ` [PATCH] " Luck, Tony 2018-09-26 23:02 ` Luck, Tony 2018-09-27 4:52 ` [PATCH] " Borislav Petkov 2018-09-27 4:52 ` Borislav Petkov 2018-09-27 21:44 ` [PATCH] " Luck, Tony 2018-09-27 21:44 ` Luck, Tony 2018-09-27 22:03 ` [PATCH] " Borislav Petkov 2018-09-27 22:03 ` Borislav Petkov 2018-09-28 1:10 ` [PATCH] " Mauro Carvalho Chehab 2018-09-28 1:10 ` Mauro Carvalho Chehab 2018-10-01 12:47 ` [PATCH] " Borislav Petkov 2018-10-01 12:47 ` Borislav Petkov 2018-10-01 22:43 ` [PATCH] EDAC: Don't add devices under /sys/bus/edac Luck, Tony 2018-10-01 22:43 ` Luck, Tony 2018-10-02 1:22 ` [PATCH] " Mauro Carvalho Chehab 2018-10-02 1:22 ` Mauro Carvalho Chehab 2018-10-02 15:51 ` [PATCH] " Ernst, Justin 2018-10-02 15:51 ` Justin Ernst 2018-10-02 16:26 ` [PATCH] " Borislav Petkov 2018-10-02 16:26 ` Borislav Petkov 2018-11-06 14:45 ` [PATCH] " Borislav Petkov 2018-11-06 14:45 ` Borislav Petkov 2018-11-13 19:09 ` [PATCH] " Ernst, Justin 2018-11-13 19:09 ` Justin Ernst 2018-11-13 19:15 ` [PATCH] " Borislav Petkov 2018-11-13 19:15 ` Borislav Petkov 2018-09-26 7:55 ` [PATCH] Raise maximum number of memory controllers Zhuo, Qiuxu 2018-09-26 7:55 ` Qiuxu Zhuo 2018-09-26 13:53 ` [PATCH] " Russ Anderson 2018-09-26 13:53 ` Russ Anderson 2018-09-26 16:13 ` [PATCH] " Aristeu Rozanski 2018-09-26 16:13 ` Aristeu Rozanski 2018-09-27 5:56 ` [PATCH] " Borislav Petkov 2018-09-27 5:56 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180925180458.GG23986@zn.tnic \ --to=bp@alien8.de \ --cc=justin.ernst@hpe.com \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=russ.anderson@hpe.com \ --cc=tony.luck@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.