All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ernst, Justin" <justin.ernst@hpe.com>
To: Borislav Petkov <bp@alien8.de>, "Luck, Tony" <tony.luck@intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"Anderson, Russ" <russ.anderson@hpe.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Aristeu Rozanski Filho" <arozansk@redhat.com>,
	"Ernst, Justin" <justin.ernst@hpe.com>
Subject: RE: [PATCH] EDAC: Don't add devices under /sys/bus/edac
Date: Tue, 13 Nov 2018 19:09:24 +0000	[thread overview]
Message-ID: <AT5PR8401MB0371BD98A030E08B1A1833A787C20@AT5PR8401MB0371.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20181106144535.GI13712@zn.tnic>

Looks good on a 32 socket system. All 64 memory controllers show up and I'm able to see the same sysfs diff.
Thanks
-Justin

> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Tuesday, November 6, 2018 8:46 AM
> To: Ernst, Justin <justin.ernst@hpe.com>; Luck, Tony <tony.luck@intel.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>; Anderson, Russ
> <russ.anderson@hpe.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; linux-edac@vger.kernel.org; linux-
> kernel@vger.kernel.org; Aristeu Rozanski Filho <arozansk@redhat.com>
> Subject: Re: [PATCH] EDAC: Don't add devices under /sys/bus/edac
> 
> On Tue, Oct 02, 2018 at 06:26:08PM +0200, Borislav Petkov wrote:
> > On Tue, Oct 02, 2018 at 03:51:41PM +0000, Ernst, Justin wrote:
> > > The combined patches work on a 20 socket system.
> > > Thanks!
> >
> > Cool, thanks for testing.
> >
> > Nevertheless, I'll queue them for 4.21 so that we have a full cycle of
> > testing before we really kill the bus thing.
> 
> Ok, I've pushed the two patches ontop of EDAC's for-next branch, here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-
> 4.21-bus
> 
> and I'd appreciate testing them one more time on the big boxes you guys
> have.
> 
> Diffing sysfs here shows this:
> 
> --- edac.before	2018-11-06 13:37:37.925448609 +0100
> +++ edac.after	2018-11-06 15:36:11.229497795 +0100
> @@ -37,7 +37,6 @@
>  /sys/devices/system/edac/mc/mc0/dimm3/power/control
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_dev_type
>  /sys/devices/system/edac/mc/mc0/dimm3/size
> -/sys/devices/system/edac/mc/mc0/dimm3/subsystem
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_label
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_location
> 
> which is the bus symlink:
> 
> subsystem -> ../../../../../../bus/mc0
> 
> and I think that's ok as nothing should be using it.
> 
> Thx.
> 
> --
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.

WARNING: multiple messages have this Message-ID (diff)
From: Justin Ernst <justin.ernst@hpe.com>
To: Borislav Petkov <bp@alien8.de>, "Luck, Tony" <tony.luck@intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"Anderson, Russ" <russ.anderson@hpe.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Aristeu Rozanski Filho <arozansk@redhat.com>,
	"Ernst, Justin" <justin.ernst@hpe.com>
Subject: EDAC: Don't add devices under /sys/bus/edac
Date: Tue, 13 Nov 2018 19:09:24 +0000	[thread overview]
Message-ID: <AT5PR8401MB0371BD98A030E08B1A1833A787C20@AT5PR8401MB0371.NAMPRD84.PROD.OUTLOOK.COM> (raw)

Looks good on a 32 socket system. All 64 memory controllers show up and I'm able to see the same sysfs diff.
Thanks
-Justin

> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Tuesday, November 6, 2018 8:46 AM
> To: Ernst, Justin <justin.ernst@hpe.com>; Luck, Tony <tony.luck@intel.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>; Anderson, Russ
> <russ.anderson@hpe.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; linux-edac@vger.kernel.org; linux-
> kernel@vger.kernel.org; Aristeu Rozanski Filho <arozansk@redhat.com>
> Subject: Re: [PATCH] EDAC: Don't add devices under /sys/bus/edac
> 
> On Tue, Oct 02, 2018 at 06:26:08PM +0200, Borislav Petkov wrote:
> > On Tue, Oct 02, 2018 at 03:51:41PM +0000, Ernst, Justin wrote:
> > > The combined patches work on a 20 socket system.
> > > Thanks!
> >
> > Cool, thanks for testing.
> >
> > Nevertheless, I'll queue them for 4.21 so that we have a full cycle of
> > testing before we really kill the bus thing.
> 
> Ok, I've pushed the two patches ontop of EDAC's for-next branch, here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-
> 4.21-bus
> 
> and I'd appreciate testing them one more time on the big boxes you guys
> have.
> 
> Diffing sysfs here shows this:
> 
> --- edac.before	2018-11-06 13:37:37.925448609 +0100
> +++ edac.after	2018-11-06 15:36:11.229497795 +0100
> @@ -37,7 +37,6 @@
>  /sys/devices/system/edac/mc/mc0/dimm3/power/control
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_dev_type
>  /sys/devices/system/edac/mc/mc0/dimm3/size
> -/sys/devices/system/edac/mc/mc0/dimm3/subsystem
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_label
>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_location
> 
> which is the bus symlink:
> 
> subsystem -> ../../../../../../bus/mc0
> 
> and I think that's ok as nothing should be using it.
> 
> Thx.
> 
> --
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2018-11-13 19:09 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 14:34 [PATCH] Raise maximum number of memory controllers Justin Ernst
2018-09-25 14:34 ` Justin Ernst
2018-09-25 15:26 ` [PATCH] " Borislav Petkov
2018-09-25 15:26   ` Borislav Petkov
2018-09-25 17:50   ` [PATCH] " Luck, Tony
2018-09-25 17:50     ` Luck, Tony
2018-09-25 18:07     ` [PATCH] " Borislav Petkov
2018-09-25 18:07       ` Borislav Petkov
2018-09-26  9:35       ` [PATCH] " Borislav Petkov
2018-09-26  9:35         ` Borislav Petkov
2018-09-26 15:27         ` [PATCH] " Borislav Petkov
2018-09-26 15:27           ` Borislav Petkov
2018-09-26 16:03           ` [PATCH] " Mauro Carvalho Chehab
2018-09-26 16:03             ` Mauro Carvalho Chehab
2018-09-26 16:17             ` [PATCH] " Borislav Petkov
2018-09-26 16:17               ` Borislav Petkov
2018-09-26 17:39               ` [PATCH] " Mauro Carvalho Chehab
2018-09-26 17:39                 ` Mauro Carvalho Chehab
2018-09-26 18:10               ` [PATCH] " Luck, Tony
2018-09-26 18:10                 ` Luck, Tony
2018-09-26 18:23                 ` [PATCH] " Russ Anderson
2018-09-26 18:23                   ` Russ Anderson
2018-09-26 23:02                   ` [PATCH] " Luck, Tony
2018-09-26 23:02                     ` Luck, Tony
2018-09-27  4:52                     ` [PATCH] " Borislav Petkov
2018-09-27  4:52                       ` Borislav Petkov
2018-09-27 21:44                       ` [PATCH] " Luck, Tony
2018-09-27 21:44                         ` Luck, Tony
2018-09-27 22:03                         ` [PATCH] " Borislav Petkov
2018-09-27 22:03                           ` Borislav Petkov
2018-09-28  1:10                           ` [PATCH] " Mauro Carvalho Chehab
2018-09-28  1:10                             ` Mauro Carvalho Chehab
2018-10-01 12:47                             ` [PATCH] " Borislav Petkov
2018-10-01 12:47                               ` Borislav Petkov
2018-10-01 22:43                               ` [PATCH] EDAC: Don't add devices under /sys/bus/edac Luck, Tony
2018-10-01 22:43                                 ` Luck, Tony
2018-10-02  1:22                                 ` [PATCH] " Mauro Carvalho Chehab
2018-10-02  1:22                                   ` Mauro Carvalho Chehab
2018-10-02 15:51                                   ` [PATCH] " Ernst, Justin
2018-10-02 15:51                                     ` Justin Ernst
2018-10-02 16:26                                     ` [PATCH] " Borislav Petkov
2018-10-02 16:26                                       ` Borislav Petkov
2018-11-06 14:45                                       ` [PATCH] " Borislav Petkov
2018-11-06 14:45                                         ` Borislav Petkov
2018-11-13 19:09                                         ` Ernst, Justin [this message]
2018-11-13 19:09                                           ` Justin Ernst
2018-11-13 19:15                                           ` [PATCH] " Borislav Petkov
2018-11-13 19:15                                             ` Borislav Petkov
2018-09-26  7:55 ` [PATCH] Raise maximum number of memory controllers Zhuo, Qiuxu
2018-09-26  7:55   ` Qiuxu Zhuo
2018-09-26 13:53   ` [PATCH] " Russ Anderson
2018-09-26 13:53     ` Russ Anderson
2018-09-26 16:13 ` [PATCH] " Aristeu Rozanski
2018-09-26 16:13   ` Aristeu Rozanski
2018-09-27  5:56 ` [PATCH] " Borislav Petkov
2018-09-27  5:56   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AT5PR8401MB0371BD98A030E08B1A1833A787C20@AT5PR8401MB0371.NAMPRD84.PROD.OUTLOOK.COM \
    --to=justin.ernst@hpe.com \
    --cc=arozansk@redhat.com \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=russ.anderson@hpe.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.