* [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
@ 2018-10-01 7:16 Juergen Gross
0 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-10-01 7:16 UTC (permalink / raw)
To: linux-kernel, xen-devel, x86
Cc: Juergen Gross, Waiman.Long, peterz, mingo, bp, hpa,
boris.ostrovsky, tglx
The Xen specific queue spinlock wait function has two issues which
could result in a hanging system.
They have a similar root cause of clearing a pending wakeup of a
waiting vcpu and later going to sleep waiting for the just cleared
wakeup event, which of course won't ever happen.
Juergen Gross (2):
xen: fix race in xen_qlock_wait()
xen: make xen_qlock_wait() nestable
arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
1 file changed, 12 insertions(+), 21 deletions(-)
Cc: Waiman.Long@hp.com
Cc: peterz@infradead.org
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
@ 2018-10-01 7:16 Juergen Gross
2018-10-01 7:37 ` Juergen Gross
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Juergen Gross @ 2018-10-01 7:16 UTC (permalink / raw)
To: linux-kernel, xen-devel, x86
Cc: boris.ostrovsky, hpa, tglx, mingo, bp, Juergen Gross,
Waiman.Long, peterz
The Xen specific queue spinlock wait function has two issues which
could result in a hanging system.
They have a similar root cause of clearing a pending wakeup of a
waiting vcpu and later going to sleep waiting for the just cleared
wakeup event, which of course won't ever happen.
Juergen Gross (2):
xen: fix race in xen_qlock_wait()
xen: make xen_qlock_wait() nestable
arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
1 file changed, 12 insertions(+), 21 deletions(-)
Cc: Waiman.Long@hp.com
Cc: peterz@infradead.org
--
2.16.4
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
2018-10-01 7:16 Juergen Gross
@ 2018-10-01 7:37 ` Juergen Gross
2018-10-01 7:37 ` Juergen Gross
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-10-01 7:37 UTC (permalink / raw)
To: linux-kernel, xen-devel, x86
Cc: peterz, mingo, Borislav Petkov, hpa, Waiman Long, boris.ostrovsky, tglx
Correcting Waiman's mail address
On 01/10/2018 09:16, Juergen Gross wrote:
> The Xen specific queue spinlock wait function has two issues which
> could result in a hanging system.
>
> They have a similar root cause of clearing a pending wakeup of a
> waiting vcpu and later going to sleep waiting for the just cleared
> wakeup event, which of course won't ever happen.
>
> Juergen Gross (2):
> xen: fix race in xen_qlock_wait()
> xen: make xen_qlock_wait() nestable
>
> arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
> 1 file changed, 12 insertions(+), 21 deletions(-)
>
> Cc: longman@redhat.com
> Cc: peterz@infradead.org
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
2018-10-01 7:16 Juergen Gross
2018-10-01 7:37 ` Juergen Gross
@ 2018-10-01 7:37 ` Juergen Gross
2018-10-09 14:40 ` David Woodhouse
2018-10-09 14:40 ` David Woodhouse
3 siblings, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-10-01 7:37 UTC (permalink / raw)
To: linux-kernel, xen-devel, x86
Cc: boris.ostrovsky, hpa, tglx, mingo, Borislav Petkov, peterz, Waiman Long
Correcting Waiman's mail address
On 01/10/2018 09:16, Juergen Gross wrote:
> The Xen specific queue spinlock wait function has two issues which
> could result in a hanging system.
>
> They have a similar root cause of clearing a pending wakeup of a
> waiting vcpu and later going to sleep waiting for the just cleared
> wakeup event, which of course won't ever happen.
>
> Juergen Gross (2):
> xen: fix race in xen_qlock_wait()
> xen: make xen_qlock_wait() nestable
>
> arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
> 1 file changed, 12 insertions(+), 21 deletions(-)
>
> Cc: longman@redhat.com
> Cc: peterz@infradead.org
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
2018-10-01 7:16 Juergen Gross
2018-10-01 7:37 ` Juergen Gross
2018-10-01 7:37 ` Juergen Gross
@ 2018-10-09 14:40 ` David Woodhouse
2018-10-09 14:40 ` David Woodhouse
3 siblings, 0 replies; 8+ messages in thread
From: David Woodhouse @ 2018-10-09 14:40 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel, x86
Cc: Waiman.Long, peterz, mingo, bp, hpa, boris.ostrovsky, tglx
[-- Attachment #1.1: Type: text/plain, Size: 720 bytes --]
On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote:
> The Xen specific queue spinlock wait function has two issues which
> could result in a hanging system.
>
> They have a similar root cause of clearing a pending wakeup of a
> waiting vcpu and later going to sleep waiting for the just cleared
> wakeup event, which of course won't ever happen.
>
> Juergen Gross (2):
> xen: fix race in xen_qlock_wait()
> xen: make xen_qlock_wait() nestable
>
> arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
> 1 file changed, 12 insertions(+), 21 deletions(-)
>
> Cc: Waiman.Long@hp.com
> Cc: peterz@infradead.org
LGTM. Both these should be Cc:stable@vger.kernel.org, yes?
Thanks.
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
2018-10-01 7:16 Juergen Gross
` (2 preceding siblings ...)
2018-10-09 14:40 ` David Woodhouse
@ 2018-10-09 14:40 ` David Woodhouse
2018-10-09 14:52 ` Juergen Gross
2018-10-09 14:52 ` Juergen Gross
3 siblings, 2 replies; 8+ messages in thread
From: David Woodhouse @ 2018-10-09 14:40 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel, x86
Cc: boris.ostrovsky, hpa, tglx, mingo, bp, Waiman.Long, peterz
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote:
> The Xen specific queue spinlock wait function has two issues which
> could result in a hanging system.
>
> They have a similar root cause of clearing a pending wakeup of a
> waiting vcpu and later going to sleep waiting for the just cleared
> wakeup event, which of course won't ever happen.
>
> Juergen Gross (2):
> xen: fix race in xen_qlock_wait()
> xen: make xen_qlock_wait() nestable
>
> arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
> 1 file changed, 12 insertions(+), 21 deletions(-)
>
> Cc: Waiman.Long@hp.com
> Cc: peterz@infradead.org
LGTM. Both these should be Cc:stable@vger.kernel.org, yes?
Thanks.
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
2018-10-09 14:40 ` David Woodhouse
@ 2018-10-09 14:52 ` Juergen Gross
2018-10-09 14:52 ` Juergen Gross
1 sibling, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-10-09 14:52 UTC (permalink / raw)
To: David Woodhouse, linux-kernel, xen-devel, x86
Cc: Waiman.Long, peterz, mingo, bp, hpa, boris.ostrovsky, tglx
On 09/10/2018 16:40, David Woodhouse wrote:
> On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote:
>> The Xen specific queue spinlock wait function has two issues which
>> could result in a hanging system.
>>
>> They have a similar root cause of clearing a pending wakeup of a
>> waiting vcpu and later going to sleep waiting for the just cleared
>> wakeup event, which of course won't ever happen.
>>
>> Juergen Gross (2):
>> xen: fix race in xen_qlock_wait()
>> xen: make xen_qlock_wait() nestable
>>
>> arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
>> 1 file changed, 12 insertions(+), 21 deletions(-)
>>
>> Cc: Waiman.Long@hp.com
>> Cc: peterz@infradead.org
>
> LGTM. Both these should be Cc:stable@vger.kernel.org, yes?
Yes, they are.
I have them already queued in the Xen tree. As the bug is rather
old I didn't want to rush the patches in so late in the rc phase of
4.19.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling
2018-10-09 14:40 ` David Woodhouse
2018-10-09 14:52 ` Juergen Gross
@ 2018-10-09 14:52 ` Juergen Gross
1 sibling, 0 replies; 8+ messages in thread
From: Juergen Gross @ 2018-10-09 14:52 UTC (permalink / raw)
To: David Woodhouse, linux-kernel, xen-devel, x86
Cc: boris.ostrovsky, hpa, tglx, mingo, bp, Waiman.Long, peterz
On 09/10/2018 16:40, David Woodhouse wrote:
> On Mon, 2018-10-01 at 09:16 +0200, Juergen Gross wrote:
>> The Xen specific queue spinlock wait function has two issues which
>> could result in a hanging system.
>>
>> They have a similar root cause of clearing a pending wakeup of a
>> waiting vcpu and later going to sleep waiting for the just cleared
>> wakeup event, which of course won't ever happen.
>>
>> Juergen Gross (2):
>> xen: fix race in xen_qlock_wait()
>> xen: make xen_qlock_wait() nestable
>>
>> arch/x86/xen/spinlock.c | 33 ++++++++++++---------------------
>> 1 file changed, 12 insertions(+), 21 deletions(-)
>>
>> Cc: Waiman.Long@hp.com
>> Cc: peterz@infradead.org
>
> LGTM. Both these should be Cc:stable@vger.kernel.org, yes?
Yes, they are.
I have them already queued in the Xen tree. As the bug is rather
old I didn't want to rush the patches in so late in the rc phase of
4.19.
Juergen
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-10-09 14:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 7:16 [PATCH 0/2] xen: fix two issues in Xen pv qspinlock handling Juergen Gross
2018-10-01 7:16 Juergen Gross
2018-10-01 7:37 ` Juergen Gross
2018-10-01 7:37 ` Juergen Gross
2018-10-09 14:40 ` David Woodhouse
2018-10-09 14:40 ` David Woodhouse
2018-10-09 14:52 ` Juergen Gross
2018-10-09 14:52 ` Juergen Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.