All of lore.kernel.org
 help / color / mirror / Atom feed
* [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
@ 2018-10-06 13:57 Bhanusree Pola
  2018-10-06 14:07 ` [Outreachy Kernel][PATCH v4] " Bhanusree
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Bhanusree Pola @ 2018-10-06 13:57 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Adjust all lines exceeding 75 chars per line to fix checkpatch warning.

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
changes in v4:
-Remove Whitespace in comment section of module_comedi_pci_driver()
 to fix checkpatch Error.

changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
 Adjust the chars to 75 per line
-Modified log message.
-Added change log.

changes in v2:
-comedi_pci_auto_config() function prototype is exceeds 
 75 characters per line. Adjust to 75 chars to improve 
 readability and also adjust the arguments to match open 
 parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
 characters. Modified contents to adjust 75 chars per line.

 drivers/staging/comedi/comedi_pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
index 1cc5436cb415..7291d3c0b7dc 100644
--- a/drivers/staging/comedi/comedi_pci.h
+++ b/drivers/staging/comedi/comedi_pci.h
@@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
 				  struct pci_driver *pci_driver);
 
 /**
- * module_comedi_pci_driver()-Helper macro for registering a comedi PCI 
+ * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
  * driver
  * @__comedi_driver: comedi_driver struct
  * @__pci_driver: pci_driver struct
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [Outreachy Kernel][PATCH v4] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 13:57 [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line Bhanusree Pola
@ 2018-10-06 14:07 ` Bhanusree
  2018-10-06 17:55 ` [Outreachy kernel] [Outreachy Kernel][PATCH v3] " Himanshu Jha
  2018-10-06 17:59 ` Himanshu Jha
  2 siblings, 0 replies; 14+ messages in thread
From: Bhanusree @ 2018-10-06 14:07 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman



On Saturday 06 October 2018 07:27 PM, Bhanusree Pola wrote:

> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
> changes in v4:
> -Remove Whitespace in comment section of module_comedi_pci_driver()
>   to fix checkpatch Error.
>
> changes in v3:
> -Comment section of module_pci_driver() exceeds 75 characters.
>   Adjust the chars to 75 per line
> -Modified log message.
> -Added change log.
>
> changes in v2:
> -comedi_pci_auto_config() function prototype is exceeds
>   75 characters per line. Adjust to 75 chars to improve
>   readability and also adjust the arguments to match open
>   parantheses.
> -Comment section of module_comedi_pci_driver() exceeds 75
>   characters. Modified contents to adjust 75 chars per line.
>
>   drivers/staging/comedi/comedi_pci.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 1cc5436cb415..7291d3c0b7dc 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
>   				  struct pci_driver *pci_driver);
>   
>   /**
> - * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
> + * module_comedi_pci_driver()-Helper macro for registering a comedi PCI
>    * driver
>    * @__comedi_driver: comedi_driver struct
>    * @__pci_driver: pci_driver struct


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 13:57 [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line Bhanusree Pola
  2018-10-06 14:07 ` [Outreachy Kernel][PATCH v4] " Bhanusree
@ 2018-10-06 17:55 ` Himanshu Jha
       [not found]   ` <68d61f32-294d-6056-7b3d-a89735bc539f@gmail.com>
  2018-10-06 17:59 ` Himanshu Jha
  2 siblings, 1 reply; 14+ messages in thread
From: Himanshu Jha @ 2018-10-06 17:55 UTC (permalink / raw)
  To: julia.lawall; +Cc: outreachy-kernel, gregkh

On Sat, Oct 06, 2018 at 07:27:52PM +0530, Bhanusree Pola wrote:
> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
> 
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---

Your subject says v3 but changelog says v4 ...

> changes in v4:
> -Remove Whitespace in comment section of module_comedi_pci_driver()
>  to fix checkpatch Error.
> 
> changes in v3:
> -Comment section of module_pci_driver() exceeds 75 characters.
>  Adjust the chars to 75 per line
> -Modified log message.
> -Added change log.
> 
> changes in v2:
> -comedi_pci_auto_config() function prototype is exceeds 
>  75 characters per line. Adjust to 75 chars to improve 
>  readability and also adjust the arguments to match open 
>  parantheses.
> -Comment section of module_comedi_pci_driver() exceeds 75
>  characters. Modified contents to adjust 75 chars per line.
> 
>  drivers/staging/comedi/comedi_pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
> index 1cc5436cb415..7291d3c0b7dc 100644
> --- a/drivers/staging/comedi/comedi_pci.h
> +++ b/drivers/staging/comedi/comedi_pci.h
> @@ -42,7 +42,7 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
>  				  struct pci_driver *pci_driver);
>  
>  /**
> - * module_comedi_pci_driver()-Helper macro for registering a comedi PCI 
> + * module_comedi_pci_driver()-Helper macro for registering a comedi PCI

The change is identical ?
Use `git rebase` to fixup and send again.


>   * driver
>   * @__comedi_driver: comedi_driver struct
>   * @__pci_driver: pci_driver struct
> -- 
> 2.17.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006135752.GA3037%40veda-VGN-CS3AGH-R.
> For more options, visit https://groups.google.com/d/optout.

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 13:57 [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line Bhanusree Pola
  2018-10-06 14:07 ` [Outreachy Kernel][PATCH v4] " Bhanusree
  2018-10-06 17:55 ` [Outreachy kernel] [Outreachy Kernel][PATCH v3] " Himanshu Jha
@ 2018-10-06 17:59 ` Himanshu Jha
  2018-10-06 18:05   ` Bhanusree
  2 siblings, 1 reply; 14+ messages in thread
From: Himanshu Jha @ 2018-10-06 17:59 UTC (permalink / raw)
  To: Bhanusree Pola; +Cc: outreachy-kernel, gregkh

On Sat, Oct 06, 2018 at 07:27:52PM +0530, Bhanusree Pola wrote:
> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
> 

Would you mind explaining this:

from:	Bhanusree Pola <bhanusreemahesh@gmail.com>
reply-to:	himanshujha199640@gmail.com
to:	outreachy-kernel@googlegroups.com
cc:	bhanusreemahesh@gmail.com,
gregkh@linuxfoundation.org
date:	6 Oct 2018, 16:44
subject:	[Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
mailing list:	outreachy-kernel@googlegroups.com Filter messages from this mailing list
mailed-by:	googlegroups.com
Signed by:	gmail.com

"reply-to" ?

Please check your email settings!

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 17:59 ` Himanshu Jha
@ 2018-10-06 18:05   ` Bhanusree
  2018-10-06 18:13     ` Himanshu Jha
  0 siblings, 1 reply; 14+ messages in thread
From: Bhanusree @ 2018-10-06 18:05 UTC (permalink / raw)
  To: Himanshu Jha; +Cc: outreachy-kernel, gregkh



On Saturday 06 October 2018 11:29 PM, Himanshu Jha wrote:
> On Sat, Oct 06, 2018 at 07:27:52PM +0530, Bhanusree Pola wrote:
>> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
>>
> Would you mind explaining this:
>
> from:	Bhanusree Pola <bhanusreemahesh@gmail.com>
> reply-to:	himanshujha199640@gmail.com
> to:	outreachy-kernel@googlegroups.com
> cc:	bhanusreemahesh@gmail.com,
> gregkh@linuxfoundation.org
> date:	6 Oct 2018, 16:44
> subject:	[Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
> mailing list:	outreachy-kernel@googlegroups.com Filter messages from this mailing list
> mailed-by:	googlegroups.com
> Signed by:	gmail.com
>
> "reply-to" ?
>
> >Please check your email settings!
>
I did not understand.What was the mistake i have done ? shouldn't I 
mention "reply-to" in specific ?


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
       [not found]     ` <20181006180243.GG6283@himanshu-Vostro-3559>
@ 2018-10-06 18:12       ` Bhanusree
  2018-10-06 18:27         ` Himanshu Jha
  0 siblings, 1 reply; 14+ messages in thread
From: Bhanusree @ 2018-10-06 18:12 UTC (permalink / raw)
  To: Himanshu Jha; +Cc: outreachy-kernel, gregkh

>Then please state that reasoning in subject too ...

>Subject: [PATCH v4] .... 


>---
>changelog:

>v4: corrected whitespace error.
>v3: ...
>v2: ...

I made changes mentioned and sent already with Subject:[PATCH v4]. Am I 
supposed to send it again?

On Saturday 06 October 2018 11:32 PM, Himanshu Jha wrote:
> On Sat, Oct 06, 2018 at 11:28:36PM +0530, Bhanusree wrote:
>> Change is not identical. In v3 whitespace error is observed. So corrected it
>> and sent as v4 again.
> Then please state that reasoning in subject too ...
>
> Subject: [PATCH v4] ....
>
>
> ---
> changelog:
>
> v4: corrected whitespace error.
> v3: ...
> v2: ...
>
> And use 'reply-all` please!
>



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 18:05   ` Bhanusree
@ 2018-10-06 18:13     ` Himanshu Jha
  2018-10-06 18:15       ` Bhanusree
  0 siblings, 1 reply; 14+ messages in thread
From: Himanshu Jha @ 2018-10-06 18:13 UTC (permalink / raw)
  To: Bhanusree; +Cc: outreachy-kernel, gregkh

On Sat, Oct 06, 2018 at 11:35:34PM +0530, Bhanusree wrote:
> 
> 
> On Saturday 06 October 2018 11:29 PM, Himanshu Jha wrote:
> > On Sat, Oct 06, 2018 at 07:27:52PM +0530, Bhanusree Pola wrote:
> > > Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
> > > 
> > Would you mind explaining this:
> > 
> > from:	Bhanusree Pola <bhanusreemahesh@gmail.com>
> > reply-to:	himanshujha199640@gmail.com
> > to:	outreachy-kernel@googlegroups.com
> > cc:	bhanusreemahesh@gmail.com,
> > gregkh@linuxfoundation.org
> > date:	6 Oct 2018, 16:44
> > subject:	[Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
> > mailing list:	outreachy-kernel@googlegroups.com Filter messages from this mailing list
> > mailed-by:	googlegroups.com
> > Signed by:	gmail.com
> > 
> > "reply-to" ?
> > 
> > >Please check your email settings!
> > 
> I did not understand.What was the mistake i have done ? shouldn't I mention
> "reply-to" in specific ?

Lookout for the purpose for "reply-to".

If someone replies to this thread, that reply would go to address
mentioned in the "reply-to" which is currently my email address.

reply-to:	himanshujha199640@gmail.com

I hope I'm clear now.

You can add *your* secondary address in reply-to if you want to
receive the reply at that specified address.

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 18:13     ` Himanshu Jha
@ 2018-10-06 18:15       ` Bhanusree
  0 siblings, 0 replies; 14+ messages in thread
From: Bhanusree @ 2018-10-06 18:15 UTC (permalink / raw)
  To: Himanshu Jha; +Cc: outreachy-kernel, gregkh

Thank you.


On Saturday 06 October 2018 11:43 PM, Himanshu Jha wrote:
> On Sat, Oct 06, 2018 at 11:35:34PM +0530, Bhanusree wrote:
>>
>> On Saturday 06 October 2018 11:29 PM, Himanshu Jha wrote:
>>> On Sat, Oct 06, 2018 at 07:27:52PM +0530, Bhanusree Pola wrote:
>>>> Adjust all lines exceeding 75 chars per line to fix checkpatch warning.
>>>>
>>> Would you mind explaining this:
>>>
>>> from:	Bhanusree Pola <bhanusreemahesh@gmail.com>
>>> reply-to:	himanshujha199640@gmail.com
>>> to:	outreachy-kernel@googlegroups.com
>>> cc:	bhanusreemahesh@gmail.com,
>>> gregkh@linuxfoundation.org
>>> date:	6 Oct 2018, 16:44
>>> subject:	[Outreachy kernel][PATCH v2]staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
>>> mailing list:	outreachy-kernel@googlegroups.com Filter messages from this mailing list
>>> mailed-by:	googlegroups.com
>>> Signed by:	gmail.com
>>>
>>> "reply-to" ?
>>>
>>>> Please check your email settings!
>> I did not understand.What was the mistake i have done ? shouldn't I mention
>> "reply-to" in specific ?
> Lookout for the purpose for "reply-to".
>
> If someone replies to this thread, that reply would go to address
> mentioned in the "reply-to" which is currently my email address.
>
> reply-to:	himanshujha199640@gmail.com
>
> I hope I'm clear now.
>
> You can add *your* secondary address in reply-to if you want to
> receive the reply at that specified address.
>



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 18:12       ` Bhanusree
@ 2018-10-06 18:27         ` Himanshu Jha
  2018-10-06 18:29           ` Bhanusree
  0 siblings, 1 reply; 14+ messages in thread
From: Himanshu Jha @ 2018-10-06 18:27 UTC (permalink / raw)
  To: Bhanusree; +Cc: outreachy-kernel, gregkh

On Sat, Oct 06, 2018 at 11:42:16PM +0530, Bhanusree wrote:
> > Then please state that reasoning in subject too ...
> 
> > Subject: [PATCH v4] ....
> 
> 
> > ---
> > changelog:
> 
> > v4: corrected whitespace error.
> > v3: ...
> > v2: ...
> 
> I made changes mentioned and sent already with Subject:[PATCH v4]. Am I
> supposed to send it again?

Ah, I see.

Subject: [Outreachy kernel] Re: [Outreachy Kernel][PATCH v4] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line

You send the patch as a "Re:" as you forgot to use `get_maintainer`
in the first place.

Took me some time to figure that out.

And I think this is not the correct way.

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 18:27         ` Himanshu Jha
@ 2018-10-06 18:29           ` Bhanusree
  2018-10-06 18:32             ` Himanshu Jha
  0 siblings, 1 reply; 14+ messages in thread
From: Bhanusree @ 2018-10-06 18:29 UTC (permalink / raw)
  To: Himanshu Jha; +Cc: outreachy-kernel, gregkh

Please let me know what to do on this ?


On Saturday 06 October 2018 11:57 PM, Himanshu Jha wrote:
> On Sat, Oct 06, 2018 at 11:42:16PM +0530, Bhanusree wrote:
>>> Then please state that reasoning in subject too ...
>>> Subject: [PATCH v4] ....
>>
>>> ---
>>> changelog:
>>> v4: corrected whitespace error.
>>> v3: ...
>>> v2: ...
>> I made changes mentioned and sent already with Subject:[PATCH v4]. Am I
>> supposed to send it again?
> Ah, I see.
>
> Subject: [Outreachy kernel] Re: [Outreachy Kernel][PATCH v4] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
>
> You send the patch as a "Re:" as you forgot to use `get_maintainer`
> in the first place.
>
> Took me some time to figure that out.
>
> And I think this is not the correct way.
>



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 18:29           ` Bhanusree
@ 2018-10-06 18:32             ` Himanshu Jha
  2018-10-06 18:48               ` Bhanusree
  0 siblings, 1 reply; 14+ messages in thread
From: Himanshu Jha @ 2018-10-06 18:32 UTC (permalink / raw)
  To: Bhanusree; +Cc: outreachy-kernel, gregkh

On Sat, Oct 06, 2018 at 11:59:02PM +0530, Bhanusree wrote:
> Please let me know what to do on this ?

Send a new patch with v5 with changelog.

And don't top-post!


-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 18:32             ` Himanshu Jha
@ 2018-10-06 18:48               ` Bhanusree
  2018-10-06 18:53                 ` Julia Lawall
  0 siblings, 1 reply; 14+ messages in thread
From: Bhanusree @ 2018-10-06 18:48 UTC (permalink / raw)
  To: Himanshu Jha; +Cc: outreachy-kernel, gregkh



On Sunday 07 October 2018 12:02 AM, Himanshu Jha wrote:
> On Sat, Oct 06, 2018 at 11:59:02PM +0530, Bhanusree wrote:
>> Please let me know what to do on this ?
> > Send a new patch with v5 with changelog.
Can I mention 'No changes in v5' in change log or am I supposed to 
mention any ?


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [Outreachy kernel] [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
  2018-10-06 18:48               ` Bhanusree
@ 2018-10-06 18:53                 ` Julia Lawall
  0 siblings, 0 replies; 14+ messages in thread
From: Julia Lawall @ 2018-10-06 18:53 UTC (permalink / raw)
  To: Bhanusree; +Cc: Himanshu Jha, outreachy-kernel, gregkh



On Sun, 7 Oct 2018, Bhanusree wrote:

>
>
> On Sunday 07 October 2018 12:02 AM, Himanshu Jha wrote:
> > On Sat, Oct 06, 2018 at 11:59:02PM +0530, Bhanusree wrote:
> > > Please let me know what to do on this ?
> > > Send a new patch with v5 with changelog.
> Can I mention 'No changes in v5' in change log or am I supposed to mention any
> ?

Your comments about the changes in the version go under the --- so that
they don't appear in the change log.  If there are no changes in some
cases, then you should mention that.

julia

>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/4e37d6bc-9b6f-f128-38fc-8fca295573d4%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Outreachy kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line
@ 2018-10-06 13:28 Bhanusree Pola
  0 siblings, 0 replies; 14+ messages in thread
From: Bhanusree Pola @ 2018-10-06 13:28 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: bhanusreemahesh, gregkh

Adjust all lines exceeding 75 chars per line to fix checkpatch warning.

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
changes in v3:
-Comment section of module_pci_driver() exceeds 75 characters.
 Adjust the chars to 75 per line
-Modified log message.
-Added change log.

changes in v2:
-comedi_pci_auto_config() function prototype is exceeds 
 75 characters per line. Adjust to 75 chars to improve 
 readability and also adjust the arguments to match open 
 parantheses.
-Comment section of module_comedi_pci_driver() exceeds 75
 characters. Modified contents to adjust 75 chars per line.

 drivers/staging/comedi/comedi_pci.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h
index d89273e43cea..1cc5436cb415 100644
--- a/drivers/staging/comedi/comedi_pci.h
+++ b/drivers/staging/comedi/comedi_pci.h
@@ -42,7 +42,8 @@ void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
 				  struct pci_driver *pci_driver);
 
 /**
- * module_comedi_pci_driver()-Helper macro to register a comedi PCI driver
+ * module_comedi_pci_driver()-Helper macro for registering a comedi PCI 
+ * driver
  * @__comedi_driver: comedi_driver struct
  * @__pci_driver: pci_driver struct
  *
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2018-10-06 18:53 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-06 13:57 [Outreachy Kernel][PATCH v3] staging:comedi:comedi_pci.h Prefer a maximum 75 chars per line Bhanusree Pola
2018-10-06 14:07 ` [Outreachy Kernel][PATCH v4] " Bhanusree
2018-10-06 17:55 ` [Outreachy kernel] [Outreachy Kernel][PATCH v3] " Himanshu Jha
     [not found]   ` <68d61f32-294d-6056-7b3d-a89735bc539f@gmail.com>
     [not found]     ` <20181006180243.GG6283@himanshu-Vostro-3559>
2018-10-06 18:12       ` Bhanusree
2018-10-06 18:27         ` Himanshu Jha
2018-10-06 18:29           ` Bhanusree
2018-10-06 18:32             ` Himanshu Jha
2018-10-06 18:48               ` Bhanusree
2018-10-06 18:53                 ` Julia Lawall
2018-10-06 17:59 ` Himanshu Jha
2018-10-06 18:05   ` Bhanusree
2018-10-06 18:13     ` Himanshu Jha
2018-10-06 18:15       ` Bhanusree
  -- strict thread matches above, loose matches on Subject: below --
2018-10-06 13:28 [Outreachy kernel][PATCH " Bhanusree Pola

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.