* [PATCH] staging: erofs: adds a space around '*'
@ 2018-10-08 11:45 ` Daeseok Youn
0 siblings, 0 replies; 6+ messages in thread
From: Daeseok Youn @ 2018-10-08 11:45 UTC (permalink / raw)
To: Gao Xiang, Chao Yu, Greg Kroah-Hartman, linux-erofs, devel, linux-kernel
fix checkpatch.pl error:
ERROR: need consistent spacing around '*' (ctx:WxV)
+ memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c
index f5b665f..501cfe0 100644
--- a/drivers/staging/erofs/unzip_vle_lz4.c
+++ b/drivers/staging/erofs/unzip_vle_lz4.c
@@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
for (i = 0; i < clusterpages; ++i) {
void *t = kmap_atomic(compressed_pages[i]);
- memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
+ memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
kunmap_atomic(t);
}
} else if (clusterpages == 1)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] staging: erofs: adds a space around '*'
@ 2018-10-08 11:45 ` Daeseok Youn
0 siblings, 0 replies; 6+ messages in thread
From: Daeseok Youn @ 2018-10-08 11:45 UTC (permalink / raw)
fix checkpatch.pl error:
ERROR: need consistent spacing around '*' (ctx:WxV)
+ memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com>
---
drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c
index f5b665f..501cfe0 100644
--- a/drivers/staging/erofs/unzip_vle_lz4.c
+++ b/drivers/staging/erofs/unzip_vle_lz4.c
@@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
for (i = 0; i < clusterpages; ++i) {
void *t = kmap_atomic(compressed_pages[i]);
- memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
+ memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
kunmap_atomic(t);
}
} else if (clusterpages == 1)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: erofs: adds a space around '*'
2018-10-08 11:45 ` Daeseok Youn
@ 2018-10-08 12:36 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-08 12:36 UTC (permalink / raw)
To: Daeseok Youn, Gao Xiang, Chao Yu, Greg Kroah-Hartman,
linux-erofs, devel, linux-kernel
Hi,
On 10/8/18 1:45 PM, Daeseok Youn wrote:
> fix checkpatch.pl error:
> ERROR: need consistent spacing around '*' (ctx:WxV)
> + memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c
> index f5b665f..501cfe0 100644
> --- a/drivers/staging/erofs/unzip_vle_lz4.c
> +++ b/drivers/staging/erofs/unzip_vle_lz4.c
> @@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
> for (i = 0; i < clusterpages; ++i) {
> void *t = kmap_atomic(compressed_pages[i]);
>
> - memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> + memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
> kunmap_atomic(t);
> }
> } else if (clusterpages == 1)
>
This exact fix was applied to linux-next some days ago:
commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc
Make sure you are working from linux-next rather than from mainline.
See this link: https://www.kernel.org/doc/man-pages/linux-next.html
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] staging: erofs: adds a space around '*'
@ 2018-10-08 12:36 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-08 12:36 UTC (permalink / raw)
Hi,
On 10/8/18 1:45 PM, Daeseok Youn wrote:
> fix checkpatch.pl error:
> ERROR: need consistent spacing around '*' (ctx:WxV)
> + memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
>
> Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com>
> ---
> drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c
> index f5b665f..501cfe0 100644
> --- a/drivers/staging/erofs/unzip_vle_lz4.c
> +++ b/drivers/staging/erofs/unzip_vle_lz4.c
> @@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
> for (i = 0; i < clusterpages; ++i) {
> void *t = kmap_atomic(compressed_pages[i]);
>
> - memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> + memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
> kunmap_atomic(t);
> }
> } else if (clusterpages == 1)
>
This exact fix was applied to linux-next some days ago:
commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc
Make sure you are working from linux-next rather than from mainline.
See this link: https://www.kernel.org/doc/man-pages/linux-next.html
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: erofs: adds a space around '*'
2018-10-08 12:36 ` Gustavo A. R. Silva
@ 2018-10-09 7:31 ` DaeSeok Youn
-1 siblings, 0 replies; 6+ messages in thread
From: DaeSeok Youn @ 2018-10-09 7:31 UTC (permalink / raw)
To: gustavo; +Cc: Gao Xiang, Chao Yu, Greg KH, linux-erofs, devel, linux-kernel
2018년 10월 8일 (월) 오후 9:37, Gustavo A. R. Silva <gustavo@embeddedor.com>님이 작성:
>
> Hi,
>
> On 10/8/18 1:45 PM, Daeseok Youn wrote:
> > fix checkpatch.pl error:
> > ERROR: need consistent spacing around '*' (ctx:WxV)
> > + memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> >
> > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> > ---
> > drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c
> > index f5b665f..501cfe0 100644
> > --- a/drivers/staging/erofs/unzip_vle_lz4.c
> > +++ b/drivers/staging/erofs/unzip_vle_lz4.c
> > @@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
> > for (i = 0; i < clusterpages; ++i) {
> > void *t = kmap_atomic(compressed_pages[i]);
> >
> > - memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> > + memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
> > kunmap_atomic(t);
> > }
> > } else if (clusterpages == 1)
> >
>
Hi Gustavo,
Thanks for letting me know the patch.
> This exact fix was applied to linux-next some days ago:
>
> commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc
yes, you're right.
>
> Make sure you are working from linux-next rather than from mainline.
I got the linux kernel source from the staging-next tree than
linux-next. I knew that the patches related to staging should be
merged into staging-tree first. But I didn't update the source tree to
get latest.
>
> See this link: https://www.kernel.org/doc/man-pages/linux-next.html
>
Thanks.
Regards,
Daeseok Youn.
> Thanks
> --
> Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] staging: erofs: adds a space around '*'
@ 2018-10-09 7:31 ` DaeSeok Youn
0 siblings, 0 replies; 6+ messages in thread
From: DaeSeok Youn @ 2018-10-09 7:31 UTC (permalink / raw)
2018? 10? 8? (?) ?? 9:37, Gustavo A. R. Silva <gustavo at embeddedor.com>?? ??:
>
> Hi,
>
> On 10/8/18 1:45 PM, Daeseok Youn wrote:
> > fix checkpatch.pl error:
> > ERROR: need consistent spacing around '*' (ctx:WxV)
> > + memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> >
> > Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com>
> > ---
> > drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/erofs/unzip_vle_lz4.c
> > index f5b665f..501cfe0 100644
> > --- a/drivers/staging/erofs/unzip_vle_lz4.c
> > +++ b/drivers/staging/erofs/unzip_vle_lz4.c
> > @@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed_pages,
> > for (i = 0; i < clusterpages; ++i) {
> > void *t = kmap_atomic(compressed_pages[i]);
> >
> > - memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> > + memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
> > kunmap_atomic(t);
> > }
> > } else if (clusterpages == 1)
> >
>
Hi Gustavo,
Thanks for letting me know the patch.
> This exact fix was applied to linux-next some days ago:
>
> commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc
yes, you're right.
>
> Make sure you are working from linux-next rather than from mainline.
I got the linux kernel source from the staging-next tree than
linux-next. I knew that the patches related to staging should be
merged into staging-tree first. But I didn't update the source tree to
get latest.
>
> See this link: https://www.kernel.org/doc/man-pages/linux-next.html
>
Thanks.
Regards,
Daeseok Youn.
> Thanks
> --
> Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-09 7:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 11:45 [PATCH] staging: erofs: adds a space around '*' Daeseok Youn
2018-10-08 11:45 ` Daeseok Youn
2018-10-08 12:36 ` Gustavo A. R. Silva
2018-10-08 12:36 ` Gustavo A. R. Silva
2018-10-09 7:31 ` DaeSeok Youn
2018-10-09 7:31 ` DaeSeok Youn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.