From: Jean-Philippe Brucker <jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, tnowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org, mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org Subject: [PATCH v3 0/7] Add virtio-iommu driver Date: Fri, 12 Oct 2018 15:59:10 +0100 [thread overview] Message-ID: <20181012145917.6840-1-jean-philippe.brucker@arm.com> (raw) Implement the virtio-iommu driver, following specification v0.8 [1]. Changes since v2 [2]: * Patches 2-4 allow virtio-iommu to use the PCI transport, since QEMU would like to phase out the MMIO transport. This produces a complex topology where the programming interface of the IOMMU could appear lower than the endpoints that it translates. It's not unheard of (e.g. AMD IOMMU), and the guest easily copes with this. The "Firmware description" section of the specification has been updated with all combinations of PCI, MMIO and DT, ACPI. * Fix structures layout, they don't need the "packed" attribute anymore. * While we're at it, add domain parameter to DETACH request, and leave some padding. This way the next version, that adds PASID support, won't have to introduce a "DETACH2" request to stay backward compatible. * Require virtio device 1.0+. Remove legacy transport notes from the specification. * Request timeout is now only enabled with DEBUG. * The patch for VFIO Kconfig (previously patch 5/5) is in next. You can find Linux driver and kvmtool device on branches virtio-iommu/v0.8 [3] (currently based on 4.19-rc7 but rebasing onto next only produced a trivial conflict). Branch virtio-iommu/devel contains a few patches that I'd like to send once the base is upstream: * virtio-iommu as a module. It got *much* nicer after Rob's probe deferral rework, but I still have a bug to fix when re-loading the virtio-iommu module. * ACPI support requires a minor IORT spec update (reservation of node ID). I think it should be easier to obtain once the device and drivers are upstream. [1] Virtio-iommu specification v0.8, diff from v0.7, and sources git://linux-arm.org/virtio-iommu.git virtio-iommu/v0.8 http://jpbrucker.net/virtio-iommu/spec/v0.8/virtio-iommu-v0.8.pdf http://jpbrucker.net/virtio-iommu/spec/diffs/virtio-iommu-pdf-diff-v0.7-v0.8.pdf [2] [PATCH v2 0/5] Add virtio-iommu driver https://www.spinics.net/lists/kvm/msg170655.html [3] git://linux-arm.org/linux-jpb.git virtio-iommu/v0.8 git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.8 Jean-Philippe Brucker (7): dt-bindings: virtio-mmio: Add IOMMU description dt-bindings: virtio: Add virtio-pci-iommu node PCI: OF: allow endpoints to bypass the iommu PCI: OF: Initialize dev->fwnode appropriately iommu: Add virtio-iommu driver iommu/virtio: Add probe request iommu/virtio: Add event queue .../devicetree/bindings/virtio/iommu.txt | 66 + .../devicetree/bindings/virtio/mmio.txt | 30 + MAINTAINERS | 7 + drivers/iommu/Kconfig | 11 + drivers/iommu/Makefile | 1 + drivers/iommu/virtio-iommu.c | 1171 +++++++++++++++++ drivers/pci/of.c | 14 +- include/uapi/linux/virtio_ids.h | 1 + include/uapi/linux/virtio_iommu.h | 159 +++ 9 files changed, 1457 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/virtio/iommu.txt create mode 100644 drivers/iommu/virtio-iommu.c create mode 100644 include/uapi/linux/virtio_iommu.h -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> To: iommu@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org Cc: linux-pci@vger.kernel.org, kvmarm@lists.cs.columbia.edu, peter.maydell@linaro.org, joro@8bytes.org, mst@redhat.com, jasowang@redhat.com, robh+dt@kernel.org, mark.rutland@arm.com, eric.auger@redhat.com, tnowicki@caviumnetworks.com, kevin.tian@intel.com, marc.zyngier@arm.com, robin.murphy@arm.com, will.deacon@arm.com, lorenzo.pieralisi@arm.com Subject: [PATCH v3 0/7] Add virtio-iommu driver Date: Fri, 12 Oct 2018 15:59:10 +0100 [thread overview] Message-ID: <20181012145917.6840-1-jean-philippe.brucker@arm.com> (raw) Implement the virtio-iommu driver, following specification v0.8 [1]. Changes since v2 [2]: * Patches 2-4 allow virtio-iommu to use the PCI transport, since QEMU would like to phase out the MMIO transport. This produces a complex topology where the programming interface of the IOMMU could appear lower than the endpoints that it translates. It's not unheard of (e.g. AMD IOMMU), and the guest easily copes with this. The "Firmware description" section of the specification has been updated with all combinations of PCI, MMIO and DT, ACPI. * Fix structures layout, they don't need the "packed" attribute anymore. * While we're at it, add domain parameter to DETACH request, and leave some padding. This way the next version, that adds PASID support, won't have to introduce a "DETACH2" request to stay backward compatible. * Require virtio device 1.0+. Remove legacy transport notes from the specification. * Request timeout is now only enabled with DEBUG. * The patch for VFIO Kconfig (previously patch 5/5) is in next. You can find Linux driver and kvmtool device on branches virtio-iommu/v0.8 [3] (currently based on 4.19-rc7 but rebasing onto next only produced a trivial conflict). Branch virtio-iommu/devel contains a few patches that I'd like to send once the base is upstream: * virtio-iommu as a module. It got *much* nicer after Rob's probe deferral rework, but I still have a bug to fix when re-loading the virtio-iommu module. * ACPI support requires a minor IORT spec update (reservation of node ID). I think it should be easier to obtain once the device and drivers are upstream. [1] Virtio-iommu specification v0.8, diff from v0.7, and sources git://linux-arm.org/virtio-iommu.git virtio-iommu/v0.8 http://jpbrucker.net/virtio-iommu/spec/v0.8/virtio-iommu-v0.8.pdf http://jpbrucker.net/virtio-iommu/spec/diffs/virtio-iommu-pdf-diff-v0.7-v0.8.pdf [2] [PATCH v2 0/5] Add virtio-iommu driver https://www.spinics.net/lists/kvm/msg170655.html [3] git://linux-arm.org/linux-jpb.git virtio-iommu/v0.8 git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.8 Jean-Philippe Brucker (7): dt-bindings: virtio-mmio: Add IOMMU description dt-bindings: virtio: Add virtio-pci-iommu node PCI: OF: allow endpoints to bypass the iommu PCI: OF: Initialize dev->fwnode appropriately iommu: Add virtio-iommu driver iommu/virtio: Add probe request iommu/virtio: Add event queue .../devicetree/bindings/virtio/iommu.txt | 66 + .../devicetree/bindings/virtio/mmio.txt | 30 + MAINTAINERS | 7 + drivers/iommu/Kconfig | 11 + drivers/iommu/Makefile | 1 + drivers/iommu/virtio-iommu.c | 1171 +++++++++++++++++ drivers/pci/of.c | 14 +- include/uapi/linux/virtio_ids.h | 1 + include/uapi/linux/virtio_iommu.h | 159 +++ 9 files changed, 1457 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/virtio/iommu.txt create mode 100644 drivers/iommu/virtio-iommu.c create mode 100644 include/uapi/linux/virtio_iommu.h -- 2.19.1
next reply other threads:[~2018-10-12 14:59 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-12 14:59 Jean-Philippe Brucker [this message] 2018-10-12 14:59 ` [PATCH v3 0/7] Add virtio-iommu driver Jean-Philippe Brucker 2018-10-12 14:59 ` [PATCH v3 1/7] dt-bindings: virtio-mmio: Add IOMMU description Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-18 0:30 ` Rob Herring [not found] ` <20181012145917.6840-2-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> 2018-10-18 0:30 ` Rob Herring 2018-10-18 0:30 ` Rob Herring 2018-11-15 8:45 ` Auger Eric 2018-11-15 8:45 ` Auger Eric 2018-10-12 14:59 ` [PATCH v3 2/7] dt-bindings: virtio: Add virtio-pci-iommu node Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-18 0:35 ` Rob Herring 2018-10-18 0:35 ` Rob Herring 2018-10-18 0:35 ` Rob Herring 2018-11-15 8:45 ` Auger Eric 2018-11-15 8:45 ` Auger Eric 2018-11-15 8:45 ` Auger Eric 2018-10-12 14:59 ` [PATCH v3 3/7] PCI: OF: Allow endpoints to bypass the iommu Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker [not found] ` <20181012145917.6840-4-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> 2018-10-12 19:41 ` Bjorn Helgaas 2018-10-12 19:41 ` Bjorn Helgaas 2018-10-15 10:52 ` Michael S. Tsirkin 2018-10-15 11:32 ` Robin Murphy [not found] ` <20181012194158.GX5906-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org> 2018-10-15 10:52 ` Michael S. Tsirkin 2018-10-15 10:52 ` Michael S. Tsirkin [not found] ` <20181015065024-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-10-15 19:46 ` Jean-philippe Brucker 2018-10-15 19:46 ` Jean-philippe Brucker 2018-10-17 15:14 ` Michael S. Tsirkin 2018-10-17 15:14 ` Michael S. Tsirkin 2018-10-18 10:47 ` Robin Murphy 2018-10-18 10:47 ` Robin Murphy 2018-10-18 10:47 ` Robin Murphy [not found] ` <20181017111100-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-10-22 11:27 ` Jean-Philippe Brucker 2018-10-22 11:27 ` Jean-Philippe Brucker 2018-10-22 11:27 ` Jean-Philippe Brucker 2018-10-15 11:32 ` Robin Murphy 2018-10-15 11:32 ` Robin Murphy 2018-10-15 19:45 ` Jean-philippe Brucker 2018-10-15 19:45 ` Jean-philippe Brucker 2018-10-12 14:59 ` [PATCH v3 4/7] PCI: OF: Initialize dev->fwnode appropriately Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker [not found] ` <20181012145917.6840-5-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> 2018-10-12 19:44 ` Bjorn Helgaas 2018-10-12 19:44 ` Bjorn Helgaas 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 14:59 ` [PATCH v3 5/7] iommu: Add virtio-iommu driver Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 16:35 ` Michael S. Tsirkin 2018-10-12 16:35 ` Michael S. Tsirkin 2018-10-12 16:35 ` Michael S. Tsirkin [not found] ` <20181012120953-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-10-12 18:54 ` Jean-Philippe Brucker 2018-10-12 18:54 ` Jean-Philippe Brucker 2018-10-12 18:54 ` Jean-Philippe Brucker 2018-11-08 14:51 ` Auger Eric 2018-11-08 14:51 ` Auger Eric 2018-11-08 16:46 ` Jean-Philippe Brucker 2018-11-08 16:46 ` Jean-Philippe Brucker 2018-11-08 16:46 ` Jean-Philippe Brucker 2018-11-08 14:51 ` Auger Eric 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 14:59 ` [PATCH v3 6/7] iommu/virtio: Add probe request Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 16:42 ` Michael S. Tsirkin 2018-10-12 16:42 ` Michael S. Tsirkin 2018-11-08 14:48 ` Auger Eric [not found] ` <20181012145917.6840-7-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> 2018-11-08 14:48 ` Auger Eric 2018-11-08 14:48 ` Auger Eric [not found] ` <295d30bb-5aef-2727-01c0-ec10c7a8fa8c-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-11-08 16:46 ` Jean-Philippe Brucker 2018-11-08 16:46 ` Jean-Philippe Brucker 2018-11-08 16:46 ` Jean-Philippe Brucker 2018-11-15 13:20 ` Auger Eric 2018-11-15 13:20 ` Auger Eric 2018-11-15 16:22 ` Jean-Philippe Brucker 2018-11-15 16:22 ` Jean-Philippe Brucker 2018-11-15 16:22 ` Jean-Philippe Brucker 2018-11-15 13:20 ` Auger Eric 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 14:59 ` [PATCH v3 7/7] iommu/virtio: Add event queue Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 14:59 ` Jean-Philippe Brucker 2018-10-12 17:00 ` [PATCH v3 0/7] Add virtio-iommu driver Michael S. Tsirkin [not found] ` <20181012145917.6840-1-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> 2018-10-12 17:00 ` Michael S. Tsirkin 2018-10-12 17:00 ` Michael S. Tsirkin 2018-10-12 18:55 ` Jean-Philippe Brucker [not found] ` <20181012125443-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-10-12 18:55 ` Jean-Philippe Brucker 2018-10-12 18:55 ` Jean-Philippe Brucker 2018-10-16 9:25 ` Auger Eric 2018-10-16 9:25 ` Auger Eric 2018-10-16 18:44 ` Jean-Philippe Brucker 2018-10-16 18:44 ` Jean-Philippe Brucker 2018-10-16 20:31 ` Auger Eric 2018-10-16 20:31 ` Auger Eric 2018-10-17 11:54 ` Jean-Philippe Brucker 2018-10-17 11:54 ` Jean-Philippe Brucker 2018-10-17 15:23 ` Michael S. Tsirkin 2018-10-17 15:23 ` Michael S. Tsirkin 2018-10-17 15:23 ` Michael S. Tsirkin 2018-10-16 18:44 ` Jean-Philippe Brucker 2018-10-16 9:25 ` Auger Eric 2018-10-12 14:59 Jean-Philippe Brucker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181012145917.6840-1-jean-philippe.brucker@arm.com \ --to=jean-philippe.brucker-5wv7dgnigg8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \ --cc=jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org \ --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \ --cc=tnowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org \ --cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \ --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.