From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
To: Auger Eric <eric.auger@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: lorenzo.pieralisi@arm.com, tnowicki@caviumnetworks.com,
devicetree@vger.kernel.org, marc.zyngier@arm.com,
linux-pci@vger.kernel.org, joro@8bytes.org, will.deacon@arm.com,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
robin.murphy@arm.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3 5/7] iommu: Add virtio-iommu driver
Date: Thu, 8 Nov 2018 16:46:19 +0000 [thread overview]
Message-ID: <eebdbcd4-e7eb-d5cf-3cc9-6223d9bcfbe0@arm.com> (raw)
In-Reply-To: <60605670-0419-3f64-a379-9c4057d90db1@redhat.com>
On 08/11/2018 14:51, Auger Eric wrote:
>>> +/*
>>> + * viommu_replay_mappings - re-send MAP requests
>>> + *
>>> + * When reattaching a domain that was previously detached from all endpoints,
>>> + * mappings were deleted from the device. Re-create the mappings available in
>>> + * the internal tree.
>>> + */
>>> +static int viommu_replay_mappings(struct viommu_domain *vdomain)
>>> +{
>>> + int ret;
> ret needs to be initialized here. Otherwise this can lead to a crash in
> viommu_add_device.
I actually hit this one while testing the other day :) Fixed in next version
Thanks,
Jean
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
To: Auger Eric <eric.auger@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: mark.rutland@arm.com, peter.maydell@linaro.org,
lorenzo.pieralisi@arm.com, tnowicki@caviumnetworks.com,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
joro@8bytes.org, will.deacon@arm.com,
virtualization@lists.linux-foundation.org, marc.zyngier@arm.com,
iommu@lists.linux-foundation.org, robh+dt@kernel.org,
robin.murphy@arm.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3 5/7] iommu: Add virtio-iommu driver
Date: Thu, 8 Nov 2018 16:46:19 +0000 [thread overview]
Message-ID: <eebdbcd4-e7eb-d5cf-3cc9-6223d9bcfbe0@arm.com> (raw)
In-Reply-To: <60605670-0419-3f64-a379-9c4057d90db1@redhat.com>
On 08/11/2018 14:51, Auger Eric wrote:
>>> +/*
>>> + * viommu_replay_mappings - re-send MAP requests
>>> + *
>>> + * When reattaching a domain that was previously detached from all endpoints,
>>> + * mappings were deleted from the device. Re-create the mappings available in
>>> + * the internal tree.
>>> + */
>>> +static int viommu_replay_mappings(struct viommu_domain *vdomain)
>>> +{
>>> + int ret;
> ret needs to be initialized here. Otherwise this can lead to a crash in
> viommu_add_device.
I actually hit this one while testing the other day :) Fixed in next version
Thanks,
Jean
next prev parent reply other threads:[~2018-11-08 16:46 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 14:59 [PATCH v3 0/7] Add virtio-iommu driver Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` [PATCH v3 1/7] dt-bindings: virtio-mmio: Add IOMMU description Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-18 0:30 ` Rob Herring
[not found] ` <20181012145917.6840-2-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-10-18 0:30 ` Rob Herring
2018-10-18 0:30 ` Rob Herring
2018-11-15 8:45 ` Auger Eric
2018-11-15 8:45 ` Auger Eric
2018-10-12 14:59 ` [PATCH v3 2/7] dt-bindings: virtio: Add virtio-pci-iommu node Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-18 0:35 ` Rob Herring
2018-10-18 0:35 ` Rob Herring
2018-10-18 0:35 ` Rob Herring
2018-11-15 8:45 ` Auger Eric
2018-11-15 8:45 ` Auger Eric
2018-11-15 8:45 ` Auger Eric
2018-10-12 14:59 ` [PATCH v3 3/7] PCI: OF: Allow endpoints to bypass the iommu Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
[not found] ` <20181012145917.6840-4-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-10-12 19:41 ` Bjorn Helgaas
2018-10-12 19:41 ` Bjorn Helgaas
2018-10-15 10:52 ` Michael S. Tsirkin
2018-10-15 11:32 ` Robin Murphy
[not found] ` <20181012194158.GX5906-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-10-15 10:52 ` Michael S. Tsirkin
2018-10-15 10:52 ` Michael S. Tsirkin
[not found] ` <20181015065024-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-10-15 19:46 ` Jean-philippe Brucker
2018-10-15 19:46 ` Jean-philippe Brucker
2018-10-17 15:14 ` Michael S. Tsirkin
2018-10-17 15:14 ` Michael S. Tsirkin
2018-10-18 10:47 ` Robin Murphy
2018-10-18 10:47 ` Robin Murphy
2018-10-18 10:47 ` Robin Murphy
[not found] ` <20181017111100-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-10-22 11:27 ` Jean-Philippe Brucker
2018-10-22 11:27 ` Jean-Philippe Brucker
2018-10-22 11:27 ` Jean-Philippe Brucker
2018-10-15 11:32 ` Robin Murphy
2018-10-15 11:32 ` Robin Murphy
2018-10-15 19:45 ` Jean-philippe Brucker
2018-10-15 19:45 ` Jean-philippe Brucker
2018-10-12 14:59 ` [PATCH v3 4/7] PCI: OF: Initialize dev->fwnode appropriately Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
[not found] ` <20181012145917.6840-5-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-10-12 19:44 ` Bjorn Helgaas
2018-10-12 19:44 ` Bjorn Helgaas
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` [PATCH v3 5/7] iommu: Add virtio-iommu driver Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 16:35 ` Michael S. Tsirkin
2018-10-12 16:35 ` Michael S. Tsirkin
2018-10-12 16:35 ` Michael S. Tsirkin
[not found] ` <20181012120953-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-10-12 18:54 ` Jean-Philippe Brucker
2018-10-12 18:54 ` Jean-Philippe Brucker
2018-10-12 18:54 ` Jean-Philippe Brucker
2018-11-08 14:51 ` Auger Eric
2018-11-08 14:51 ` Auger Eric
2018-11-08 16:46 ` Jean-Philippe Brucker [this message]
2018-11-08 16:46 ` Jean-Philippe Brucker
2018-11-08 16:46 ` Jean-Philippe Brucker
2018-11-08 14:51 ` Auger Eric
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` [PATCH v3 6/7] iommu/virtio: Add probe request Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 16:42 ` Michael S. Tsirkin
2018-10-12 16:42 ` Michael S. Tsirkin
2018-11-08 14:48 ` Auger Eric
[not found] ` <20181012145917.6840-7-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-11-08 14:48 ` Auger Eric
2018-11-08 14:48 ` Auger Eric
[not found] ` <295d30bb-5aef-2727-01c0-ec10c7a8fa8c-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-08 16:46 ` Jean-Philippe Brucker
2018-11-08 16:46 ` Jean-Philippe Brucker
2018-11-08 16:46 ` Jean-Philippe Brucker
2018-11-15 13:20 ` Auger Eric
2018-11-15 13:20 ` Auger Eric
2018-11-15 16:22 ` Jean-Philippe Brucker
2018-11-15 16:22 ` Jean-Philippe Brucker
2018-11-15 16:22 ` Jean-Philippe Brucker
2018-11-15 13:20 ` Auger Eric
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` [PATCH v3 7/7] iommu/virtio: Add event queue Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 14:59 ` Jean-Philippe Brucker
2018-10-12 17:00 ` [PATCH v3 0/7] Add virtio-iommu driver Michael S. Tsirkin
[not found] ` <20181012145917.6840-1-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2018-10-12 17:00 ` Michael S. Tsirkin
2018-10-12 17:00 ` Michael S. Tsirkin
2018-10-12 18:55 ` Jean-Philippe Brucker
[not found] ` <20181012125443-mutt-send-email-mst-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-10-12 18:55 ` Jean-Philippe Brucker
2018-10-12 18:55 ` Jean-Philippe Brucker
2018-10-16 9:25 ` Auger Eric
2018-10-16 9:25 ` Auger Eric
2018-10-16 18:44 ` Jean-Philippe Brucker
2018-10-16 18:44 ` Jean-Philippe Brucker
2018-10-16 20:31 ` Auger Eric
2018-10-16 20:31 ` Auger Eric
2018-10-17 11:54 ` Jean-Philippe Brucker
2018-10-17 11:54 ` Jean-Philippe Brucker
2018-10-17 15:23 ` Michael S. Tsirkin
2018-10-17 15:23 ` Michael S. Tsirkin
2018-10-17 15:23 ` Michael S. Tsirkin
2018-10-16 18:44 ` Jean-Philippe Brucker
2018-10-16 9:25 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebdbcd4-e7eb-d5cf-3cc9-6223d9bcfbe0@arm.com \
--to=jean-philippe.brucker@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mst@redhat.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tnowicki@caviumnetworks.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.