* [PATCH 0/5] Add Du support to RZ/G1C and RZ/G1N
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: linux-arm-kernel
Dear All,
this series documents and adds driver support for the DUs found
inside RZ/G1C (a.k.a. R8A77470) and RZ/G1N (a.k.a. R8A7744).
Also, this series enables the SII902X driver as the SiI9022ACNU
HDMI transmitter is found on the iwg23s.
Thanks,
Fab
Biju Das (2):
dt-bindings: display: renesas: du: Document the r8a7744 bindings
drm: rcar-du: Add R8A7744 support
Fabrizio Castro (3):
dt-bindings: display: renesas: du: Document the r8a77470 bindings
drm: rcar-du: Add r8a77470 support
ARM: shmobile: defconfig: Enable SII902X
.../devicetree/bindings/display/renesas,du.txt | 4 ++++
arch/arm/configs/shmobile_defconfig | 1 +
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 27 ++++++++++++++++++++++
3 files changed, 32 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 0/5] Add Du support to RZ/G1C and RZ/G1N
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, Simon Horman, Magnus Damm, Russell King,
dri-devel, linux-renesas-soc, devicetree, linux-arm-kernel,
Chris Paterson, Biju Das
Dear All,
this series documents and adds driver support for the DUs found
inside RZ/G1C (a.k.a. R8A77470) and RZ/G1N (a.k.a. R8A7744).
Also, this series enables the SII902X driver as the SiI9022ACNU
HDMI transmitter is found on the iwg23s.
Thanks,
Fab
Biju Das (2):
dt-bindings: display: renesas: du: Document the r8a7744 bindings
drm: rcar-du: Add R8A7744 support
Fabrizio Castro (3):
dt-bindings: display: renesas: du: Document the r8a77470 bindings
drm: rcar-du: Add r8a77470 support
ARM: shmobile: defconfig: Enable SII902X
.../devicetree/bindings/display/renesas,du.txt | 4 ++++
arch/arm/configs/shmobile_defconfig | 1 +
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 27 ++++++++++++++++++++++
3 files changed, 32 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-09-21 18:08 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Magnus Damm,
Russell King, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, linux-arm-kernel
Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index ec9d34be..2b28ae2 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -5,6 +5,7 @@ Required Properties:
- compatible: must be one of the following.
- "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
+ - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
- "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
- "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
@@ -51,6 +52,7 @@ corresponding to each DU output.
-----------------------------------------------------------------------------
R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
+ R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: linux-arm-kernel
Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index ec9d34be..2b28ae2 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -5,6 +5,7 @@ Required Properties:
- compatible: must be one of the following.
- "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
+ - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
- "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
- "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
@@ -51,6 +52,7 @@ corresponding to each DU output.
-----------------------------------------------------------------------------
R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
+ R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, Simon Horman, Magnus Damm, Russell King,
dri-devel, linux-renesas-soc, devicetree, linux-arm-kernel,
Chris Paterson, Biju Das
Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index ec9d34be..2b28ae2 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -5,6 +5,7 @@ Required Properties:
- compatible: must be one of the following.
- "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
+ - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
- "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
- "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
@@ -51,6 +52,7 @@ corresponding to each DU output.
-----------------------------------------------------------------------------
R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
+ R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-10-15 15:16 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2018-10-15 15:16 UTC (permalink / raw)
Cc: Mark Rutland, Fabrizio Castro, Chris Paterson,
Geert Uytterhoeven, devicetree, David Airlie, Magnus Damm,
Russell King, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, Laurent Pinchart, linux-arm-kernel
On Fri, 21 Sep 2018 19:08:27 +0100, Fabrizio Castro wrote:
> Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
@ 2018-10-15 15:16 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2018-10-15 15:16 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 21 Sep 2018 19:08:27 +0100, Fabrizio Castro wrote:
> Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
@ 2018-10-15 15:16 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2018-10-15 15:16 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Geert Uytterhoeven, Laurent Pinchart, Mark Rutland,
Fabrizio Castro, Simon Horman, Magnus Damm, Russell King,
dri-devel, linux-renesas-soc, devicetree, linux-arm-kernel,
Chris Paterson, Biju Das
On Fri, 21 Sep 2018 19:08:27 +0100, Fabrizio Castro wrote:
> Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-10-15 22:16 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:16 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Mark Rutland, Simon Horman, Chris Paterson, Geert Uytterhoeven,
devicetree, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:27 EEST Fabrizio Castro wrote:
> Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> ec9d34be..2b28ae2 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -5,6 +5,7 @@ Required Properties:
> - compatible: must be one of the following.
> - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> + - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> @@ -51,6 +52,7 @@ corresponding to each DU output.
> ---------------------------------------------------------------------------
> -- R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - - +
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
> R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
@ 2018-10-15 22:16 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:16 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:27 EEST Fabrizio Castro wrote:
> Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> ec9d34be..2b28ae2 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -5,6 +5,7 @@ Required Properties:
> - compatible: must be one of the following.
> - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> + - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> @@ -51,6 +52,7 @@ corresponding to each DU output.
> ---------------------------------------------------------------------------
> -- R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - - +
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
> R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 1/5] dt-bindings: display: renesas: du: Document the r8a77470 bindings
@ 2018-10-15 22:16 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:16 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Biju Das
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:27 EEST Fabrizio Castro wrote:
> Document the RZ/G1C (r8a77470) SoC in R-Car DU bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> ec9d34be..2b28ae2 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -5,6 +5,7 @@ Required Properties:
> - compatible: must be one of the following.
> - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> + - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> - "renesas,du-r8a7790" for R8A7790 (R-Car H2) compatible DU
> - "renesas,du-r8a7791" for R8A7791 (R-Car M2-W) compatible DU
> @@ -51,6 +52,7 @@ corresponding to each DU output.
> ---------------------------------------------------------------------------
> -- R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - - +
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
> R8A7790 (R-Car H2) DPAD 0 LVDS 0 LVDS 1 -
> R8A7791 (R-Car M2-W) DPAD 0 LVDS 0 - -
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-09-21 18:08 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Magnus Damm,
Russell King, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, linux-arm-kernel
From: Biju Das <biju.das@bp.renesas.com>
Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index 2b28ae2..aad9cf1 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -4,6 +4,7 @@ Required Properties:
- compatible: must be one of the following.
- "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
+ - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
- "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
@@ -51,6 +52,7 @@ corresponding to each DU output.
Port0 Port1 Port2 Port3
-----------------------------------------------------------------------------
R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
+ R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Biju Das <biju.das@bp.renesas.com>
Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index 2b28ae2..aad9cf1 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -4,6 +4,7 @@ Required Properties:
- compatible: must be one of the following.
- "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
+ - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
- "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
@@ -51,6 +52,7 @@ corresponding to each DU output.
Port0 Port1 Port2 Port3
-----------------------------------------------------------------------------
R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
+ R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Fabrizio Castro
From: Biju Das <biju.das@bp.renesas.com>
Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt
index 2b28ae2..aad9cf1 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.txt
+++ b/Documentation/devicetree/bindings/display/renesas,du.txt
@@ -4,6 +4,7 @@ Required Properties:
- compatible: must be one of the following.
- "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
+ - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
- "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
- "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
- "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
@@ -51,6 +52,7 @@ corresponding to each DU output.
Port0 Port1 Port2 Port3
-----------------------------------------------------------------------------
R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - -
+ R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-10-15 15:17 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2018-10-15 15:17 UTC (permalink / raw)
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
David Airlie, Magnus Damm, Russell King, dri-devel, Biju Das,
linux-renesas-soc, Simon Horman, Fabrizio Castro,
Laurent Pinchart, linux-arm-kernel
On Fri, 21 Sep 2018 19:08:28 +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
@ 2018-10-15 15:17 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2018-10-15 15:17 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 21 Sep 2018 19:08:28 +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
@ 2018-10-15 15:17 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2018-10-15 15:17 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Geert Uytterhoeven, Laurent Pinchart, Mark Rutland,
Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Fabrizio Castro
On Fri, 21 Sep 2018 19:08:28 +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-10-15 22:18 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:18 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:28 EEST Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> 2b28ae2..aad9cf1 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -4,6 +4,7 @@ Required Properties:
>
> - compatible: must be one of the following.
> - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> + - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> @@ -51,6 +52,7 @@ corresponding to each DU output.
> Port0 Port1 Port2 Port3
> ---------------------------------------------------------------------------
> -- R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - - +
> R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
@ 2018-10-15 22:18 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:28 EEST Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> 2b28ae2..aad9cf1 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -4,6 +4,7 @@ Required Properties:
>
> - compatible: must be one of the following.
> - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> + - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> @@ -51,6 +52,7 @@ corresponding to each DU output.
> Port0 Port1 Port2 Port3
> ---------------------------------------------------------------------------
> -- R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - - +
> R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 2/5] dt-bindings: display: renesas: du: Document the r8a7744 bindings
@ 2018-10-15 22:18 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:18 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:28 EEST Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document the RZ/G1N (R8A7744) SoC in the R-Car DU bindings.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt
> b/Documentation/devicetree/bindings/display/renesas,du.txt index
> 2b28ae2..aad9cf1 100644
> --- a/Documentation/devicetree/bindings/display/renesas,du.txt
> +++ b/Documentation/devicetree/bindings/display/renesas,du.txt
> @@ -4,6 +4,7 @@ Required Properties:
>
> - compatible: must be one of the following.
> - "renesas,du-r8a7743" for R8A7743 (RZ/G1M) compatible DU
> + - "renesas,du-r8a7744" for R8A7744 (RZ/G1N) compatible DU
> - "renesas,du-r8a7745" for R8A7745 (RZ/G1E) compatible DU
> - "renesas,du-r8a77470" for R8A77470 (RZ/G1C) compatible DU
> - "renesas,du-r8a7779" for R8A7779 (R-Car H1) compatible DU
> @@ -51,6 +52,7 @@ corresponding to each DU output.
> Port0 Port1 Port2 Port3
> ---------------------------------------------------------------------------
> -- R8A7743 (RZ/G1M) DPAD 0 LVDS 0 - - +
> R8A7744 (RZ/G1N) DPAD 0 LVDS 0 - -
> R8A7745 (RZ/G1E) DPAD 0 DPAD 1 - -
> R8A77470 (RZ/G1C) DPAD 0 DPAD 1 LVDS 0 -
> R8A7779 (R-Car H1) DPAD 0 DPAD 1 - -
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 3/5] drm: rcar-du: Add r8a77470 support
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-09-21 18:08 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Magnus Damm,
Russell King, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, linux-arm-kernel
Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 02aee6c..c07d3f1 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -77,6 +77,31 @@ static const struct rcar_du_device_info rzg1_du_r8a7745_info = {
},
};
+static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
+ .gen = 2,
+ .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
+ | RCAR_DU_FEATURE_EXT_CTRL_REGS,
+ .channels_mask = BIT(1) | BIT(0),
+ .routes = {
+ /*
+ * R8A77470 has two RGB outputs, one LVDS output, and
+ * one analog video output (unsupported)
+ */
+ [RCAR_DU_OUTPUT_DPAD0] = {
+ .possible_crtcs = BIT(0),
+ .port = 0,
+ },
+ [RCAR_DU_OUTPUT_DPAD1] = {
+ .possible_crtcs = BIT(1),
+ .port = 1,
+ },
+ [RCAR_DU_OUTPUT_LVDS0] = {
+ .possible_crtcs = BIT(0) | BIT(1),
+ .port = 2,
+ },
+ },
+};
+
static const struct rcar_du_device_info rcar_du_r8a7779_info = {
.gen = 2,
.features = 0,
@@ -297,6 +322,7 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = {
static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
+ { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 3/5] drm: rcar-du: Add r8a77470 support
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: linux-arm-kernel
Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 02aee6c..c07d3f1 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -77,6 +77,31 @@ static const struct rcar_du_device_info rzg1_du_r8a7745_info = {
},
};
+static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
+ .gen = 2,
+ .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
+ | RCAR_DU_FEATURE_EXT_CTRL_REGS,
+ .channels_mask = BIT(1) | BIT(0),
+ .routes = {
+ /*
+ * R8A77470 has two RGB outputs, one LVDS output, and
+ * one analog video output (unsupported)
+ */
+ [RCAR_DU_OUTPUT_DPAD0] = {
+ .possible_crtcs = BIT(0),
+ .port = 0,
+ },
+ [RCAR_DU_OUTPUT_DPAD1] = {
+ .possible_crtcs = BIT(1),
+ .port = 1,
+ },
+ [RCAR_DU_OUTPUT_LVDS0] = {
+ .possible_crtcs = BIT(0) | BIT(1),
+ .port = 2,
+ },
+ },
+};
+
static const struct rcar_du_device_info rcar_du_r8a7779_info = {
.gen = 2,
.features = 0,
@@ -297,6 +322,7 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = {
static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
+ { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 3/5] drm: rcar-du: Add r8a77470 support
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, Simon Horman, Magnus Damm, Russell King,
dri-devel, linux-renesas-soc, devicetree, linux-arm-kernel,
Chris Paterson, Biju Das
Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 02aee6c..c07d3f1 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -77,6 +77,31 @@ static const struct rcar_du_device_info rzg1_du_r8a7745_info = {
},
};
+static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
+ .gen = 2,
+ .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
+ | RCAR_DU_FEATURE_EXT_CTRL_REGS,
+ .channels_mask = BIT(1) | BIT(0),
+ .routes = {
+ /*
+ * R8A77470 has two RGB outputs, one LVDS output, and
+ * one analog video output (unsupported)
+ */
+ [RCAR_DU_OUTPUT_DPAD0] = {
+ .possible_crtcs = BIT(0),
+ .port = 0,
+ },
+ [RCAR_DU_OUTPUT_DPAD1] = {
+ .possible_crtcs = BIT(1),
+ .port = 1,
+ },
+ [RCAR_DU_OUTPUT_LVDS0] = {
+ .possible_crtcs = BIT(0) | BIT(1),
+ .port = 2,
+ },
+ },
+};
+
static const struct rcar_du_device_info rcar_du_r8a7779_info = {
.gen = 2,
.features = 0,
@@ -297,6 +322,7 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = {
static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
+ { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
{ .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-10-15 22:22 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:22 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Mark Rutland, Simon Horman, Chris Paterson, Geert Uytterhoeven,
devicetree, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote:
> Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -77,6 +77,31 @@ static const struct rcar_du_device_info
> rzg1_du_r8a7745_info = { },
> };
>
> +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> + .gen = 2,
> + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> + | RCAR_DU_FEATURE_EXT_CTRL_REGS,
The DU driver has recently gained two new feature flags,
RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both
should be set here. Could you please confirm (and test) ?
> + .channels_mask = BIT(1) | BIT(0),
> + .routes = {
> + /*
> + * R8A77470 has two RGB outputs, one LVDS output, and
> + * one analog video output (unsupported)
I'd write this "and one (currently unsupported) analog video output" to match
the other device entries. With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> + [RCAR_DU_OUTPUT_DPAD0] = {
> + .possible_crtcs = BIT(0),
> + .port = 0,
> + },
> + [RCAR_DU_OUTPUT_DPAD1] = {
> + .possible_crtcs = BIT(1),
> + .port = 1,
> + },
> + [RCAR_DU_OUTPUT_LVDS0] = {
> + .possible_crtcs = BIT(0) | BIT(1),
> + .port = 2,
> + },
> + },
> +};
> +
> static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> .gen = 2,
> .features = 0,
> @@ -297,6 +322,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a77970_info = { static const struct of_device_id
> rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> + { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread* [PATCH 3/5] drm: rcar-du: Add r8a77470 support
@ 2018-10-15 22:22 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote:
> Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -77,6 +77,31 @@ static const struct rcar_du_device_info
> rzg1_du_r8a7745_info = { },
> };
>
> +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> + .gen = 2,
> + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> + | RCAR_DU_FEATURE_EXT_CTRL_REGS,
The DU driver has recently gained two new feature flags,
RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both
should be set here. Could you please confirm (and test) ?
> + .channels_mask = BIT(1) | BIT(0),
> + .routes = {
> + /*
> + * R8A77470 has two RGB outputs, one LVDS output, and
> + * one analog video output (unsupported)
I'd write this "and one (currently unsupported) analog video output" to match
the other device entries. With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> + [RCAR_DU_OUTPUT_DPAD0] = {
> + .possible_crtcs = BIT(0),
> + .port = 0,
> + },
> + [RCAR_DU_OUTPUT_DPAD1] = {
> + .possible_crtcs = BIT(1),
> + .port = 1,
> + },
> + [RCAR_DU_OUTPUT_LVDS0] = {
> + .possible_crtcs = BIT(0) | BIT(1),
> + .port = 2,
> + },
> + },
> +};
> +
> static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> .gen = 2,
> .features = 0,
> @@ -297,6 +322,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a77970_info = { static const struct of_device_id
> rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> + { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support
@ 2018-10-15 22:22 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:22 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Biju Das
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote:
> Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -77,6 +77,31 @@ static const struct rcar_du_device_info
> rzg1_du_r8a7745_info = { },
> };
>
> +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> + .gen = 2,
> + .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> + | RCAR_DU_FEATURE_EXT_CTRL_REGS,
The DU driver has recently gained two new feature flags,
RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both
should be set here. Could you please confirm (and test) ?
> + .channels_mask = BIT(1) | BIT(0),
> + .routes = {
> + /*
> + * R8A77470 has two RGB outputs, one LVDS output, and
> + * one analog video output (unsupported)
I'd write this "and one (currently unsupported) analog video output" to match
the other device entries. With this fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> + */
> + [RCAR_DU_OUTPUT_DPAD0] = {
> + .possible_crtcs = BIT(0),
> + .port = 0,
> + },
> + [RCAR_DU_OUTPUT_DPAD1] = {
> + .possible_crtcs = BIT(1),
> + .port = 1,
> + },
> + [RCAR_DU_OUTPUT_LVDS0] = {
> + .possible_crtcs = BIT(0) | BIT(1),
> + .port = 2,
> + },
> + },
> +};
> +
> static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> .gen = 2,
> .features = 0,
> @@ -297,6 +322,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a77970_info = { static const struct of_device_id
> rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> + { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread* RE: [PATCH 3/5] drm: rcar-du: Add r8a77470 support
2018-10-15 22:22 ` Laurent Pinchart
(?)
@ 2018-10-16 15:19 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-10-16 15:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mark Rutland, Simon Horman, Chris Paterson, Geert Uytterhoeven,
devicetree, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hello Laurent,
Thank you for your feedback.
> Subject: Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote:
> > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -77,6 +77,31 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7745_info = { },
> > };
> >
> > +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> > +.gen = 2,
> > +.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> > + | RCAR_DU_FEATURE_EXT_CTRL_REGS,
>
> The DU driver has recently gained two new feature flags,
> RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both
> should be set here. Could you please confirm (and test) ?
I can confirm that both feature flags need to be set and all the test pass.
Will send a new version for this.
>
> > +.channels_mask = BIT(1) | BIT(0),
> > +.routes = {
> > +/*
> > + * R8A77470 has two RGB outputs, one LVDS output, and
> > + * one analog video output (unsupported)
>
> I'd write this "and one (currently unsupported) analog video output" to match
> the other device entries. With this fixed,
Will fix this as well.
Thanks,
Fab
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > + */
> > +[RCAR_DU_OUTPUT_DPAD0] = {
> > +.possible_crtcs = BIT(0),
> > +.port = 0,
> > +},
> > +[RCAR_DU_OUTPUT_DPAD1] = {
> > +.possible_crtcs = BIT(1),
> > +.port = 1,
> > +},
> > +[RCAR_DU_OUTPUT_LVDS0] = {
> > +.possible_crtcs = BIT(0) | BIT(1),
> > +.port = 2,
> > +},
> > +},
> > +};
> > +
> > static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> > .gen = 2,
> > .features = 0,
> > @@ -297,6 +322,7 @@ static const struct rcar_du_device_info
> > rcar_du_r8a77970_info = { static const struct of_device_id
> > rcar_du_of_table[] = {
> > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > +{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> > { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread* [PATCH 3/5] drm: rcar-du: Add r8a77470 support
@ 2018-10-16 15:19 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-10-16 15:19 UTC (permalink / raw)
To: linux-arm-kernel
Hello Laurent,
Thank you for your feedback.
> Subject: Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote:
> > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -77,6 +77,31 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7745_info = { },
> > };
> >
> > +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> > +.gen = 2,
> > +.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> > + | RCAR_DU_FEATURE_EXT_CTRL_REGS,
>
> The DU driver has recently gained two new feature flags,
> RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both
> should be set here. Could you please confirm (and test) ?
I can confirm that both feature flags need to be set and all the test pass.
Will send a new version for this.
>
> > +.channels_mask = BIT(1) | BIT(0),
> > +.routes = {
> > +/*
> > + * R8A77470 has two RGB outputs, one LVDS output, and
> > + * one analog video output (unsupported)
>
> I'd write this "and one (currently unsupported) analog video output" to match
> the other device entries. With this fixed,
Will fix this as well.
Thanks,
Fab
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > + */
> > +[RCAR_DU_OUTPUT_DPAD0] = {
> > +.possible_crtcs = BIT(0),
> > +.port = 0,
> > +},
> > +[RCAR_DU_OUTPUT_DPAD1] = {
> > +.possible_crtcs = BIT(1),
> > +.port = 1,
> > +},
> > +[RCAR_DU_OUTPUT_LVDS0] = {
> > +.possible_crtcs = BIT(0) | BIT(1),
> > +.port = 2,
> > +},
> > +},
> > +};
> > +
> > static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> > .gen = 2,
> > .features = 0,
> > @@ -297,6 +322,7 @@ static const struct rcar_du_device_info
> > rcar_du_r8a77970_info = { static const struct of_device_id
> > rcar_du_of_table[] = {
> > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > +{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> > { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread* RE: [PATCH 3/5] drm: rcar-du: Add r8a77470 support
@ 2018-10-16 15:19 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-10-16 15:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Biju Das
Hello Laurent,
Thank you for your feedback.
> Subject: Re: [PATCH 3/5] drm: rcar-du: Add r8a77470 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 21 September 2018 21:08:29 EEST Fabrizio Castro wrote:
> > Add RZ/G1C (a.k.a. r8a77470) support to the R-Car DU driver.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 02aee6c..c07d3f1 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -77,6 +77,31 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7745_info = { },
> > };
> >
> > +static const struct rcar_du_device_info rzg1_du_r8a77470_info = {
> > +.gen = 2,
> > +.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
> > + | RCAR_DU_FEATURE_EXT_CTRL_REGS,
>
> The DU driver has recently gained two new feature flags,
> RCAR_DU_FEATURE_INTERLACED and RCAR_DU_FEATURE_TVM_SYNC. I believe that both
> should be set here. Could you please confirm (and test) ?
I can confirm that both feature flags need to be set and all the test pass.
Will send a new version for this.
>
> > +.channels_mask = BIT(1) | BIT(0),
> > +.routes = {
> > +/*
> > + * R8A77470 has two RGB outputs, one LVDS output, and
> > + * one analog video output (unsupported)
>
> I'd write this "and one (currently unsupported) analog video output" to match
> the other device entries. With this fixed,
Will fix this as well.
Thanks,
Fab
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > + */
> > +[RCAR_DU_OUTPUT_DPAD0] = {
> > +.possible_crtcs = BIT(0),
> > +.port = 0,
> > +},
> > +[RCAR_DU_OUTPUT_DPAD1] = {
> > +.possible_crtcs = BIT(1),
> > +.port = 1,
> > +},
> > +[RCAR_DU_OUTPUT_LVDS0] = {
> > +.possible_crtcs = BIT(0) | BIT(1),
> > +.port = 2,
> > +},
> > +},
> > +};
> > +
> > static const struct rcar_du_device_info rcar_du_r8a7779_info = {
> > .gen = 2,
> > .features = 0,
> > @@ -297,6 +322,7 @@ static const struct rcar_du_device_info
> > rcar_du_r8a77970_info = { static const struct of_device_id
> > rcar_du_of_table[] = {
> > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > +{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> > { .compatible = "renesas,du-r8a7791", .data = &rcar_du_r8a7791_info },
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 4/5] drm: rcar-du: Add R8A7744 support
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-09-21 18:08 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Magnus Damm,
Russell King, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, linux-arm-kernel
From: Biju Das <biju.das@bp.renesas.com>
Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
it has 1 DPAD (RGB) output and 1 LVDS output.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index c07d3f1..2c3d0e5 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -321,6 +321,7 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = {
static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
+ { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Biju Das <biju.das@bp.renesas.com>
Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
it has 1 DPAD (RGB) output and 1 LVDS output.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index c07d3f1..2c3d0e5 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -321,6 +321,7 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = {
static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
+ { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Fabrizio Castro
From: Biju Das <biju.das@bp.renesas.com>
Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
it has 1 DPAD (RGB) output and 1 LVDS output.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index c07d3f1..2c3d0e5 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -321,6 +321,7 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = {
static const struct of_device_id rcar_du_of_table[] = {
{ .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
+ { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread* Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-10-15 22:25 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:25 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
> it has 1 DPAD (RGB) output and 1 LVDS output.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a77970_info = {
>
> static const struct of_device_id rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> + { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
This looks good to me. I would also apply this change:
@@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info
= {
.channels_mask = BIT(1) | BIT(0),
.routes = {
/*
- * R8A7743 has one RGB output and one LVDS output
+ * R8A774[34] has one RGB output and one LVDS output
*/
[RCAR_DU_OUTPUT_DPAD0] = {
.possible_crtcs = BIT(1) | BIT(0),
With this,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
There's no need to resubmit, I've applied the patch to my tree with the above
change.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread* [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-10-15 22:25 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
> it has 1 DPAD (RGB) output and 1 LVDS output.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a77970_info = {
>
> static const struct of_device_id rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> + { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
This looks good to me. I would also apply this change:
@@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info
= {
.channels_mask = BIT(1) | BIT(0),
.routes = {
/*
- * R8A7743 has one RGB output and one LVDS output
+ * R8A774[34] has one RGB output and one LVDS output
*/
[RCAR_DU_OUTPUT_DPAD0] = {
.possible_crtcs = BIT(1) | BIT(0),
With this,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
There's no need to resubmit, I've applied the patch to my tree with the above
change.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-10-15 22:25 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-10-15 22:25 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson
Hi Fabrizio,
Thank you for the patch.
On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
> it has 1 DPAD (RGB) output and 1 LVDS output.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> rcar_du_r8a77970_info = {
>
> static const struct of_device_id rcar_du_of_table[] = {
> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> + { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
This looks good to me. I would also apply this change:
@@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info
= {
.channels_mask = BIT(1) | BIT(0),
.routes = {
/*
- * R8A7743 has one RGB output and one LVDS output
+ * R8A774[34] has one RGB output and one LVDS output
*/
[RCAR_DU_OUTPUT_DPAD0] = {
.possible_crtcs = BIT(1) | BIT(0),
With this,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
There's no need to resubmit, I've applied the patch to my tree with the above
change.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread* RE: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
2018-10-15 22:25 ` Laurent Pinchart
(?)
@ 2018-11-22 15:59 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-11-22 15:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hello Laurent,
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 15 October 2018 23:25
> Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> > From: Biju Das <biju.das@bp.renesas.com>
> >
> > Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
> > it has 1 DPAD (RGB) output and 1 LVDS output.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> > rcar_du_r8a77970_info = {
> >
> > static const struct of_device_id rcar_du_of_table[] = {
> > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>
> This looks good to me. I would also apply this change:
>
> @@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info
> = {
> .channels_mask = BIT(1) | BIT(0),
> .routes = {
> /*
> - * R8A7743 has one RGB output and one LVDS output
> + * R8A774[34] has one RGB output and one LVDS output
> */
> [RCAR_DU_OUTPUT_DPAD0] = {
> .possible_crtcs = BIT(1) | BIT(0),
>
> With this,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> There's no need to resubmit, I've applied the patch to my tree with the above
> change.
I was expecting to see this patch at least on linux-next by now but it looks like it's not in there, could you please double check what happened to it?
Thanks,
Fab
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread* [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-11-22 15:59 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-11-22 15:59 UTC (permalink / raw)
To: linux-arm-kernel
Hello Laurent,
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 15 October 2018 23:25
> Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> > From: Biju Das <biju.das@bp.renesas.com>
> >
> > Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
> > it has 1 DPAD (RGB) output and 1 LVDS output.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> > rcar_du_r8a77970_info = {
> >
> > static const struct of_device_id rcar_du_of_table[] = {
> > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>
> This looks good to me. I would also apply this change:
>
> @@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info
> = {
> .channels_mask = BIT(1) | BIT(0),
> .routes = {
> /*
> - * R8A7743 has one RGB output and one LVDS output
> + * R8A774[34] has one RGB output and one LVDS output
> */
> [RCAR_DU_OUTPUT_DPAD0] = {
> .possible_crtcs = BIT(1) | BIT(0),
>
> With this,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> There's no need to resubmit, I've applied the patch to my tree with the above
> change.
I was expecting to see this patch at least on linux-next by now but it looks like it's not in there, could you please double check what happened to it?
Thanks,
Fab
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread* RE: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-11-22 15:59 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-11-22 15:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson
Hello Laurent,
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 15 October 2018 23:25
> Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> > From: Biju Das <biju.das@bp.renesas.com>
> >
> > Add support for the R8A7744 DU (which is very similar to the R8A7743 DU);
> > it has 1 DPAD (RGB) output and 1 LVDS output.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> > rcar_du_r8a77970_info = {
> >
> > static const struct of_device_id rcar_du_of_table[] = {
> > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>
> This looks good to me. I would also apply this change:
>
> @@ -41,7 +41,7 @@ static const struct rcar_du_device_info rzg1_du_r8a7743_info
> = {
> .channels_mask = BIT(1) | BIT(0),
> .routes = {
> /*
> - * R8A7743 has one RGB output and one LVDS output
> + * R8A774[34] has one RGB output and one LVDS output
> */
> [RCAR_DU_OUTPUT_DPAD0] = {
> .possible_crtcs = BIT(1) | BIT(0),
>
> With this,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> There's no need to resubmit, I've applied the patch to my tree with the above
> change.
I was expecting to see this patch at least on linux-next by now but it looks like it's not in there, could you please double check what happened to it?
Thanks,
Fab
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
2018-11-22 15:59 ` Fabrizio Castro
(?)
@ 2018-11-23 12:05 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-11-23 12:05 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hi Fabrizio,
On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> On 15 October 2018 23:25 Laurent Pinchart wrote:
> > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> >> From: Biju Das <biju.das@bp.renesas.com>
> >>
> >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> >> DU);
> >> it has 1 DPAD (RGB) output and 1 LVDS output.
> >>
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> ---
> >>
> >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> >> rcar_du_r8a77970_info = {
> >> static const struct of_device_id rcar_du_of_table[] = {
> >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> >> },
> >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> >
> > This looks good to me. I would also apply this change:
> >
> > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7743_info = {
> > .channels_mask = BIT(1) | BIT(0),
> > .routes = {
> > /*
> > - * R8A7743 has one RGB output and one LVDS output
> > + * R8A774[34] has one RGB output and one LVDS output
> > */
> > [RCAR_DU_OUTPUT_DPAD0] = {
> > .possible_crtcs = BIT(1) | BIT(0),
> >
> > With this,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > There's no need to resubmit, I've applied the patch to my tree with the
> > above change.
>
> I was expecting to see this patch at least on linux-next by now but it looks
> like it's not in there, could you please double check what happened to it?
I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
next in the near future.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread* [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-11-23 12:05 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-11-23 12:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabrizio,
On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> On 15 October 2018 23:25 Laurent Pinchart wrote:
> > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> >> From: Biju Das <biju.das@bp.renesas.com>
> >>
> >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> >> DU);
> >> it has 1 DPAD (RGB) output and 1 LVDS output.
> >>
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> ---
> >>
> >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> >> rcar_du_r8a77970_info = {
> >> static const struct of_device_id rcar_du_of_table[] = {
> >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> >> },
> >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> >
> > This looks good to me. I would also apply this change:
> >
> > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7743_info = {
> > .channels_mask = BIT(1) | BIT(0),
> > .routes = {
> > /*
> > - * R8A7743 has one RGB output and one LVDS output
> > + * R8A774[34] has one RGB output and one LVDS output
> > */
> > [RCAR_DU_OUTPUT_DPAD0] = {
> > .possible_crtcs = BIT(1) | BIT(0),
> >
> > With this,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > There's no need to resubmit, I've applied the patch to my tree with the
> > above change.
>
> I was expecting to see this patch at least on linux-next by now but it looks
> like it's not in there, could you please double check what happened to it?
I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
next in the near future.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread* Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-11-23 12:05 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2018-11-23 12:05 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson
Hi Fabrizio,
On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> On 15 October 2018 23:25 Laurent Pinchart wrote:
> > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> >> From: Biju Das <biju.das@bp.renesas.com>
> >>
> >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> >> DU);
> >> it has 1 DPAD (RGB) output and 1 LVDS output.
> >>
> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >> ---
> >>
> >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> >> rcar_du_r8a77970_info = {
> >> static const struct of_device_id rcar_du_of_table[] = {
> >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> >> },
> >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> >
> > This looks good to me. I would also apply this change:
> >
> > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > rzg1_du_r8a7743_info = {
> > .channels_mask = BIT(1) | BIT(0),
> > .routes = {
> > /*
> > - * R8A7743 has one RGB output and one LVDS output
> > + * R8A774[34] has one RGB output and one LVDS output
> > */
> > [RCAR_DU_OUTPUT_DPAD0] = {
> > .possible_crtcs = BIT(1) | BIT(0),
> >
> > With this,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > There's no need to resubmit, I've applied the patch to my tree with the
> > above change.
>
> I was expecting to see this patch at least on linux-next by now but it looks
> like it's not in there, could you please double check what happened to it?
I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
next in the near future.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread* RE: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
2018-11-23 12:05 ` Laurent Pinchart
(?)
@ 2018-11-23 12:32 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-11-23 12:32 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
Simon Horman, David Airlie, Magnus Damm, Russell King, dri-devel,
Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel
Thank you Laurent.
Cheers,
Fab
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 23 November 2018 12:05
> Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
>
> Hi Fabrizio,
>
> On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> > On 15 October 2018 23:25 Laurent Pinchart wrote:
> > > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> > >> From: Biju Das <biju.das@bp.renesas.com>
> > >>
> > >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> > >> DU);
> > >> it has 1 DPAD (RGB) output and 1 LVDS output.
> > >>
> > >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >> ---
> > >>
> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > >> 1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> > >> rcar_du_r8a77970_info = {
> > >> static const struct of_device_id rcar_du_of_table[] = {
> > >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> > >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> > >> },
> > >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > >
> > > This looks good to me. I would also apply this change:
> > >
> > > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > > rzg1_du_r8a7743_info = {
> > > .channels_mask = BIT(1) | BIT(0),
> > > .routes = {
> > > /*
> > > - * R8A7743 has one RGB output and one LVDS output
> > > + * R8A774[34] has one RGB output and one LVDS output
> > > */
> > > [RCAR_DU_OUTPUT_DPAD0] = {
> > > .possible_crtcs = BIT(1) | BIT(0),
> > >
> > > With this,
> > >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > There's no need to resubmit, I've applied the patch to my tree with the
> > > above change.
> >
> > I was expecting to see this patch at least on linux-next by now but it looks
> > like it's not in there, could you please double check what happened to it?
>
> I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
> next in the near future.
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread* [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-11-23 12:32 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-11-23 12:32 UTC (permalink / raw)
To: linux-arm-kernel
Thank you Laurent.
Cheers,
Fab
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 23 November 2018 12:05
> Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
>
> Hi Fabrizio,
>
> On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> > On 15 October 2018 23:25 Laurent Pinchart wrote:
> > > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> > >> From: Biju Das <biju.das@bp.renesas.com>
> > >>
> > >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> > >> DU);
> > >> it has 1 DPAD (RGB) output and 1 LVDS output.
> > >>
> > >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >> ---
> > >>
> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > >> 1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> > >> rcar_du_r8a77970_info = {
> > >> static const struct of_device_id rcar_du_of_table[] = {
> > >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> > >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> > >> },
> > >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > >
> > > This looks good to me. I would also apply this change:
> > >
> > > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > > rzg1_du_r8a7743_info = {
> > > .channels_mask = BIT(1) | BIT(0),
> > > .routes = {
> > > /*
> > > - * R8A7743 has one RGB output and one LVDS output
> > > + * R8A774[34] has one RGB output and one LVDS output
> > > */
> > > [RCAR_DU_OUTPUT_DPAD0] = {
> > > .possible_crtcs = BIT(1) | BIT(0),
> > >
> > > With this,
> > >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > There's no need to resubmit, I've applied the patch to my tree with the
> > > above change.
> >
> > I was expecting to see this patch at least on linux-next by now but it looks
> > like it's not in there, could you please double check what happened to it?
>
> I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
> next in the near future.
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread* RE: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
@ 2018-11-23 12:32 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-11-23 12:32 UTC (permalink / raw)
To: Laurent Pinchart
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Mark Rutland,
Biju Das, Simon Horman, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson
Thank you Laurent.
Cheers,
Fab
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 23 November 2018 12:05
> Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support
>
> Hi Fabrizio,
>
> On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote:
> > On 15 October 2018 23:25 Laurent Pinchart wrote:
> > > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote:
> > >> From: Biju Das <biju.das@bp.renesas.com>
> > >>
> > >> Add support for the R8A7744 DU (which is very similar to the R8A7743
> > >> DU);
> > >> it has 1 DPAD (RGB) output and 1 LVDS output.
> > >>
> > >> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > >> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >> ---
> > >>
> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > >> 1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644
> > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info
> > >> rcar_du_r8a77970_info = {
> > >> static const struct of_device_id rcar_du_of_table[] = {
> > >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info },
> > >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
> > >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
> > >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info
> > >> },
> > >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
> > >
> > > This looks good to me. I would also apply this change:
> > >
> > > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info
> > > rzg1_du_r8a7743_info = {
> > > .channels_mask = BIT(1) | BIT(0),
> > > .routes = {
> > > /*
> > > - * R8A7743 has one RGB output and one LVDS output
> > > + * R8A774[34] has one RGB output and one LVDS output
> > > */
> > > [RCAR_DU_OUTPUT_DPAD0] = {
> > > .possible_crtcs = BIT(1) | BIT(0),
> > >
> > > With this,
> > >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > There's no need to resubmit, I've applied the patch to my tree with the
> > > above change.
> >
> > I was expecting to see this patch at least on linux-next by now but it looks
> > like it's not in there, could you please double check what happened to it?
>
> I've sent the R-Car DU v4.21 pull request today, it should end up in linux-
> next in the near future.
>
> --
> Regards,
>
> Laurent Pinchart
>
>
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-09-21 18:08 ` Fabrizio Castro
-1 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, devicetree, Chris Paterson, Magnus Damm,
Russell King, dri-devel, Biju Das, linux-renesas-soc,
Simon Horman, linux-arm-kernel
The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
this patch makes sure the corresponding driver gets built.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
Hello Simon,
a patch for the multi_v7_defconfig will be sent at a later stage.
Thanks,
Fab
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index d090022..9e5a5ad 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -142,6 +142,7 @@ CONFIG_DRM=y
CONFIG_DRM_RCAR_DU=y
CONFIG_DRM_RCAR_LVDS=y
CONFIG_DRM_DUMB_VGA_DAC=y
+CONFIG_DRM_SII902X=y
CONFIG_DRM_I2C_ADV7511=y
CONFIG_DRM_I2C_ADV7511_AUDIO=y
CONFIG_FB_SH_MOBILE_LCDC=y
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: linux-arm-kernel
The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
this patch makes sure the corresponding driver gets built.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
Hello Simon,
a patch for the multi_v7_defconfig will be sent at a later stage.
Thanks,
Fab
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index d090022..9e5a5ad 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -142,6 +142,7 @@ CONFIG_DRM=y
CONFIG_DRM_RCAR_DU=y
CONFIG_DRM_RCAR_LVDS=y
CONFIG_DRM_DUMB_VGA_DAC=y
+CONFIG_DRM_SII902X=y
CONFIG_DRM_I2C_ADV7511=y
CONFIG_DRM_I2C_ADV7511_AUDIO=y
CONFIG_FB_SH_MOBILE_LCDC=y
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
@ 2018-09-21 18:08 ` Fabrizio Castro
0 siblings, 0 replies; 54+ messages in thread
From: Fabrizio Castro @ 2018-09-21 18:08 UTC (permalink / raw)
To: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland
Cc: Fabrizio Castro, Simon Horman, Magnus Damm, Russell King,
dri-devel, linux-renesas-soc, devicetree, linux-arm-kernel,
Chris Paterson, Biju Das
The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
this patch makes sure the corresponding driver gets built.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
Hello Simon,
a patch for the multi_v7_defconfig will be sent at a later stage.
Thanks,
Fab
arch/arm/configs/shmobile_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index d090022..9e5a5ad 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -142,6 +142,7 @@ CONFIG_DRM=y
CONFIG_DRM_RCAR_DU=y
CONFIG_DRM_RCAR_LVDS=y
CONFIG_DRM_DUMB_VGA_DAC=y
+CONFIG_DRM_SII902X=y
CONFIG_DRM_I2C_ADV7511=y
CONFIG_DRM_I2C_ADV7511_AUDIO=y
CONFIG_FB_SH_MOBILE_LCDC=y
--
2.7.4
^ permalink raw reply related [flat|nested] 54+ messages in thread
* Re: [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
2018-09-21 18:08 ` Fabrizio Castro
(?)
@ 2018-09-24 9:08 ` Simon Horman
-1 siblings, 0 replies; 54+ messages in thread
From: Simon Horman @ 2018-09-24 9:08 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
David Airlie, Magnus Damm, Russell King, dri-devel, Biju Das,
linux-renesas-soc, Rob Herring, Laurent Pinchart,
linux-arm-kernel
On Fri, Sep 21, 2018 at 07:08:31PM +0100, Fabrizio Castro wrote:
> The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
> this patch makes sure the corresponding driver gets built.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
>
> Hello Simon,
>
> a patch for the multi_v7_defconfig will be sent at a later stage.
Thanks Fabrizio,
This looks fine to me but I will wait to see if there are other reviews
before applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thanks,
> Fab
>
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index d090022..9e5a5ad 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -142,6 +142,7 @@ CONFIG_DRM=y
> CONFIG_DRM_RCAR_DU=y
> CONFIG_DRM_RCAR_LVDS=y
> CONFIG_DRM_DUMB_VGA_DAC=y
> +CONFIG_DRM_SII902X=y
> CONFIG_DRM_I2C_ADV7511=y
> CONFIG_DRM_I2C_ADV7511_AUDIO=y
> CONFIG_FB_SH_MOBILE_LCDC=y
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
@ 2018-09-24 9:08 ` Simon Horman
0 siblings, 0 replies; 54+ messages in thread
From: Simon Horman @ 2018-09-24 9:08 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 21, 2018 at 07:08:31PM +0100, Fabrizio Castro wrote:
> The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
> this patch makes sure the corresponding driver gets built.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
>
> Hello Simon,
>
> a patch for the multi_v7_defconfig will be sent at a later stage.
Thanks Fabrizio,
This looks fine to me but I will wait to see if there are other reviews
before applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thanks,
> Fab
>
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index d090022..9e5a5ad 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -142,6 +142,7 @@ CONFIG_DRM=y
> CONFIG_DRM_RCAR_DU=y
> CONFIG_DRM_RCAR_LVDS=y
> CONFIG_DRM_DUMB_VGA_DAC=y
> +CONFIG_DRM_SII902X=y
> CONFIG_DRM_I2C_ADV7511=y
> CONFIG_DRM_I2C_ADV7511_AUDIO=y
> CONFIG_FB_SH_MOBILE_LCDC=y
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
@ 2018-09-24 9:08 ` Simon Horman
0 siblings, 0 replies; 54+ messages in thread
From: Simon Horman @ 2018-09-24 9:08 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Biju Das
On Fri, Sep 21, 2018 at 07:08:31PM +0100, Fabrizio Castro wrote:
> The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
> this patch makes sure the corresponding driver gets built.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
>
> Hello Simon,
>
> a patch for the multi_v7_defconfig will be sent at a later stage.
Thanks Fabrizio,
This looks fine to me but I will wait to see if there are other reviews
before applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thanks,
> Fab
>
> arch/arm/configs/shmobile_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index d090022..9e5a5ad 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -142,6 +142,7 @@ CONFIG_DRM=y
> CONFIG_DRM_RCAR_DU=y
> CONFIG_DRM_RCAR_LVDS=y
> CONFIG_DRM_DUMB_VGA_DAC=y
> +CONFIG_DRM_SII902X=y
> CONFIG_DRM_I2C_ADV7511=y
> CONFIG_DRM_I2C_ADV7511_AUDIO=y
> CONFIG_FB_SH_MOBILE_LCDC=y
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
2018-09-24 9:08 ` Simon Horman
(?)
@ 2018-10-18 13:10 ` Simon Horman
-1 siblings, 0 replies; 54+ messages in thread
From: Simon Horman @ 2018-10-18 13:10 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Mark Rutland, devicetree, Chris Paterson, Geert Uytterhoeven,
David Airlie, Magnus Damm, Russell King, dri-devel, Biju Das,
linux-renesas-soc, Rob Herring, Laurent Pinchart,
linux-arm-kernel
On Mon, Sep 24, 2018 at 11:08:51AM +0200, Simon Horman wrote:
> On Fri, Sep 21, 2018 at 07:08:31PM +0100, Fabrizio Castro wrote:
> > The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
> > this patch makes sure the corresponding driver gets built.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> >
> > Hello Simon,
> >
> > a patch for the multi_v7_defconfig will be sent at a later stage.
>
> Thanks Fabrizio,
>
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
Sorry for letting this slip.
I have applied it for v4.21.
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
@ 2018-10-18 13:10 ` Simon Horman
0 siblings, 0 replies; 54+ messages in thread
From: Simon Horman @ 2018-10-18 13:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 24, 2018 at 11:08:51AM +0200, Simon Horman wrote:
> On Fri, Sep 21, 2018 at 07:08:31PM +0100, Fabrizio Castro wrote:
> > The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
> > this patch makes sure the corresponding driver gets built.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> >
> > Hello Simon,
> >
> > a patch for the multi_v7_defconfig will be sent at a later stage.
>
> Thanks Fabrizio,
>
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
Sorry for letting this slip.
I have applied it for v4.21.
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH 5/5] ARM: shmobile: defconfig: Enable SII902X
@ 2018-10-18 13:10 ` Simon Horman
0 siblings, 0 replies; 54+ messages in thread
From: Simon Horman @ 2018-10-18 13:10 UTC (permalink / raw)
To: Fabrizio Castro
Cc: David Airlie, Rob Herring, Geert Uytterhoeven, Laurent Pinchart,
Mark Rutland, Magnus Damm, Russell King, dri-devel,
linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson,
Biju Das
On Mon, Sep 24, 2018 at 11:08:51AM +0200, Simon Horman wrote:
> On Fri, Sep 21, 2018 at 07:08:31PM +0100, Fabrizio Castro wrote:
> > The iwg23s board comes with the SiI9022ACNU HDMI transmitter,
> > this patch makes sure the corresponding driver gets built.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> >
> > Hello Simon,
> >
> > a patch for the multi_v7_defconfig will be sent at a later stage.
>
> Thanks Fabrizio,
>
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
Sorry for letting this slip.
I have applied it for v4.21.
^ permalink raw reply [flat|nested] 54+ messages in thread