All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: oleksandr@natalenko.name
Cc: dave.taht@gmail.com, hkallweit1@gmail.com, toke@toke.dk,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: CAKE and r8169 cause panic on upload in v4.19
Date: Sat, 27 Oct 2018 21:44:26 -0700 (PDT)	[thread overview]
Message-ID: <20181027.214426.537959459795607171.davem@davemloft.net> (raw)
In-Reply-To: <b80e6819da8ea74f18b6ec0aaf9128fa@natalenko.name>

From: Oleksandr Natalenko <oleksandr@natalenko.name>
Date: Fri, 26 Oct 2018 22:54:12 +0200

> Next, I've seen GRO bits in the call trace and decided to disable GRO
> on this NIC. So far, I cannot trigger a panic with GRO disabled even
> after 20 rounds of speedtest.
> 
> So, must be some generic thing indeed.

Yeah something is out-of-whack with GRO.

Does this fix it?

diff --git a/net/core/dev.c b/net/core/dev.c
index 022ad73d6253..77d43ae2a7bb 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head *head)
 	/* Do not adjust napi->gro_hash[].count, caller is adding a new
 	 * SKB to the chain.
 	 */
-	list_del(&oldest->list);
+	skb_list_del_init(oldest);
 	napi_gro_complete(oldest);
 }
 

  parent reply	other threads:[~2018-10-28  4:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 19:26 CAKE and r8169 cause panic on upload in v4.19 Oleksandr Natalenko
2018-10-26 20:21 ` Heiner Kallweit
2018-10-26 20:25   ` Dave Taht
2018-10-26 20:54     ` Oleksandr Natalenko
2018-10-26 23:08       ` Dave Taht
2018-10-27 11:04         ` Oleksandr Natalenko
2018-10-27 13:43       ` Heiner Kallweit
2018-10-27 15:37         ` Oleksandr Natalenko
2018-10-28  4:44       ` David Miller [this message]
2018-10-28 12:22         ` Oleksandr Natalenko
2018-10-28 17:45           ` David Miller
2018-10-28 17:45             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181027.214426.537959459795607171.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dave.taht@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=toke@toke.dk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.