All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: David Miller <davem@davemloft.net>
Cc: dave.taht@gmail.com, hkallweit1@gmail.com, toke@toke.dk,
	jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: CAKE and r8169 cause panic on upload in v4.19
Date: Sun, 28 Oct 2018 13:22:09 +0100	[thread overview]
Message-ID: <3d749bf1ec48ee9f4172b23bde84ec4b@natalenko.name> (raw)
In-Reply-To: <20181027.214426.537959459795607171.davem@davemloft.net>

Hi.

On 28.10.2018 05:44, David Miller wrote:
> Does this fix it?
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 022ad73d6253..77d43ae2a7bb 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5457,7 +5457,7 @@ static void gro_flush_oldest(struct list_head 
> *head)
>  	/* Do not adjust napi->gro_hash[].count, caller is adding a new
>  	 * SKB to the chain.
>  	 */
> -	list_del(&oldest->list);
> +	skb_list_del_init(oldest);
>  	napi_gro_complete(oldest);
>  }

Yes, but I had to apply both a8305bff6852 and 992cba7e276d too to get it 
compiled. With these 3 patches the panic is not triggered any more while 
having GRO enabled.

Thanks!

-- 
   Oleksandr Natalenko (post-factum)

  reply	other threads:[~2018-10-28 12:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 19:26 CAKE and r8169 cause panic on upload in v4.19 Oleksandr Natalenko
2018-10-26 20:21 ` Heiner Kallweit
2018-10-26 20:25   ` Dave Taht
2018-10-26 20:54     ` Oleksandr Natalenko
2018-10-26 23:08       ` Dave Taht
2018-10-27 11:04         ` Oleksandr Natalenko
2018-10-27 13:43       ` Heiner Kallweit
2018-10-27 15:37         ` Oleksandr Natalenko
2018-10-28  4:44       ` David Miller
2018-10-28 12:22         ` Oleksandr Natalenko [this message]
2018-10-28 17:45           ` David Miller
2018-10-28 17:45             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d749bf1ec48ee9f4172b23bde84ec4b@natalenko.name \
    --to=oleksandr@natalenko.name \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.